206339 2020-01-15 23:31:01 -0800 operationToObject() should check for a null errorMessage. 2020-01-16 09:26:55 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1607371 0 mark.lam 2020-01-15 23:31:01 -0800 r224280 introduced operationToObject() with an option to specify a custom error message. r254252 added a scenario where the passed in error message is null but did not fix operationToObject() to allow for this. We should add the missing null check. <rdar://problem/58449666> 1607372 1 387897 mark.lam 2020-01-15 23:35:38 -0800 Created attachment 387897 proposed patch. 1607373 2 387897 ysuzuki 2020-01-15 23:37:59 -0800 Comment on attachment 387897 proposed patch. r=me 1607505 3 mark.lam 2020-01-16 09:26:55 -0800 Thanks for the review. Landed in r254687: <http://trac.webkit.org/r254687>. 387897 2020-01-15 23:35:38 -0800 2020-01-15 23:37:59 -0800 proposed patch. bug-206339.patch text/plain 2635 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTQ2NjgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDIwLTAxLTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBvcGVyYXRpb25Ub09iamVjdCgpIHNob3VsZCBjaGVjayBmb3IgYSBudWxs IGVycm9yTWVzc2FnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwNjMzOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTg0NDk2NjY+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3Mvb3BlcmF0 aW9uVG9PYmplY3Qtc2hvdWxkLWNoZWNrLWZvci1udWxsLWVycm9yTWVzc2FnZS5qczogQWRkZWQu CisKIDIwMjAtMDEtMTUgIENhaXRsaW4gUG90dGVyIDxjYWl0cEBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtKU0NdIEFkZCBzdXBwb3J0IGZvciBwdWJsaWMgY2xhc3MgZmllbGRzCkluZGV4OiBKU1Rl c3RzL3N0cmVzcy9vcGVyYXRpb25Ub09iamVjdC1zaG91bGQtY2hlY2stZm9yLW51bGwtZXJyb3JN ZXNzYWdlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL29wZXJhdGlvblRvT2JqZWN0 LXNob3VsZC1jaGVjay1mb3ItbnVsbC1lcnJvck1lc3NhZ2UuanMJKG5vbmV4aXN0ZW50KQorKysg SlNUZXN0cy9zdHJlc3Mvb3BlcmF0aW9uVG9PYmplY3Qtc2hvdWxkLWNoZWNrLWZvci1udWxsLWVy cm9yTWVzc2FnZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDkgQEAKK2Z1bmN0aW9uIGZv bygpIHsKKyAgICBmb3IgKGxldCBqID0gMDsgaiA8IDU7IGorKykge30KKyAgICBuZXcgUHJvbWlz ZSgoKT0+IHsKKyAgICAgICAgbmV3IFByb21pc2UoW10udmFsdWVzKTsKKyAgICB9KTsKK30KKwor Zm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDsgaSsrKQorICAgIGZvbygpOwpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTQ2MzYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDEtMTUg IE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIG9wZXJhdGlvblRvT2Jq ZWN0KCkgc2hvdWxkIGNoZWNrIGZvciBhIG51bGwgZXJyb3JNZXNzYWdlLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MzM5CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS81ODQ0OTY2Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICByMjI0MjgwIGludHJvZHVjZWQgb3BlcmF0aW9uVG9PYmplY3QoKSB3aXRo IGFuIG9wdGlvbiB0byBzcGVjaWZ5IGEgY3VzdG9tIGVycm9yCisgICAgICAgIG1lc3NhZ2UuICBy MjU0MjUyIGFkZGVkIGEgc2NlbmFyaW8gd2hlcmUgdGhlIHBhc3NlZCBpbiBlcnJvciBtZXNzYWdl IGlzIG51bGwgYnV0CisgICAgICAgIGRpZCBub3QgdXBkYXRlIG9wZXJhdGlvblRvT2JqZWN0KCkg dG8gYWxsb3cgZm9yIHRoaXMuICBUaGlzIHBhdGNoIGFkZHMgdGhlCisgICAgICAgIG1pc3Npbmcg bnVsbCBjaGVjay4KKworICAgICAgICAqIGRmZy9ERkdPcGVyYXRpb25zLmNwcDoKKwogMjAyMC0w MS0xNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZlcnQgYnl0ZWNvZGUgY2hlY2twb2ludHMgc2luY2UgaXQgYnJlYWtzIHdhdGNoCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAJKHJldmlzaW9uIDI1 NDYzNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQ1NSw3ICs0NTUsNyBAQCBKU0NlbGwqIEpJVF9PUEVSQVRJT04gb3Bl cmF0aW9uVG9PYmplY3QoCiAgICAgQVNTRVJUKCF2YWx1ZS5pc09iamVjdCgpKTsKIAogICAgIGlm IChVTkxJS0VMWSh2YWx1ZS5pc1VuZGVmaW5lZE9yTnVsbCgpKSkgewotICAgICAgICBpZiAoZXJy b3JNZXNzYWdlLT5sZW5ndGgoKSkgeworICAgICAgICBpZiAoZXJyb3JNZXNzYWdlICYmIGVycm9y TWVzc2FnZS0+bGVuZ3RoKCkpIHsKICAgICAgICAgICAgIHRocm93Vk1UeXBlRXJyb3IoZ2xvYmFs T2JqZWN0LCBzY29wZSwgZXJyb3JNZXNzYWdlKTsKICAgICAgICAgICAgIHJldHVybiBudWxscHRy OwogICAgICAgICB9Cg==