206331 2020-01-15 18:06:16 -0800 REGRESSION(r254565): It caused many timeouts for the layout tests of the GTK port (Requested by clopez on #webkit). 2020-01-15 18:11:14 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 206234 1 commit-queue commit-queue calvaris clopez tsaunier webkit-bug-importer oldest_to_newest 1607287 0 commit-queue 2020-01-15 18:06:16 -0800 https://trac.webkit.org/changeset/254565 broke the build: It caused many timeouts for the layout tests of the GTK port (Requested by clopez on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1607289 1 387881 commit-queue 2020-01-15 18:06:21 -0800 Created attachment 387881 ROLLOUT of r254565 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1607291 2 387881 commit-queue 2020-01-15 18:10:02 -0800 Comment on attachment 387881 ROLLOUT of r254565 Clearing flags on attachment: 387881 Committed r254660: <https://trac.webkit.org/changeset/254660> 1607292 3 commit-queue 2020-01-15 18:10:04 -0800 All reviewed patches have been landed. Closing bug. 1607293 4 webkit-bug-importer 2020-01-15 18:11:14 -0800 <rdar://problem/58629012> 387881 2020-01-15 18:06:21 -0800 2020-01-15 18:10:02 -0800 ROLLOUT of r254565 bug-206331-20200115180620.patch text/plain 6618 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmEwZTU4NmZhM2U2NmYx NmZlYWUyZDRmMzAwZjBhZTI3OTI2NjAyYi4uZjZjYmIzZGQ1Nzc0NTYyMDgzMmMzY2MxN2VjNWE5 MjhiM2JkN2ZkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAxLTE1ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMjU0NTY1LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA2MzMxCisKKyAgICAgICAgSXQgY2F1c2VkIG1hbnkgdGltZW91dHMg Zm9yIHRoZSBsYXlvdXQgdGVzdHMgb2YgdGhlIEdUSyBwb3J0CisgICAgICAgIChSZXF1ZXN0ZWQg YnkgY2xvcGV6IG9uICN3ZWJraXQpLgorCisgICAgICAgIFJldmVydGVkIGNoYW5nZXNldDoKKwor ICAgICAgICAiW0dTdHJlYW1lcl0gU2V2ZXJhbCBidWZmZXJpbmcgZml4ZXMiCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYyMzQKKyAgICAgICAgaHR0 cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzI1NDU2NQorCiAyMDIwLTAxLTE1ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgS2VlcCBS ZWZQdHIgaW5zdGVhZCBvZiByYXcgcG9pbnRlciB0byBtZXNzYWdlIHF1ZXVlIG9uIFdlYkNvcmVS ZXNvdXJjZUhhbmRsZUFzT3BlcmF0aW9uUXVldWVEZWxlZ2F0ZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCA4YWExYmQ2NmEwODg2ODU0MTE1 NDJhN2IyODI3MjY4ZGJmZWYwZjcwLi44NWFhZjA0ZTdhMjNkNzAyMzkwNDFkMDUyMDVlMGEwMTQz NWM2YTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmNwcApAQCAtMTA1Myw3ICsxMDUzLDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXI6OmR1cmF0aW9uQ2hhbmdlZCgpCiAgICAgTWVkaWFUaW1lIHByZXZpb3VzRHVyYXRpb24gPSBk dXJhdGlvbk1lZGlhVGltZSgpOwogICAgIG1fY2FjaGVkRHVyYXRpb24gPSBNZWRpYVRpbWU6Omlu dmFsaWRUaW1lKCk7CiAKLSAgICAvLyBBdm9pZCBlbWl0dGluZyBkdXJhdGlvbkNoYW5nZWQgaW4g dGhlIGNhc2Ugd2hlcmUgdGhlIHByZXZpb3VzCisgICAgLy8gQXZvaWQgZW1pdGluZyBkdXJhdGlv bmNoYW5nZWQgaW4gdGhlIGNhc2Ugd2hlcmUgdGhlIHByZXZpb3VzCiAgICAgLy8gZHVyYXRpb24g d2FzIDAgYmVjYXVzZSB0aGF0IGNhc2UgaXMgYWxyZWFkeSBoYW5kbGVkIGJ5IHRoZQogICAgIC8v IEhUTUxNZWRpYUVsZW1lbnQuCiAgICAgaWYgKHByZXZpb3VzRHVyYXRpb24gJiYgZHVyYXRpb25N ZWRpYVRpbWUoKSAhPSBwcmV2aW91c0R1cmF0aW9uKQpAQCAtMTQ1Niw3ICsxNDU2LDcgQEAgdm9p ZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmZpbGxUaW1lckZpcmVkKCkKICAgICBkb3Vi bGUgZmlsbFN0YXR1cyA9IDEwMC4wOwogICAgIEdzdEJ1ZmZlcmluZ01vZGUgbW9kZSA9IEdTVF9C VUZGRVJJTkdfRE9XTkxPQUQ7CiAKLSAgICBpZiAoZ3N0X2VsZW1lbnRfcXVlcnkocGlwZWxpbmUo KSwgcXVlcnkuZ2V0KCkpKSB7CisgICAgaWYgKGdzdF9lbGVtZW50X3F1ZXJ5KG1fc291cmNlLmdl dCgpLCBxdWVyeS5nZXQoKSkpIHsKICAgICAgICAgZ3N0X3F1ZXJ5X3BhcnNlX2J1ZmZlcmluZ19z dGF0cyhxdWVyeS5nZXQoKSwgJm1vZGUsIG51bGxwdHIsIG51bGxwdHIsIG51bGxwdHIpOwogCiAg ICAgICAgIGludCBwZXJjZW50YWdlOwpAQCAtMTQ3MCwxMCArMTQ3MCw3IEBAIHZvaWQgTWVkaWFQ bGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpmaWxsVGltZXJGaXJlZCgpCiAgICAgICAgIHJldHVybjsK ICAgICB9CiAKLSAgICBpZiAobW9kZSAhPSBHU1RfQlVGRkVSSU5HX0RPV05MT0FEKQotICAgICAg ICBHU1RfSU5GT19PQkpFQ1QocGlwZWxpbmUoKSwgIklnbm9yaW5nIGJ1ZmZlcmluZyBpbiAlcyIs IGVudW1Ub1N0cmluZyhHU1RfVFlQRV9CVUZGRVJJTkdfTU9ERSwgbW9kZSkuZGF0YSgpKTsKLSAg ICBlbHNlCi0gICAgICAgIHVwZGF0ZUJ1ZmZlcmluZ1N0YXR1cyhtb2RlLCBmaWxsU3RhdHVzKTsK KyAgICB1cGRhdGVCdWZmZXJpbmdTdGF0dXMobW9kZSwgZmlsbFN0YXR1cyk7CiB9CiAKIHZvaWQg TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpsb2FkU3RhdGVDaGFuZ2VkKCkKQEAgLTIyMDEs MTEgKzIxOTgsNiBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6aGFuZGxlTWVz c2FnZShHc3RNZXNzYWdlKiBtZXNzYWdlKQogICAgICAgICAgICAgICAgIGlmIChjb25zdCBjaGFy KiB1cmkgPSBnc3Rfc3RydWN0dXJlX2dldF9zdHJpbmcoc3RydWN0dXJlLCAidXJpIikpCiAgICAg ICAgICAgICAgICAgICAgIG1faGFzVGFpbnRlZE9yaWdpbiA9IHdlYktpdFNyY1dvdWxkVGFpbnRP cmlnaW4oV0VCS0lUX1dFQl9TUkNfQ0FTVChtX3NvdXJjZS5nZXQoKSksIFNlY3VyaXR5T3JpZ2lu OjpjcmVhdGUoVVJMKFVSTCgpLCB1cmkpKSk7CiAgICAgICAgICAgICB9Ci0gICAgICAgIH0gZWxz ZSBpZiAoZ3N0X3N0cnVjdHVyZV9oYXNfbmFtZShzdHJ1Y3R1cmUsICJHc3RDYWNoZURvd25sb2Fk Q29tcGxldGUiKSkgewotICAgICAgICAgICAgR1NUX0lORk9fT0JKRUNUKHBpcGVsaW5lKCksICJT dHJlYW0gaXMgZnVsbHkgZG93bmxvYWRlZCwgc3RvcHBpbmcgbW9uaXRvcmluZyBkb3dubG9hZGlu ZyBwcm9ncmVzcy4iKTsKLSAgICAgICAgICAgIG1fZmlsbFRpbWVyLnN0b3AoKTsKLSAgICAgICAg ICAgIG1fYnVmZmVyaW5nUGVyY2VudGFnZSA9IDEwMDsKLSAgICAgICAgICAgIHVwZGF0ZVN0YXRl cygpOwogICAgICAgICB9IGVsc2UKICAgICAgICAgICAgIEdTVF9ERUJVR19PQkpFQ1QocGlwZWxp bmUoKSwgIlVuaGFuZGxlZCBlbGVtZW50IG1lc3NhZ2U6ICUiIEdTVF9QVFJfRk9STUFULCBzdHJ1 Y3R1cmUpOwogICAgICAgICBicmVhazsKQEAgLTIzMDAsMjkgKzIyOTIsMjkgQEAgdm9pZCBNZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnVwZGF0ZU1heFRpbWVMb2FkZWQoZG91YmxlIHBlcmNl bnRhZ2UpCiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjp1cGRhdGVCdWZmZXJp bmdTdGF0dXMoR3N0QnVmZmVyaW5nTW9kZSBtb2RlLCBkb3VibGUgcGVyY2VudGFnZSkKIHsKLSAg ICBib29sIHdhc0J1ZmZlcmluZyA9IG1faXNCdWZmZXJpbmc7Ci0KICAgICBHU1RfREVCVUdfT0JK RUNUKHBpcGVsaW5lKCksICJbQnVmZmVyaW5nXSBtb2RlOiAlcywgc3RhdHVzOiAlZiUlIiwgZW51 bVRvU3RyaW5nKEdTVF9UWVBFX0JVRkZFUklOR19NT0RFLCBtb2RlKS5kYXRhKCksIHBlcmNlbnRh Z2UpOwogCiAgICAgbV9kaWREb3dubG9hZEZpbmlzaCA9IHBlcmNlbnRhZ2UgPT0gMTAwOwogICAg IG1faXNCdWZmZXJpbmcgPSAhbV9kaWREb3dubG9hZEZpbmlzaDsKIAotICAgIGlmICghbV9kaWRE b3dubG9hZEZpbmlzaCkKLSAgICAgICAgbV9pc0J1ZmZlcmluZyA9IHRydWU7Ci0KLSAgICBtX2J1 ZmZlcmluZ1BlcmNlbnRhZ2UgPSBwZXJjZW50YWdlOwogICAgIHN3aXRjaCAobW9kZSkgewogICAg IGNhc2UgR1NUX0JVRkZFUklOR19TVFJFQU06IHsKICAgICAgICAgdXBkYXRlTWF4VGltZUxvYWRl ZChwZXJjZW50YWdlKTsKIAogICAgICAgICBtX2J1ZmZlcmluZ1BlcmNlbnRhZ2UgPSBwZXJjZW50 YWdlOwotICAgICAgICBpZiAobV9kaWREb3dubG9hZEZpbmlzaCB8fCAoIXdhc0J1ZmZlcmluZyAm JiBtX2lzQnVmZmVyaW5nKSkKKyAgICAgICAgaWYgKG1fZGlkRG93bmxvYWRGaW5pc2gpCiAgICAg ICAgICAgICB1cGRhdGVTdGF0ZXMoKTsKIAogICAgICAgICBicmVhazsKICAgICB9CiAgICAgY2Fz ZSBHU1RfQlVGRkVSSU5HX0RPV05MT0FEOiB7CiAgICAgICAgIHVwZGF0ZU1heFRpbWVMb2FkZWQo cGVyY2VudGFnZSk7CisKKyAgICAgICAgLy8gTWVkaWEgaXMgbm93IGZ1bGx5IGxvYWRlZC4gSXQg d2lsbCBwbGF5IGV2ZW4gaWYgbmV0d29yayBjb25uZWN0aW9uIGlzCisgICAgICAgIC8vIGN1dC4g QnVmZmVyaW5nIGlzIGRvbmUsIHJlbW92ZSB0aGUgZmlsbCBzb3VyY2UgZnJvbSB0aGUgbWFpbiBs b29wLgorICAgICAgICBpZiAobV9kaWREb3dubG9hZEZpbmlzaCkKKyAgICAgICAgICAgIG1fZmls bFRpbWVyLnN0b3AoKTsKKwogICAgICAgICB1cGRhdGVTdGF0ZXMoKTsKICAgICAgICAgYnJlYWs7 CiAgICAgfQpAQCAtMjU4NSwxNyArMjU3Nyw5IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyOjp1cGRhdGVTdGF0ZXMoKQogICAgICAgICAgICAgRkFMTFRIUk9VR0g7CiAgICAgICAg IGNhc2UgR1NUX1NUQVRFX1BMQVlJTkc6CiAgICAgICAgICAgICBpZiAobV9pc0J1ZmZlcmluZykg ewotICAgICAgICAgICAgICAgIEdSZWZQdHI8R3N0UXVlcnk+IHF1ZXJ5ID0gYWRvcHRHUmVmKGdz dF9xdWVyeV9uZXdfYnVmZmVyaW5nKEdTVF9GT1JNQVRfUEVSQ0VOVCkpOwotCi0gICAgICAgICAg ICAgICAgbV9pc0J1ZmZlcmluZyA9IG1fYnVmZmVyaW5nUGVyY2VudGFnZSA9PSAxMDA7Ci0gICAg ICAgICAgICAgICAgaWYgKGdzdF9lbGVtZW50X3F1ZXJ5KG1fcGlwZWxpbmUuZ2V0KCksIHF1ZXJ5 LmdldCgpKSkgewotICAgICAgICAgICAgICAgICAgICBnYm9vbGVhbiBpc0J1ZmZlcmluZyA9IG1f aXNCdWZmZXJpbmc7Ci0gICAgICAgICAgICAgICAgICAgIGdzdF9xdWVyeV9wYXJzZV9idWZmZXJp bmdfcGVyY2VudChxdWVyeS5nZXQoKSwgJmlzQnVmZmVyaW5nLCBudWxscHRyKTsKLSAgICAgICAg ICAgICAgICAgICAgbV9pc0J1ZmZlcmluZyA9IGlzQnVmZmVyaW5nOwotICAgICAgICAgICAgICAg IH0KLQotICAgICAgICAgICAgICAgIGlmICghbV9pc0J1ZmZlcmluZykgewotICAgICAgICAgICAg ICAgICAgICBHU1RfSU5GT19PQkpFQ1QocGlwZWxpbmUoKSwgIltCdWZmZXJpbmddIENvbXBsZXRl LiIpOworICAgICAgICAgICAgICAgIGlmIChtX2J1ZmZlcmluZ1BlcmNlbnRhZ2UgPT0gMTAwKSB7 CisgICAgICAgICAgICAgICAgICAgIEdTVF9ERUJVR19PQkpFQ1QocGlwZWxpbmUoKSwgIltCdWZm ZXJpbmddIENvbXBsZXRlLiIpOworICAgICAgICAgICAgICAgICAgICBtX2lzQnVmZmVyaW5nID0g ZmFsc2U7CiAgICAgICAgICAgICAgICAgICAgIG1fcmVhZHlTdGF0ZSA9IE1lZGlhUGxheWVyOjpS ZWFkeVN0YXRlOjpIYXZlRW5vdWdoRGF0YTsKICAgICAgICAgICAgICAgICAgICAgbV9uZXR3b3Jr U3RhdGUgPSBtX2RpZERvd25sb2FkRmluaXNoID8gTWVkaWFQbGF5ZXI6Ok5ldHdvcmtTdGF0ZTo6 SWRsZSA6IE1lZGlhUGxheWVyOjpOZXR3b3JrU3RhdGU6OkxvYWRpbmc7CiAgICAgICAgICAgICAg ICAgfSBlbHNlIHsKQEAgLTI2MjUsMTQgKzI2MDksMTQgQEAgdm9pZCBNZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXI6OnVwZGF0ZVN0YXRlcygpCiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAg IGlmIChkaWRCdWZmZXJpbmcgJiYgIW1faXNCdWZmZXJpbmcgJiYgIW1faXNQYXVzZWQgJiYgbV9w bGF5YmFja1JhdGUpIHsKLSAgICAgICAgICAgICAgICBHU1RfSU5GT19PQkpFQ1QocGlwZWxpbmUo KSwgIltCdWZmZXJpbmddIFJlc3RhcnRpbmcgcGxheWJhY2suIik7CisgICAgICAgICAgICAgICAg R1NUX0RFQlVHX09CSkVDVChwaXBlbGluZSgpLCAiW0J1ZmZlcmluZ10gUmVzdGFydGluZyBwbGF5 YmFjay4iKTsKICAgICAgICAgICAgICAgICBjaGFuZ2VQaXBlbGluZVN0YXRlKEdTVF9TVEFURV9Q TEFZSU5HKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfSBlbHNlIGlmIChtX2N1cnJlbnRTdGF0 ZSA9PSBHU1RfU1RBVEVfUExBWUlORykgewogICAgICAgICAgICAgbV9pc1BhdXNlZCA9IGZhbHNl OwogCiAgICAgICAgICAgICBpZiAoKG1faXNCdWZmZXJpbmcgJiYgIW1faXNMaXZlU3RyZWFtKSB8 fCAhbV9wbGF5YmFja1JhdGUpIHsKLSAgICAgICAgICAgICAgICBHU1RfSU5GT19PQkpFQ1QocGlw ZWxpbmUoKSwgIltCdWZmZXJpbmddIFBhdXNpbmcgc3RyZWFtIGZvciBidWZmZXJpbmcuIik7Cisg ICAgICAgICAgICAgICAgR1NUX0RFQlVHX09CSkVDVChwaXBlbGluZSgpLCAiW0J1ZmZlcmluZ10g UGF1c2luZyBzdHJlYW0gZm9yIGJ1ZmZlcmluZy4iKTsKICAgICAgICAgICAgICAgICBjaGFuZ2VQ aXBlbGluZVN0YXRlKEdTVF9TVEFURV9QQVVTRUQpOwogICAgICAgICAgICAgfQogICAgICAgICB9 IGVsc2UK