206330 2020-01-15 17:51:01 -0800 Reduce the code generated by DFGSlowPathGenerator.h 2020-01-16 15:05:03 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rmorisset rmorisset commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1607279 0 rmorisset 2020-01-15 17:51:01 -0800 The FunctionType parameter is only needed by CallResultAndArgumentsSlowPathGenerator, not by its base class CallSlowPathGenerator. Moving it allows saving about 300kB from JavaScriptCore, by reducing the number of instantiations of the methods of CallSlowPathGenerator. 1607282 1 387880 rmorisset 2020-01-15 17:54:17 -0800 Created attachment 387880 Patch 1607284 2 rmorisset 2020-01-15 17:59:46 -0800 (In reply to Robin Morisset from comment #0) > The FunctionType parameter is only needed by > CallResultAndArgumentsSlowPathGenerator, not by its base class > CallSlowPathGenerator. > Moving it allows saving about 300kB from JavaScriptCore, by reducing the > number of instantiations of the methods of CallSlowPathGenerator. NB: the 300kB were measured on a debug build, it is probably about 4x less in release mode. 1607654 3 387880 mark.lam 2020-01-16 14:06:39 -0800 Comment on attachment 387880 Patch r=me 1607655 4 387880 mark.lam 2020-01-16 14:07:33 -0800 Comment on attachment 387880 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387880&action=review > Source/JavaScriptCore/ChangeLog:9 > + Moving it allows saving about 300kB from JavaScriptCore, by reducing the number of instantiations of the methods of CallSlowPathGenerator. You should make it clear that this is on a Debug build. The better thing to do would be to cite numbers for a Release build. 1607671 5 387960 rmorisset 2020-01-16 14:32:22 -0800 Created attachment 387960 Patch Thanks for the review! I updated the Changelog, it is 200kB in release mode. 1607689 6 387960 commit-queue 2020-01-16 15:04:33 -0800 Comment on attachment 387960 Patch Clearing flags on attachment: 387960 Committed r254712: <https://trac.webkit.org/changeset/254712> 1607690 7 commit-queue 2020-01-16 15:04:35 -0800 All reviewed patches have been landed. Closing bug. 387880 2020-01-15 17:54:17 -0800 2020-01-16 14:32:22 -0800 Patch patch206330 text/plain 3515 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGY4ZDhhYWZkZjRmLi5mNDMxN2FlYzRhOSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDEtMTUgIFJvYmlu IE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICBSZWR1Y2UgdGhlIGNv ZGUgZ2VuZXJhdGVkIGJ5IERGR1Nsb3dQYXRoR2VuZXJhdG9yLmgKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjMzMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBGdW5jdGlvblR5cGUgcGFyYW1ldGVy IGlzIG9ubHkgbmVlZGVkIGJ5IENhbGxSZXN1bHRBbmRBcmd1bWVudHNTbG93UGF0aEdlbmVyYXRv ciwgbm90IGJ5IGl0cyBiYXNlIGNsYXNzIENhbGxTbG93UGF0aEdlbmVyYXRvci4KKyAgICAgICAg TW92aW5nIGl0IGFsbG93cyBzYXZpbmcgYWJvdXQgMzAwa0IgZnJvbSBKYXZhU2NyaXB0Q29yZSwg YnkgcmVkdWNpbmcgdGhlIG51bWJlciBvZiBpbnN0YW50aWF0aW9ucyBvZiB0aGUgbWV0aG9kcyBv ZiBDYWxsU2xvd1BhdGhHZW5lcmF0b3IuCisKKyAgICAgICAgKiBkZmcvREZHU2xvd1BhdGhHZW5l cmF0b3IuaDoKKyAgICAgICAgKEpTQzo6REZHOjpDYWxsU2xvd1BhdGhHZW5lcmF0b3I6OkNhbGxT bG93UGF0aEdlbmVyYXRvcik6CisgICAgICAgIChKU0M6OkRGRzo6Q2FsbFJlc3VsdEFuZEFyZ3Vt ZW50c1Nsb3dQYXRoR2VuZXJhdG9yOjpDYWxsUmVzdWx0QW5kQXJndW1lbnRzU2xvd1BhdGhHZW5l cmF0b3IpOgorCiAyMDIwLTAxLTE1ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWls LmNvbT4KIAogICAgICAgICBPYmplY3QucHJldmVudEV4dGVuc2lvbnMgc2hvdWxkIHRocm93IGlm IG5vdCBzdWNjZXNzZnVsCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R1Nsb3dQYXRoR2VuZXJhdG9yLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nsb3dQ YXRoR2VuZXJhdG9yLmgKaW5kZXggOGZmYmQzYzg2MDEuLmQ4N2Y1NDdlYjYzIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nsb3dQYXRoR2VuZXJhdG9yLmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTbG93UGF0aEdlbmVyYXRvci5oCkBAIC0xMDIs MTcgKzEwMiwxNiBAQCBlbnVtIGNsYXNzIEV4Y2VwdGlvbkNoZWNrUmVxdWlyZW1lbnQgOiB1aW50 OF90IHsKICAgICBDaGVja05vdE5lZWRlZAogfTsKIAotdGVtcGxhdGU8dHlwZW5hbWUgSnVtcFR5 cGUsIHR5cGVuYW1lIEZ1bmN0aW9uVHlwZSwgdHlwZW5hbWUgUmVzdWx0VHlwZT4KK3RlbXBsYXRl PHR5cGVuYW1lIEp1bXBUeXBlLCB0eXBlbmFtZSBSZXN1bHRUeXBlPgogY2xhc3MgQ2FsbFNsb3dQ YXRoR2VuZXJhdG9yIDogcHVibGljIEp1bXBpbmdTbG93UGF0aEdlbmVyYXRvcjxKdW1wVHlwZT4g ewogcHVibGljOgogICAgIENhbGxTbG93UGF0aEdlbmVyYXRvcigKLSAgICAgICAgSnVtcFR5cGUg ZnJvbSwgU3BlY3VsYXRpdmVKSVQqIGppdCwgRnVuY3Rpb25UeXBlIGZ1bmN0aW9uLAorICAgICAg ICBKdW1wVHlwZSBmcm9tLCBTcGVjdWxhdGl2ZUpJVCogaml0LAogICAgICAgICBTcGlsbFJlZ2lz dGVyc01vZGUgc3BpbGxNb2RlLCBFeGNlcHRpb25DaGVja1JlcXVpcmVtZW50IHJlcXVpcmVtZW50 LCBSZXN1bHRUeXBlIHJlc3VsdCkKICAgICAgICAgOiBKdW1waW5nU2xvd1BhdGhHZW5lcmF0b3I8 SnVtcFR5cGU+KGZyb20sIGppdCkKICAgICAgICAgLCBtX3NwaWxsTW9kZShzcGlsbE1vZGUpCiAg ICAgICAgICwgbV9leGNlcHRpb25DaGVja1JlcXVpcmVtZW50KHJlcXVpcmVtZW50KQogICAgICAg ICAsIG1fcmVzdWx0KHJlc3VsdCkKLSAgICAgICAgLCBtX2Z1bmN0aW9uKGZ1bmN0aW9uKQogICAg IHsKICAgICAgICAgaWYgKG1fc3BpbGxNb2RlID09IE5lZWRUb1NwaWxsKQogICAgICAgICAgICAg aml0LT5zaWxlbnRTcGlsbEFsbFJlZ2lzdGVyc0ltcGwoZmFsc2UsIG1fcGxhbnMsIGV4dHJhY3RS ZXN1bHQocmVzdWx0KSk7CkBAIC0xNTMsMTkgKzE1MiwxOCBAQCBwcm90ZWN0ZWQ6CiAgICAgU3Bp bGxSZWdpc3RlcnNNb2RlIG1fc3BpbGxNb2RlOwogICAgIEV4Y2VwdGlvbkNoZWNrUmVxdWlyZW1l bnQgbV9leGNlcHRpb25DaGVja1JlcXVpcmVtZW50OwogICAgIFJlc3VsdFR5cGUgbV9yZXN1bHQ7 Ci0gICAgRnVuY3Rpb25UeXBlIG1fZnVuY3Rpb247CiAgICAgVmVjdG9yPFNpbGVudFJlZ2lzdGVy U2F2ZVBsYW4sIDI+IG1fcGxhbnM7CiB9OwogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBKdW1wVHlwZSwg dHlwZW5hbWUgRnVuY3Rpb25UeXBlLCB0eXBlbmFtZSBSZXN1bHRUeXBlLCB0eXBlbmFtZS4uLiBB cmd1bWVudHM+CiBjbGFzcyBDYWxsUmVzdWx0QW5kQXJndW1lbnRzU2xvd1BhdGhHZW5lcmF0b3IK LSAgICA6IHB1YmxpYyBDYWxsU2xvd1BhdGhHZW5lcmF0b3I8SnVtcFR5cGUsIEZ1bmN0aW9uVHlw ZSwgUmVzdWx0VHlwZT4geworICAgIDogcHVibGljIENhbGxTbG93UGF0aEdlbmVyYXRvcjxKdW1w VHlwZSwgUmVzdWx0VHlwZT4gewogcHVibGljOgogICAgIENhbGxSZXN1bHRBbmRBcmd1bWVudHNT bG93UGF0aEdlbmVyYXRvcigKICAgICAgICAgSnVtcFR5cGUgZnJvbSwgU3BlY3VsYXRpdmVKSVQq IGppdCwgRnVuY3Rpb25UeXBlIGZ1bmN0aW9uLAogICAgICAgICBTcGlsbFJlZ2lzdGVyc01vZGUg c3BpbGxNb2RlLCBFeGNlcHRpb25DaGVja1JlcXVpcmVtZW50IHJlcXVpcmVtZW50LCBSZXN1bHRU eXBlIHJlc3VsdCwgQXJndW1lbnRzLi4uIGFyZ3VtZW50cykKLSAgICAgICAgOiBDYWxsU2xvd1Bh dGhHZW5lcmF0b3I8SnVtcFR5cGUsIEZ1bmN0aW9uVHlwZSwgUmVzdWx0VHlwZT4oCi0gICAgICAg ICAgICBmcm9tLCBqaXQsIGZ1bmN0aW9uLCBzcGlsbE1vZGUsIHJlcXVpcmVtZW50LCByZXN1bHQp CisgICAgICAgIDogQ2FsbFNsb3dQYXRoR2VuZXJhdG9yPEp1bXBUeXBlLCBSZXN1bHRUeXBlPihm cm9tLCBqaXQsIHNwaWxsTW9kZSwgcmVxdWlyZW1lbnQsIHJlc3VsdCkKKyAgICAgICAgLCBtX2Z1 bmN0aW9uKGZ1bmN0aW9uKQogICAgICAgICAsIG1fYXJndW1lbnRzKHN0ZDo6Zm9yd2FyZDxBcmd1 bWVudHM+KGFyZ3VtZW50cykuLi4pCiAgICAgewogICAgIH0KQEAgLTE4NCw2ICsxODIsNyBAQCBw cm90ZWN0ZWQ6CiAgICAgICAgIHVucGFja0FuZEdlbmVyYXRlKGppdCwgc3RkOjptYWtlX2luZGV4 X3NlcXVlbmNlPHN0ZDo6dHVwbGVfc2l6ZTxzdGQ6OnR1cGxlPEFyZ3VtZW50cy4uLj4+Ojp2YWx1 ZT4oKSk7CiAgICAgfQogCisgICAgRnVuY3Rpb25UeXBlIG1fZnVuY3Rpb247CiAgICAgc3RkOjp0 dXBsZTxBcmd1bWVudHMuLi4+IG1fYXJndW1lbnRzOwogfTsKIAo= 387960 2020-01-16 14:32:22 -0800 2020-01-16 15:04:33 -0800 Patch patch206330 text/plain 3518 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGVmMTgyZDA2Yjc5Li5mYzNjMzM5ZTJmZiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDEtMTUgIFJvYmlu IE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICBSZWR1Y2UgdGhlIGNv ZGUgZ2VuZXJhdGVkIGJ5IERGR1Nsb3dQYXRoR2VuZXJhdG9yLmgKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjMzMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE1hcmsgTGFtLgorCisgICAgICAgIFRoZSBGdW5jdGlvblR5cGUgcGFyYW1ldGVyIGlzIG9u bHkgbmVlZGVkIGJ5IENhbGxSZXN1bHRBbmRBcmd1bWVudHNTbG93UGF0aEdlbmVyYXRvciwgbm90 IGJ5IGl0cyBiYXNlIGNsYXNzIENhbGxTbG93UGF0aEdlbmVyYXRvci4KKyAgICAgICAgTW92aW5n IGl0IGFsbG93cyBzYXZpbmcgYWJvdXQgMjAwa0IgZnJvbSBKYXZhU2NyaXB0Q29yZSAoaW4gUmVs ZWFzZSBtb2RlKSwgYnkgcmVkdWNpbmcgdGhlIG51bWJlciBvZiBpbnN0YW50aWF0aW9ucyBvZiB0 aGUgbWV0aG9kcyBvZiBDYWxsU2xvd1BhdGhHZW5lcmF0b3IuCisKKyAgICAgICAgKiBkZmcvREZH U2xvd1BhdGhHZW5lcmF0b3IuaDoKKyAgICAgICAgKEpTQzo6REZHOjpDYWxsU2xvd1BhdGhHZW5l cmF0b3I6OkNhbGxTbG93UGF0aEdlbmVyYXRvcik6CisgICAgICAgIChKU0M6OkRGRzo6Q2FsbFJl c3VsdEFuZEFyZ3VtZW50c1Nsb3dQYXRoR2VuZXJhdG9yOjpDYWxsUmVzdWx0QW5kQXJndW1lbnRz U2xvd1BhdGhHZW5lcmF0b3IpOgorCiAyMDIwLTAxLTE2ICBEb24gT2xtc3RlYWQgIDxkb24ub2xt c3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgTm9uLXVuaWZpZWQgYnVpbGQgZml4ZXMgbWlkIEph bnVhcnkgMjAyMCBlZGl0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR1Nsb3dQYXRoR2VuZXJhdG9yLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Ns b3dQYXRoR2VuZXJhdG9yLmgKaW5kZXggOGZmYmQzYzg2MDEuLmQ4N2Y1NDdlYjYzIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nsb3dQYXRoR2VuZXJhdG9yLmgKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTbG93UGF0aEdlbmVyYXRvci5oCkBAIC0x MDIsMTcgKzEwMiwxNiBAQCBlbnVtIGNsYXNzIEV4Y2VwdGlvbkNoZWNrUmVxdWlyZW1lbnQgOiB1 aW50OF90IHsKICAgICBDaGVja05vdE5lZWRlZAogfTsKIAotdGVtcGxhdGU8dHlwZW5hbWUgSnVt cFR5cGUsIHR5cGVuYW1lIEZ1bmN0aW9uVHlwZSwgdHlwZW5hbWUgUmVzdWx0VHlwZT4KK3RlbXBs YXRlPHR5cGVuYW1lIEp1bXBUeXBlLCB0eXBlbmFtZSBSZXN1bHRUeXBlPgogY2xhc3MgQ2FsbFNs b3dQYXRoR2VuZXJhdG9yIDogcHVibGljIEp1bXBpbmdTbG93UGF0aEdlbmVyYXRvcjxKdW1wVHlw ZT4gewogcHVibGljOgogICAgIENhbGxTbG93UGF0aEdlbmVyYXRvcigKLSAgICAgICAgSnVtcFR5 cGUgZnJvbSwgU3BlY3VsYXRpdmVKSVQqIGppdCwgRnVuY3Rpb25UeXBlIGZ1bmN0aW9uLAorICAg ICAgICBKdW1wVHlwZSBmcm9tLCBTcGVjdWxhdGl2ZUpJVCogaml0LAogICAgICAgICBTcGlsbFJl Z2lzdGVyc01vZGUgc3BpbGxNb2RlLCBFeGNlcHRpb25DaGVja1JlcXVpcmVtZW50IHJlcXVpcmVt ZW50LCBSZXN1bHRUeXBlIHJlc3VsdCkKICAgICAgICAgOiBKdW1waW5nU2xvd1BhdGhHZW5lcmF0 b3I8SnVtcFR5cGU+KGZyb20sIGppdCkKICAgICAgICAgLCBtX3NwaWxsTW9kZShzcGlsbE1vZGUp CiAgICAgICAgICwgbV9leGNlcHRpb25DaGVja1JlcXVpcmVtZW50KHJlcXVpcmVtZW50KQogICAg ICAgICAsIG1fcmVzdWx0KHJlc3VsdCkKLSAgICAgICAgLCBtX2Z1bmN0aW9uKGZ1bmN0aW9uKQog ICAgIHsKICAgICAgICAgaWYgKG1fc3BpbGxNb2RlID09IE5lZWRUb1NwaWxsKQogICAgICAgICAg ICAgaml0LT5zaWxlbnRTcGlsbEFsbFJlZ2lzdGVyc0ltcGwoZmFsc2UsIG1fcGxhbnMsIGV4dHJh Y3RSZXN1bHQocmVzdWx0KSk7CkBAIC0xNTMsMTkgKzE1MiwxOCBAQCBwcm90ZWN0ZWQ6CiAgICAg U3BpbGxSZWdpc3RlcnNNb2RlIG1fc3BpbGxNb2RlOwogICAgIEV4Y2VwdGlvbkNoZWNrUmVxdWly ZW1lbnQgbV9leGNlcHRpb25DaGVja1JlcXVpcmVtZW50OwogICAgIFJlc3VsdFR5cGUgbV9yZXN1 bHQ7Ci0gICAgRnVuY3Rpb25UeXBlIG1fZnVuY3Rpb247CiAgICAgVmVjdG9yPFNpbGVudFJlZ2lz dGVyU2F2ZVBsYW4sIDI+IG1fcGxhbnM7CiB9OwogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBKdW1wVHlw ZSwgdHlwZW5hbWUgRnVuY3Rpb25UeXBlLCB0eXBlbmFtZSBSZXN1bHRUeXBlLCB0eXBlbmFtZS4u LiBBcmd1bWVudHM+CiBjbGFzcyBDYWxsUmVzdWx0QW5kQXJndW1lbnRzU2xvd1BhdGhHZW5lcmF0 b3IKLSAgICA6IHB1YmxpYyBDYWxsU2xvd1BhdGhHZW5lcmF0b3I8SnVtcFR5cGUsIEZ1bmN0aW9u VHlwZSwgUmVzdWx0VHlwZT4geworICAgIDogcHVibGljIENhbGxTbG93UGF0aEdlbmVyYXRvcjxK dW1wVHlwZSwgUmVzdWx0VHlwZT4gewogcHVibGljOgogICAgIENhbGxSZXN1bHRBbmRBcmd1bWVu dHNTbG93UGF0aEdlbmVyYXRvcigKICAgICAgICAgSnVtcFR5cGUgZnJvbSwgU3BlY3VsYXRpdmVK SVQqIGppdCwgRnVuY3Rpb25UeXBlIGZ1bmN0aW9uLAogICAgICAgICBTcGlsbFJlZ2lzdGVyc01v ZGUgc3BpbGxNb2RlLCBFeGNlcHRpb25DaGVja1JlcXVpcmVtZW50IHJlcXVpcmVtZW50LCBSZXN1 bHRUeXBlIHJlc3VsdCwgQXJndW1lbnRzLi4uIGFyZ3VtZW50cykKLSAgICAgICAgOiBDYWxsU2xv d1BhdGhHZW5lcmF0b3I8SnVtcFR5cGUsIEZ1bmN0aW9uVHlwZSwgUmVzdWx0VHlwZT4oCi0gICAg ICAgICAgICBmcm9tLCBqaXQsIGZ1bmN0aW9uLCBzcGlsbE1vZGUsIHJlcXVpcmVtZW50LCByZXN1 bHQpCisgICAgICAgIDogQ2FsbFNsb3dQYXRoR2VuZXJhdG9yPEp1bXBUeXBlLCBSZXN1bHRUeXBl Pihmcm9tLCBqaXQsIHNwaWxsTW9kZSwgcmVxdWlyZW1lbnQsIHJlc3VsdCkKKyAgICAgICAgLCBt X2Z1bmN0aW9uKGZ1bmN0aW9uKQogICAgICAgICAsIG1fYXJndW1lbnRzKHN0ZDo6Zm9yd2FyZDxB cmd1bWVudHM+KGFyZ3VtZW50cykuLi4pCiAgICAgewogICAgIH0KQEAgLTE4NCw2ICsxODIsNyBA QCBwcm90ZWN0ZWQ6CiAgICAgICAgIHVucGFja0FuZEdlbmVyYXRlKGppdCwgc3RkOjptYWtlX2lu ZGV4X3NlcXVlbmNlPHN0ZDo6dHVwbGVfc2l6ZTxzdGQ6OnR1cGxlPEFyZ3VtZW50cy4uLj4+Ojp2 YWx1ZT4oKSk7CiAgICAgfQogCisgICAgRnVuY3Rpb25UeXBlIG1fZnVuY3Rpb247CiAgICAgc3Rk Ojp0dXBsZTxBcmd1bWVudHMuLi4+IG1fYXJndW1lbnRzOwogfTsKIAo=