206322 2020-01-15 15:43:59 -0800 Quote file argument to git check-attr 2020-03-11 17:12:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 198948 1 jdarpinian jdarpinian ap commit-queue darin dbates ews-watchlist jbedard kbr webkit-bug-importer oldest_to_newest 1607207 0 jdarpinian 2020-01-15 15:43:59 -0800 Quote file argument to git check-attr 1607209 1 387860 jdarpinian 2020-01-15 15:44:59 -0800 Created attachment 387860 Quote file argument 1607283 2 387860 ap 2020-01-15 17:59:00 -0800 Comment on attachment 387860 Quote file argument Can a regression test be created for this? I’m not familiar with prepare-ChangeLig tests. 1607509 3 387860 jbedard 2020-01-16 09:46:48 -0800 Comment on attachment 387860 Quote file argument View in context: https://bugs.webkit.org/attachment.cgi?id=387860&action=review > Tools/Scripts/prepare-ChangeLog:2140 > + my $command = GIT . " check-attr $attr -- '$file'"; This appears correct, but I'm also curious what made you look into this in the first place. Did you edit a file with a space in the name? 1607510 4 jbedard 2020-01-16 09:48:41 -0800 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 387860 [details] > Quote file argument > > Can a regression test be created for this? I’m not familiar with > prepare-ChangeLig tests. We should be able to, Tools/Scripts/webkitperl/prepare-ChangeLog_unittest...probably run by test-webkitperl. 1611578 5 388898 jdarpinian 2020-01-27 13:42:42 -0800 Created attachment 388898 Add test 1611580 6 387860 jdarpinian 2020-01-27 13:44:54 -0800 Comment on attachment 387860 Quote file argument View in context: https://bugs.webkit.org/attachment.cgi?id=387860&action=review Added a test. >> Tools/Scripts/prepare-ChangeLog:2140 >> + my $command = GIT . " check-attr $attr -- '$file'"; > > This appears correct, but I'm also curious what made you look into this in the first place. Did you edit a file with a space in the name? I was updating a third-party dependency, ANGLE, and there's an upstream file with parentheses in the name. Obviously this is not ideal and I can work to rename the upstream file, but this is also a bug that should be fixed. 1612134 7 388898 commit-queue 2020-01-28 13:07:52 -0800 Comment on attachment 388898 Add test Clearing flags on attachment: 388898 Committed r255272: <https://trac.webkit.org/changeset/255272> 1612135 8 commit-queue 2020-01-28 13:07:53 -0800 All reviewed patches have been landed. Closing bug. 1612138 9 webkit-bug-importer 2020-01-28 13:08:17 -0800 <rdar://problem/58966431> 1613756 10 darin 2020-02-01 15:41:03 -0800 Not to be a jerk about it, but a better fix would work even for the filenames containing a single quote character. 387860 2020-01-15 15:44:59 -0800 2020-01-27 13:42:41 -0800 Quote file argument bug-206322-20200115154459.patch text/plain 1228 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NjQxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWNmMGI2ZWM1ZjAyYzlhNmQ0MTNjY2NjZjViOWMwMTk5 OGNjZTU5Ny4uMTZlZmYyZDAxNmU1MzQ2ZmE0MDdjN2I1YWQyOTVhOWU3MTY2ZWM4ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIwLTAxLTE1ICBKYW1lcyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGNocm9taXVtLm9y Zz4KKworICAgICAgICBRdW90ZSBmaWxlIGFyZ3VtZW50IHRvIGdpdCBjaGVjay1hdHRyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYzMjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcHJl cGFyZS1DaGFuZ2VMb2c6CisgICAgICAgIChhdHRyaWJ1dGVDb21tYW5kKToKKwogMjAyMC0wMS0x NSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEVuYWJsZSAt V2NvbmRpdGlvbmFsLXVuaW5pdGlhbGl6ZWQgaW4gRHVtcFJlbmRlclRyZWUsIFdlYktpdFRlc3RS dW5uZXIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cgYi9Ub29s cy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCmluZGV4IDBiYjM3Zjc1OGJkZmRjMTJmNzJlMjhk MDY5MDYwY2ZkNmIzYzYwYmEuLmVhYjgzZjk1YTZiYWU4OWY1YzlmNDYzZTRiZmIyOTI5NzlmYzk2 ZTYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKKysrIGIvVG9v bHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwpAQCAtMjEzNyw3ICsyMTM3LDcgQEAgc3ViIGF0 dHJpYnV0ZUNvbW1hbmQoJCQpCiAgICAgICAgIH0KICAgICAgICAgJHJlc3VsdCA9ICRhdHRyaWJ1 dGVDYWNoZXskYXR0cn17JGZpbGV9OwogICAgIH0gZWxzaWYgKGlzR2l0KCkpIHsKLSAgICAgICAg bXkgJGNvbW1hbmQgPSBHSVQgLiAiIGNoZWNrLWF0dHIgJGF0dHIgLS0gJGZpbGUiOworICAgICAg ICBteSAkY29tbWFuZCA9IEdJVCAuICIgY2hlY2stYXR0ciAkYXR0ciAtLSAnJGZpbGUnIjsKICAg ICAgICAgJHJlc3VsdCA9IGAkY29tbWFuZGA7CiAgICAgICAgIGNob21wICRyZXN1bHQ7CiAgICAg ICAgICRyZXN1bHQgPX4gcy8uKlxXKFx3KS8kMS87Cg== 388898 2020-01-27 13:42:42 -0800 2020-01-28 13:07:52 -0800 Add test bug-206322-20200127134241.patch text/plain 4114 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NjQxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWNmMGI2ZWM1ZjAyYzlhNmQ0MTNjY2NjZjViOWMwMTk5 OGNjZTU5Ny4uMDMzM2RiZjYwYmVjNTQzNzRlN2MzYjMyMTU3Zjk3Yzg5NmMwOGRkZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTAxLTI3ICBKYW1lcyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGNocm9taXVtLm9y Zz4KKworICAgICAgICBRdW90ZSBmaWxlIGFyZ3VtZW50IHRvIGdpdCBjaGVjay1hdHRyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYzMjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcHJl cGFyZS1DaGFuZ2VMb2c6CisgICAgICAgIChhdHRyaWJ1dGVDb21tYW5kKToKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHBlcmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRlc3QvZmlsZW5hbWVXaXRo UGFyZW50aGVzZXMucGw6IEFkZGVkLgorICAgICAgICAod3JpdGVGaWxlV2l0aENvbnRlbnQpOgor CiAyMDIwLTAxLTE1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAg ICAgRW5hYmxlIC1XY29uZGl0aW9uYWwtdW5pbml0aWFsaXplZCBpbiBEdW1wUmVuZGVyVHJlZSwg V2ViS2l0VGVzdFJ1bm5lcgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5n ZUxvZyBiL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKaW5kZXggMGJiMzdmNzU4YmRm ZGMxMmY3MmUyOGQwNjkwNjBjZmQ2YjNjNjBiYS4uZWFiODNmOTVhNmJhZTg5ZjVjOWY0NjNlNGJm YjI5Mjk3OWZjOTZlNiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxv ZworKysgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCkBAIC0yMTM3LDcgKzIxMzcs NyBAQCBzdWIgYXR0cmlidXRlQ29tbWFuZCgkJCkKICAgICAgICAgfQogICAgICAgICAkcmVzdWx0 ID0gJGF0dHJpYnV0ZUNhY2hleyRhdHRyfXskZmlsZX07CiAgICAgfSBlbHNpZiAoaXNHaXQoKSkg ewotICAgICAgICBteSAkY29tbWFuZCA9IEdJVCAuICIgY2hlY2stYXR0ciAkYXR0ciAtLSAkZmls ZSI7CisgICAgICAgIG15ICRjb21tYW5kID0gR0lUIC4gIiBjaGVjay1hdHRyICRhdHRyIC0tICck ZmlsZSciOwogICAgICAgICAkcmVzdWx0ID0gYCRjb21tYW5kYDsKICAgICAgICAgY2hvbXAgJHJl c3VsdDsKICAgICAgICAgJHJlc3VsdCA9fiBzLy4qXFcoXHcpLyQxLzsKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cGVybC9wcmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9maWxlbmFt ZVdpdGhQYXJlbnRoZXNlcy5wbCBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9wcmVwYXJlLUNo YW5nZUxvZ191bml0dGVzdC9maWxlbmFtZVdpdGhQYXJlbnRoZXNlcy5wbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40 NTI3ZWE1NjVhZTUyZDBkYWIxMGVhMjUyMmJkYzUxMmY2Y2Q5YjZkCi0tLSAvZGV2L251bGwKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3VuaXR0ZXN0L2Zp bGVuYW1lV2l0aFBhcmVudGhlc2VzLnBsCkBAIC0wLDAgKzEsNTggQEAKKyMhL3Vzci9iaW4vZW52 IHBlcmwKKyMKKyMgQ29weXJpZ2h0IChDKSAyMDIwIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCisjICAgCisjICAgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJp bmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisjICAgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0 dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisjICAgYXJlIG1ldDoK KyMgICAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBh Ym92ZSBjb3B5cmlnaHQKKyMgICAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBh bmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorIyAgIDIuICBSZWRpc3RyaWJ1dGlvbnMgaW4g YmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAorIyAgICAgICBu b3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWlt ZXIgaW4gdGhlCisjICAgICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBw cm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisjICAgCisjICAgVEhJUyBTT0ZUV0FSRSBJ UyBQUk9WSURFRCBCWSBHT09HTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTJycg QU5ECisjICAgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJV VCBOT1QgTElNSVRFRCBUTywgVEhFCisjICAgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5U QUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UKKyMgICBBUkUgRElT Q0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgR09PR0xFIElOQy4gT1IgSVRTIENPTlRSSUJVVE9S UyBCRSBMSUFCTEUKKyMgICBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQ RUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTAorIyAgIERBTUFHRVMgKElOQ0xVRElO RywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9S CisjICAgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVT UyBJTlRFUlJVUFRJT04pIEhPV0VWRVIKKyMgICBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0Yg TElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QKKyMgICBMSUFCSUxJVFksIE9S IFRPUlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkg V0FZCisjICAgT1VUIE9GIFRIRSBVU0UgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VE IE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNICisjICAgREFNQUdFLgorCit1c2Ugc3RyaWN0Owor dXNlIHdhcm5pbmdzOworCit1c2UgRmlsZTo6VGVtcDsKK3VzZSBGaW5kQmluOwordXNlIFRlc3Q6 Ok1vcmU7Cit1c2UgVkNTVXRpbHM7CisKK3VzZSBsaWIgRmlsZTo6U3BlYy0+Y2F0ZGlyKCRGaW5k QmluOjpCaW4sICIuLiIpOwordXNlIExvYWRBc01vZHVsZSBxdyhQcmVwYXJlQ2hhbmdlTG9nIHBy ZXBhcmUtQ2hhbmdlTG9nKTsKKworcGxhbih0ZXN0cyA9PiAxKTsKKworc3ViIHdyaXRlRmlsZVdp dGhDb250ZW50KCQkKQoreworICAgIG15ICgkZmlsZSwgJGNvbnRlbnQpID0gQF87CisgICAgb3Bl bihGSUxFLCAiPiIsICRmaWxlKSBvciBkaWUgIkNhbm5vdCBvcGVuICRmaWxlOiAkISI7CisgICAg cHJpbnQgRklMRSAkY29udGVudDsKKyAgICBjbG9zZShGSUxFKTsKK30KKworbXkgJHRlbXBvcmFy eURpcmVjdG9yeSA9IEZpbGU6OlRlbXAtPm5ld2RpcigpOworc3lzdGVtKCJnaXQiLCAiaW5pdCIs ICR0ZW1wb3JhcnlEaXJlY3RvcnkpOworbXkgJGZpbGVuYW1lID0gRmlsZTo6U3BlYy0+Y2F0Zmls ZSgkdGVtcG9yYXJ5RGlyZWN0b3J5LCAiRmlsZVdpdGgoUGFyZW50aGVzZXMpLnR4dCIpOword3Jp dGVGaWxlV2l0aENvbnRlbnQoJGZpbGVuYW1lLCAiIik7Cit3cml0ZUZpbGVXaXRoQ29udGVudChG aWxlOjpTcGVjLT5jYXRmaWxlKCR0ZW1wb3JhcnlEaXJlY3RvcnksICIuZ2l0YXR0cmlidXRlcyIp LCAiKiBmb289MVxuYiIpOworCitteSAkcmVzdWx0ID0gMDsKK2NoZGlyICR0ZW1wb3JhcnlEaXJl Y3Rvcnk7CiskcmVzdWx0ID0gUHJlcGFyZUNoYW5nZUxvZzo6YXR0cmlidXRlQ29tbWFuZCgkZmls ZW5hbWUsICJmb28iKTsKK2NoZGlyICcuLic7CisKK2lzKCRyZXN1bHQsIDEsICJTaG91bGQgc3Vj Y2Vzc2Z1bGx5IGdldCBmb28gYXR0cmlidXRlIGZyb20gZmlsZSB3aXRoIHBhcmVudGhlc2VzIGlu IG5hbWUuIik7Cg==