206311 2020-01-15 13:38:57 -0800 Web Inspector: show the device settings menu when Web Inspector's debug mode is enabled 2020-01-16 17:15:12 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1607132 0 hi 2020-01-15 13:38:57 -0800 . 1607136 1 387838 hi 2020-01-15 13:41:40 -0800 Created attachment 387838 Patch 1607759 2 387838 bburg 2020-01-16 16:37:30 -0800 Comment on attachment 387838 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387838&action=review rs=me, except speling. > Source/WebInspectorUI/ChangeLog:11 > + toolbar icon, but it will not reapper when Web Inspector is next opened (to allow for taking Nit: reappear 1607760 3 387983 hi 2020-01-16 16:39:02 -0800 Created attachment 387983 Patch 1607797 4 commit-queue 2020-01-16 17:14:13 -0800 The commit-queue encountered the following flaky tests while processing attachment 387983: imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large.html bug 201849 The commit-queue is continuing to process your patch. 1607798 5 387983 commit-queue 2020-01-16 17:14:44 -0800 Comment on attachment 387983 Patch Clearing flags on attachment: 387983 Committed r254727: <https://trac.webkit.org/changeset/254727> 1607799 6 commit-queue 2020-01-16 17:14:45 -0800 All reviewed patches have been landed. Closing bug. 1607800 7 webkit-bug-importer 2020-01-16 17:15:12 -0800 <rdar://problem/58665014> 387838 2020-01-15 13:41:40 -0800 2020-01-16 16:39:02 -0800 Patch bug-206311-20200115134139.patch text/plain 2470 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRiZDQ2OWIzMDA0ZDNkNTZiM2VlMzVmZjcyZjNm ZjEwZjBiMWU5N2EuLjk2ODljNDQyMzc4M2IyODk0MTU2ZTIyMGQ2OWY5YmI1MTk3YzdlMmIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAxLTE1ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBz aG93IHRoZSBkZXZpY2Ugc2V0dGluZ3MgbWVudSB3aGVuIFdlYiBJbnNwZWN0b3IncyBkZWJ1ZyBt b2RlIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwNjMxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgb25seSBoYXMgYW4gZWZmZWN0IHdoZW4gV2ViIEluc3BlY3RvciBpcyBvcGVu ZWQgYW5kIHRoZSBkZWJ1ZyBtb2RlIGlzIGVuYWJsZWQuIElmIHNvLAorICAgICAgICB0aGUgZGV2 aWNlIHNldHRpbmdzIHRvb2xiYXIgaWNvbiB3aWxsIGFwcGVhciByZWdhcmRsZXNzIG9mIHdoZXRo ZXIgdGhlIGluc3BlY3RlZCB0YXJnZXQgaXMKKyAgICAgICAgYSByZW1vdGUgZGV2aWNlIG9yIG5v dC4gRGlzYWJsaW5nIGRlYnVnIG1vZGUgd2lsbCBub3QgaW1tZWRpYXRlbHkgcmVtb3ZlIHRoZSBk ZXZpY2Ugc2V0dGluZ3MKKyAgICAgICAgdG9vbGJhciBpY29uLCBidXQgaXQgd2lsbCBub3QgcmVh cHBlciB3aGVuIFdlYiBJbnNwZWN0b3IgaXMgbmV4dCBvcGVuZWQgKHRvIGFsbG93IGZvciB0YWtp bmcKKyAgICAgICAgc2NyZWVuc2hvdHMgYW5kIG90aGVyIHN1Y2ggdGhpbmdzKS4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV0kuY29udGVudExvYWRl ZCk6CisKIDIwMjAtMDEtMTMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6ICJFbmFibGUgTG9jYWwgT3ZlcnJpZGUiIGFuZCAiRGVsZXRl IExvY2FsIE92ZXJyaWRlIiBhcmUgZGlzcGxheWVkIHR3aWNlIGluIHRoZSBjb250ZXh0dWFsIG1l bnUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2Uv TWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5q cwppbmRleCBmZjIyODAxNWI4OTg0YTUyZTIwZjIyMTU4NTFlMjc0ZTc5YmQxMDc1Li43MTY1MGQz NzVlMzhhZGNkNjc4Yzc5NjkyMDBjNTkyOWUzNDc0MzE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC00MDAsNyArNDAwLDcgQEAg V0kuY29udGVudExvYWRlZCA9IGZ1bmN0aW9uKCkKICAgICBXSS5faW5zcGVjdE1vZGVUb29sYmFy QnV0dG9uLmFkZEV2ZW50TGlzdGVuZXIoV0kuQnV0dG9uTmF2aWdhdGlvbkl0ZW0uRXZlbnQuQ2xp Y2tlZCwgV0kuX3RvZ2dsZUluc3BlY3RNb2RlKTsKIAogICAgIC8vIENPTVBBVElCSUxJVFkgKGlP UyAxMi4yKTogUGFnZS5vdmVycmlkZVNldHRpbmcgZGlkIG5vdCBleGlzdC4KLSAgICBpZiAoSW5z cGVjdG9yRnJvbnRlbmRIb3N0LmlzUmVtb3RlICYmIEluc3BlY3RvckJhY2tlbmQuaGFzQ29tbWFu ZCgiUGFnZS5vdmVycmlkZVVzZXJBZ2VudCIpICYmIEluc3BlY3RvckJhY2tlbmQuaGFzQ29tbWFu ZCgiUGFnZS5vdmVycmlkZVNldHRpbmciKSkgeworICAgIGlmICgoSW5zcGVjdG9yRnJvbnRlbmRI b3N0LmlzUmVtb3RlIHx8IFdJLmlzRGVidWdVSUVuYWJsZWQoKSkgJiYgSW5zcGVjdG9yQmFja2Vu ZC5oYXNDb21tYW5kKCJQYWdlLm92ZXJyaWRlVXNlckFnZW50IikgJiYgSW5zcGVjdG9yQmFja2Vu ZC5oYXNDb21tYW5kKCJQYWdlLm92ZXJyaWRlU2V0dGluZyIpKSB7CiAgICAgICAgIGNvbnN0IGRl dmljZVNldHRpbmdzVG9vbHRpcCA9IFdJLlVJU3RyaW5nKCJEZXZpY2UgU2V0dGluZ3MiKTsKICAg ICAgICAgV0kuX2RldmljZVNldHRpbmdzVG9vbGJhckJ1dHRvbiA9IG5ldyBXSS5BY3RpdmF0ZUJ1 dHRvblRvb2xiYXJJdGVtKCJkZXZpY2Utc2V0dGluZ3MiLCBkZXZpY2VTZXR0aW5nc1Rvb2x0aXAs IGRldmljZVNldHRpbmdzVG9vbHRpcCwgIkltYWdlcy9EZXZpY2Uuc3ZnIik7CiAgICAgICAgIFdJ Ll9kZXZpY2VTZXR0aW5nc1Rvb2xiYXJCdXR0b24uYWRkRXZlbnRMaXN0ZW5lcihXSS5CdXR0b25O YXZpZ2F0aW9uSXRlbS5FdmVudC5DbGlja2VkLCBXSS5faGFuZGxlRGV2aWNlU2V0dGluZ3NUb29s YmFyQnV0dG9uQ2xpY2tlZCk7Cg== 387983 2020-01-16 16:39:02 -0800 2020-01-16 17:14:44 -0800 Patch bug-206311.patch text/plain 2467 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRiZDQ2OWIzMDA0ZDNkNTZiM2VlMzVmZjcyZjNm ZjEwZjBiMWU5N2EuLjk2ODljNDQyMzc4M2IyODk0MTU2ZTIyMGQ2OWY5YmI1MTk3YzdlMmIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAxLTE2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBz aG93IHRoZSBkZXZpY2Ugc2V0dGluZ3MgbWVudSB3aGVuIFdlYiBJbnNwZWN0b3IncyBkZWJ1ZyBt b2RlIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwNjMxMQorCisgICAgICAgIFJldmlld2VkIGJ5IEJyaWFuIEJ1cmcuCisKKyAgICAg ICAgVGhpcyBvbmx5IGhhcyBhbiBlZmZlY3Qgd2hlbiBXZWIgSW5zcGVjdG9yIGlzIG9wZW5lZCBh bmQgdGhlIGRlYnVnIG1vZGUgaXMgZW5hYmxlZC4gSWYgc28sCisgICAgICAgIHRoZSBkZXZpY2Ug c2V0dGluZ3MgdG9vbGJhciBpY29uIHdpbGwgYXBwZWFyIHJlZ2FyZGxlc3Mgb2Ygd2hldGhlciB0 aGUgaW5zcGVjdGVkIHRhcmdldCBpcworICAgICAgICBhIHJlbW90ZSBkZXZpY2Ugb3Igbm90LiBE aXNhYmxpbmcgZGVidWcgbW9kZSB3aWxsIG5vdCBpbW1lZGlhdGVseSByZW1vdmUgdGhlIGRldmlj ZSBzZXR0aW5ncworICAgICAgICB0b29sYmFyIGljb24sIGJ1dCBpdCB3aWxsIG5vdCByZWFwcGVh ciB3aGVuIFdlYiBJbnNwZWN0b3IgaXMgbmV4dCBvcGVuZWQgKHRvIGFsbG93IGZvciB0YWtpbmcK KyAgICAgICAgc2NyZWVuc2hvdHMgYW5kIG90aGVyIHN1Y2ggdGhpbmdzKS4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV0kuY29udGVudExvYWRlZCk6 CisKIDIwMjAtMDEtMTMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6ICJFbmFibGUgTG9jYWwgT3ZlcnJpZGUiIGFuZCAiRGVsZXRlIExv Y2FsIE92ZXJyaWRlIiBhcmUgZGlzcGxheWVkIHR3aWNlIGluIHRoZSBjb250ZXh0dWFsIG1lbnUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFp bi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpp bmRleCBmZjIyODAxNWI4OTg0YTUyZTIwZjIyMTU4NTFlMjc0ZTc5YmQxMDc1Li43MTY1MGQzNzVl MzhhZGNkNjc4Yzc5NjkyMDBjNTkyOWUzNDc0MzE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC00MDAsNyArNDAwLDcgQEAgV0ku Y29udGVudExvYWRlZCA9IGZ1bmN0aW9uKCkKICAgICBXSS5faW5zcGVjdE1vZGVUb29sYmFyQnV0 dG9uLmFkZEV2ZW50TGlzdGVuZXIoV0kuQnV0dG9uTmF2aWdhdGlvbkl0ZW0uRXZlbnQuQ2xpY2tl ZCwgV0kuX3RvZ2dsZUluc3BlY3RNb2RlKTsKIAogICAgIC8vIENPTVBBVElCSUxJVFkgKGlPUyAx Mi4yKTogUGFnZS5vdmVycmlkZVNldHRpbmcgZGlkIG5vdCBleGlzdC4KLSAgICBpZiAoSW5zcGVj dG9yRnJvbnRlbmRIb3N0LmlzUmVtb3RlICYmIEluc3BlY3RvckJhY2tlbmQuaGFzQ29tbWFuZCgi UGFnZS5vdmVycmlkZVVzZXJBZ2VudCIpICYmIEluc3BlY3RvckJhY2tlbmQuaGFzQ29tbWFuZCgi UGFnZS5vdmVycmlkZVNldHRpbmciKSkgeworICAgIGlmICgoSW5zcGVjdG9yRnJvbnRlbmRIb3N0 LmlzUmVtb3RlIHx8IFdJLmlzRGVidWdVSUVuYWJsZWQoKSkgJiYgSW5zcGVjdG9yQmFja2VuZC5o YXNDb21tYW5kKCJQYWdlLm92ZXJyaWRlVXNlckFnZW50IikgJiYgSW5zcGVjdG9yQmFja2VuZC5o YXNDb21tYW5kKCJQYWdlLm92ZXJyaWRlU2V0dGluZyIpKSB7CiAgICAgICAgIGNvbnN0IGRldmlj ZVNldHRpbmdzVG9vbHRpcCA9IFdJLlVJU3RyaW5nKCJEZXZpY2UgU2V0dGluZ3MiKTsKICAgICAg ICAgV0kuX2RldmljZVNldHRpbmdzVG9vbGJhckJ1dHRvbiA9IG5ldyBXSS5BY3RpdmF0ZUJ1dHRv blRvb2xiYXJJdGVtKCJkZXZpY2Utc2V0dGluZ3MiLCBkZXZpY2VTZXR0aW5nc1Rvb2x0aXAsIGRl dmljZVNldHRpbmdzVG9vbHRpcCwgIkltYWdlcy9EZXZpY2Uuc3ZnIik7CiAgICAgICAgIFdJLl9k ZXZpY2VTZXR0aW5nc1Rvb2xiYXJCdXR0b24uYWRkRXZlbnRMaXN0ZW5lcihXSS5CdXR0b25OYXZp Z2F0aW9uSXRlbS5FdmVudC5DbGlja2VkLCBXSS5faGFuZGxlRGV2aWNlU2V0dGluZ3NUb29sYmFy QnV0dG9uQ2xpY2tlZCk7Cg==