206300 2020-01-15 11:15:43 -0800 [LFC][IFC] LineLayoutContext::nextContentForLine should take LineCandidateContent& 2020-01-15 13:17:57 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1607026 0 zalan 2020-01-15 11:15:43 -0800 this is a hot codepath and LineCandidateContent is rather heavy. 1607027 1 webkit-bug-importer 2020-01-15 11:15:58 -0800 <rdar://problem/58612197> 1607032 2 387809 zalan 2020-01-15 11:20:41 -0800 Created attachment 387809 Patch 1607112 3 commit-queue 2020-01-15 13:17:25 -0800 The commit-queue encountered the following flaky tests while processing attachment 387809: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1607113 4 387809 commit-queue 2020-01-15 13:17:55 -0800 Comment on attachment 387809 Patch Clearing flags on attachment: 387809 Committed r254630: <https://trac.webkit.org/changeset/254630> 1607114 5 commit-queue 2020-01-15 13:17:57 -0800 All reviewed patches have been landed. Closing bug. 387809 2020-01-15 11:20:41 -0800 2020-01-15 13:17:55 -0800 Patch bug-206300-20200115112041.patch text/plain 6372 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmNiM2U3NTdlMGE1M2Rm MTI2NDk4YzQ5NjY2NzYzZjczNmY5MzdhMC4uZTFmMjM1Y2FhYWM1ZWUyMDFlNzM1MGYxMzUwZWFk NzQ5MmFmNjRlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTAxLTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBMaW5lTGF5 b3V0Q29udGV4dDo6bmV4dENvbnRlbnRGb3JMaW5lIHNob3VsZCB0YWtlIExpbmVDYW5kaWRhdGVD b250ZW50JgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA2MzAwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODYxMjE5Nz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB+NSUgcHJvZ3Jlc3Npb24gb24gUGVy Zm9ybWFuY2VUZXN0cy9MYXlvdXQvbGluZS1sYXlvdXQtc2ltcGxlLmh0bWwuCisgICAgICAgIExp bmVMYXlvdXRDb250ZXh0OjpuZXh0Q29udGVudEZvckxpbmUgaXMgaG90IGFuZCBMaW5lQ2FuZGlk YXRlQ29udGVudCBoYXMgVmVjdG9yIG1lbWJlcnMgKHRvbyBoZWF2eSkuCisKKyAgICAgICAgKiBs YXlvdXQvaW5saW5lZm9ybWF0dGluZy9MaW5lTGF5b3V0Q29udGV4dC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpMYXlvdXQ6OkxpbmVDYW5kaWRhdGVDb250ZW50OjpyZXNldCk6CisgICAgICAgIChX ZWJDb3JlOjpMYXlvdXQ6OkxpbmVMYXlvdXRDb250ZXh0OjpsYXlvdXRMaW5lKToKKyAgICAgICAg KFdlYkNvcmU6OkxheW91dDo6TGluZUxheW91dENvbnRleHQ6Om5leHRDb250ZW50Rm9yTGluZSk6 CisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvTGluZUxheW91dENvbnRleHQuaDoK KwogMjAyMC0wMS0xNSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAg IFtMRkNdW0lGQ10gQ29udGludW91c0NvbnRlbnQgc2hvdWxkIG5vdCBuZWVkIGEgY29weSBvZiBS dW5MaXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGlu Zy9MaW5lTGF5b3V0Q29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9y bWF0dGluZy9MaW5lTGF5b3V0Q29udGV4dC5jcHAKaW5kZXggMWQ0ZjgwNzM4N2U4NTMwMGZlNDQ4 MTg0MjBkZjUzNTNkOTdkYjYxZC4uYjhkZDc4Mjk3ZmM4Njc3MDllNjIzMmYxOWUzOTYzMmMxNTE5 MGMzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcv TGluZUxheW91dENvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVm b3JtYXR0aW5nL0xpbmVMYXlvdXRDb250ZXh0LmNwcApAQCAtMTg1LDYgKzE4NSw4IEBAIHN0cnVj dCBMaW5lQ2FuZGlkYXRlQ29udGVudCB7CiAKICAgICBjb25zdCBJbmxpbmVJdGVtKiB0cmFpbGlu Z0xpbmVCcmVhaygpIGNvbnN0IHsgcmV0dXJuIG1fdHJhaWxpbmdMaW5lQnJlYWs7IH0KIAorICAg IHZvaWQgcmVzZXQoKTsKKwogcHJpdmF0ZToKICAgICB2b2lkIHNldFRyYWlsaW5nTGluZUJyZWFr KGNvbnN0IElubGluZUl0ZW0mIGxpbmVCcmVha0l0ZW0pIHsgbV90cmFpbGluZ0xpbmVCcmVhayA9 ICZsaW5lQnJlYWtJdGVtOyB9CiAKQEAgLTIwMyw2ICsyMDUsMTMgQEAgdm9pZCBMaW5lQ2FuZGlk YXRlQ29udGVudDo6YXBwZW5kKGNvbnN0IElubGluZUl0ZW0mIGlubGluZUl0ZW0sIE9wdGlvbmFs PElubGluZUwKICAgICBtX2lubGluZVJ1bnMuYXBwZW5kKHsgaW5saW5lSXRlbSwgKmxvZ2ljYWxX aWR0aCB9KTsKIH0KIAordm9pZCBMaW5lQ2FuZGlkYXRlQ29udGVudDo6cmVzZXQoKQoreworICAg IG1faW5saW5lUnVucy5jbGVhcigpOworICAgIG1fZmxvYXRzLmNsZWFyKCk7CisgICAgbV90cmFp bGluZ0xpbmVCcmVhayA9IG51bGxwdHI7Cit9CisKIHN0YXRpYyBJbmxpbmVMYXlvdXRVbml0IGlu bGluZUl0ZW1XaWR0aChjb25zdCBGb3JtYXR0aW5nQ29udGV4dCYgZm9ybWF0dGluZ0NvbnRleHQs IGNvbnN0IElubGluZUl0ZW0mIGlubGluZUl0ZW0sIElubGluZUxheW91dFVuaXQgY29udGVudExv Z2ljYWxMZWZ0KQogewogICAgIGlmIChpbmxpbmVJdGVtLmlzTGluZUJyZWFrKCkpCkBAIC0yNTgs MTIgKzI2NywxMyBAQCBMaW5lTGF5b3V0Q29udGV4dDo6TGluZUNvbnRlbnQgTGluZUxheW91dENv bnRleHQ6OmxheW91dExpbmUoTGluZUJ1aWxkZXImIGxpbmUsCiAgICAgYXV0byBsaW5lQnJlYWtl ciA9IExpbmVCcmVha2VyIHsgfTsKICAgICBhdXRvIGN1cnJlbnRJdGVtSW5kZXggPSBsZWFkaW5n SW5saW5lSXRlbUluZGV4OwogICAgIHVuc2lnbmVkIGNvbW1pdHRlZElubGluZUl0ZW1Db3VudCA9 IDA7CisgICAgYXV0byBjYW5kaWRhdGVDb250ZW50ID0gTGluZUNhbmRpZGF0ZUNvbnRlbnQgeyB9 OwogICAgIHdoaWxlIChjdXJyZW50SXRlbUluZGV4IDwgbV9pbmxpbmVJdGVtcy5zaXplKCkpIHsK ICAgICAgICAgLy8gMS4gQ29sbGVjdCB0aGUgc2V0IG9mIHJ1bnMgdGhhdCB3ZSBjYW4gY29tbWl0 IHRvIHRoZSBsaW5lIGFzIG9uZSBlbnRpdHkgZS5nLiA8c3Bhbj50ZXh0X2FuZF9zcGFuX3N0YXJ0 X3NwYW5fZW5kPC9zcGFuPi4KICAgICAgICAgLy8gMi4gQXBwbHkgZmxvYXRzIGFuZCBzaHJpbmsg dGhlIGF2YWlsYWJsZSBob3Jpem9udGFsIHNwYWNlIGUuZy4gPHNwYW4+aW50cnVfPGRpdiBzdHls ZT0iZmxvYXQ6IGxlZnQiPjwvZGl2PnNpdmVfZmxvYXQ8L3NwYW4+LgogICAgICAgICAvLyAzLiBD aGVjayBpZiB0aGUgY29udGVudCBmaXRzIHRoZSBsaW5lIGFuZCBjb21taXQgdGhlIGNvbnRlbnQg YWNjb3JkaW5nbHkgKGZ1bGwsIHBhcnRpYWwgb3Igbm90IGNvbW1pdCBhdCBhbGwpLgogICAgICAg ICAvLyA0LiBSZXR1cm4gaWYgd2UgYXJlIGF0IHRoZSBlbmQgb2YgdGhlIGxpbmUgZWl0aGVyIGJ5 IG5vdCBiZWluZyBhYmxlIHRvIGZpdCBtb3JlIGNvbnRlbnQgb3IgYmVjYXVzZSBvZiBhbiBleHBs aWNpdCBsaW5lIGJyZWFrLgotICAgICAgICBhdXRvIGNhbmRpZGF0ZUNvbnRlbnQgPSBuZXh0Q29u dGVudEZvckxpbmUoY3VycmVudEl0ZW1JbmRleCwgcGFydGlhbExlYWRpbmdDb250ZW50TGVuZ3Ro LCBsaW5lLmxpbmVCb3goKS5sb2dpY2FsV2lkdGgoKSk7CisgICAgICAgIG5leHRDb250ZW50Rm9y TGluZShjYW5kaWRhdGVDb250ZW50LCBjdXJyZW50SXRlbUluZGV4LCBwYXJ0aWFsTGVhZGluZ0Nv bnRlbnRMZW5ndGgsIGxpbmUubGluZUJveCgpLmxvZ2ljYWxXaWR0aCgpKTsKICAgICAgICAgaWYg KGNhbmRpZGF0ZUNvbnRlbnQuaGFzSW50cnVzaXZlRmxvYXRzKCkpIHsKICAgICAgICAgICAgIC8v IEFkZCBmbG9hdHMgZmlyc3QgYmVjYXVzZSB0aGV5IHNocmluayB0aGUgYXZhaWxhYmxlIGhvcml6 b250YWwgc3BhY2UgZm9yIHRoZSByZXN0IG9mIHRoZSBjb250ZW50LgogICAgICAgICAgICAgYXV0 byByZXN1bHQgPSB0cnlBZGRpbmdGbG9hdEl0ZW1zKGxpbmUsIGNhbmRpZGF0ZUNvbnRlbnQuZmxv YXRzKCkpOwpAQCAtMzI4LDkgKzMzOCwxMCBAQCBMaW5lTGF5b3V0Q29udGV4dDo6TGluZUNvbnRl bnQgTGluZUxheW91dENvbnRleHQ6OmNsb3NlKExpbmVCdWlsZGVyJiBsaW5lLCB1bnNpZwogICAg IHJldHVybiBMaW5lQ29udGVudCB7IHRyYWlsaW5nSW5saW5lSXRlbUluZGV4LCBwYXJ0aWFsQ29u dGVudCwgV1RGTW92ZShtX2Zsb2F0cyksIGxpbmUuY2xvc2UoaXNMYXN0TGluZVdpdGhJbmxpbmVD b250ZW50KSwgbGluZS5saW5lQm94KCkgfTsKIH0KIAotTGluZUNhbmRpZGF0ZUNvbnRlbnQgTGlu ZUxheW91dENvbnRleHQ6Om5leHRDb250ZW50Rm9yTGluZSh1bnNpZ25lZCBpbmxpbmVJdGVtSW5k ZXgsIE9wdGlvbmFsPHVuc2lnbmVkPiBwYXJ0aWFsTGVhZGluZ0NvbnRlbnRMZW5ndGgsIElubGlu ZUxheW91dFVuaXQgY3VycmVudExvZ2ljYWxSaWdodCkKK3ZvaWQgTGluZUxheW91dENvbnRleHQ6 Om5leHRDb250ZW50Rm9yTGluZShMaW5lQ2FuZGlkYXRlQ29udGVudCYgY2FuZGlkYXRlQ29udGVu dCwgdW5zaWduZWQgaW5saW5lSXRlbUluZGV4LCBPcHRpb25hbDx1bnNpZ25lZD4gcGFydGlhbExl YWRpbmdDb250ZW50TGVuZ3RoLCBJbmxpbmVMYXlvdXRVbml0IGN1cnJlbnRMb2dpY2FsUmlnaHQp CiB7CiAgICAgQVNTRVJUKGlubGluZUl0ZW1JbmRleCA8IG1faW5saW5lSXRlbXMuc2l6ZSgpKTsK KyAgICBjYW5kaWRhdGVDb250ZW50LnJlc2V0KCk7CiAgICAgLy8gMS4gU2ltcGx5IGFkZCBhbnkg b3ZlcmZsb3cgY29udGVudCBmcm9tIHRoZSBwcmV2aW91cyBsaW5lIHRvIHRoZSBjYW5kaWRhdGUg Y29udGVudC4gSXQncyBhbHdheXMgYSB0ZXh0IGNvbnRlbnQuCiAgICAgLy8gMi4gRmluZCB0aGUg bmV4dCBzb2Z0IHdyYXAgcG9zaXRpb24gb3IgZXhwbGljaXQgbGluZSBicmVhay4KICAgICAvLyAz LiBDb2xsZWN0IGZsb2F0cyBiZXR3ZWVuIHRoZSBpbmxpbmUgY29udGVudC4KQEAgLTMzOCw3ICsz NDksNiBAQCBMaW5lQ2FuZGlkYXRlQ29udGVudCBMaW5lTGF5b3V0Q29udGV4dDo6bmV4dENvbnRl bnRGb3JMaW5lKHVuc2lnbmVkIGlubGluZUl0ZW1JbgogICAgIC8vIHNvZnRXcmFwT3Bwb3J0dW5p dHlJbmRleCA9PSBtX2lubGluZUl0ZW1zLnNpemUoKSBtZWFucyB3ZSBkb24ndCBoYXZlIGFueSB3 cmFwIG9wcG9ydHVuaXR5IGluIHRoaXMgY29udGVudC4KICAgICBBU1NFUlQoc29mdFdyYXBPcHBv cnR1bml0eUluZGV4IDw9IG1faW5saW5lSXRlbXMuc2l6ZSgpKTsKIAotICAgIGF1dG8gY2FuZGlk YXRlQ29udGVudCA9IExpbmVDYW5kaWRhdGVDb250ZW50IHsgfTsKICAgICBpZiAocGFydGlhbExl YWRpbmdDb250ZW50TGVuZ3RoKSB7CiAgICAgICAgIC8vIEhhbmRsZSBsZWFkaW5nIHBhcnRpYWwg Y29udGVudCBmaXJzdCAoc3BsaXQgdGV4dCBmcm9tIHRoZSBwcmV2aW91cyBsaW5lKS4KICAgICAg ICAgLy8gQ29uc3RydWN0IGEgcGFydGlhbCBsZWFkaW5nIGlubGluZSBpdGVtLgpAQCAtMzYxLDcg KzM3MSw2IEBAIExpbmVDYW5kaWRhdGVDb250ZW50IExpbmVMYXlvdXRDb250ZXh0OjpuZXh0Q29u dGVudEZvckxpbmUodW5zaWduZWQgaW5saW5lSXRlbUluCiAgICAgICAgIGNhbmRpZGF0ZUNvbnRl bnQuYXBwZW5kKGlubGluZUl0ZW0sIGlubGluZUl0ZW5tV2lkdGgpOwogICAgICAgICBjdXJyZW50 TG9naWNhbFJpZ2h0ICs9IGlubGluZUl0ZW5tV2lkdGg7CiAgICAgfQotICAgIHJldHVybiBjYW5k aWRhdGVDb250ZW50OwogfQogCiBMaW5lTGF5b3V0Q29udGV4dDo6UmVzdWx0IExpbmVMYXlvdXRD b250ZXh0Ojp0cnlBZGRpbmdGbG9hdEl0ZW1zKExpbmVCdWlsZGVyJiBsaW5lLCBjb25zdCBGbG9h dExpc3QmIGZsb2F0cykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVm b3JtYXR0aW5nL0xpbmVMYXlvdXRDb250ZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5s aW5lZm9ybWF0dGluZy9MaW5lTGF5b3V0Q29udGV4dC5oCmluZGV4IGE3NWRjNGE0NDQ5ZGI5Zjkz Y2VmMDU5ZDU3NjQ0N2Q3MGRlMDJkMmYuLmY0MDI5ODUzMDMyZWNjZTcxOTViYjMyYTI4ZGRmNmYw MzM4MmMzYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0 aW5nL0xpbmVMYXlvdXRDb250ZXh0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvTGluZUxheW91dENvbnRleHQuaApAQCAtNTQsNyArNTQsNyBAQCBwdWJsaWM6 CiAgICAgdXNpbmcgRmxvYXRMaXN0ID0gVmVjdG9yPFdlYWtQdHI8SW5saW5lSXRlbT4+OwogCiBw cml2YXRlOgotICAgIExpbmVDYW5kaWRhdGVDb250ZW50IG5leHRDb250ZW50Rm9yTGluZSh1bnNp Z25lZCBpbmxpbmVJdGVtSW5kZXgsIE9wdGlvbmFsPHVuc2lnbmVkPiBvdmVyZmxvd0xlbmd0aCwg SW5saW5lTGF5b3V0VW5pdCBjdXJyZW50TG9naWNhbFJpZ2h0KTsKKyAgICB2b2lkIG5leHRDb250 ZW50Rm9yTGluZShMaW5lQ2FuZGlkYXRlQ29udGVudCYsIHVuc2lnbmVkIGlubGluZUl0ZW1JbmRl eCwgT3B0aW9uYWw8dW5zaWduZWQ+IG92ZXJmbG93TGVuZ3RoLCBJbmxpbmVMYXlvdXRVbml0IGN1 cnJlbnRMb2dpY2FsUmlnaHQpOwogICAgIHN0cnVjdCBSZXN1bHQgewogICAgICAgICBMaW5lQnJl YWtlcjo6SXNFbmRPZkxpbmUgaXNFbmRPZkxpbmUgeyBMaW5lQnJlYWtlcjo6SXNFbmRPZkxpbmU6 Ok5vIH07CiAgICAgICAgIHNpemVfdCBjb21taXR0ZWRDb3VudCB7IDAgfTsK