206294 2020-01-15 09:39:35 -0800 webkitpy: Remove self assignments 2020-01-15 11:34:11 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain bburg commit-queue ews-watchlist glenn hi joepeck keith_miller mark.lam msaboff saam slewis tzagallo webkit-bug-importer oldest_to_newest 1606955 0 jbedard 2020-01-15 09:39:35 -0800 There are a number of places in webkitpy where we assign a value to itself. This is silly, we should remove this unneeded code. 1606958 1 387795 jbedard 2020-01-15 09:44:33 -0800 Created attachment 387795 Patch 1606960 2 ews-watchlist 2020-01-15 09:45:35 -0800 This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) 1607040 3 387795 commit-queue 2020-01-15 11:33:57 -0800 Comment on attachment 387795 Patch Clearing flags on attachment: 387795 Committed r254625: <https://trac.webkit.org/changeset/254625> 1607041 4 commit-queue 2020-01-15 11:33:59 -0800 All reviewed patches have been landed. Closing bug. 1607042 5 webkit-bug-importer 2020-01-15 11:34:11 -0800 <rdar://problem/58612977> 387795 2020-01-15 09:44:33 -0800 2020-01-15 11:33:57 -0800 Patch bug-206294-20200115094433.patch text/plain 3275 jbedard SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjU0NTcxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDIwLTAxLTE1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAg ICAgICB3ZWJraXRweTogUmVtb3ZlIHNlbGYgYXNzaWdubWVudHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjI5NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL3NjcmlwdHMvY29kZWdl bi9nZW5lcmF0b3IucHk6CisgICAgICAgIChHZW5lcmF0b3IuanNfbmFtZV9mb3JfcGFyYW1ldGVy X3R5cGUpOgorCiAyMDIwLTAxLTE0ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0 Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjU0NDgwLCByMjU0NDk2 LCBhbmQgcjI1NDUxNy4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2Ny aXB0cy9jb2RlZ2VuL2dlbmVyYXRvci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvY29kZWdlbi9nZW5lcmF0b3IucHkJKHJldmlzaW9uIDI1 NDU3MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy9jb2RlZ2Vu L2dlbmVyYXRvci5weQkod29ya2luZyBjb3B5KQpAQCAtMjk1LDcgKzI5NSw2IEBAIGNsYXNzIEdl bmVyYXRvcjoKIAogICAgIEBzdGF0aWNtZXRob2QKICAgICBkZWYganNfbmFtZV9mb3JfcGFyYW1l dGVyX3R5cGUoX3R5cGUpOgotICAgICAgICBfdHlwZSA9IF90eXBlCiAgICAgICAgIGlmIGlzaW5z dGFuY2UoX3R5cGUsIEFsaWFzZWRUeXBlKToKICAgICAgICAgICAgIF90eXBlID0gX3R5cGUuYWxp YXNlZF90eXBlICAjIEZhbGwgdGhyb3VnaC4KICAgICAgICAgaWYgaXNpbnN0YW5jZShfdHlwZSwg RW51bVR5cGUpOgpJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0No YW5nZUxvZwkocmV2aXNpb24gMjU0NTcxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDEtMTUgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRh cmRAYXBwbGUuY29tPgorCisgICAgICAgIHdlYmtpdHB5OiBSZW1vdmUgc2VsZiBhc3NpZ25tZW50 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2Mjk0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi93ZWJraXRfZmluZGVyLnB5OgorICAgICAgICAoV2ViS2l0Rmlu ZGVyLndlYmtpdF9iYXNlKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvZmFjdG9y eS5weToKKyAgICAgICAgKF9idWlsZGVyX29wdGlvbnMpOgorCiAyMDIwLTAxLTE1ICBBbGljaWEg Qm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1RGXSBSZW1vdmUg TWVkaWFUaW1lLmNwcCB0ZXN0IHdhcm5pbmcgaW4gR0NDCkluZGV4OiBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi93ZWJraXRfZmluZGVyLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL3dlYmtpdF9maW5kZXIucHkJKHJldmlzaW9uIDI1NDU3MSkKKysr IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3dlYmtpdF9maW5kZXIucHkJKHdvcmtpbmcg Y29weSkKQEAgLTQ0LDcgKzQ0LDYgQEAgY2xhc3MgV2ViS2l0RmluZGVyKG9iamVjdCk6CiAgICAg ICAgICMgKHRoZSBjaHJvbWl1bSB0ZXN0IGJvdHMsIGZvciBleGFtcGxlKSwgbWlnaHQgb25seSBj aGVjayBvdXQgc3ViZGlyZWN0b3JpZXMgbGlrZQogICAgICAgICAjIFRvb2xzL1NjcmlwdHMuIFRo aXMgY29kZSB3aWxsIGFsc28gd29yayBpZiB0aGVyZSBpcyBubyBTQ00gc3lzdGVtIGF0IGFsbC4K ICAgICAgICAgaWYgbm90IHNlbGYuX3dlYmtpdF9iYXNlOgotICAgICAgICAgICAgc2VsZi5fd2Vi a2l0X2Jhc2UgPSBzZWxmLl93ZWJraXRfYmFzZQogICAgICAgICAgICAgbW9kdWxlX3BhdGggPSBz ZWxmLl9maWxlc3lzdGVtLnBhdGhfdG9fbW9kdWxlKHNlbGYuX19tb2R1bGVfXykKICAgICAgICAg ICAgIHRvb2xzX2luZGV4ID0gbW9kdWxlX3BhdGgucmZpbmQoJ1Rvb2xzJykKICAgICAgICAgICAg IGFzc2VydCB0b29sc19pbmRleCAhPSAtMSwgImNvdWxkIG5vdCBmaW5kIGxvY2F0aW9uIG9mIHRo aXMgY2hlY2tvdXQgZnJvbSAlcyIgJSBtb2R1bGVfcGF0aApJbmRleDogVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L2ZhY3RvcnkucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wb3J0L2ZhY3RvcnkucHkJKHJldmlzaW9uIDI1NDU3MSkKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC9mYWN0b3J5LnB5CSh3b3JraW5nIGNvcHkpCkBAIC05MSw3ICs5MSw2IEBA IGRlZiBjb25maWd1cmF0aW9uX29wdGlvbnMoKToKIGRlZiBfYnVpbGRlcl9vcHRpb25zKGJ1aWxk ZXJfbmFtZSk6CiAgICAgY29uZmlndXJhdGlvbiA9ICJEZWJ1ZyIgaWYgcmUuc2VhcmNoKHIiW2R8 RF0oZWJ1fGIpZyIsIGJ1aWxkZXJfbmFtZSkgZWxzZSAiUmVsZWFzZSIKICAgICBpc193ZWJraXQy ID0gYnVpbGRlcl9uYW1lLmZpbmQoIldLMiIpICE9IC0xCi0gICAgYnVpbGRlcl9uYW1lID0gYnVp bGRlcl9uYW1lCiAgICAgcmV0dXJuIG9wdHBhcnNlLlZhbHVlcyh7J2J1aWxkZXJfbmFtZSc6IGJ1 aWxkZXJfbmFtZSwgJ2NvbmZpZ3VyYXRpb24nOiBjb25maWd1cmF0aW9uLCAnd2Via2l0X3Rlc3Rf cnVubmVyJzogaXNfd2Via2l0Mn0pCiAKIAo=