206259 2020-01-14 14:20:38 -0800 Regression r254533: iOS and mac build broken 2020-01-14 15:30:28 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206112 InRadar P2 Normal --- 1 aakash_jain jiewen_tan achristensen ap jiewen_tan ryanhaddad webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1606589 0 aakash_jain 2020-01-14 14:20:38 -0800 r254533 seems to have broken iOS and mac builds. e.g.: https://build.webkit.org/builders/Apple%20Mojave%20Debug%20%28Build%29/builds/11790 https://build.webkit.org/builders/Apple%20iOS%2013%20Release%20%28Build%29/builds/3286 Relevant build error:/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.1.sdk/usr/include/objc/runtime.h:634:47: error: reference to 'Protocol' is ambiguous 1606597 1 ryanhaddad 2020-01-14 14:26:35 -0800 In file included from /Volumes/Data/slave/mojave-debug/build/WebKitBuild/Debug/DerivedSources/WebKit2/unified-sources/UnifiedSource55.cpp:1: /Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.cpp:42:17: error: member access into incomplete type 'WebKit::CtapDriver' m_driver->cancel(); ^ In file included from /Volumes/Data/slave/mojave-debug/build/WebKitBuild/Debug/DerivedSources/WebKit2/unified-sources/UnifiedSource55.cpp:1: In file included from /Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.cpp:27: /Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.h:34:7: note: forward declaration of 'WebKit::CtapDriver' class CtapDriver; ^ 1606601 2 jiewen_tan 2020-01-14 14:31:23 -0800 Committed r254535: <https://trac.webkit.org/changeset/254535> 1606603 3 webkit-bug-importer 2020-01-14 14:32:12 -0800 <rdar://problem/58582018> 1606618 4 aakash_jain 2020-01-14 15:04:31 -0800 (In reply to Jiewen Tan from comment #2) > Committed r254535: <https://trac.webkit.org/changeset/254535> Build is still broken. e.g.: https://build.webkit.org/builders/Apple-Catalina-Release-Build/builds/2446 1606632 5 ap 2020-01-14 15:30:28 -0800 Ryan reverted the change and the first build fix attempt.