20624 2008-09-03 05:24:50 -0700 WebKit-gtk uses deprecated GtkType/GtkObject 2008-10-05 18:43:38 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 chris webkit-unassigned christian oldest_to_newest 90011 0 chris 2008-09-03 05:24:50 -0700 The plugin widget in webkit-gtk uses GtkType instead of GType. The means it fails to build with GTK without deprecated functions enabled (and will fail to build when these functions are removed). The attached patch fixes that (and works fine, in my testing). 90012 1 23138 chris 2008-09-03 05:25:51 -0700 Created attachment 23138 Patch to remove deprecated Gtk types/functions in webkit-gtk 90021 2 23142 chris 2008-09-03 08:22:19 -0700 Created attachment 23142 Patch to remove deprecated Gtk types/functions in webkit-gtk Fixed coding style (hopefully). 90753 3 christian 2008-09-10 03:54:53 -0700 (In reply to comment #2) > Created an attachment (id=23142) [edit] > Patch to remove deprecated Gtk types/functions in webkit-gtk > > Fixed coding style (hopefully). While you are at it, can't we use G_DEFINE_TYPE? Btw you should mark patches with a ? if you want them to be reviewed. 94148 4 23142 jmalonzo 2008-10-05 04:28:32 -0700 Comment on attachment 23142 Patch to remove deprecated Gtk types/functions in webkit-gtk setting patch for review... 94184 5 23142 alp 2008-10-05 16:09:44 -0700 Comment on attachment 23142 Patch to remove deprecated Gtk types/functions in webkit-gtk r=me (assuming you checked and it doesn't break Xt plugins) Cheers 94196 6 jmalonzo 2008-10-05 18:43:38 -0700 Thanks guys. Landed in r37322 23138 2008-09-03 05:25:51 -0700 2008-09-03 08:22:19 -0700 Patch to remove deprecated Gtk types/functions in webkit-gtk fix-gtk-deprecation.patch text/plain 1749 chris SW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9ndGsvZ3RrMnh0YmluLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbHVnaW5zL2d0ay9ndGsyeHRiaW4uaAkocmV2aXNpb24gMzYwMjkpCisrKyBXZWJDb3Jl L3BsdWdpbnMvZ3RrL2d0azJ4dGJpbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDAsNyArMTAwLDcg QEAKICAgR3RrU29ja2V0Q2xhc3Mgd2lkZ2V0X2NsYXNzOwogfTsKIAotR1RLWFRCSU5fQVBJKEd0 a1R5cGUpICAgICBndGtfeHRiaW5fZ2V0X3R5cGUgKHZvaWQpOworR1RLWFRCSU5fQVBJKEdUeXBl KSAgICAgZ3RrX3h0YmluX2dldF90eXBlICh2b2lkKTsKIEdUS1hUQklOX0FQSShHdGtXaWRnZXQg KikgZ3RrX3h0YmluX25ldyAoR2RrV2luZG93ICpwYXJlbnRfd2luZG93LCBTdHJpbmcgKmYpOwog R1RLWFRCSU5fQVBJKHZvaWQpICAgICAgICBndGtfeHRiaW5fc2V0X3Bvc2l0aW9uIChHdGtYdEJp biAqeHRiaW4sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGdpbnQgICAgICAgeCwKSW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9ndGsvZ3RrMnh0YmluLmMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9wbHVnaW5zL2d0ay9ndGsyeHRiaW4uYwkocmV2aXNpb24g MzYwMjkpCisrKyBXZWJDb3JlL3BsdWdpbnMvZ3RrL2d0azJ4dGJpbi5jCSh3b3JraW5nIGNvcHkp CkBAIC0yMTMsMjQgKzIxMywzMCBAQAogICByZXR1cm4gVFJVRTsKIH0KIAotR3RrVHlwZQorR1R5 cGUKIGd0a194dGJpbl9nZXRfdHlwZSAodm9pZCkKIHsKLSAgc3RhdGljIEd0a1R5cGUgeHRiaW5f dHlwZSA9IDA7CisgIHN0YXRpYyBHVHlwZSB4dGJpbl90eXBlID0gMDsKIAogICBpZiAoIXh0Ymlu X3R5cGUpIHsKICAgICAgIHN0YXRpYyBjb25zdCBHdGtUeXBlSW5mbyB4dGJpbl9pbmZvID0KICAg ICAgIHsKLSAgICAgICAgIkd0a1h0QmluIiwKKyAgICAgICAgc2l6ZW9mIChHdGtYdEJpbkNsYXNz KSwKKyAgICAgICAgTlVMTCwKKwlOVUxMLAorCisgICAgICAgIChHQ2xhc3NJbml0RnVuYykgZ3Rr X3h0YmluX2NsYXNzX2luaXQsCisgICAgICAgIE5VTEwsCisgICAgICAgIE5VTEwsCisKICAgICAg ICAgc2l6ZW9mIChHdGtYdEJpbiksCi0gICAgICAgIHNpemVvZiAoR3RrWHRCaW5DbGFzcyksCi0g ICAgICAgIChHdGtDbGFzc0luaXRGdW5jKSBndGtfeHRiaW5fY2xhc3NfaW5pdCwKLSAgICAgICAg KEd0a09iamVjdEluaXRGdW5jKSBndGtfeHRiaW5faW5pdCwKLSAgICAgICAgLyogcmVzZXJ2ZWRf MSAqLyBOVUxMLAotICAgICAgICAvKiByZXNlcnZlZF8yICovIE5VTEwsCi0gICAgICAgIChHdGtD bGFzc0luaXRGdW5jKSBOVUxMCisJMCwKKwkoR0luc3RhbmNlSW5pdEZ1bmMpIGd0a194dGJpbl9p bml0LAogICAgICAgfTsKLSAgICAgIHh0YmluX3R5cGUgPSBndGtfdHlwZV91bmlxdWUgKEdUS19U WVBFX1NPQ0tFVCwgJnh0YmluX2luZm8pOworICAgICAgeHRiaW5fdHlwZSA9IGdfdHlwZV9yZWdp c3Rlcl9zdGF0aWMgKEdUS19UWVBFX1NPQ0tFVCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiR3RrWHRCaW4iLAorCQkJCQkgICAmeHRiaW5faW5mbywKKwkJCQkJ ICAgMCk7CiAgICAgfQogICByZXR1cm4geHRiaW5fdHlwZTsKIH0K 23142 2008-09-03 08:22:19 -0700 2008-10-05 16:09:44 -0700 Patch to remove deprecated Gtk types/functions in webkit-gtk fix-gtk-deprecation.patch text/plain 1820 chris SW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9ndGsvZ3RrMnh0YmluLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbHVnaW5zL2d0ay9ndGsyeHRiaW4uaAkocmV2aXNpb24gMzYwMjkpCisrKyBXZWJDb3Jl L3BsdWdpbnMvZ3RrL2d0azJ4dGJpbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDAsNyArMTAwLDcg QEAKICAgR3RrU29ja2V0Q2xhc3Mgd2lkZ2V0X2NsYXNzOwogfTsKIAotR1RLWFRCSU5fQVBJKEd0 a1R5cGUpICAgICBndGtfeHRiaW5fZ2V0X3R5cGUgKHZvaWQpOworR1RLWFRCSU5fQVBJKEdUeXBl KSAgICAgICBndGtfeHRiaW5fZ2V0X3R5cGUgKHZvaWQpOwogR1RLWFRCSU5fQVBJKEd0a1dpZGdl dCAqKSBndGtfeHRiaW5fbmV3IChHZGtXaW5kb3cgKnBhcmVudF93aW5kb3csIFN0cmluZyAqZik7 CiBHVEtYVEJJTl9BUEkodm9pZCkgICAgICAgIGd0a194dGJpbl9zZXRfcG9zaXRpb24gKEd0a1h0 QmluICp4dGJpbiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgZ2ludCAgICAgICB4LApJbmRleDogV2ViQ29yZS9wbHVnaW5zL2d0ay9ndGsyeHRiaW4u Ywo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvZ3RrL2d0azJ4dGJpbi5jCShyZXZpc2lv biAzNjAyOSkKKysrIFdlYkNvcmUvcGx1Z2lucy9ndGsvZ3RrMnh0YmluLmMJKHdvcmtpbmcgY29w eSkKQEAgLTIxMywyNSArMjEzLDMxIEBACiAgIHJldHVybiBUUlVFOwogfQogCi1HdGtUeXBlCitH VHlwZQogZ3RrX3h0YmluX2dldF90eXBlICh2b2lkKQogewotICBzdGF0aWMgR3RrVHlwZSB4dGJp bl90eXBlID0gMDsKKyAgc3RhdGljIEdUeXBlIHh0YmluX3R5cGUgPSAwOwogCiAgIGlmICgheHRi aW5fdHlwZSkgewotICAgICAgc3RhdGljIGNvbnN0IEd0a1R5cGVJbmZvIHh0YmluX2luZm8gPQor ICAgICAgc3RhdGljIGNvbnN0IEdUeXBlSW5mbyB4dGJpbl9pbmZvID0KICAgICAgIHsKLSAgICAg ICAgIkd0a1h0QmluIiwKKyAgICAgICAgc2l6ZW9mIChHdGtYdEJpbkNsYXNzKSwKKyAgICAgICAg TlVMTCwKKyAgICAgICAgTlVMTCwKKworICAgICAgICAoR0NsYXNzSW5pdEZ1bmMpZ3RrX3h0Ymlu X2NsYXNzX2luaXQsCisgICAgICAgIE5VTEwsCisgICAgICAgIE5VTEwsCisKICAgICAgICAgc2l6 ZW9mIChHdGtYdEJpbiksCi0gICAgICAgIHNpemVvZiAoR3RrWHRCaW5DbGFzcyksCi0gICAgICAg IChHdGtDbGFzc0luaXRGdW5jKSBndGtfeHRiaW5fY2xhc3NfaW5pdCwKLSAgICAgICAgKEd0a09i amVjdEluaXRGdW5jKSBndGtfeHRiaW5faW5pdCwKLSAgICAgICAgLyogcmVzZXJ2ZWRfMSAqLyBO VUxMLAotICAgICAgICAvKiByZXNlcnZlZF8yICovIE5VTEwsCi0gICAgICAgIChHdGtDbGFzc0lu aXRGdW5jKSBOVUxMCisgICAgICAgIDAsCisgICAgICAgIChHSW5zdGFuY2VJbml0RnVuYylndGtf eHRiaW5faW5pdCwKICAgICAgIH07Ci0gICAgICB4dGJpbl90eXBlID0gZ3RrX3R5cGVfdW5pcXVl IChHVEtfVFlQRV9TT0NLRVQsICZ4dGJpbl9pbmZvKTsKLSAgICB9CisgICAgICB4dGJpbl90eXBl ID0gZ190eXBlX3JlZ2lzdGVyX3N0YXRpYyAoR1RLX1RZUEVfU09DS0VULAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJHdGtYdEJpbiIsCisJCQkJCSAgICZ4dGJp bl9pbmZvLAorCQkJCQkgICAwKTsKKyAgfQogICByZXR1cm4geHRiaW5fdHlwZTsKIH0KIAo=