206239 2020-01-14 09:05:54 -0800 Supported mime types for encoding should be supported mime types for loading 2020-01-14 15:45:59 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa commit-queue dino simon.fraser webkit-bug-importer oldest_to_newest 1606424 0 sabouhallawa 2020-01-14 09:05:54 -0800 It does not make sense to allow unsupported mime types for canvas.toDataURL(). If the system allows encoding to them, we are going to return DataURL that we do not allow loading. 1606426 1 sabouhallawa 2020-01-14 09:10:39 -0800 <rdar://problem/55512630> 1606431 2 387664 sabouhallawa 2020-01-14 09:22:53 -0800 Created attachment 387664 Patch 1606644 3 387664 commit-queue 2020-01-14 15:45:58 -0800 Comment on attachment 387664 Patch Clearing flags on attachment: 387664 Committed r254541: <https://trac.webkit.org/changeset/254541> 1606645 4 commit-queue 2020-01-14 15:45:59 -0800 All reviewed patches have been landed. Closing bug. 387664 2020-01-14 09:22:53 -0800 2020-01-14 15:45:58 -0800 Patch bug-206239-20200114092252.patch text/plain 4760 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1NDUxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAxLTE0ICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgU3VwcG9ydGVk IG1pbWUgdHlwZXMgZm9yIGVuY29kaW5nIHNob3VsZCBiZSBzdXBwb3J0ZWQgbWltZSB0eXBlcyBm b3IgbG9hZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA2MjM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ29uc3VsdCBpc1N1cHBvcnRlZEltYWdlVHlwZSgpIGZvciB0aGUgc3lzdGVtIHN1cHBvcnRl ZCBVVEkgYmVmb3JlCisgICAgICAgIGNvbnNpZGVyaW5nIGl0cyBtaW1lIHR5cGUgaXMgYWxsb3dl ZCBmb3IgdGhlIGltYWdlIERhdGFVUkwgZW5jb2RpbmcuCisKKyAgICAgICAgVGVzdDogZmFzdC9j YW52YXMvdG9EYXRhVVJMLXVuc3VwcG9ydGVkVHlwZXMuaHRtbAorCisgICAgICAgICogcGxhdGZv cm0vTUlNRVR5cGVSZWdpc3RyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNSU1FVHlwZVJlZ2lz dHJ5OjpjcmVhdGVNSU1FVHlwZVJlZ2lzdHJ5VGhyZWFkR2xvYmFsRGF0YSk6CisKIDIwMjAtMDEt MTQgIFBlbmcgTGl1ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KIAogICAgICAgICBBIHZpZGVvIGVs ZW1lbnQgY2Fubm90IGVudGVyIGZ1bGxzY3JlZW4gZnJvbSBQaVAgbW9kZQpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHAJKHJldmlzaW9uIDI1NDMx NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnkuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC00NDYsOSArNDQ2LDEwIEBAIHN0ZDo6dW5pcXVlX3B0cjxNSU1FVHlwZVJl Z2lzdHJ5VGhyZWFkR2wKICAgICBDRkluZGV4IGNvdW50ID0gQ0ZBcnJheUdldENvdW50KHN1cHBv cnRlZFR5cGVzLmdldCgpKTsKICAgICBmb3IgKENGSW5kZXggaSA9IDA7IGkgPCBjb3VudDsgaSsr KSB7CiAgICAgICAgIENGU3RyaW5nUmVmIHN1cHBvcnRlZFR5cGUgPSByZWludGVycHJldF9jYXN0 PENGU3RyaW5nUmVmPihDRkFycmF5R2V0VmFsdWVBdEluZGV4KHN1cHBvcnRlZFR5cGVzLmdldCgp LCBpKSk7Ci0gICAgICAgIFN0cmluZyBtaW1lVHlwZSA9IE1JTUVUeXBlRm9ySW1hZ2VUeXBlKHN1 cHBvcnRlZFR5cGUpOwotICAgICAgICBpZiAoIW1pbWVUeXBlLmlzRW1wdHkoKSkKKyAgICAgICAg aWYgKGlzU3VwcG9ydGVkSW1hZ2VUeXBlKHN1cHBvcnRlZFR5cGUpKSB7CisgICAgICAgICAgICBT dHJpbmcgbWltZVR5cGUgPSBNSU1FVHlwZUZvckltYWdlVHlwZShzdXBwb3J0ZWRUeXBlKTsKICAg ICAgICAgICAgIHN1cHBvcnRlZEltYWdlTUlNRVR5cGVzRm9yRW5jb2RpbmcuYWRkKG1pbWVUeXBl KTsKKyAgICAgICAgfQogICAgIH0KICNlbHNlCiAgICAgSGFzaFNldDxTdHJpbmcsIEFTQ0lJQ2Fz ZUluc2Vuc2l0aXZlSGFzaD4gc3VwcG9ydGVkSW1hZ2VNSU1FVHlwZXNGb3JFbmNvZGluZyA9IHN0 ZDo6aW5pdGlhbGl6ZXJfbGlzdDxTdHJpbmc+IHsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1NDMxNykK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTAxLTE0ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+ CisKKyAgICAgICAgU3VwcG9ydGVkIG1pbWUgdHlwZXMgZm9yIGVuY29kaW5nIHNob3VsZCBiZSBz dXBwb3J0ZWQgbWltZSB0eXBlcyBmb3IgbG9hZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MjM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2NhbnZhcy90b0RhdGFVUkwtdW5zdXBwb3J0 ZWRUeXBlcy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY2FudmFzL3RvRGF0 YVVSTC11bnN1cHBvcnRlZFR5cGVzLmh0bWw6IEFkZGVkLgorICAgICAgICBVbnN1cHBvcnRlZCBt aW1lLXR5cGVzIGZvciBlbmNvZGluZyBzaG91bGQgZmFsbCBiYWNrIHRvICdpbWFnZS9wbmcnLgor CiAyMDIwLTAxLTA5ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT04gKHIyNTM2NjIpOiBMYXJnZSBEYXRhIFVSTHMgYXJlIG5vdCBiZWluZyBo YW5kbGVkIHByb3Blcmx5CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy90b0RhdGFVUkwt dW5zdXBwb3J0ZWRUeXBlcy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZmFzdC9jYW52YXMvdG9EYXRhVVJMLXVuc3VwcG9ydGVkVHlwZXMtZXhwZWN0ZWQudHh0CShub25l eGlzdGVudCkKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3RvRGF0YVVSTC11bnN1cHBvcnRl ZFR5cGVzLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE0IEBACitUaGlz IGlzIGEgdGVzdCBvZiB0aGUgdW5zdXBwb3J0ZWQgbWltZS10eXBlcyBmb3IgY2FudmFzLnRvRGF0 YVVSTCgpLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1l c3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBjYW52YXMudG9E YXRhVVJMKCdpbWFnZS9oZWljJykgaXMgY2FudmFzLnRvRGF0YVVSTCgnaW1hZ2UvcG5nJykKK1BB U1MgY2FudmFzLnRvRGF0YVVSTCgnaW1hZ2UvaGVpYy1zZXF1ZW5jZScpIGlzIGNhbnZhcy50b0Rh dGFVUkwoJ2ltYWdlL3BuZycpCitQQVNTIGNhbnZhcy50b0RhdGFVUkwoJ2ltYWdlL3ZuZC5hZG9i ZS5waG90b3Nob3AnKSBpcyBjYW52YXMudG9EYXRhVVJMKCdpbWFnZS9wbmcnKQorUEFTUyBjYW52 YXMudG9EYXRhVVJMKCdhcHBsaWNhdGlvbi9wZGYnKSBpcyBjYW52YXMudG9EYXRhVVJMKCdpbWFn ZS9wbmcnKQorUEFTUyBjYW52YXMudG9EYXRhVVJMKCdpbWFnZS90YXJnYScpIGlzIGNhbnZhcy50 b0RhdGFVUkwoJ2ltYWdlL3BuZycpCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisK K1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvdG9EYXRhVVJM LXVuc3VwcG9ydGVkVHlwZXMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nh bnZhcy90b0RhdGFVUkwtdW5zdXBwb3J0ZWRUeXBlcy5odG1sCShub25leGlzdGVudCkKKysrIExh eW91dFRlc3RzL2Zhc3QvY2FudmFzL3RvRGF0YVVSTC11bnN1cHBvcnRlZFR5cGVzLmh0bWwJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSwyMCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aGVhZD4KKyAg ICA8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K KzwvaGVhZD4KKzxib2R5PgorICAgIDxjYW52YXMgd2lkdGg9IjgiIGhlaWdodD0iOCI+PC9jYW52 YXM+CisgICAgPHNjcmlwdD4KKyAgICAgICAgdmFyIGNhbnZhcyA9IGRvY3VtZW50LnF1ZXJ5U2Vs ZWN0b3IoImNhbnZhcyIpOworICAgICAgICBjYW52YXMud2lkdGggPSA4OworICAgICAgICBjYW52 YXMuaGVpZ2h0ID0gODsKKworICAgICAgICBkZXNjcmlwdGlvbigiVGhpcyBpcyBhIHRlc3Qgb2Yg dGhlIHVuc3VwcG9ydGVkIG1pbWUtdHlwZXMgZm9yIGNhbnZhcy50b0RhdGFVUkwoKS4iKTsKKyAg ICAgICAgc2hvdWxkQmUoImNhbnZhcy50b0RhdGFVUkwoJ2ltYWdlL2hlaWMnKSIsICJjYW52YXMu dG9EYXRhVVJMKCdpbWFnZS9wbmcnKSIpOworICAgICAgICBzaG91bGRCZSgiY2FudmFzLnRvRGF0 YVVSTCgnaW1hZ2UvaGVpYy1zZXF1ZW5jZScpIiwgImNhbnZhcy50b0RhdGFVUkwoJ2ltYWdlL3Bu ZycpIik7CisgICAgICAgIHNob3VsZEJlKCJjYW52YXMudG9EYXRhVVJMKCdpbWFnZS92bmQuYWRv YmUucGhvdG9zaG9wJykiLCAiY2FudmFzLnRvRGF0YVVSTCgnaW1hZ2UvcG5nJykiKTsKKyAgICAg ICAgc2hvdWxkQmUoImNhbnZhcy50b0RhdGFVUkwoJ2FwcGxpY2F0aW9uL3BkZicpIiwgImNhbnZh cy50b0RhdGFVUkwoJ2ltYWdlL3BuZycpIik7CisgICAgICAgIHNob3VsZEJlKCJjYW52YXMudG9E YXRhVVJMKCdpbWFnZS90YXJnYScpIiwgImNhbnZhcy50b0RhdGFVUkwoJ2ltYWdlL3BuZycpIik7 CisgICAgPC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0 LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5Pgo=