206238 2020-01-14 09:02:27 -0800 [WTF] Remove MediaTime.cpp test warning in GCC 2020-01-15 03:46:21 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aboya aboya calvaris commit-queue cturner webkit-bug-importer oldest_to_newest 1606419 0 aboya 2020-01-14 09:02:27 -0800 GCC emits warnings when it finds clang pragmas, so I'm wrapping them in #ifdef __clang__ to reduce the noise. 1606423 1 387662 aboya 2020-01-14 09:05:31 -0800 Created attachment 387662 Patch 1606446 2 cturner 2020-01-14 09:35:07 -0800 I think the macros in Compiler.h (IGNORE_*) should be used/modified for these sorts of checks, they have logic to check for compiler support and probably other gotchas. 1606462 3 aboya 2020-01-14 10:11:58 -0800 (In reply to Charlie Turner from comment #2) > I think the macros in Compiler.h (IGNORE_*) should be used/modified for > these sorts of checks, they have logic to check for compiler support and > probably other gotchas. Thing is, these macros are made to ignore warnings in certain compilers. This code on the other hand is intended to turn a specific, disabled by default warning, into an error in clang. This specific warning is also only supported by clang. And since that code uses clang pragmas, GCC shows a warning, which now I'm trying to avoid. From a glance at Compiler.h I don't see how they could be used for this case. I could use `#if COMPILER(clang)` instead of `#ifdef __clang__` though. 1606464 4 387671 aboya 2020-01-14 10:15:09 -0800 Created attachment 387671 Patch 1606872 5 387671 commit-queue 2020-01-15 03:45:55 -0800 Comment on attachment 387671 Patch Clearing flags on attachment: 387671 Committed r254563: <https://trac.webkit.org/changeset/254563> 1606873 6 commit-queue 2020-01-15 03:45:56 -0800 All reviewed patches have been landed. Closing bug. 1606874 7 webkit-bug-importer 2020-01-15 03:46:21 -0800 <rdar://problem/58601295> 387662 2020-01-14 09:05:31 -0800 2020-01-14 10:15:06 -0800 Patch bug-206238-20200114180530.patch text/plain 1497 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NTExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYThiZThhMDg2NGJmMjQzZDExMWQ2ODk2MjRkNDI1NDRh NDQxYjg2NS4uMmEzYjE0YzZmMjI0NTU2YWRiYTdiYmUxYjJlMWUxYjhhZGZmNGI3MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTAxLTE0ICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4K KworICAgICAgICBbV1RGXSBSZW1vdmUgTWVkaWFUaW1lLmNwcCB0ZXN0IHdhcm5pbmcgaW4gR0ND CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYyMzgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHQ0MgZW1p dHMgd2FybmluZ3Mgd2hlbiBpdCBmaW5kcyBjbGFuZyBwcmFnbWFzLCBzbyBJJ20gd3JhcHBpbmcg dGhlbQorICAgICAgICBpbiAjaWZkZWYgX19jbGFuZ19fIHRvIHJlZHVjZSB0aGUgbm9pc2UuCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NZWRpYVRpbWUuY3BwOgorCiAyMDIw LTAxLTE0ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZD XVtJbnRlZ3JhdGlvbl0gU3VwcG9ydCB0aGUgZmVhdHVyZSBmbGFnIGluIER1bXBSZW5kZXJUcmVl CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NZWRpYVRpbWUuY3Bw IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWVkaWFUaW1lLmNwcAppbmRleCAyMWNk Y2YwOTljMTUyNDA0ZjM4MGY1Y2M4MWUxMmJkYzUxNDhkOGI4Li4zNzliNWZlODNkZTlmZjdkNTYz ZTE4MzU5NzAyYTNmNDFiNjM3NWM2IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dURi9NZWRpYVRpbWUuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RG L01lZGlhVGltZS5jcHAKQEAgLTU4LDEwICs1OCwxNCBAQCBuYW1lc3BhY2UgVGVzdFdlYktpdEFQ SSB7CiAKIC8vIE1lZGlhVGltZSB2YWx1ZXMgc2hvdWxkIGJlIGFibGUgdG8gYmUgZGVjbGFyZWQg c3RhdGljIGFueXdoZXJlLCBqdXN0IGxpa2UgeW91IGNhbiBkbyBzbyB3aXRoIGludGVnZXJzLgog Ly8gVGhpcyBzaG91bGQgbm90IHJlcXVpcmUgZ2xvYmFsIGNvbnN0cnVjdG9ycyBvciBkZXN0cnVj dG9ycy4KKyNpZmRlZiBfX2NsYW5nX18KICNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwdXNoCiAj cHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgZXJyb3IgIi1XZ2xvYmFsLWNvbnN0cnVjdG9ycyIKKyNl bmRpZgogc3RhdGljIGNvbnN0IE1lZGlhVGltZSBvbmVTZWNvbmQoMSwgMSk7CisjaWZkZWYgX19j bGFuZ19fCiAjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcG9wCisjZW5kaWYKIAogVEVTVChXVEYs IE1lZGlhVGltZSkKIHsK 387671 2020-01-14 10:15:09 -0800 2020-01-15 03:45:55 -0800 Patch bug-206238-20200114191508.patch text/plain 1506 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NTExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYThiZThhMDg2NGJmMjQzZDExMWQ2ODk2MjRkNDI1NDRh NDQxYjg2NS4uMDg2OWFhZjNkM2Y2YTQ3OTQzOTM0MTI5MTcwMjg0MTk3YTczOGZiOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTAxLTE0ICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4K KworICAgICAgICBbV1RGXSBSZW1vdmUgTWVkaWFUaW1lLmNwcCB0ZXN0IHdhcm5pbmcgaW4gR0ND CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYyMzgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHQ0MgZW1p dHMgd2FybmluZ3Mgd2hlbiBpdCBmaW5kcyBjbGFuZyBwcmFnbWFzLCBzbyBJJ20gd3JhcHBpbmcg dGhlbQorICAgICAgICBpbiAjaWYgQ09NUElMRVIoQ0xBTkcpIHRvIHJlZHVjZSB0aGUgbm9pc2Uu CisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NZWRpYVRpbWUuY3BwOgorCiAy MDIwLTAxLTE0ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBb TEZDXVtJbnRlZ3JhdGlvbl0gU3VwcG9ydCB0aGUgZmVhdHVyZSBmbGFnIGluIER1bXBSZW5kZXJU cmVlCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NZWRpYVRpbWUu Y3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWVkaWFUaW1lLmNwcAppbmRleCAy MWNkY2YwOTljMTUyNDA0ZjM4MGY1Y2M4MWUxMmJkYzUxNDhkOGI4Li5iMGI1NGE4MDNmYWM4NWQx NTg0ZTcyM2M4NmUxZDljYmE0NGRjZTdhIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dURi9NZWRpYVRpbWUuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V1RGL01lZGlhVGltZS5jcHAKQEAgLTU4LDEwICs1OCwxNCBAQCBuYW1lc3BhY2UgVGVzdFdlYktp dEFQSSB7CiAKIC8vIE1lZGlhVGltZSB2YWx1ZXMgc2hvdWxkIGJlIGFibGUgdG8gYmUgZGVjbGFy ZWQgc3RhdGljIGFueXdoZXJlLCBqdXN0IGxpa2UgeW91IGNhbiBkbyBzbyB3aXRoIGludGVnZXJz LgogLy8gVGhpcyBzaG91bGQgbm90IHJlcXVpcmUgZ2xvYmFsIGNvbnN0cnVjdG9ycyBvciBkZXN0 cnVjdG9ycy4KKyNpZiBDT01QSUxFUihDTEFORykKICNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBw dXNoCiAjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgZXJyb3IgIi1XZ2xvYmFsLWNvbnN0cnVjdG9y cyIKKyNlbmRpZgogc3RhdGljIGNvbnN0IE1lZGlhVGltZSBvbmVTZWNvbmQoMSwgMSk7CisjaWYg Q09NUElMRVIoQ0xBTkcpCiAjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcG9wCisjZW5kaWYKIAog VEVTVChXVEYsIE1lZGlhVGltZSkKIHsK