206215 2020-01-13 23:16:55 -0800 Always Use CAIRO_OPERATOR_SOURCE to copyRectFromOneSurfaceToAnother 2020-01-14 17:53:50 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 tomoki.imai webkit-unassigned cgarcia commit-queue dino don.olmstead ews-watchlist fujii graouts kondapallykalyan ross.kirsling webkit-bug-importer zan oldest_to_newest 1606267 0 tomoki.imai 2020-01-13 23:16:55 -0800 Most of copyRectFromOneSurfaceToAnother callers passed CAIRO_OPERATOR_SOURCE not to blend. BackingStoreBackendCairoImpl::scroll had copyRectFromOneSurfaceToAnother with the default cairoOperator CAIRO_OPERATOR_OVER, but scrolling should use CAIRO_OPERATOR_SOURCE because there is no need to blend and it can have a performance benefit. copyRectFromOneSurfaceToAnother callers; - https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp?rev=254496#L68 - https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp?rev=254496#L69 - https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp?rev=254496#L72 - https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp?rev=254496#L489 - https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp?rev=254496#L653 1606273 1 387624 tomoki.imai 2020-01-13 23:20:39 -0800 Created attachment 387624 patch to remove cairoOperator from copyRectFromOneSurfaceToAnother 1606312 2 387624 commit-queue 2020-01-14 02:01:14 -0800 Comment on attachment 387624 patch to remove cairoOperator from copyRectFromOneSurfaceToAnother Clearing flags on attachment: 387624 Committed r254502: <https://trac.webkit.org/changeset/254502> 1606313 3 commit-queue 2020-01-14 02:01:15 -0800 All reviewed patches have been landed. Closing bug. 1606314 4 webkit-bug-importer 2020-01-14 02:02:15 -0800 <rdar://problem/58562059> 1606746 5 tomoki.imai 2020-01-14 17:53:50 -0800 Thanks for your reviews! 387624 2020-01-13 23:20:39 -0800 2020-01-14 02:01:14 -0800 patch to remove cairoOperator from copyRectFromOneSurfaceToAnother 206215.patch text/plain 6625 tomoki.imai ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MWMwYzkwMGZkYy4uZmM1ZGNkMzhmZjQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAyMC0wMS0xNCAgVG9tb2tpIEltYWkgIDxUb21va2kuSW1haUBzb255LmNv bT4KKworICAgICAgICBBbHdheXMgVXNlIENBSVJPX09QRVJBVE9SX1NPVVJDRSB0byBjb3B5UmVj dEZyb21PbmVTdXJmYWNlVG9Bbm90aGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDYyMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNb3N0IG9mIGNvcHlSZWN0RnJvbU9uZVN1cmZhY2VUb0Fub3RoZXIg Y2FsbGVycyBwYXNzZWQgQ0FJUk9fT1BFUkFUT1JfU09VUkNFIG5vdCB0byBibGVuZC4KKyAgICAg ICAgQmFja2luZ1N0b3JlQmFja2VuZENhaXJvSW1wbDo6c2Nyb2xsIGhhZCBjb3B5UmVjdEZyb21P bmVTdXJmYWNlVG9Bbm90aGVyIHdpdGggdGhlIGRlZmF1bHQgY2Fpcm9PcGVyYXRvciBDQUlST19P UEVSQVRPUl9PVkVSLAorICAgICAgICBidXQgc2Nyb2xsaW5nIHNob3VsZCB1c2UgQ0FJUk9fT1BF UkFUT1JfU09VUkNFIGJlY2F1c2UgdGhlcmUgaXMgbm8gbmVlZCB0byBibGVuZCBhbmQgaXQgY2Fu IGhhdmUgYSBwZXJmb3JtYW5jZSBiZW5lZml0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgY292 ZXJlZCBieSB0aGUgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9jYWlyby9DYWlyb1V0aWxpdGllcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjb3B5UmVjdEZy b21PbmVTdXJmYWNlVG9Bbm90aGVyKTogVXNlIENBSVJPX09QRVJBVE9SX1NPVVJDRSB0byBjb3B5 IHJlY3QuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQ2Fpcm9VdGlsaXRpZXMu aDogUmVtb3ZlIGNhaXJvT3BlcmF0b3IgcGFyYW1ldGVyIGZyb20gY29weVJlY3RGcm9tT25lU3Vy ZmFjZVRvQW5vdGhlci4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGlj c0NvbnRleHRHTENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dEdM T3BlbkdMOjpJbWFnZUV4dHJhY3Rvcjo6ZXh0cmFjdEltYWdlKToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jYWlyby9JbWFnZUJ1ZmZlckNhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmdldEltYWdlRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6cHV0Qnl0ZUFy cmF5KToKKwogMjAyMC0wMS0xMyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXggZm9yIFBsYXlTdGF0aW9uIGFuZCBj bGFuZy1jbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nh aXJvL0NhaXJvVXRpbGl0aWVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL0NhaXJvVXRpbGl0aWVzLmNwcAppbmRleCBmOTBhYjI4MTQ4Yy4uOGEwYTI5OWIzMGUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0NhaXJv VXRpbGl0aWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWly by9DYWlyb1V0aWxpdGllcy5jcHAKQEAgLTI5OSwxMSArMjk5LDExIEBAIHZvaWQgY29weVJlY3RG cm9tQ2Fpcm9TdXJmYWNlVG9Db250ZXh0KGNhaXJvX3N1cmZhY2VfdCogZnJvbSwgY2Fpcm9fdCog dG8sIGNvbnN0CiAgICAgY2Fpcm9fZmlsbCh0byk7CiB9CiAKLXZvaWQgY29weVJlY3RGcm9tT25l U3VyZmFjZVRvQW5vdGhlcihjYWlyb19zdXJmYWNlX3QqIGZyb20sIGNhaXJvX3N1cmZhY2VfdCog dG8sIGNvbnN0IEludFNpemUmIHNvdXJjZU9mZnNldCwgY29uc3QgSW50UmVjdCYgcmVjdCwgY29u c3QgSW50U2l6ZSYgZGVzdE9mZnNldCwgY2Fpcm9fb3BlcmF0b3JfdCBjYWlyb09wZXJhdG9yKQor dm9pZCBjb3B5UmVjdEZyb21PbmVTdXJmYWNlVG9Bbm90aGVyKGNhaXJvX3N1cmZhY2VfdCogZnJv bSwgY2Fpcm9fc3VyZmFjZV90KiB0bywgY29uc3QgSW50U2l6ZSYgc291cmNlT2Zmc2V0LCBjb25z dCBJbnRSZWN0JiByZWN0LCBjb25zdCBJbnRTaXplJiBkZXN0T2Zmc2V0KQogewogICAgIFJlZlB0 cjxjYWlyb190PiBjb250ZXh0ID0gYWRvcHRSZWYoY2Fpcm9fY3JlYXRlKHRvKSk7CiAgICAgY2Fp cm9fdHJhbnNsYXRlKGNvbnRleHQuZ2V0KCksIGRlc3RPZmZzZXQud2lkdGgoKSwgZGVzdE9mZnNl dC5oZWlnaHQoKSk7Ci0gICAgY2Fpcm9fc2V0X29wZXJhdG9yKGNvbnRleHQuZ2V0KCksIGNhaXJv T3BlcmF0b3IpOworICAgIGNhaXJvX3NldF9vcGVyYXRvcihjb250ZXh0LmdldCgpLCBDQUlST19P UEVSQVRPUl9TT1VSQ0UpOwogICAgIGNvcHlSZWN0RnJvbUNhaXJvU3VyZmFjZVRvQ29udGV4dChm cm9tLCBjb250ZXh0LmdldCgpLCBzb3VyY2VPZmZzZXQsIHJlY3QpOwogfQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9DYWlyb1V0aWxpdGllcy5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQ2Fpcm9VdGlsaXRpZXMu aAppbmRleCAxZjEzZTVlM2M5Yy4uZmU1NGQyYmE0NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0NhaXJvVXRpbGl0aWVzLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQ2Fpcm9VdGlsaXRpZXMuaApAQCAtODYs NyArODYsNyBAQCB2b2lkIGRyYXdQYXR0ZXJuVG9DYWlyb0NvbnRleHQoY2Fpcm9fdCogY3IsIGNh aXJvX3N1cmZhY2VfdCogaW1hZ2UsIGNvbnN0IEludFNpegogUmVmUHRyPGNhaXJvX3N1cmZhY2Vf dD4gY29weUNhaXJvSW1hZ2VTdXJmYWNlKGNhaXJvX3N1cmZhY2VfdCopOwogCiB2b2lkIGNvcHlS ZWN0RnJvbUNhaXJvU3VyZmFjZVRvQ29udGV4dChjYWlyb19zdXJmYWNlX3QqIGZyb20sIGNhaXJv X3QqIHRvLCBjb25zdCBJbnRTaXplJiBvZmZzZXQsIGNvbnN0IEludFJlY3QmKTsKLXZvaWQgY29w eVJlY3RGcm9tT25lU3VyZmFjZVRvQW5vdGhlcihjYWlyb19zdXJmYWNlX3QqIGZyb20sIGNhaXJv X3N1cmZhY2VfdCogdG8sIGNvbnN0IEludFNpemUmIG9mZnNldCwgY29uc3QgSW50UmVjdCYsIGNv bnN0IEludFNpemUmID0gSW50U2l6ZSgpLCBjYWlyb19vcGVyYXRvcl90ID0gQ0FJUk9fT1BFUkFU T1JfT1ZFUik7Cit2b2lkIGNvcHlSZWN0RnJvbU9uZVN1cmZhY2VUb0Fub3RoZXIoY2Fpcm9fc3Vy ZmFjZV90KiBmcm9tLCBjYWlyb19zdXJmYWNlX3QqIHRvLCBjb25zdCBJbnRTaXplJiBvZmZzZXQs IGNvbnN0IEludFJlY3QmLCBjb25zdCBJbnRTaXplJiA9IEludFNpemUoKSk7CiAKIEludFNpemUg Y2Fpcm9TdXJmYWNlU2l6ZShjYWlyb19zdXJmYWNlX3QqKTsKIHZvaWQgZmxpcEltYWdlU3VyZmFj ZVZlcnRpY2FsbHkoY2Fpcm9fc3VyZmFjZV90Kik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRHTENhaXJvLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dEdMQ2Fp cm8uY3BwCmluZGV4IDBhNWNjOWQ2MTU1Li40NzgyNGVlNTZjNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0R0xDYWlyby5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3ND b250ZXh0R0xDYWlyby5jcHAKQEAgLTY5LDcgKzY5LDcgQEAgYm9vbCBHcmFwaGljc0NvbnRleHRH TE9wZW5HTDo6SW1hZ2VFeHRyYWN0b3I6OmV4dHJhY3RJbWFnZShib29sIHByZW11bHRpcGx5QWxw aGEKICAgICAgICAgaWYgKG1faW1hZ2VTdXJmYWNlICYmIGNhaXJvX3N1cmZhY2VfZ2V0X3R5cGUo bV9pbWFnZVN1cmZhY2UuZ2V0KCkpICE9IENBSVJPX1NVUkZBQ0VfVFlQRV9JTUFHRSkgewogICAg ICAgICAgICAgSW50U2l6ZSBzdXJmYWNlU2l6ZSA9IGNhaXJvU3VyZmFjZVNpemUobV9pbWFnZVN1 cmZhY2UuZ2V0KCkpOwogICAgICAgICAgICAgYXV0byB0bXBTdXJmYWNlID0gYWRvcHRSZWYoY2Fp cm9faW1hZ2Vfc3VyZmFjZV9jcmVhdGUoQ0FJUk9fRk9STUFUX0FSR0IzMiwgc3VyZmFjZVNpemUu d2lkdGgoKSwgc3VyZmFjZVNpemUuaGVpZ2h0KCkpKTsKLSAgICAgICAgICAgIGNvcHlSZWN0RnJv bU9uZVN1cmZhY2VUb0Fub3RoZXIobV9pbWFnZVN1cmZhY2UuZ2V0KCksIHRtcFN1cmZhY2UuZ2V0 KCksIEludFNpemUoKSwgSW50UmVjdChJbnRQb2ludCgpLCBzdXJmYWNlU2l6ZSksIEludFNpemUo KSwgQ0FJUk9fT1BFUkFUT1JfU09VUkNFKTsKKyAgICAgICAgICAgIGNvcHlSZWN0RnJvbU9uZVN1 cmZhY2VUb0Fub3RoZXIobV9pbWFnZVN1cmZhY2UuZ2V0KCksIHRtcFN1cmZhY2UuZ2V0KCksIElu dFNpemUoKSwgSW50UmVjdChJbnRQb2ludCgpLCBzdXJmYWNlU2l6ZSksIEludFNpemUoKSk7CiAg ICAgICAgICAgICBtX2ltYWdlU3VyZmFjZSA9IFdURk1vdmUodG1wU3VyZmFjZSk7CiAgICAgICAg IH0KICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9JbWFnZUJ1ZmZlckNhaXJvLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8uY3BwCmluZGV4IDA3OTY1N2UzYjI5Li4xZjEzMzNh NzQyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8v SW1hZ2VCdWZmZXJDYWlyby5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHAKQEAgLTQ4Niw3ICs0ODYsNyBAQCBSZWZQdHI8 VWludDhDbGFtcGVkQXJyYXk+IGdldEltYWdlRGF0YShjb25zdCBJbnRSZWN0JiByZWN0LCBjb25z dCBJbnRSZWN0JiBsb2dpYwogICAgIGlmIChpbWFnZVN1cmZhY2UgIT0gZGF0YS5tX3N1cmZhY2Uu Z2V0KCkpIHsKICAgICAgICAgLy8gVGhpcyBjYWlybyBzdXJmYWNlIG9wZXJhdGlvbiBpcyBkb25l IGluIExvZ2ljYWxDb29yZGluYXRlU3lzdGVtLgogICAgICAgICBJbnRSZWN0IGxvZ2ljYWxBcmVh ID0gaW50ZXJzZWN0aW9uKGxvZ2ljYWxSZWN0LCBJbnRSZWN0KDAsIDAsIGxvZ2ljYWxTaXplLndp ZHRoKCksIGxvZ2ljYWxTaXplLmhlaWdodCgpKSk7Ci0gICAgICAgIGNvcHlSZWN0RnJvbU9uZVN1 cmZhY2VUb0Fub3RoZXIoZGF0YS5tX3N1cmZhY2UuZ2V0KCksIGltYWdlU3VyZmFjZS5nZXQoKSwg SW50U2l6ZSgtbG9naWNhbEFyZWEueCgpLCAtbG9naWNhbEFyZWEueSgpKSwgSW50UmVjdChJbnRQ b2ludCgpLCBsb2dpY2FsQXJlYS5zaXplKCkpLCBJbnRTaXplKCksIENBSVJPX09QRVJBVE9SX1NP VVJDRSk7CisgICAgICAgIGNvcHlSZWN0RnJvbU9uZVN1cmZhY2VUb0Fub3RoZXIoZGF0YS5tX3N1 cmZhY2UuZ2V0KCksIGltYWdlU3VyZmFjZS5nZXQoKSwgSW50U2l6ZSgtbG9naWNhbEFyZWEueCgp LCAtbG9naWNhbEFyZWEueSgpKSwgSW50UmVjdChJbnRQb2ludCgpLCBsb2dpY2FsQXJlYS5zaXpl KCkpLCBJbnRTaXplKCkpOwogICAgIH0KIAogICAgIHVuc2lnbmVkIGNoYXIqIGRhdGFTcmMgPSBj YWlyb19pbWFnZV9zdXJmYWNlX2dldF9kYXRhKGltYWdlU3VyZmFjZS5nZXQoKSk7CkBAIC02NTAs NyArNjUwLDcgQEAgdm9pZCBJbWFnZUJ1ZmZlcjo6cHV0Qnl0ZUFycmF5KGNvbnN0IFVpbnQ4Q2xh bXBlZEFycmF5JiBzb3VyY2UsIEFscGhhUHJlbXVsdGlwbGkKIAogICAgIGlmIChpbWFnZVN1cmZh Y2UgIT0gbV9kYXRhLm1fc3VyZmFjZS5nZXQoKSkgewogICAgICAgICAvLyBUaGlzIGNhaXJvIHN1 cmZhY2Ugb3BlcmF0aW9uIGlzIGRvbmUgaW4gTG9naWNhbENvb3JkaW5hdGVTeXN0ZW0uCi0gICAg ICAgIGNvcHlSZWN0RnJvbU9uZVN1cmZhY2VUb0Fub3RoZXIoaW1hZ2VTdXJmYWNlLmdldCgpLCBt X2RhdGEubV9zdXJmYWNlLmdldCgpLCBJbnRTaXplKCksIEludFJlY3QoMCwgMCwgbG9naWNhbE51 bUNvbHVtbnMsIGxvZ2ljYWxOdW1Sb3dzKSwgSW50U2l6ZShsb2dpY2FsRGVzdFBvaW50LngoKSAr IGxvZ2ljYWxTb3VyY2VSZWN0LngoKSwgbG9naWNhbERlc3RQb2ludC55KCkgKyBsb2dpY2FsU291 cmNlUmVjdC55KCkpLCBDQUlST19PUEVSQVRPUl9TT1VSQ0UpOworICAgICAgICBjb3B5UmVjdEZy b21PbmVTdXJmYWNlVG9Bbm90aGVyKGltYWdlU3VyZmFjZS5nZXQoKSwgbV9kYXRhLm1fc3VyZmFj ZS5nZXQoKSwgSW50U2l6ZSgpLCBJbnRSZWN0KDAsIDAsIGxvZ2ljYWxOdW1Db2x1bW5zLCBsb2dp Y2FsTnVtUm93cyksIEludFNpemUobG9naWNhbERlc3RQb2ludC54KCkgKyBsb2dpY2FsU291cmNl UmVjdC54KCksIGxvZ2ljYWxEZXN0UG9pbnQueSgpICsgbG9naWNhbFNvdXJjZVJlY3QueSgpKSk7 CiAgICAgfQogfQogCg==