<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>206204</bug_id>
          
          <creation_ts>2020-01-13 16:05:49 -0800</creation_ts>
          <short_desc>Nullptr crash in DocumentLoader::clearMainResourceLoader</short_desc>
          <delta_ts>2020-01-15 19:02:26 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Page Loading</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=206304</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>206306</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Pinki Gyanchandani">pgyanchandani</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>achristensen</cc>
    
    <cc>ap</cc>
    
    <cc>beidson</cc>
    
    <cc>bfulgham</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>ews-feeder</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>japhet</cc>
    
    <cc>product-security</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit-bot-watchers-bugzilla</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1606119</commentid>
    <comment_count>0</comment_count>
    <who name="Pinki Gyanchandani">pgyanchandani</who>
    <bug_when>2020-01-13 16:05:49 -0800</bug_when>
    <thetext>: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x00000002cd8c2000 WebCore::FrameLoader::activeDocumentLoader() const + 16
1   com.apple.WebCore             	0x00000002cd86b77b WebCore::DocumentLoader::clearMainResourceLoader() + 43
2   com.apple.WebCore             	0x00000002cd86d007 WebCore::DocumentLoader::finishedLoading() + 519
3   com.apple.WebCore             	0x00000002cd86cc15 WebCore::DocumentLoader::notifyFinished(WebCore::CachedResource&amp;) + 501
4   com.apple.WebCore             	0x00000002cd9b6212 WebCore::CachedResource::checkNotify() + 130
5   com.apple.WebCore             	0x00000002cd9b2184 WebCore::CachedResource::finishLoading(WebCore::SharedBuffer*) + 52
6   com.apple.WebCore             	0x00000002cd9b3434 WebCore::CachedRawResource::finishLoading(WebCore::SharedBuffer*) + 324
7   com.apple.WebCore             	0x00000002cd946616 WebCore::SubresourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&amp;) + 1206
8   com.apple.WebCore             	0x00000002cd93e0c7 auto WebCore::ResourceLoader::loadDataURL()::$_2::operator()&lt;WTF::Optional&lt;WebCore::DataURLDecoder::Result&gt; &gt;(WTF::Optional&lt;WebCore::DataURLDecoder::Result&gt;)::&apos;lambda&apos;()::operator()() + 247
9   com.apple.WebCore             	0x00000002cd93deee WTF::Detail::CallableWrapper&lt;auto WebCore::ResourceLoader::loadDataURL()::$_2::operator()&lt;WTF::Optional&lt;WebCore::DataURLDecoder::Result&gt; &gt;(WTF::Optional&lt;WebCore::DataURLDecoder::Result&gt;)::&apos;lambda&apos;(), void&gt;::call() + 30
10  com.apple.WebCore             	0x00000002ca83b392 WTF::Function&lt;void ()&gt;::operator()() const + 130
11  com.apple.WebCore             	0x00000002ca8a0c7e WTF::CompletionHandler&lt;void ()&gt;::operator()() + 238
12  com.apple.WebCore             	0x00000002cd948504 WebCore::SubresourceLoader::didReceiveResponsePolicy() + 180
13  com.apple.WebCore             	0x00000002cd8a3465 WebCore::DocumentLoader::responseReceived(WebCore::ResourceResponse const&amp;, WTF::CompletionHandler&lt;void ()&gt;&amp;&amp;)::$_3::operator()(WebCore::PolicyAction, WebCore::PolicyCheckIdentifier) + 229
14  com.apple.WebCore             	0x00000002cd8a3237 WTF::Detail::CallableWrapper&lt;WebCore::DocumentLoader::responseReceived(WebCore::ResourceResponse const&amp;, WTF::CompletionHandler&lt;void ()&gt;&amp;&amp;)::$_3, void, WebCore::PolicyAction, WebCore::PolicyCheckIdentifier&gt;::call(WebCore::PolicyAction, WebCore::PolicyCheckIdentifier) + 103
15  com.apple.WebKit              	0x00000002c1243a88 WTF::Function&lt;void (WebCore::PolicyAction, WebCore::PolicyCheckIdentifier)&gt;::operator()(WebCore::PolicyAction, WebCore::PolicyCheckIdentifier) const + 216
16  com.apple.WebKit              	0x00000002c12bde0e WebKit::WebFrame::invalidatePolicyListener() + 286
17  com.apple.WebKit              	0x00000002c1245d79 WebKit::WebFrameLoaderClient::cancelPolicyCheck() + 25
18  com.apple.WebCore             	0x00000002cd9185ec WebCore::PolicyChecker::stopCheck() + 44
19  com.apple.WebCore             	0x00000002cd87436e WebCore::DocumentLoader::cancelPolicyCheckIfNeeded() + 174
20  com.apple.WebCore             	0x00000002cd86c853 WebCore::DocumentLoader::cancelMainResourceLoad(WebCore::ResourceError const&amp;) + 499
21  com.apple.WebCore             	0x00000002cd86bcea WebCore::DocumentLoader::stopLoading() + 1354
22  com.apple.WebCore             	0x00000002cd901d43 WebCore::NavigationScheduler::schedule(std::__1::unique_ptr&lt;WebCore::ScheduledNavigation, std::__1::default_delete&lt;WebCore::ScheduledNavigation&gt; &gt;) + 211
23  com.apple.WebCore             	0x00000002cd902539 WebCore::NavigationScheduler::scheduleLocationChange(WebCore::Document&amp;, WebCore::SecurityOrigin&amp;, WTF::URL const&amp;, WTF::String const&amp;, WebCore::LockHistory, WebCore::LockBackForwardList, WTF::CompletionHandler&lt;void ()&gt;&amp;&amp;) + 1241
24  com.apple.WebCore             	0x00000002cd93248a WebCore::SubframeLoader::loadOrRedirectSubframe(WebCore::HTMLFrameOwnerElement&amp;, WTF::URL const&amp;, WTF::AtomString const&amp;, WebCore::LockHistory, WebCore::LockBackForwardList) + 362
25  com.apple.WebCore             	0x00000002cd931fa0 WebCore::SubframeLoader::requestFrame(WebCore::HTMLFrameOwnerElement&amp;, WTF::String const&amp;, WTF::AtomString const&amp;, WebCore::LockHistory, WebCore::LockBackForwardList) + 560
26  com.apple.WebCore             	0x00000002cd304d13 WebCore::HTMLFrameElementBase::openURL(WebCore::LockHistory, WebCore::LockBackForwardList) + 467
27  com.apple.WebCore             	0x00000002cd304e20 WebCore::HTMLFrameElementBase::setLocation(WTF::String const&amp;) + 192
28  com.apple.WebCore             	0x00000002cd3045e9 WebCore::HTMLFrameElementBase::parseAttribute(WebCore::QualifiedName const&amp;, WTF::AtomString const&amp;) + 105
29  com.apple.WebCore             	0x00000002cd30e846 WebCore::HTMLIFrameElement::parseAttribute(WebCore::QualifiedName const&amp;, WTF::AtomString const&amp;) + 438
30  com.apple.WebCore             	0x00000002ccf63994 WebCore::Element::attributeChanged(WebCore::QualifiedName const&amp;, WTF::AtomString const&amp;, WTF::AtomString const&amp;, WebCore::Element::AttributeModificationReason) + 1156
31  com.apple.WebCore             	0x00000002cd0accdc WebCore::StyledElement::attributeChanged(WebCore::QualifiedName const&amp;, WTF::AtomString const&amp;, WTF::AtomString const&amp;, WebCore::Element::AttributeModificationReason) + 236
32  com.apple.WebCore             	0x00000002ccf6a222 WebCore::Element::didAddAttribute(WebCore::QualifiedName const&amp;, WTF::AtomString const&amp;) + 82
33  com.apple.WebCore             	0x00000002ccf6a173 WebCore::Element::addAttributeInternal(WebCore::QualifiedName const&amp;, WTF::AtomString const&amp;, WebCore::Element::SynchronizationOfLazyAttribute) + 195
34  com.apple.WebCore             	0x00000002ccf63081 WebCore::Element::setAttributeInternal(unsigned int, WebCore::QualifiedName const&amp;, WTF::AtomString const&amp;, WebCore::Element::SynchronizationOfLazyAttribute) + 129
35  com.apple.WebCore             	0x00000002ccf63485 WebCore::Element::setAttributeWithoutSynchronization(WebCore::QualifiedName const&amp;, WTF::AtomString const&amp;) + 117
36  com.apple.WebCore             	0x00000002cb2ae308 WebCore::setJSHTMLIFrameElementSrcdocSetter(JSC::JSGlobalObject&amp;, WebCore::JSHTMLIFrameElement&amp;, JSC::JSValue, JSC::ThrowScope&amp;)::&apos;lambda&apos;()::operator()() const + 88
37  com.apple.WebCore             	0x00000002cb2ae29d std::__1::enable_if&lt;std::is_same&lt;void, decltype(fp1())&gt;::value, void&gt;::type WebCore::AttributeSetter::call&lt;WebCore::setJSHTMLIFrameElementSrcdocSetter(JSC::JSGlobalObject&amp;, WebCore::JSHTMLIFrameElement&amp;, JSC::JSValue, JSC::ThrowScope&amp;)::&apos;lambda&apos;()&gt;(JSC::JSGlobalObject&amp;, JSC::ThrowScope&amp;, WebCore::setJSHTMLIFrameElementSrcdocSetter(JSC::JSGlobalObject&amp;, WebCore::JSHTMLIFrameElement&amp;, JSC::JSValue, JSC::ThrowScope&amp;)::&apos;lambda&apos;()&amp;&amp;) + 29
38  com.apple.WebCore             	0x00000002cb2ae249 WebCore::setJSHTMLIFrameElementSrcdocSetter(JSC::JSGlobalObject&amp;, WebCore::JSHTMLIFrameElement&amp;, JSC::JSValue, JSC::ThrowScope&amp;) + 169
39  com.apple.WebCore             	0x00000002cb212384 bool WebCore::IDLAttribute&lt;WebCore::JSHTMLIFrameElement&gt;::set&lt;&amp;(WebCore::setJSHTMLIFrameElementSrcdocSetter(JSC::JSGlobalObject&amp;, WebCore::JSHTMLIFrameElement&amp;, JSC::JSValue, JSC::ThrowScope&amp;)), (WebCore::CastedThisErrorBehavior)0&gt;(JSC::JSGlobalObject&amp;, long long, long long, char const*) + 324
40  com.apple.WebCore             	0x00000002cb21222c WebCore::setJSHTMLIFrameElementSrcdoc(JSC::JSGlobalObject*, long long, long long) + 44
41  com.apple.JavaScriptCore      	0x00000002e45ae75e JSC::callCustomSetter(JSC::JSGlobalObject*, bool (*)(JSC::JSGlobalObject*, long long, long long), bool, JSC::JSValue, JSC::JSValue) + 190
42  com.apple.JavaScriptCore      	0x00000002e45ae832 JSC::callCustomSetter(JSC::JSGlobalObject*, JSC::JSValue, bool, JSC::JSObject*, JSC::JSValue, JSC::JSValue) + 162
43  com.apple.JavaScriptCore      	0x00000002e47059ee JSC::JSObject::putInlineSlow(JSC::JSGlobalObject*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&amp;) + 1566
44  com.apple.JavaScriptCore      	0x00000002e3f51a41 JSC::JSObject::putInlineForJSObject(JSC::JSCell*, JSC::JSGlobalObject*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&amp;) + 1265
45  com.apple.JavaScriptCore      	0x00000002e3f51508 JSC::JSCell::putInline(JSC::JSGlobalObject*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&amp;) + 152
46  com.apple.JavaScriptCore      	0x00000002e3f53463 JSC::JSValue::putInline(JSC::JSGlobalObject*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&amp;) + 163
47  com.apple.JavaScriptCore      	0x00000002e435b29c llint_slow_path_put_by_id + 700
48  com.apple.JavaScriptCore      	0x00000002e3575960 llint_entry + 43090
49  com.apple.JavaScriptCore      	0x00000002e35879f1 llint_entry + 116963
50  com.apple.JavaScriptCore      	0x00000002e356aea3 vmEntryToJavaScript + 273
51  com.apple.JavaScriptCore      	0x00000002e424f327 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) + 199
52  com.apple.JavaScriptCore      	0x00000002e424f976 JSC::Interpreter::executeCall(JSC::JSGlobalObject*, JSC::JSObject*, JSC::CallType, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;) + 1494
53  com.apple.JavaScriptCore      	0x00000002e453bd09 JSC::call(JSC::JSGlobalObject*, JSC::JSValue, JSC::CallType, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;) + 233
54  com.apple.JavaScriptCore      	0x00000002e453bdfa JSC::call(JSC::JSGlobalObject*, JSC::JSValue, JSC::CallType, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;, WTF::NakedPtr&lt;JSC::Exception&gt;&amp;) + 218
55  com.apple.JavaScriptCore      	0x00000002e453c0ee JSC::profiledCall(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;, WTF::NakedPtr&lt;JSC::Exception&gt;&amp;) + 142
56  com.apple.WebCore             	0x00000002cc944c58 WebCore::JSExecState::profiledCall(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;, WTF::NakedPtr&lt;JSC::Exception&gt;&amp;) + 136
57  com.apple.WebCore             	0x00000002cc9603d7 WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext&amp;, WebCore::Event&amp;) + 1927
58  com.apple.WebCore             	0x00000002ccf9f37d WebCore::EventTarget::innerInvokeEventListeners(WebCore::Event&amp;, WTF::Vector&lt;WTF::RefPtr&lt;WebCore::RegisteredEventListener, WTF::DumbPtrTraits&lt;WebCore::RegisteredEventListener&gt; &gt;, 1ul, WTF::CrashOnOverflow, 16ul&gt;, WebCore::EventTarget::EventInvokePhase) + 925
59  com.apple.WebCore             	0x00000002ccf9b614 WebCore::EventTarget::fireEventListeners(WebCore::Event&amp;, WebCore::EventTarget::EventInvokePhase) + 356
60  com.apple.WebCore             	0x00000002cd00f942 WebCore::Node::handleLocalEvents(WebCore::Event&amp;, WebCore::EventTarget::EventInvokePhase) + 178
61  com.apple.WebCore             	0x00000002ccf75921 WebCore::EventContext::handleLocalEvents(WebCore::Event&amp;, WebCore::EventTarget::EventInvokePhase) const + 193
62  com.apple.WebCore             	0x00000002ccf7641f WebCore::dispatchEventInDOM(WebCore::Event&amp;, WebCore::EventPath const&amp;) + 383
63  com.apple.WebCore             	0x00000002ccf75f27 WebCore::EventDispatcher::dispatchEvent(WebCore::Node&amp;, WebCore::Event&amp;) + 567
64  com.apple.WebCore             	0x00000002cd00f99d WebCore::Node::dispatchEvent(WebCore::Event&amp;) + 29
65  com.apple.WebCore             	0x00000002cda39a45 WebCore::DOMWindow::dispatchLoadEvent() + 485
66  com.apple.WebCore             	0x00000002ccea74f8 WebCore::Document::dispatchWindowLoadEvent() + 136
67  com.apple.WebCore             	0x00000002ccea6fc8 WebCore::Document::implicitClose() + 600
68  com.apple.WebCore             	0x00000002cd8c62cb WebCore::FrameLoader::checkCallImplicitClose() + 155
69  com.apple.WebCore             	0x00000002cd8c5dda WebCore::FrameLoader::checkCompleted() + 442
70  com.apple.WebCore             	0x00000002cd8c41dd WebCore::FrameLoader::finishedParsing() + 285
71  com.apple.WebCore             	0x00000002cceb9bde WebCore::Document::finishedParsing() + 670
72  com.apple.WebCore             	0x00000002cd522398 WebCore::HTMLConstructionSite::finishedParsing() + 24
73  com.apple.WebCore             	0x00000002cd56e767 WebCore::HTMLTreeBuilder::finished() + 263
74  com.apple.WebCore             	0x00000002cd5296d8 WebCore::HTMLDocumentParser::end() + 248
75  com.apple.WebCore             	0x00000002cd527658 WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd() + 296
76  com.apple.WebCore             	0x00000002cd527387 WebCore::HTMLDocumentParser::prepareToStopParsing() + 295
77  com.apple.WebCore             	0x00000002cd529742 WebCore::HTMLDocumentParser::attemptToEnd() + 66
78  com.apple.WebCore             	0x00000002cd529819 WebCore::HTMLDocumentParser::finish() + 73
79  com.apple.WebCore             	0x00000002cd86e072 WebCore::DocumentWriter::end() + 386
80  com.apple.WebCore             	0x00000002cd86cfcf WebCore::DocumentLoader::finishedLoading() + 463
81  com.apple.WebCore             	0x00000002cd871df6 WebCore::DocumentLoader::continueAfterContentPolicy(WebCore::PolicyAction) + 1990
82  com.apple.WebCore             	0x00000002cd86eab8 WebCore::DocumentLoader::responseReceived(WebCore::ResourceResponse const&amp;, WTF::CompletionHandler&lt;void ()&gt;&amp;&amp;) + 2248
83  com.apple.WebCore             	0x00000002cd869e85 WebCore::DocumentLoader::handleSubstituteDataLoadNow() + 341
84  com.apple.WebCore             	0x00000002cd899bab WTF::RunLoopTimer&lt;WebCore::DocumentLoader&gt;::fired() + 107
85  com.apple.JavaScriptCore      	0x00000002e314563e WTF::timerFired(__CFRunLoopTimer*, void*) + 46
86  com.apple.CoreFoundation      	0x00007fff3d6cff08 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
87  com.apple.CoreFoundation      	0x00007fff3d6cfa6e __CFRunLoopDoTimer + 872
88  com.apple.CoreFoundation      	0x00007fff3d6cf489 __CFRunLoopDoTimers + 322
89  com.apple.CoreFoundation      	0x00007fff3d6b072d __CFRunLoopRun + 1885
90  com.apple.CoreFoundation      	0x00007fff3d6afd53 CFRunLoopRunSpecific + 466
91  com.apple.Foundation          	0x00007fff3fe19cd7 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 212
92  com.apple.Foundation          	0x00007fff3fe19bf0 -[NSRunLoop(NSRunLoop) run] + 76
93  libxpc.dylib                  	0x00007fff78f41e52 _xpc_objc_main.cold.4 + 49
94  libxpc.dylib                  	0x00007fff78f29e6b _xpc_objc_main + 559
95  libxpc.dylib                  	0x00007fff78f299e5 xpc_main + 377
96  com.apple.WebKit              	0x00000002c0762747 WebKit::XPCServiceMain(int, char const**) + 1303
97  com.apple.WebKit              	0x00000002c175788b WKXPCServiceMain + 27
98  com.apple.WebKit.WebContent   	0x000000010ab91eb2 main + 34
99                   	0x00007fff78cce765 start + 1

[...]
￼</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1606121</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-01-13 16:07:24 -0800</bug_when>
    <thetext>&lt;rdar://problem/58548455&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1606142</commentid>
    <comment_count>2</comment_count>
      <attachid>387592</attachid>
    <who name="Pinki Gyanchandani">pgyanchandani</who>
    <bug_when>2020-01-13 16:51:17 -0800</bug_when>
    <thetext>Created attachment 387592
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1606144</commentid>
    <comment_count>3</comment_count>
      <attachid>387592</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2020-01-13 16:57:54 -0800</bug_when>
    <thetext>Comment on attachment 387592
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387592&amp;action=review

r- because change logs need to be fixed.

&gt; Source/WebCore/ChangeLog:8
&gt; +        No new tests (OOPS!).

Please remove this line but add a description as to what caused the bug &amp; how you&apos;re fixing it.

&gt; Source/WebCore/loader/DocumentLoader.cpp:159
&gt; +

Please revert this change.

&gt; Source/WebCore/loader/DocumentLoader.cpp:1273
&gt;  {

Should the caller exit early as well?

&gt; Tools/ChangeLog:8
&gt; +        * WebKitTestRunner/WebKitTestRunner.xcodeproj/xcshareddata/xcschemes/WebKitTestRunner.xcscheme:

Please revert this change log change.

&gt; ChangeLog:8
&gt; +        * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings:

Ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1606148</commentid>
    <comment_count>4</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2020-01-13 17:06:52 -0800</bug_when>
    <thetext>This is not a security bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1606606</commentid>
    <comment_count>5</comment_count>
      <attachid>387706</attachid>
    <who name="Pinki Gyanchandani">pgyanchandani</who>
    <bug_when>2020-01-14 14:34:11 -0800</bug_when>
    <thetext>Created attachment 387706
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1606778</commentid>
    <comment_count>6</comment_count>
      <attachid>387706</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2020-01-14 21:09:18 -0800</bug_when>
    <thetext>Comment on attachment 387706
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387706&amp;action=review

&gt; Source/WebCore/loader/DocumentLoader.cpp:159
&gt; +

Again, please revert this unnecessary code change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1606823</commentid>
    <comment_count>7</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2020-01-14 22:59:55 -0800</bug_when>
    <thetext>rdar://problem/56968500</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1606992</commentid>
    <comment_count>8</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-01-15 10:41:35 -0800</bug_when>
    <thetext>I removed the unneeded space addition and committed this to http://trac.webkit.org/r254576</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607054</commentid>
    <comment_count>9</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-01-15 11:49:39 -0800</bug_when>
    <thetext>(In reply to Alex Christensen from comment #8)
&gt; I removed the unneeded space addition and committed this to http://trac.webkit.org/r254576
Newly added test change-src-during-iframe-load-crash.html seems to be consistently timing out, and slowing down commit-queue. Tracked in https://bugs.webkit.org/show_bug.cgi?id=206304</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607066</commentid>
    <comment_count>10</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-01-15 12:14:39 -0800</bug_when>
    <thetext>The test failure was also indicated by EWS in https://ews-build.webkit.org/#/builders/30/builds/604 and https://ews-build.webkit.org/#/builders/10/builds/3730</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607070</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-01-15 12:18:58 -0800</bug_when>
    <thetext>Re-opened since this is blocked by bug 206306</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607075</commentid>
    <comment_count>12</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-01-15 12:21:32 -0800</bug_when>
    <thetext>This also caused http/tests/security/http-0.9/xhr-blocked.html to fail, because of possibly unintended addition of &apos;asdf&apos;

https://results.webkit.org/?suite=layout-tests&amp;test=http%2Ftests%2Fsecurity%2Fhttp-0.9%2Fxhr-blocked.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607237</commentid>
    <comment_count>13</comment_count>
      <attachid>387706</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2020-01-15 16:38:59 -0800</bug_when>
    <thetext>Comment on attachment 387706
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387706&amp;action=review

&gt; LayoutTests/loader/change-src-during-iframe-load-crash.html:3
&gt; +function load() {

The issue is that in WebKit1, this event handler runs after eventhandler3 had finished running.
The solution is to add a flag which eventhandler3 set, and only call waitUntilDone when the flag isn&apos;t set like this:

let didLoad = false;
let didFinishTesting = false;

function load() {
    document.body.innerHTML = &apos;The test is declared pass if there is no crash observed.&apos;;
    didLoad = true;
    if (window.testRunner) {
        testRunner.dumpAsText();
        if (!didFinishTesting)
            testRunner.waitUntilDone();
    }
}

function eventhandler3() {
    iframe1.srcdoc = &quot;x&quot;;
    didFinishTesting = true;
    if (window.testRunner &amp;&amp; didLoad)
        testRunner.notifyDone();
}

&gt; LayoutTests/loader/change-src-during-iframe-load-crash.html:11
&gt; +function eventhandler3() {

Can we rename this event handler to something more sensible like didLoadFrame2.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607238</commentid>
    <comment_count>14</comment_count>
      <attachid>387706</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2020-01-15 16:39:13 -0800</bug_when>
    <thetext>Comment on attachment 387706
Patch

r- given this patch caused the landed test to fail in WK1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607263</commentid>
    <comment_count>15</comment_count>
      <attachid>387876</attachid>
    <who name="Pinki Gyanchandani">pgyanchandani</who>
    <bug_when>2020-01-15 17:30:17 -0800</bug_when>
    <thetext>Created attachment 387876
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607303</commentid>
    <comment_count>16</comment_count>
      <attachid>387876</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2020-01-15 18:29:30 -0800</bug_when>
    <thetext>Comment on attachment 387876
Patch

Let&apos;s wait for EWS before landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607316</commentid>
    <comment_count>17</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2020-01-15 19:02:26 -0800</bug_when>
    <thetext>Committed r254662: &lt;https://trac.webkit.org/changeset/254662&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>387592</attachid>
            <date>2020-01-13 16:51:17 -0800</date>
            <delta_ts>2020-01-14 14:34:09 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-206204-20200113165116.patch</filename>
            <type>text/plain</type>
            <size>2943</size>
            <attacher name="Pinki Gyanchandani">pgyanchandani</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDEzNzE4MjE5N2VhY2Ri
MzM4OGFiNDE3YjQxMWVkMGRkNTlmZjBiOC4uYmQ1ZGJkMDkwMWE3NGYwZjM4YmJhMDZkYzUyYjk0
N2QwYjJhZTNkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTEzICBQaW5r
aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs
IFB0ciBEZXJlZiBAIFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpjbGVhck1haW5SZXNvdXJjZUxv
YWRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2
MjA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g
bmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBsb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3Bw
OgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnRMb2FkZXI6OmZyYW1lTG9hZGVyIGNvbnN0KToK
KyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpjbGVhck1haW5SZXNvdXJjZUxvYWRl
cik6CisKIDIwMjAtMDEtMDcgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29t
PgogCiAgICAgICAgIFVucmV2aWV3ZWQgcmVzdGFiaWxpemF0aW9uIG9mIG5vbi11bmlmaWVkIGJ1
aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNw
cCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKaW5kZXggYmUyN2Vm
MWJiZTMyYjdlNWY5MjVkOTk3NDkzNmEzY2JiNTljMjgwYS4uMzIwZGU4MGVhM2Q4YWUwM2M1NGU5
NGI4ZjNlMjRmOGVmNDk2NDkxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0Rv
Y3VtZW50TG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2Fk
ZXIuY3BwCkBAIC0xNTYsNiArMTU2LDcgQEAgRnJhbWVMb2FkZXIqIERvY3VtZW50TG9hZGVyOjpm
cmFtZUxvYWRlcigpIGNvbnN0CiB7CiAgICAgaWYgKCFtX2ZyYW1lKQogICAgICAgICByZXR1cm4g
bnVsbHB0cjsKKwogICAgIHJldHVybiAmbV9mcmFtZS0+bG9hZGVyKCk7CiB9CiAKQEAgLTEyNzIs
NyArMTI3MywxMiBAQCB2b2lkIERvY3VtZW50TG9hZGVyOjpjbGVhck1haW5SZXNvdXJjZUxvYWRl
cigpCiB7CiAgICAgbV9sb2FkaW5nTWFpblJlc291cmNlID0gZmFsc2U7CiAKLSAgICBpZiAodGhp
cyA9PSBmcmFtZUxvYWRlcigpLT5hY3RpdmVEb2N1bWVudExvYWRlcigpKQorICAgIGF1dG8qIGZy
YW1lTG9hZGVyID0gdGhpcy0+ZnJhbWVMb2FkZXIoKTsKKworICAgIGlmICghZnJhbWVMb2FkZXIp
CisgICAgICAgIHJldHVybjsKKworICAgIGlmICh0aGlzID09IGZyYW1lTG9hZGVyLT5hY3RpdmVE
b2N1bWVudExvYWRlcigpKQogICAgICAgICBjaGVja0xvYWRDb21wbGV0ZSgpOwogfQogCmRpZmYg
LS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTM5Zjg1ZGRm
M2VmNjY3NjM5OGY2N2QxZTRiNzYzNGIyNWJkMTIyNC4uYTVmNjBmMWQ2ODJkZDFlMWQ1NDcwNmJj
YzNlNmU1ZThmOTY1Yzc5OSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTAxLTEzICBQaW5raSBHeWFuY2hhbmRh
bmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxsIFB0ciBEZXJlZiBA
IFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpjbGVhck1haW5SZXNvdXJjZUxvYWRlcgorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MjA0CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVu
bmVyL1dlYktpdFRlc3RSdW5uZXIueGNvZGVwcm9qL3hjc2hhcmVkZGF0YS94Y3NjaGVtZXMvV2Vi
S2l0VGVzdFJ1bm5lci54Y3NjaGVtZToKKwogMjAyMC0wMS0wNyAgVHJ1aXR0IFNhdmVsbCAgPHRz
YXZlbGxAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNTQx
NjUuCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggOTFhMTFlY2Q4OTJi
MGFmN2VkY2MzYzY3NmMzYjczMDIzYjc0ODExYy4uODkzM2U4ODcxNTU5NDE2ZWZmM2YyYTE1OGEy
NmZjOTdiNmNkMmU1ZSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAt
MSwzICsxLDEzIEBACisyMDIwLTAxLTEzICBQaW5raSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5k
YW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxsIFB0ciBEZXJlZiBAIFdlYkNvcmU6OkRvY3Vt
ZW50TG9hZGVyOjpjbGVhck1haW5SZXNvdXJjZUxvYWRlcgorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MjA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXQueGN3b3Jrc3BhY2UveGNzaGFyZWRk
YXRhL1dvcmtzcGFjZVNldHRpbmdzLnhjc2V0dGluZ3M6CisgICAgICAgICogV2ViS2l0Lnhjd29y
a3NwYWNlL3hjc2hhcmVkZGF0YS94Y3NjaGVtZXMvQWxsIFRvb2xzLnhjc2NoZW1lOgorCiAyMDIw
LTAxLTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg
ICAgICBbR1RLXVtXUEVdIEFkZCBBUEkgdG8gc2V0IHB1cnBvc2UgYW5kIGhpbnRzIG9mIGFjdGl2
ZSBlZGl0YWJsZSBlbGVtZW50IHRvIGlucHV0IG1ldGhvZHMK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>387706</attachid>
            <date>2020-01-14 14:34:11 -0800</date>
            <delta_ts>2020-01-15 17:30:15 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-206204-20200114143410.patch</filename>
            <type>text/plain</type>
            <size>3751</size>
            <attacher name="Pinki Gyanchandani">pgyanchandani</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDEzNzE4MjE5N2VhY2Ri
MzM4OGFiNDE3YjQxMWVkMGRkNTlmZjBiOC4uMWZlMDdlNjk5Y2YzMzU2N2MyZjFhNTA4ODlkOGQ0
ZDBmNzM3M2E1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTE0ICBQaW5r
aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs
IFB0ciBEZXJlZiBAIFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpjbGVhck1haW5SZXNvdXJjZUxv
YWRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2
MjA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVz
dDogbG9hZGVyL2NoYW5nZS1zcmMtZHVyaW5nLWlmcmFtZS1sb2FkLWNyYXNoLmh0bWwKKworICAg
ICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1
bWVudExvYWRlcjo6ZnJhbWVMb2FkZXIgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1l
bnRMb2FkZXI6OmNsZWFyTWFpblJlc291cmNlTG9hZGVyKToKKwogMjAyMC0wMS0wNyAgUm9zcyBL
aXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBy
ZXN0YWJpbGl6YXRpb24gb2Ygbm9uLXVuaWZpZWQgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy
L0RvY3VtZW50TG9hZGVyLmNwcAppbmRleCBiZTI3ZWYxYmJlMzJiN2U1ZjkyNWQ5OTc0OTM2YTNj
YmI1OWMyODBhLi4zMjBkZTgwZWEzZDhhZTAzYzU0ZTk0YjhmM2UyNGY4ZWY0OTY0OTExIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKQEAgLTE1Niw2ICsxNTYsNyBA
QCBGcmFtZUxvYWRlciogRG9jdW1lbnRMb2FkZXI6OmZyYW1lTG9hZGVyKCkgY29uc3QKIHsKICAg
ICBpZiAoIW1fZnJhbWUpCiAgICAgICAgIHJldHVybiBudWxscHRyOworCiAgICAgcmV0dXJuICZt
X2ZyYW1lLT5sb2FkZXIoKTsKIH0KIApAQCAtMTI3Miw3ICsxMjczLDEyIEBAIHZvaWQgRG9jdW1l
bnRMb2FkZXI6OmNsZWFyTWFpblJlc291cmNlTG9hZGVyKCkKIHsKICAgICBtX2xvYWRpbmdNYWlu
UmVzb3VyY2UgPSBmYWxzZTsKIAotICAgIGlmICh0aGlzID09IGZyYW1lTG9hZGVyKCktPmFjdGl2
ZURvY3VtZW50TG9hZGVyKCkpCisgICAgYXV0byogZnJhbWVMb2FkZXIgPSB0aGlzLT5mcmFtZUxv
YWRlcigpOworCisgICAgaWYgKCFmcmFtZUxvYWRlcikKKyAgICAgICAgcmV0dXJuOworCisgICAg
aWYgKHRoaXMgPT0gZnJhbWVMb2FkZXItPmFjdGl2ZURvY3VtZW50TG9hZGVyKCkpCiAgICAgICAg
IGNoZWNrTG9hZENvbXBsZXRlKCk7CiB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n
ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlMDU2ZmY4OGViMzM0MDBiM2RkNTVm
YzA1ODI3NzVlNWE3MzRmNzI5Li4xNDdkYWVhMjIxZjZhZWRjZTM0ZjY5MDhkYmQ4MjdlZTAwMjU3
NGMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv
Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMTQgIFBpbmtpIEd5YW5jaGFuZGFu
aSAgPHBneWFuY2hhbmRhbmlAYXBwbGUuY29tPgorCisgICAgICAgIE51bGwgUHRyIERlcmVmIEAg
V2ViQ29yZTo6RG9jdW1lbnRMb2FkZXI6OmNsZWFyTWFpblJlc291cmNlTG9hZGVyCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYyMDQKKworICAgICAg
ICBBZGRlZCBhIE5VTEwgcG9pbnRlciBjaGVjayBmb3IgRnJhbWVMb2FkZXIuIElmIEZyYW1Mb2Fk
ZXIgaXMgTlVMTCB0aGVuIHJldHVybiBpbnN0ZWFkIG9mCisgICAgICAgIGFjY2Vzc2luZyBhY3Rp
dmVEb2N1bWVudExvYWRlci4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICAqIGxvYWRlci9jaGFuZ2Utc3JjLWR1cmluZy1pZnJhbWUtbG9hZC1jcmFzaC1l
eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGxvYWRlci9jaGFuZ2Utc3JjLWR1cmluZy1p
ZnJhbWUtbG9hZC1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAyMC0wMS0wNyAgRGFuaWVsIEJhdGVz
ICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHVwIGxheW91dCB0ZXN0cyByZXN1
bHRzIGZvbGxvd2luZyByMjU0MTYwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9sb2FkZXIvY2hh
bmdlLXNyYy1kdXJpbmctaWZyYW1lLWxvYWQtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz
dHMvbG9hZGVyL2NoYW5nZS1zcmMtZHVyaW5nLWlmcmFtZS1sb2FkLWNyYXNoLWV4cGVjdGVkLnR4
dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwLi43NGJhZjg0NTM0YjQ1ODQwYmE1NzIxMDBmZTFjNWU0MTBjNzNkMGM4Ci0t
LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbG9hZGVyL2NoYW5nZS1zcmMtZHVyaW5nLWlm
cmFtZS1sb2FkLWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitUaGUgdGVzdCBpcyBk
ZWNsYXJlZCBwYXNzIGlmIHRoZXJlIGlzIG5vIGNyYXNoIG9ic2VydmVkLgpkaWZmIC0tZ2l0IGEv
TGF5b3V0VGVzdHMvbG9hZGVyL2NoYW5nZS1zcmMtZHVyaW5nLWlmcmFtZS1sb2FkLWNyYXNoLmh0
bWwgYi9MYXlvdXRUZXN0cy9sb2FkZXIvY2hhbmdlLXNyYy1kdXJpbmctaWZyYW1lLWxvYWQtY3Jh
c2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwLi5iOGQ2NzVmZDUzMjRlNmM1ZjhlNTJlN2ZkZmZkZDkwMWYwNDJj
MWUyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbG9hZGVyL2NoYW5nZS1zcmMtZHVy
aW5nLWlmcmFtZS1sb2FkLWNyYXNoLmh0bWwKQEAgLTAsMCArMSwyMCBAQAorPGh0bWw+Cis8c2Ny
aXB0PgorZnVuY3Rpb24gbG9hZCgpIHsKKyAgICBkb2N1bWVudC5ib2R5LmlubmVySFRNTCA9ICdU
aGUgdGVzdCBpcyBkZWNsYXJlZCBwYXNzIGlmIHRoZXJlIGlzIG5vIGNyYXNoIG9ic2VydmVkLic7
CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFz
VGV4dCgpOworICAgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB9Cit9CisK
K2Z1bmN0aW9uIGV2ZW50aGFuZGxlcjMoKSB7CisgICAgaWZyYW1lMS5zcmNkb2MgPSAieCI7Cisg
ICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUo
KTsKK30KKworPC9zY3JpcHQ+Cis8Ym9keSBvbmxvYWQ9ImxvYWQoKSI+Cis8aWZyYW1lIGlkPSJp
ZnJhbWUxIiBzcmM9ImRhdGE6dGV4dC9odG1sLGZvbyI+YTwvaWZyYW1lPgorPGlmcmFtZSBpZD0i
aWZyYW1lMiIgb25sb2FkPSJldmVudGhhbmRsZXIzKCkiIHNyY2RvYz0ieSI+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>387876</attachid>
            <date>2020-01-15 17:30:17 -0800</date>
            <delta_ts>2020-01-15 18:29:17 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-206204-20200115173016.patch</filename>
            <type>text/plain</type>
            <size>3747</size>
            <attacher name="Pinki Gyanchandani">pgyanchandani</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDEzNzE4MjE5N2VhY2Ri
MzM4OGFiNDE3YjQxMWVkMGRkNTlmZjBiOC4uMWZlMDdlNjk5Y2YzMzU2N2MyZjFhNTA4ODlkOGQ0
ZDBmNzM3M2E1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTE0ICBQaW5r
aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs
IFB0ciBEZXJlZiBAIFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpjbGVhck1haW5SZXNvdXJjZUxv
YWRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2
MjA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVz
dDogbG9hZGVyL2NoYW5nZS1zcmMtZHVyaW5nLWlmcmFtZS1sb2FkLWNyYXNoLmh0bWwKKworICAg
ICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1
bWVudExvYWRlcjo6ZnJhbWVMb2FkZXIgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1l
bnRMb2FkZXI6OmNsZWFyTWFpblJlc291cmNlTG9hZGVyKToKKwogMjAyMC0wMS0wNyAgUm9zcyBL
aXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBy
ZXN0YWJpbGl6YXRpb24gb2Ygbm9uLXVuaWZpZWQgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy
L0RvY3VtZW50TG9hZGVyLmNwcAppbmRleCBiZTI3ZWYxYmJlMzJiN2U1ZjkyNWQ5OTc0OTM2YTNj
YmI1OWMyODBhLi4yYWIyZWY1ZGNjOTQzNDI1MGZmZDBkYjVlYjM0MDQ0OWRmN2M4NWIxIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKQEAgLTEyNzIsNyArMTI3Miwx
MiBAQCB2b2lkIERvY3VtZW50TG9hZGVyOjpjbGVhck1haW5SZXNvdXJjZUxvYWRlcigpCiB7CiAg
ICAgbV9sb2FkaW5nTWFpblJlc291cmNlID0gZmFsc2U7CiAKLSAgICBpZiAodGhpcyA9PSBmcmFt
ZUxvYWRlcigpLT5hY3RpdmVEb2N1bWVudExvYWRlcigpKQorICAgIGF1dG8qIGZyYW1lTG9hZGVy
ID0gdGhpcy0+ZnJhbWVMb2FkZXIoKTsKKworICAgIGlmICghZnJhbWVMb2FkZXIpCisgICAgICAg
IHJldHVybjsKKworICAgIGlmICh0aGlzID09IGZyYW1lTG9hZGVyLT5hY3RpdmVEb2N1bWVudExv
YWRlcigpKQogICAgICAgICBjaGVja0xvYWRDb21wbGV0ZSgpOwogfQogCmRpZmYgLS1naXQgYS9M
YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTA1NmZm
ODhlYjMzNDAwYjNkZDU1ZmMwNTgyNzc1ZTVhNzM0ZjcyOS4uNGY1YjQ5OTIzZjVkOTY5ZjUyMTdj
ZTg4M2IyYmMxZTQ0MmJlOWRmNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr
KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTE0ICBQ
aW5raSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBO
dWxsIFB0ciBEZXJlZiBAIFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpjbGVhck1haW5SZXNvdXJj
ZUxvYWRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MjA2MjA0CisKKyAgICAgICAgQWRkZWQgYSBOVUxMIHBvaW50ZXIgY2hlY2sgZm9yIEZyYW1lTG9h
ZGVyLiBJZiBGcmFtTG9hZGVyIGlzIE5VTEwgdGhlbiByZXR1cm4gaW5zdGVhZCBvZgorICAgICAg
ICBhY2Nlc3NpbmcgYWN0aXZlRG9jdW1lbnRMb2FkZXIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Unlvc3VrZSBOaXdhLgorCisgICAgICAgICogbG9hZGVyL2NoYW5nZS1zcmMtZHVyaW5nLWlmcmFt
ZS1sb2FkLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbG9hZGVyL2NoYW5n
ZS1zcmMtZHVyaW5nLWlmcmFtZS1sb2FkLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDIwLTAxLTA3
ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdXAgbGF5
b3V0IHRlc3RzIHJlc3VsdHMgZm9sbG93aW5nIHIyNTQxNjAKZGlmZiAtLWdpdCBhL0xheW91dFRl
c3RzL2xvYWRlci9jaGFuZ2Utc3JjLWR1cmluZy1pZnJhbWUtbG9hZC1jcmFzaC1leHBlY3RlZC50
eHQgYi9MYXlvdXRUZXN0cy9sb2FkZXIvY2hhbmdlLXNyYy1kdXJpbmctaWZyYW1lLWxvYWQtY3Jh
c2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc0YmFmODQ1MzRiNDU4NDBiYTU3MjEwMGZlMWM1
ZTQxMGM3M2QwYzgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9sb2FkZXIvY2hhbmdl
LXNyYy1kdXJpbmctaWZyYW1lLWxvYWQtY3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAK
K1RoZSB0ZXN0IGlzIGRlY2xhcmVkIHBhc3MgaWYgdGhlcmUgaXMgbm8gY3Jhc2ggb2JzZXJ2ZWQu
CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9sb2FkZXIvY2hhbmdlLXNyYy1kdXJpbmctaWZyYW1l
LWxvYWQtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2xvYWRlci9jaGFuZ2Utc3JjLWR1cmluZy1p
ZnJhbWUtbG9hZC1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjYyOGJlN2E1ZTc4NWRjMzIxZWJmZDkw
NjRhZmMxOTIxNTA2M2Q5ODYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9sb2FkZXIv
Y2hhbmdlLXNyYy1kdXJpbmctaWZyYW1lLWxvYWQtY3Jhc2guaHRtbApAQCAtMCwwICsxLDI3IEBA
Cis8aHRtbD4KKzxzY3JpcHQ+CisKK2xldCBkaWRMb2FkID0gZmFsc2U7CitsZXQgZGlkRmluaXNo
VGVzdGluZyA9IGZhbHNlOworCitmdW5jdGlvbiBsb2FkKCkgeworICAgIGRvY3VtZW50LmJvZHku
aW5uZXJIVE1MID0gJ1RoZSB0ZXN0IGlzIGRlY2xhcmVkIHBhc3MgaWYgdGhlcmUgaXMgbm8gY3Jh
c2ggb2JzZXJ2ZWQuJzsKKyAgICBkaWRMb2FkID10cnVlOworICAgIGlmICh3aW5kb3cudGVzdFJ1
bm5lcikgeworICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgaWYoIWRp
ZEZpbmlzaFRlc3RpbmcpCisgICAgICAgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsK
KyAgICB9Cit9CisKK2Z1bmN0aW9uIGRpZExvYWRGcmFtZTIoKSB7CisgICAgaWZyYW1lMS5zcmNk
b2MgPSAieCI7CisgICAgZGlkRmluaXNoVGVzdGluZyA9IHRydWU7CisgICAgaWYgKHdpbmRvdy50
ZXN0UnVubmVyICYmIGRpZExvYWQpCisgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOwor
fQorCis8L3NjcmlwdD4KKzxib2R5IG9ubG9hZD0ibG9hZCgpIj4KKzxpZnJhbWUgaWQ9ImlmcmFt
ZTEiIHNyYz0iZGF0YTp0ZXh0L2h0bWwsZm9vIj5hPC9pZnJhbWU+Cis8aWZyYW1lIGlkPSJpZnJh
bWUyIiBvbmxvYWQ9ImRpZExvYWRGcmFtZTIoKSIgc3JjZG9jPSJ5Ij4K
</data>
<flag name="review"
          id="403625"
          type_id="1"
          status="+"
          setter="rniwa"
    />
          </attachment>
      

    </bug>

</bugzilla>