206191 2020-01-13 13:08:44 -0800 Web Inspector: crash in DumpRenderTree at com.apple.JavaScriptCore: WTF::RefCountedBase::hasOneRef const 2020-01-14 12:00:51 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue ddkilzer ews-watchlist hi inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1606018 0 hi 2020-01-13 13:08:44 -0800 ASSERTION FAILED: !m_deletionHasBegun /Volumes/Data/worker/macOS-High-Sierra-Debug-Build-EWS/build/WebKitBuild/Debug/usr/local/include/wtf/RefCounted.h(55) : bool WTF::RefCountedBase::hasOneRef() const 1 0x10a8e0639 WTFCrash 2 0x10bf6a73b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10be2d688 WTF::RefCountedBase::hasOneRef() const 4 0x10b019099 WTF::RefCountedBase::applyRefDerefThreadingCheck() const 5 0x10bfa06d9 WTF::RefCountedBase::ref() const 6 0x10b2521f5 void WTF::refIfNotNull<JSC::SourceProvider>(JSC::SourceProvider*) 7 0x10b2521b4 WTF::RefPtr<JSC::SourceProvider, WTF::DumbPtrTraits<JSC::SourceProvider> >::RefPtr(JSC::SourceProvider*) 8 0x10b25217d WTF::RefPtr<JSC::SourceProvider, WTF::DumbPtrTraits<JSC::SourceProvider> >::RefPtr(JSC::SourceProvider*) 9 0x10bb17713 WTF::RefPtr<JSC::SourceProvider, WTF::DumbPtrTraits<JSC::SourceProvider> >::operator=(JSC::SourceProvider*) 10 0x10bb1735e Inspector::ScriptDebugServer::sourceParsed(JSC::JSGlobalObject*, JSC::SourceProvider*, int, WTF::String const&) 11 0x10b4b3de8 JSC::Debugger::attach(JSC::JSGlobalObject*) 12 0x1197766c0 WebCore::JSWindowProxy::attachDebugger(JSC::Debugger*) 13 0x11979d519 WebCore::WindowProxy::attachDebugger(JSC::Debugger*) 14 0x11a95199a WebCore::Page::setDebugger(JSC::Debugger*) 15 0x11a4c2cb7 WebCore::PageScriptDebugServer::attachDebugger() 16 0x10bb17f40 Inspector::ScriptDebugServer::addListener(Inspector::ScriptDebugListener*) 17 0x10bb2ca32 Inspector::InspectorDebuggerAgent::enable() 18 0x11a5b7f53 WebCore::WebDebuggerAgent::enable() 19 0x11a5ea6a3 WebCore::PageDebuggerAgent::enable() 20 0x10bb2d4d9 Inspector::InspectorDebuggerAgent::enable(WTF::String&) 21 0x10ba8dc9a Inspector::DebuggerBackendDispatcher::enable(long, WTF::RefPtr<WTF::JSONImpl::Object, WTF::DumbPtrTraits<WTF::JSONImpl::Object> >&&) 22 0x10ba8db31 Inspector::DebuggerBackendDispatcher::dispatch(long, WTF::String const&, WTF::Ref<WTF::JSONImpl::Object, WTF::DumbPtrTraits<WTF::JSONImpl::Object> >&&) 23 0x10ba72b29 Inspector::BackendDispatcher::dispatch(WTF::String const&) 24 0x11a48edfc WebCore::InspectorController::dispatchMessageFromFrontend(WTF::String const&) 25 0x11a49c48d WebCore::InspectorBackendDispatchTask::dispatchOneMessage() 26 0x11a49c3ac WebCore::InspectorBackendDispatchTask::scheduleOneShot()::'lambda'()::operator()() const 27 0x11a49c159 WTF::Detail::CallableWrapper<WebCore::InspectorBackendDispatchTask::scheduleOneShot()::'lambda'(), void>::call() 28 0x10a906c9d WTF::Function<void ()>::operator()() const 29 0x10a9703ed WTF::RunLoop::performWork() 30 0x10a970d64 WTF::RunLoop::performWork(void*) 31 0x7fff4bcf9581 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 1606019 1 hi 2020-01-13 13:08:54 -0800 <rdar://problem/58415623> 1606022 2 387562 hi 2020-01-13 13:14:09 -0800 Created attachment 387562 Patch 1606027 3 387562 joepeck 2020-01-13 13:25:46 -0800 Comment on attachment 387562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387562&action=review r=me > Source/JavaScriptCore/debugger/Debugger.cpp:127 > + if (function->scope()->globalObject() == globalObject && function->executable()->isFunctionExecutable() && !function->isHostOrBuiltinFunction()) I would find this easier to read and modify in the future if this used early return conditions like it was before. For example: if (function->scope()->globalObject() != m_globalObject) return IterationStatus::Continue; if (!function->executable()->isFunctionExecutable()) return IterationStatus::Continue; if (function->isHostOrBuiltinFunction()) return IterationStatus::Continue; But I'll leave that style choice up to you. > Source/JavaScriptCore/debugger/Debugger.cpp:135 > + sourceParsed(globalObject, sourceProvider.get(), -1, nullString()); Is there a meaningful difference between switching to `nullString` here? 1606037 4 387562 hi 2020-01-13 13:45:40 -0800 Comment on attachment 387562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387562&action=review >> Source/JavaScriptCore/debugger/Debugger.cpp:127 >> + if (function->scope()->globalObject() == globalObject && function->executable()->isFunctionExecutable() && !function->isHostOrBuiltinFunction()) > > I would find this easier to read and modify in the future if this used early return conditions like it was before. For example: > > if (function->scope()->globalObject() != m_globalObject) > return IterationStatus::Continue; > > if (!function->executable()->isFunctionExecutable()) > return IterationStatus::Continue; > > if (function->isHostOrBuiltinFunction()) > return IterationStatus::Continue; > > But I'll leave that style choice up to you. I personally find the single `return` to be easier to read, especially in this case as it makes it super clear that we are _always_ expecting to continue iterating (rather than having to read each `return` to see that). >> Source/JavaScriptCore/debugger/Debugger.cpp:135 >> + sourceParsed(globalObject, sourceProvider.get(), -1, nullString()); > > Is there a meaningful difference between switching to `nullString` here? No, as the `-1` effectively causes it to be ignored. I was just trying to avoid another allocation with `String()`. 1606505 5 387562 commit-queue 2020-01-14 12:00:50 -0800 Comment on attachment 387562 Patch Clearing flags on attachment: 387562 Committed r254523: <https://trac.webkit.org/changeset/254523> 1606506 6 commit-queue 2020-01-14 12:00:51 -0800 All reviewed patches have been landed. Closing bug. 387562 2020-01-13 13:14:09 -0800 2020-01-14 12:00:50 -0800 Patch bug-206191-20200113131408.patch text/plain 4460 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDA2OTcyOTA0MmYwOTdiYWVlYmU3YjQ5YTUyNjc1 NzE5MDIxMTFlZDQuLjU1YzlhYzVlNzA3YWJiOGQ1MmZjY2JiYWQ3NjExYjg4MGJlMWYyYmUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAxLTEzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBj cmFzaCBpbiBEdW1wUmVuZGVyVHJlZSBhdCBjb20uYXBwbGUuSmF2YVNjcmlwdENvcmU6IFdURjo6 UmVmQ291bnRlZEJhc2U6Omhhc09uZVJlZiBjb25zdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MTkxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81 ODQxNTYyMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGRlYnVnZ2VyL0RlYnVnZ2VyLmNwcDoKKyAgICAgICAgKEpTQzo6RGVidWdnZXI6OmF0dGFj aCk6CisgICAgICAgIChHYXRoZXJTb3VyY2VQcm92aWRlcnM6OkdhdGhlclNvdXJjZVByb3ZpZGVy cyk6IERlbGV0ZWQuCisgICAgICAgIChHYXRoZXJTb3VyY2VQcm92aWRlcnM6Om9wZXJhdG9yKCkp OiBEZWxldGVkLgorICAgICAgICBVc2UgYFJlZlB0cjxTb3VyY2VQcm92aWRlcj5gIGluc3RlYWQg b2YgYFNvdXJjZVByb3ZpZGVyKmAgaW4gY2FzZSB0aGUgYEZ1bmN0aW9uRXhlY3V0YWJsZWAKKyAg ICAgICAgaXMgZGVzdHJveWVkIGFmdGVyIHRoZSBgU291cmNlUHJvdmlkZXIqYCBpcyBzYXZlZCwg d2hpY2ggd291bGQgZGVzdHJveSB0aGUgYFNvdXJjZVByb3ZpZGVyYAorICAgICAgICBhcyB3ZWxs LgorCiAyMDIwLTAxLTExICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgog CiAgICAgICAgIENoZWNrTmV1dGVyZWQgbmVlZHMgdG8gY2xhaW0gaXQgcmVhZHMgSlNUeXBlIGlu IGNsb2JiZXJpemUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIv RGVidWdnZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmNw cAppbmRleCA5YzdjZmJjZWRjOTkzNjI2NWRlZGM1YzYzNTNkNjlhYmU4MmQ5MGRiLi4zYTM3ZmE3 Y2Q0M2ZlODdiMmFhOWQ1YmJkNDZkMDE1NmFjNTFmMDVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5jcHAKQEAgLTM2LDQ3ICszNiw2IEBACiAjaW5jbHVkZSAi UHJvdGVjdC5oIgogI2luY2x1ZGUgIlZNRW50cnlTY29wZS5oIgogCi1uYW1lc3BhY2UgewotCi11 c2luZyBuYW1lc3BhY2UgSlNDOwotCi1zdHJ1Y3QgR2F0aGVyU291cmNlUHJvdmlkZXJzIDogcHVi bGljIE1hcmtlZEJsb2NrOjpWb2lkRnVuY3RvciB7Ci0gICAgLy8gRklYTUU6IFRoaXMgaXMgYSBt dXRhYmxlIGZpZWxkIGJlY2F1c2UgdGhpcyBpc24ndCBhIEMrKyBsYW1iZGEuCi0gICAgLy8gaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTY0NAotICAgIG11dGFibGUg SGFzaFNldDxTb3VyY2VQcm92aWRlcio+IHNvdXJjZVByb3ZpZGVyczsKLSAgICBKU0dsb2JhbE9i amVjdCogbV9nbG9iYWxPYmplY3Q7Ci0KLSAgICBHYXRoZXJTb3VyY2VQcm92aWRlcnMoSlNHbG9i YWxPYmplY3QqIGdsb2JhbE9iamVjdCkKLSAgICAgICAgOiBtX2dsb2JhbE9iamVjdChnbG9iYWxP YmplY3QpIHsgfQotCi0gICAgSXRlcmF0aW9uU3RhdHVzIG9wZXJhdG9yKCkoSGVhcENlbGwqIGhl YXBDZWxsLCBIZWFwQ2VsbDo6S2luZCBraW5kKSBjb25zdAotICAgIHsKLSAgICAgICAgaWYgKCFp c0pTQ2VsbEtpbmQoa2luZCkpCi0gICAgICAgICAgICByZXR1cm4gSXRlcmF0aW9uU3RhdHVzOjpD b250aW51ZTsKLSAgICAgICAgCi0gICAgICAgIEpTQ2VsbCogY2VsbCA9IHN0YXRpY19jYXN0PEpT Q2VsbCo+KGhlYXBDZWxsKTsKLSAgICAgICAgCi0gICAgICAgIEpTRnVuY3Rpb24qIGZ1bmN0aW9u ID0ganNEeW5hbWljQ2FzdDxKU0Z1bmN0aW9uKj4oY2VsbC0+dm0oKSwgY2VsbCk7Ci0gICAgICAg IGlmICghZnVuY3Rpb24pCi0gICAgICAgICAgICByZXR1cm4gSXRlcmF0aW9uU3RhdHVzOjpDb250 aW51ZTsKLQotICAgICAgICBpZiAoZnVuY3Rpb24tPnNjb3BlKCktPmdsb2JhbE9iamVjdCgpICE9 IG1fZ2xvYmFsT2JqZWN0KQotICAgICAgICAgICAgcmV0dXJuIEl0ZXJhdGlvblN0YXR1czo6Q29u dGludWU7Ci0KLSAgICAgICAgaWYgKCFmdW5jdGlvbi0+ZXhlY3V0YWJsZSgpLT5pc0Z1bmN0aW9u RXhlY3V0YWJsZSgpKQotICAgICAgICAgICAgcmV0dXJuIEl0ZXJhdGlvblN0YXR1czo6Q29udGlu dWU7Ci0KLSAgICAgICAgaWYgKGZ1bmN0aW9uLT5pc0hvc3RPckJ1aWx0aW5GdW5jdGlvbigpKQot ICAgICAgICAgICAgcmV0dXJuIEl0ZXJhdGlvblN0YXR1czo6Q29udGludWU7Ci0KLSAgICAgICAg c291cmNlUHJvdmlkZXJzLmFkZCgKLSAgICAgICAgICAgIGpzQ2FzdDxGdW5jdGlvbkV4ZWN1dGFi bGUqPihmdW5jdGlvbi0+ZXhlY3V0YWJsZSgpKS0+c291cmNlKCkucHJvdmlkZXIoKSk7Ci0gICAg ICAgIHJldHVybiBJdGVyYXRpb25TdGF0dXM6OkNvbnRpbnVlOwotICAgIH0KLX07Ci0KLX0gLy8g bmFtZXNwYWNlCi0KIG5hbWVzcGFjZSBKU0MgewogCiBjbGFzcyBEZWJ1Z2dlclBhdXNlZFNjb3Bl IHsKQEAgLTE1NywxNCArMTE2LDIzIEBAIHZvaWQgRGVidWdnZXI6OmF0dGFjaChKU0dsb2JhbE9i amVjdCogZ2xvYmFsT2JqZWN0KQogCiAgICAgbV92bS5zZXRTaG91bGRCdWlsZFBDVG9Db2RlT3Jp Z2luTWFwcGluZygpOwogCi0gICAgLy8gQ2FsbCBzb3VyY2VQYXJzZWQgYmVjYXVzZSBpdCB3aWxs IGV4ZWN1dGUgSmF2YVNjcmlwdCBpbiB0aGUgaW5zcGVjdG9yLgotICAgIEdhdGhlclNvdXJjZVBy b3ZpZGVycyBnYXRoZXJTb3VyY2VQcm92aWRlcnMoZ2xvYmFsT2JqZWN0KTsKKyAgICAvLyBDYWxs IGBzb3VyY2VQYXJzZWRgIGFmdGVyIGl0ZXJhdGluZyBiZWNhdXNlIGl0IHdpbGwgZXhlY3V0ZSBK YXZhU2NyaXB0IGluIFdlYiBJbnNwZWN0b3IuCisgICAgSGFzaFNldDxSZWZQdHI8U291cmNlUHJv dmlkZXI+PiBzb3VyY2VQcm92aWRlcnM7CiAgICAgewogICAgICAgICBIZWFwSXRlcmF0aW9uU2Nv cGUgaXRlcmF0aW9uU2NvcGUobV92bS5oZWFwKTsKLSAgICAgICAgbV92bS5oZWFwLm9iamVjdFNw YWNlKCkuZm9yRWFjaExpdmVDZWxsKGl0ZXJhdGlvblNjb3BlLCBnYXRoZXJTb3VyY2VQcm92aWRl cnMpOworICAgICAgICBtX3ZtLmhlYXAub2JqZWN0U3BhY2UoKS5mb3JFYWNoTGl2ZUNlbGwoaXRl cmF0aW9uU2NvcGUsIFsmXSAoSGVhcENlbGwqIGhlYXBDZWxsLCBIZWFwQ2VsbDo6S2luZCBraW5k KSB7CisgICAgICAgICAgICBpZiAoaXNKU0NlbGxLaW5kKGtpbmQpKSB7CisgICAgICAgICAgICAg ICAgYXV0byogY2VsbCA9IHN0YXRpY19jYXN0PEpTQ2VsbCo+KGhlYXBDZWxsKTsKKyAgICAgICAg ICAgICAgICBpZiAoYXV0byogZnVuY3Rpb24gPSBqc0R5bmFtaWNDYXN0PEpTRnVuY3Rpb24qPihj ZWxsLT52bSgpLCBjZWxsKSkgeworICAgICAgICAgICAgICAgICAgICBpZiAoZnVuY3Rpb24tPnNj b3BlKCktPmdsb2JhbE9iamVjdCgpID09IGdsb2JhbE9iamVjdCAmJiBmdW5jdGlvbi0+ZXhlY3V0 YWJsZSgpLT5pc0Z1bmN0aW9uRXhlY3V0YWJsZSgpICYmICFmdW5jdGlvbi0+aXNIb3N0T3JCdWls dGluRnVuY3Rpb24oKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIHNvdXJjZVByb3ZpZGVycy5h ZGQoanNDYXN0PEZ1bmN0aW9uRXhlY3V0YWJsZSo+KGZ1bmN0aW9uLT5leGVjdXRhYmxlKCkpLT5z b3VyY2UoKS5wcm92aWRlcigpKTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9Cisg ICAgICAgICAgICByZXR1cm4gSXRlcmF0aW9uU3RhdHVzOjpDb250aW51ZTsKKyAgICAgICAgfSk7 CiAgICAgfQotICAgIGZvciAoYXV0byogc291cmNlUHJvdmlkZXIgOiBnYXRoZXJTb3VyY2VQcm92 aWRlcnMuc291cmNlUHJvdmlkZXJzKQotICAgICAgICBzb3VyY2VQYXJzZWQoZ2xvYmFsT2JqZWN0 LCBzb3VyY2VQcm92aWRlciwgLTEsIFN0cmluZygpKTsKKyAgICBmb3IgKGF1dG8mIHNvdXJjZVBy b3ZpZGVyIDogc291cmNlUHJvdmlkZXJzKQorICAgICAgICBzb3VyY2VQYXJzZWQoZ2xvYmFsT2Jq ZWN0LCBzb3VyY2VQcm92aWRlci5nZXQoKSwgLTEsIG51bGxTdHJpbmcoKSk7CiB9CiAKIHZvaWQg RGVidWdnZXI6OmRldGFjaChKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBSZWFzb25Gb3JE ZXRhY2ggcmVhc29uKQo=