206184 2020-01-13 11:04:52 -0800 Web Inspector: "Enable Local Override" and "Delete Local Override" are displayed twice in the contextual menu 2020-01-13 19:44:36 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1605949 0 hi 2020-01-13 11:04:52 -0800 . 1605950 1 hi 2020-01-13 11:05:02 -0800 <rdar://problem/58409880> 1605953 2 387547 hi 2020-01-13 11:06:33 -0800 Created attachment 387547 Patch 1605968 3 387547 bburg 2020-01-13 11:45:01 -0800 Comment on attachment 387547 Patch r=me Kind of weird, but I guess it's fine. I guess the other option is to type-check the represented object and not add them in the case they are overrides already. 1606213 4 commit-queue 2020-01-13 19:44:02 -0800 The commit-queue encountered the following flaky tests while processing attachment 387547: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) fast/hidpi/image-srcset-relative-svg-canvas-2x.html bug 206211 (author: yoav@yoav.ws) The commit-queue is continuing to process your patch. 1606215 5 387547 commit-queue 2020-01-13 19:44:34 -0800 Comment on attachment 387547 Patch Clearing flags on attachment: 387547 Committed r254485: <https://trac.webkit.org/changeset/254485> 1606216 6 commit-queue 2020-01-13 19:44:36 -0800 All reviewed patches have been landed. Closing bug. 387547 2020-01-13 11:06:33 -0800 2020-01-13 19:44:34 -0800 Patch bug-206184-20200113110632.patch text/plain 3101 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDNlNGQ4NzRjYjBhZmE0YjcxNWFhZmU1OTgxNzQ2 MjM1NGYwMmExMGQuLmE2MzA1NDc1YzA2ZjM2ZWUzM2YzMjEyNzFjNGNjMmNlODhlZTUyOGUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAxLTEzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiAi RW5hYmxlIExvY2FsIE92ZXJyaWRlIiBhbmQgIkRlbGV0ZSBMb2NhbCBPdmVycmlkZSIgYXJlIGRp c3BsYXllZCB0d2ljZSBpbiB0aGUgY29udGV4dHVhbCBtZW51CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYxODQKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzU4NDA5ODgwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db250ZXh0TWVudVV0aWxpdGllcy5qczoKKyAg ICAgICAgKFdJLmFwcGVuZENvbnRleHRNZW51SXRlbXNGb3JTb3VyY2VDb2RlKToKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL0xvY2FsUmVzb3VyY2VPdmVycmlkZVRyZWVFbGVtZW50Lmpz OgorICAgICAgICAoV0kuTG9jYWxSZXNvdXJjZU92ZXJyaWRlVHJlZUVsZW1lbnQucHJvdG90eXBl LnBvcHVsYXRlQ29udGV4dE1lbnUpOgorICAgICAgICBBZGQgYW4gZXhwYW5kbyBmbGFnICB0aGF0 IGNhbiBiZSBzZXQgYnkgYFdJLkxvY2FsUmVzb3VyY2VPdmVycmlkZVRyZWVFbGVtZW50YCB0byBl bnN1cmUgdGhhdAorICAgICAgICB0aGUgbG9jYWwgb3ZlcnJpZGUgY29udGV4dCBtZW51IGl0ZW1z IGFyZW4ndCBhZGRlZCBhZ2FpbiBieSBgV0kuUmVzb3VyY2VUcmVlRWxlbWVudGAuCisKIDIwMjAt MDEtMDkgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3Rvcjogc3VnZ2VzdCAiY29sb3IoKSIgd2hlbiBkZWZpbmluZyBjb2xvciBpbiBD U1MgdmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0NvbnRleHRNZW51VXRpbGl0aWVzLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvQ29udGV4dE1lbnVVdGlsaXRpZXMuanMKaW5kZXggYzYxNTYwNDVi YTVjMzg4YzE5ZDFiNWMwYWM4NmE3NDgyYjhlNzgxYy4uYWQ2Njg4OTY2ZTEwYTVlMmMxYWIxNmQy ZWJiZGM5OTYzMmEyMjA0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvQ29udGV4dE1lbnVVdGlsaXRpZXMuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29udGV4dE1lbnVVdGlsaXRpZXMuanMKQEAg LTcwLDcgKzcwLDEyIEBAIFdJLmFwcGVuZENvbnRleHRNZW51SXRlbXNGb3JTb3VyY2VDb2RlID0g ZnVuY3Rpb24oY29udGV4dE1lbnUsIHNvdXJjZUNvZGVPckxvY2F0CiAgICAgaWYgKCEoc291cmNl Q29kZSBpbnN0YW5jZW9mIFdJLlNvdXJjZUNvZGUpKQogICAgICAgICByZXR1cm47CiAKLSAgICBp ZiAoV0kuTmV0d29ya01hbmFnZXIuc3VwcG9ydHNMb2NhbFJlc291cmNlT3ZlcnJpZGVzKCkpIHsK KyAgICBpZiAoY29udGV4dE1lbnUuX19kb21CcmVha3BvaW50SXRlbXNBZGRlZCkKKyAgICAgICAg cmV0dXJuOworCisgICAgaWYgKCFjb250ZXh0TWVudS5fX2xvY2FsT3ZlcnJpZGVJdGVtc0FkZGVk ICYmIFdJLk5ldHdvcmtNYW5hZ2VyLnN1cHBvcnRzTG9jYWxSZXNvdXJjZU92ZXJyaWRlcygpKSB7 CisgICAgICAgIGNvbnRleHRNZW51Ll9fbG9jYWxPdmVycmlkZUl0ZW1zQWRkZWQgPSB0cnVlOwor CiAgICAgICAgIGlmIChXSS5uZXR3b3JrTWFuYWdlci5jYW5CZU92ZXJyaWRkZW4oc291cmNlQ29k ZSkpIHsKICAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZFNlcGFyYXRvcigpOwogICAgICAg ICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXSS5VSVN0cmluZygiQ3JlYXRlIExvY2FsIE92 ZXJyaWRlIiksIGFzeW5jICgpID0+IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvY2FsUmVzb3VyY2VPdmVycmlkZVRyZWVFbGVtZW50Lmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9jYWxSZXNvdXJj ZU92ZXJyaWRlVHJlZUVsZW1lbnQuanMKaW5kZXggNDBhZDI4NWJhZmRiNWQ5NzhhYmY0YjM3ZjJk OGFlZTI5MDQ4YWI0MC4uNTcwMDliZTZiMGVkZjllMWVmZjZlYWRmOGIwNmRhNjYwZjg3MzIzNyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9j YWxSZXNvdXJjZU92ZXJyaWRlVHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9jYWxSZXNvdXJjZU92ZXJyaWRlVHJlZUVsZW1lbnQu anMKQEAgLTk5LDYgKzk5LDggQEAgV0kuTG9jYWxSZXNvdXJjZU92ZXJyaWRlVHJlZUVsZW1lbnQg PSBjbGFzcyBMb2NhbFJlc291cmNlT3ZlcnJpZGVUcmVlRWxlbWVudCBleHQKIAogICAgIHBvcHVs YXRlQ29udGV4dE1lbnUoY29udGV4dE1lbnUsIGV2ZW50KQogICAgIHsKKyAgICAgICAgY29udGV4 dE1lbnUuX19sb2NhbE92ZXJyaWRlSXRlbXNBZGRlZCA9IHRydWU7CisKICAgICAgICAgY29udGV4 dE1lbnUuYXBwZW5kSXRlbShXSS5VSVN0cmluZygiRWRpdCBMb2NhbCBPdmVycmlkZVx1MjAyNiIp LCAoZXZlbnQpID0+IHsKICAgICAgICAgICAgIGxldCBwb3BvdmVyID0gbmV3IFdJLkxvY2FsUmVz b3VyY2VPdmVycmlkZVBvcG92ZXIodGhpcyk7CiAgICAgICAgICAgICBwb3BvdmVyLnNob3codGhp cy5fbG9jYWxSZXNvdXJjZU92ZXJyaWRlLCB0aGlzLnN0YXR1cywgW1dJLlJlY3RFZGdlLk1BWF9Y LCBXSS5SZWN0RWRnZS5NSU5fWF0pOwo=