206165 2020-01-13 02:28:19 -0800 [LFC][Integration] Build and enable on Windows 2020-01-28 13:21:15 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto don.olmstead annulen bfulgham commit-queue darin don.olmstead ews-watchlist fujii gyuyoung.kim ryuan.choi sergio simon.fraser webkit-bug-importer zalan oldest_to_newest 1605778 0 koivisto 2020-01-13 02:28:19 -0800 LFC is not currently building on windows. 1607029 1 don.olmstead 2020-01-15 11:17:26 -0800 Antti our IRC connection is down otherwise I'd ping you directly. LineBreaker::Run::operator= is missing. 1607034 2 koivisto 2020-01-15 11:22:13 -0800 I guess VC++ has trouble with vectors and move semantics? 1610183 3 388561 don.olmstead 2020-01-23 10:39:23 -0800 Created attachment 388561 Patch 1610238 4 don.olmstead 2020-01-23 11:52:47 -0800 On IRC anttik mentioned that LFC had been turned off due to perf issues. This patch just enables LFC on WinCairo when experimental features are enabled. So the feature will be ON for developers only. It will also catch any build errors when using MSVC around the feature. We personally think its fine to land this assuming a r+. 1611335 5 koivisto 2020-01-27 01:09:01 -0800 We are back to enabled on Mac so this is ok. 1612097 6 389046 don.olmstead 2020-01-28 11:58:24 -0800 Created attachment 389046 Patch 1612127 7 commit-queue 2020-01-28 13:01:30 -0800 The commit-queue encountered the following flaky tests while processing attachment 389046: http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org) The commit-queue is continuing to process your patch. 1612130 8 commit-queue 2020-01-28 13:01:53 -0800 The commit-queue encountered the following flaky tests while processing attachment 389046: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1612143 9 389046 commit-queue 2020-01-28 13:20:31 -0800 Comment on attachment 389046 Patch Clearing flags on attachment: 389046 Committed r255273: <https://trac.webkit.org/changeset/255273> 1612144 10 commit-queue 2020-01-28 13:20:33 -0800 All reviewed patches have been landed. Closing bug. 1612145 11 webkit-bug-importer 2020-01-28 13:21:15 -0800 <rdar://problem/58966926> 388561 2020-01-23 10:39:23 -0800 2020-01-28 11:58:24 -0800 Patch bug-206165.diff text/plain 3436 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxNjU3NDhmNTBmYS4uOWRj OTU0YzI1ZWIgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNCBAQAorMjAyMC0wMS0yMyAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t PgorCisgICAgICAgIFtMRkNdW0ludGVncmF0aW9uXSBCdWlsZCBhbmQgZW5hYmxlIG9uIFdpbmRv d3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjE2 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJs ZSBMRkMgZm9yIFdpbmRvd3MuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1dpbi5j bWFrZToKKwogMjAyMC0wMS0yMiAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t PgogCiAgICAgICAgIFtPcGVuU1NMXSBBZGQgc3R1YnMgYW5kIGJ1aWxkIGZvciBXZWIgQ3J5cHRv CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggOGFmYjI1Y2JhZDYuLmQ1YmVhMjkyYTgzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMjAtMDEtMjMgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255 LmNvbT4KKworICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gQnVpbGQgYW5kIGVuYWJsZSBvbiBX aW5kb3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDYxNjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggbWlub3IgY29tcGlsYXRpb24gaXNzdWVzIGluIExGQyB3aGVuIHVzaW5nIE1TVkMuCisKKyAg ICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVJdGVtLmg6CisgICAgICAgICog bGF5b3V0L2lubGluZWZvcm1hdHRpbmcvTGluZUxheW91dENvbnRleHQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TGF5b3V0OjpMaW5lTGF5b3V0Q29udGV4dDo6Y2xvc2UpOgorCiAyMDIwLTAxLTIz ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBE byBub3Qgc3BlY2lhbCBjYXNlIGZvcm1hdHRpbmcgcm9vdCBsYXlvdXQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUl0ZW0uaCBiL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUl0ZW0uaAppbmRleCA0MjBj N2NiNmVlMy4uNzM4NTIwN2EyMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bmxpbmVmb3JtYXR0aW5nL0lubGluZUl0ZW0uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv aW5saW5lZm9ybWF0dGluZy9JbmxpbmVJdGVtLmgKQEAgLTI4LDYgKzI4LDcgQEAKICNpZiBFTkFC TEUoTEFZT1VUX0ZPUk1BVFRJTkdfQ09OVEVYVCkKIAogI2luY2x1ZGUgIkxheW91dEJveC5oIgor I2luY2x1ZGUgIkxheW91dFVuaXRzLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIG5hbWVzcGFj ZSBMYXlvdXQgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1h dHRpbmcvTGluZUxheW91dENvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvTGluZUxheW91dENvbnRleHQuY3BwCmluZGV4IGJjZDEzN2M2MGFlLi40ZGVi OTc5YWRkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRp bmcvTGluZUxheW91dENvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxp bmVmb3JtYXR0aW5nL0xpbmVMYXlvdXRDb250ZXh0LmNwcApAQCAtMzE2LDcgKzMxNiw3IEBAIExp bmVMYXlvdXRDb250ZXh0OjpMaW5lQ29udGVudCBMaW5lTGF5b3V0Q29udGV4dDo6Y2xvc2UoTGlu ZUJ1aWxkZXImIGxpbmUsIGNvbnN0CiAgICAgZWxzZQogICAgICAgICBtX3N1Y2Nlc3NpdmVIeXBo ZW5hdGVkTGluZUNvdW50ID0gMDsKIAotICAgIGF1dG8gdHJhaWxpbmdJbmxpbmVJdGVtSW5kZXgg PSBsYXlvdXRSYW5nZS5zdGFydCArIGNvbW1pdHRlZElubGluZUl0ZW1Db3VudCAtIDE7CisgICAg dW5zaWduZWQgdHJhaWxpbmdJbmxpbmVJdGVtSW5kZXggPSBsYXlvdXRSYW5nZS5zdGFydCArIGNv bW1pdHRlZElubGluZUl0ZW1Db3VudCAtIDE7CiAgICAgQVNTRVJUKHRyYWlsaW5nSW5saW5lSXRl bUluZGV4IDwgbGF5b3V0UmFuZ2UuZW5kKTsKICAgICBhdXRvIGlzTGFzdExpbmVXaXRoSW5saW5l Q29udGVudCA9IFsmXSB7CiAgICAgICAgIGlmICh0cmFpbGluZ0lubGluZUl0ZW1JbmRleCA9PSBs YXlvdXRSYW5nZS5lbmQgLSAxKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNXaW4u Y21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbi5jbWFrZQppbmRleCA5MzVhN2ZkMTM2Ny4u YmNhOTY3MDM5MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCisr KyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCkBAIC04NCw2ICs4NCw3IEBAIGlmICgk e1dURl9QTEFURk9STV9XSU5fQ0FJUk99KQogICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JU X1ZBTFVFKEVOQUJMRV9DU1NfUEFJTlRJTkdfQVBJIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVO VEFMX0ZFQVRVUkVTfSkKICAgICBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFC TEVfQ1NTX1RZUEVEX09NIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkK ICAgICBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfRklMVEVSU19MRVZF TF8yIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkKKyAgICBXRUJLSVRf T1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTEFZT1VUX0ZPUk1BVFRJTkdfQ09OVEVY VCBQUklWQVRFICR7RU5BQkxFX0VYUEVSSU1FTlRBTF9GRUFUVVJFU30pCiAgICAgV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1JFTU9URV9JTlNQRUNUT1IgUFJJVkFURSAk e0VOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQogICAgIFdFQktJVF9PUFRJT05fREVGQVVM VF9QT1JUX1ZBTFVFKEVOQUJMRV9SRVNPVVJDRV9MT0FEX1NUQVRJU1RJQ1MgUFJJVkFURSAke0VO QUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQogICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9Q T1JUX1ZBTFVFKEVOQUJMRV9SRVNPVVJDRV9VU0FHRSBQUklWQVRFICR7RU5BQkxFX0VYUEVSSU1F TlRBTF9GRUFUVVJFU30pCg== 389046 2020-01-28 11:58:24 -0800 2020-01-28 13:20:31 -0800 Patch bug-206165.diff text/plain 2925 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyOTdlZDRlZjcyMi4uZmNi ZmY1YTFhZWIgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNCBAQAorMjAyMC0wMS0yOCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t PgorCisgICAgICAgIFtMRkNdW0ludGVncmF0aW9uXSBCdWlsZCBhbmQgZW5hYmxlIG9uIFdpbmRv d3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjE2 NQorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgIEVuYWJsZSBM RkMgZm9yIFdpbmRvd3MuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1dpbi5jbWFr ZToKKwogMjAyMC0wMS0yNCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNv bT4KIAogICAgICAgICBSZW1vdmUgV2ViVlIgZnJvbSB0aGUgdHJlZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDc2 YzdlNGFiYzE0Li5jYmRjZThhYjIzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIw LTAxLTI4ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAg W0xGQ11bSW50ZWdyYXRpb25dIEJ1aWxkIGFuZCBlbmFibGUgb24gV2luZG93cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MTY1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgRml4IG1pbm9yIGNvbXBpbGF0aW9u IGlzc3VlcyBpbiBMRkMgd2hlbiB1c2luZyBNU1ZDLgorCisgICAgICAgICogbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvTGluZUxheW91dENvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5 b3V0OjpMaW5lTGF5b3V0Q29udGV4dDo6Y2xvc2UpOgorCiAyMDIwLTAxLTI0ICBTZXJnaW8gVmls bGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJlbW92ZSBXZWJWUiBm cm9tIHRoZSB0cmVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9y bWF0dGluZy9MaW5lTGF5b3V0Q29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5s aW5lZm9ybWF0dGluZy9MaW5lTGF5b3V0Q29udGV4dC5jcHAKaW5kZXggYmNkMTM3YzYwYWUuLjRk ZWI5NzlhZGQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0 dGluZy9MaW5lTGF5b3V0Q29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lu bGluZWZvcm1hdHRpbmcvTGluZUxheW91dENvbnRleHQuY3BwCkBAIC0zMTYsNyArMzE2LDcgQEAg TGluZUxheW91dENvbnRleHQ6OkxpbmVDb250ZW50IExpbmVMYXlvdXRDb250ZXh0OjpjbG9zZShM aW5lQnVpbGRlciYgbGluZSwgY29uc3QKICAgICBlbHNlCiAgICAgICAgIG1fc3VjY2Vzc2l2ZUh5 cGhlbmF0ZWRMaW5lQ291bnQgPSAwOwogCi0gICAgYXV0byB0cmFpbGluZ0lubGluZUl0ZW1JbmRl eCA9IGxheW91dFJhbmdlLnN0YXJ0ICsgY29tbWl0dGVkSW5saW5lSXRlbUNvdW50IC0gMTsKKyAg ICB1bnNpZ25lZCB0cmFpbGluZ0lubGluZUl0ZW1JbmRleCA9IGxheW91dFJhbmdlLnN0YXJ0ICsg Y29tbWl0dGVkSW5saW5lSXRlbUNvdW50IC0gMTsKICAgICBBU1NFUlQodHJhaWxpbmdJbmxpbmVJ dGVtSW5kZXggPCBsYXlvdXRSYW5nZS5lbmQpOwogICAgIGF1dG8gaXNMYXN0TGluZVdpdGhJbmxp bmVDb250ZW50ID0gWyZdIHsKICAgICAgICAgaWYgKHRyYWlsaW5nSW5saW5lSXRlbUluZGV4ID09 IGxheW91dFJhbmdlLmVuZCAtIDEpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dp bi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCmluZGV4IDkzNWE3ZmQxMzY3 Li5iY2E5NjcwMzkyYiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21ha2UK KysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21ha2UKQEAgLTg0LDYgKzg0LDcgQEAgaWYg KCR7V1RGX1BMQVRGT1JNX1dJTl9DQUlST30pCiAgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BP UlRfVkFMVUUoRU5BQkxFX0NTU19QQUlOVElOR19BUEkgUFJJVkFURSAke0VOQUJMRV9FWFBFUklN RU5UQUxfRkVBVFVSRVN9KQogICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9DU1NfVFlQRURfT00gUFJJVkFURSAke0VOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9 KQogICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9GSUxURVJTX0xF VkVMXzIgUFJJVkFURSAke0VOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQorICAgIFdFQktJ VF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9MQVlPVVRfRk9STUFUVElOR19DT05U RVhUIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkKICAgICBXRUJLSVRf T1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfUkVNT1RFX0lOU1BFQ1RPUiBQUklWQVRF ICR7RU5BQkxFX0VYUEVSSU1FTlRBTF9GRUFUVVJFU30pCiAgICAgV0VCS0lUX09QVElPTl9ERUZB VUxUX1BPUlRfVkFMVUUoRU5BQkxFX1JFU09VUkNFX0xPQURfU1RBVElTVElDUyBQUklWQVRFICR7 RU5BQkxFX0VYUEVSSU1FTlRBTF9GRUFUVVJFU30pCiAgICAgV0VCS0lUX09QVElPTl9ERUZBVUxU X1BPUlRfVkFMVUUoRU5BQkxFX1JFU09VUkNFX1VTQUdFIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJ TUVOVEFMX0ZFQVRVUkVTfSkK