206161 2020-01-12 21:04:34 -0800 getComputedStyle(img).height returns string of a rounded int not a float 2022-07-18 15:56:09 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 201641 242079 1 cathiechen sgill26 bfulgham emilio esprehn+autocc ews-watchlist fred.wang glenn kondapallykalyan pdr sabouhallawa simon.fraser webkit-bug-importer yurys zalan oldest_to_newest 1605746 0 cathiechen 2020-01-12 21:04:34 -0800 According to the spec getComputedStyle(img).height should return the "Used Value" if img isn't display:none. The "Used Value" of height is (used width) / (intrinsic ratio). So it can be a float, while WebKit always returns rouned int. (https://www.w3.org/TR/CSS21/visudet.html#propdef-height) The related test: LayoutTests/imported/w3c/web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio.html 1606318 1 fred.wang 2020-01-14 02:25:45 -0800 These are the relevant spec definitions: getComputedStyle(): https://drafts.csswg.org/cssom/#extensions-to-the-window-interface CSS declaration block: https://drafts.csswg.org/cssom/#css-declaration-block CSS declaration: https://drafts.csswg.org/cssom/#css-declaration Serialize a CSS declaration: https://drafts.csswg.org/cssom/#serialize-a-css-declaration Serialize a CSS value: https://drafts.csswg.org/cssom/#serialize-a-css-value Serialize a CSS component value: https://drafts.csswg.org/cssom/#serialize-a-css-component-value <length> The <number> component serialized as per <number> followed by the unit in its canonical form as defined in its respective specification. ISSUE 12: Probably should distinguish between specified and computed / resolved values. <number> A base-ten number using digits 0-9 (U+0030 to U+0039) in the shortest form possible, using "." to separate decimals (if any), rounding the value if necessary to not produce more than 6 decimals, preceded by "-" (U+002D) if it is negative. Note: scientific notation is not used. <percentage> The <number> component serialized as per <number> followed by the literal string "%" (U+0025). 1606319 2 387638 fred.wang 2020-01-14 02:26:58 -0800 Created attachment 387638 testcase Serialization seems to happen as expected in Gecko/Blink/WebKit with the attached testcase. 1606320 3 387639 fred.wang 2020-01-14 02:28:37 -0800 Created attachment 387639 testcase 1606878 4 387775 cathiechen 2020-01-15 04:07:58 -0800 Created attachment 387775 Add_img_test_cases Hi Fred, This issue seems only related to RenderReplaced, i.e, use intrinsic aspect-ratio to compute width / height. In RenderReplaced::computeReplacedLogicalWidth and RenderReplaced::computeReplacedLogicalHeight, roundToInt is called. PS: Append <img> test to your case. 1606893 5 387784 cathiechen 2020-01-15 05:55:25 -0800 Created attachment 387784 Add_img_test_cases 1607969 6 388035 cathiechen 2020-01-17 07:03:15 -0800 Created attachment 388035 Patch 1871586 7 webkit-bug-importer 2022-05-24 15:00:17 -0700 <rdar://problem/93860607> 1873132 8 sgill26 2022-05-31 14:16:52 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1191 1877130 9 ews-feeder 2022-06-21 16:29:20 -0700 Committed r295701 (251706@main): <https://commits.webkit.org/251706@main> Reviewed commits have been landed. Closing PR #1191 and removing active labels. 1879047 10 sgill26 2022-06-29 10:34:49 -0700 Re-opening for pull request https://github.com/WebKit/WebKit/pull/1902 1879055 11 ews-feeder 2022-06-29 10:47:31 -0700 Committed 251955@main (5d047d546dd9): <https://commits.webkit.org/251955@main> Reviewed commits have been landed. Closing PR #1902 and removing active labels. 1879504 12 sgill26 2022-06-30 13:32:20 -0700 Patch has been reverted due to regression reported in 242079. Reopening. 1881114 13 sgill26 2022-07-06 14:25:43 -0700 Pull request: https://github.com/WebKit/WebKit/pull/2138 1884932 14 ews-feeder 2022-07-18 15:56:06 -0700 Committed 252583@main (e2c4f937d459): <https://commits.webkit.org/252583@main> Reviewed commits have been landed. Closing PR #2138 and removing active labels. 387638 2020-01-14 02:26:58 -0800 2020-01-14 02:28:37 -0800 testcase getComputedStyle.html text/html 719 fred.wang PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPHRpdGxlPndpbmRvdy5nZXRDb21w dXRlZFN0eWxlKCk8L3RpdGxlPgogICAgPG1ldGEgY2hhcnNldD0idXRmLTgiLz4KICA8L2hlYWQ+ CiAgPGJvZHk+CgogICAgPGRpdiBpZD0iZGl2IiBzdHlsZT0iaGVpZ2h0OiAwLjMzMzMzMzMzMzMz MzMzMzMzMzMzMzMzMzNweDsgd2lkdGg6IDAuMzMzMzMzMzMzMzMzMzMzMzMzMzMzMzMzM3B4Ij48 L2Rpdj4KICAgIDxwPjxjb2RlPndpbmRvdy5nZXRDb21wdXRlZFN0eWxlKC4uLikud2lkdGg8L2Nv ZGU+OgogICAgPGlucHV0IGlkPSJ3aWR0aCIgdHlwZT0idGV4dCIgc2l6ZT0iNDAiLz48L3A+CiAg ICA8cD48Y29kZT53aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZSguLi4pLmhlaWdodDwvY29kZT46CiAg ICA8aW5wdXQgaWQ9ImhlaWdodCIgdHlwZT0idGV4dCIgc2l6ZT0iNDAiLz48L3A+CiAgICA8c2Ny aXB0PgogICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgid2lkdGgiKS52YWx1ZSA9IHdpbmRv dy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJkaXYiKSkud2lkdGg7 CiAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJoZWlnaHQiKS52YWx1ZSA9IHdpbmRvdy5n ZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJkaXYiKSkud2lkdGg7CiAg ICA8L3NjcmlwdD4KICAgIAogIDwvYm9keT4KPC9odG1sPgo= 387639 2020-01-14 02:28:37 -0800 2020-01-15 04:07:58 -0800 testcase getComputedStyle.html text/html 722 fred.wang PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPHRpdGxlPndpbmRvdy5nZXRDb21w dXRlZFN0eWxlKCk8L3RpdGxlPgogICAgPG1ldGEgY2hhcnNldD0idXRmLTgiLz4KICA8L2hlYWQ+ CiAgPGJvZHk+CgogICAgPGRpdiBpZD0iZGl2IiBzdHlsZT0id2lkdGg6IDAuMzMzMzMzMzMzMzMz MzMzMzMzMzMzMzMzM3B4OyBoZWlnaHQ6IDAuNjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NnB4OyAi PjwvZGl2PgogICAgPHA+PGNvZGU+d2luZG93LmdldENvbXB1dGVkU3R5bGUoLi4uKS53aWR0aDwv Y29kZT46CiAgICA8aW5wdXQgaWQ9IndpZHRoIiB0eXBlPSJ0ZXh0IiBzaXplPSI0MCIvPjwvcD4K ICAgIDxwPjxjb2RlPndpbmRvdy5nZXRDb21wdXRlZFN0eWxlKC4uLikuaGVpZ2h0PC9jb2RlPjoK ICAgIDxpbnB1dCBpZD0iaGVpZ2h0IiB0eXBlPSJ0ZXh0IiBzaXplPSI0MCIvPjwvcD4KICAgIDxz Y3JpcHQ+CiAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ3aWR0aCIpLnZhbHVlID0gd2lu ZG93LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRpdiIpKS53aWR0 aDsKICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImhlaWdodCIpLnZhbHVlID0gd2luZG93 LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRpdiIpKS5oZWlnaHQ7 CiAgICA8L3NjcmlwdD4KICAgIAogIDwvYm9keT4KPC9odG1sPgo= 387775 2020-01-15 04:07:58 -0800 2020-01-15 05:55:25 -0800 Add_img_test_cases testcase.html text/html 1927 cathiechen CjwhRE9DVFlQRSBodG1sPgo8aHRtbD4KICA8aGVhZD4KICAgIDx0aXRsZT53aW5kb3cuZ2V0Q29t cHV0ZWRTdHlsZSgpPC90aXRsZT4KICAgIDxtZXRhIGNoYXJzZXQ9InV0Zi04Ii8+CiAgPC9oZWFk PgogIDxib2R5PgoKICAgIDxkaXYgaWQ9ImRpdiIgc3R5bGU9IndpZHRoOiAwLjMzMzMzMzMzMzMz MzMzMzMzMzMzMzMzMzNweDsgaGVpZ2h0OiAwLjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjZweDsg Ij48L2Rpdj4KICAgIDxwPjxjb2RlPndpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRpdikud2lkdGg8 L2NvZGU+OgogICAgPGlucHV0IGlkPSJkaXZXaWR0aCIgdHlwZT0idGV4dCIgc2l6ZT0iNDAiLz48 L3A+CiAgICA8cD48Y29kZT53aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShkaXYpLmhlaWdodDwvY29k ZT46CiAgICA8aW5wdXQgaWQ9ImRpdkhlaWdodCIgdHlwZT0idGV4dCIgc2l6ZT0iNDAiLz48L3A+ CgogICAgPGRpdiBzdHlsZT0id2lkdGg6MzMuMzMzcHgiPjxpbWcgaWQ9ImltZzEiIHN0eWxlPSJ3 aWR0aDogMTAwJSIgc3JjPSJodHRwOi8vdzNjLXRlc3Qub3JnL2ltYWdlcy9ibHVlLnBuZyI+PC9k aXY+CiAgICA8cD48Y29kZT53aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShpbWcpLndpZHRoPC9jb2Rl PjoKICAgIDxpbnB1dCBpZD0iaW1nV2lkdGgxIiB0eXBlPSJ0ZXh0IiBzaXplPSI0MCIvPjwvcD4K ICAgIDxwPjxjb2RlPndpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGltZykuaGVpZ2h0PC9jb2RlPjoK ICAgIDxpbnB1dCBpZD0iaW1nSGVpZ2h0MSIgdHlwZT0idGV4dCIgc2l6ZT0iNDAiLz48L3A+Cgog ICAgPGRpdiBzdHlsZT0iaGVpZ2h0OiAzMy4zMzNweCI+PGltZyBpZD0iaW1nMiIgc3R5bGU9Imhl aWdodDogMTAwJSIgc3JjPSJodHRwOi8vdzNjLXRlc3Qub3JnL2ltYWdlcy9ibHVlLnBuZyI+PC9k aXY+CiAgICA8cD48Y29kZT53aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShpbWcpLndpZHRoPC9jb2Rl PjoKICAgIDxpbnB1dCBpZD0iaW1nV2lkdGgyIiB0eXBlPSJ0ZXh0IiBzaXplPSI0MCIvPjwvcD4K ICAgIDxwPjxjb2RlPndpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGltZykuaGVpZ2h0PC9jb2RlPjoK ICAgIDxpbnB1dCBpZD0iaW1nSGVpZ2h0MiIgdHlwZT0idGV4dCIgc2l6ZT0iNDAiLz48L3A+Cgog ICAgPHNjcmlwdD4KICAgICAgb25sb2FkID0gZnVuY3Rpb24oKSB7CiAgICAgICAgZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoImRpdldpZHRoIikudmFsdWUgPSB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHls ZShkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZGl2IikpLndpZHRoOwogICAgICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJkaXZIZWlnaHQiKS52YWx1ZSA9IHdpbmRvdy5nZXRDb21wdXRlZFN0 eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJkaXYiKSkuaGVpZ2h0OwogICAgICAgIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJpbWdXaWR0aDEiKS52YWx1ZSA9IHdpbmRvdy5nZXRDb21wdXRl ZFN0eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJpbWcxIikpLndpZHRoOwogICAgICAgIGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJpbWdIZWlnaHQxIikudmFsdWUgPSB3aW5kb3cuZ2V0Q29t cHV0ZWRTdHlsZShkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW1nMSIpKS5oZWlnaHQ7CiAgICAg ICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImltZ1dpZHRoMiIpLnZhbHVlID0gd2luZG93Lmdl dENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImltZzIiKSkud2lkdGg7CiAg ICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImltZ0hlaWdodDIiKS52YWx1ZSA9IHdpbmRv dy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJpbWcyIikpLmhlaWdo dDsKICAgIH0KICAgIDwvc2NyaXB0PgogICAgCiAgPC9ib2R5Pgo8L2h0bWw+Cg== 387784 2020-01-15 05:55:25 -0800 2020-01-15 05:55:25 -0800 Add_img_test_cases testcase.html text/html 1968 cathiechen CjwhRE9DVFlQRSBodG1sPgo8aHRtbD4KICA8aGVhZD4KICAgIDx0aXRsZT53aW5kb3cuZ2V0Q29t cHV0ZWRTdHlsZSgpPC90aXRsZT4KICAgIDxtZXRhIGNoYXJzZXQ9InV0Zi04Ii8+CiAgPC9oZWFk PgogIDxib2R5PgoKICAgIDxkaXYgaWQ9ImRpdiIgc3R5bGU9IndpZHRoOiAwLjMzMzMzMzMzMzMz MzMzMzMzMzMzMzMzMzNweDsgaGVpZ2h0OiAwLjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjZweDsg Ij48L2Rpdj4KICAgIDxwPjxjb2RlPndpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRpdikud2lkdGg8 L2NvZGU+OgogICAgPGlucHV0IGlkPSJkaXZXaWR0aCIgdHlwZT0idGV4dCIgc2l6ZT0iNDAiLz48 L3A+CiAgICA8cD48Y29kZT53aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShkaXYpLmhlaWdodDwvY29k ZT46CiAgICA8aW5wdXQgaWQ9ImRpdkhlaWdodCIgdHlwZT0idGV4dCIgc2l6ZT0iNDAiLz48L3A+ CgogICAgPGRpdiBzdHlsZT0id2lkdGg6IDMzLjMzMzMzMzMzMzMzMzMzMzMzMzMzMzMzcHgiPjxp bWcgaWQ9ImltZzEiIHN0eWxlPSJ3aWR0aDogMTAwJSIgc3JjPSJodHRwOi8vdzNjLXRlc3Qub3Jn L2ltYWdlcy9ibHVlLnBuZyI+PC9kaXY+CiAgICA8cD48Y29kZT53aW5kb3cuZ2V0Q29tcHV0ZWRT dHlsZShpbWcpLndpZHRoPC9jb2RlPjoKICAgIDxpbnB1dCBpZD0iaW1nV2lkdGgxIiB0eXBlPSJ0 ZXh0IiBzaXplPSI0MCIvPjwvcD4KICAgIDxwPjxjb2RlPndpbmRvdy5nZXRDb21wdXRlZFN0eWxl KGltZykuaGVpZ2h0PC9jb2RlPjoKICAgIDxpbnB1dCBpZD0iaW1nSGVpZ2h0MSIgdHlwZT0idGV4 dCIgc2l6ZT0iNDAiLz48L3A+CgogICAgPGRpdiBzdHlsZT0iaGVpZ2h0OiAzMy4zMzMzMzMzMzMz MzMzMzMzMzMzMzMzM3B4Ij48aW1nIGlkPSJpbWcyIiBzdHlsZT0iaGVpZ2h0OiAxMDAlIiBzcmM9 Imh0dHA6Ly93M2MtdGVzdC5vcmcvaW1hZ2VzL2JsdWUucG5nIj48L2Rpdj4KICAgIDxwPjxjb2Rl PndpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGltZykud2lkdGg8L2NvZGU+OgogICAgPGlucHV0IGlk PSJpbWdXaWR0aDIiIHR5cGU9InRleHQiIHNpemU9IjQwIi8+PC9wPgogICAgPHA+PGNvZGU+d2lu ZG93LmdldENvbXB1dGVkU3R5bGUoaW1nKS5oZWlnaHQ8L2NvZGU+OgogICAgPGlucHV0IGlkPSJp bWdIZWlnaHQyIiB0eXBlPSJ0ZXh0IiBzaXplPSI0MCIvPjwvcD4KCiAgICA8c2NyaXB0PgogICAg ICBvbmxvYWQgPSBmdW5jdGlvbigpIHsKICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi ZGl2V2lkdGgiKS52YWx1ZSA9IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJkaXYiKSkud2lkdGg7CiAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImRpdkhlaWdodCIpLnZhbHVlID0gd2luZG93LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoImRpdiIpKS5oZWlnaHQ7CiAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoImltZ1dpZHRoMSIpLnZhbHVlID0gd2luZG93LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoImltZzEiKSkud2lkdGg7CiAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoImltZ0hlaWdodDEiKS52YWx1ZSA9IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJpbWcxIikpLmhlaWdodDsKICAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgiaW1nV2lkdGgyIikudmFsdWUgPSB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW1nMiIpKS53aWR0aDsKICAgICAgICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgiaW1nSGVpZ2h0MiIpLnZhbHVlID0gd2luZG93LmdldENvbXB1dGVkU3R5 bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImltZzIiKSkuaGVpZ2h0OwogICAgfQogICAgPC9z Y3JpcHQ+CiAgICAKICA8L2JvZHk+CjwvaHRtbD4K 388035 2020-01-17 07:03:15 -0800 2020-01-17 07:03:15 -0800 Patch bug-206161-20200117230309.patch text/plain 6280 cathiechen U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDdhMzFjZDFhMDMyNzM2 N2JiYTlmM2ZiYmZkM2Q2YmU4YWYxNTJiMy4uNzJhYTc5ZmU1Y2Y0MjU5YTU1ZjRjZjU3ZTViNDky MDUzZGEzNGRlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAxLTE3ICBDYXRo aWUgQ2hlbiAgPGNhdGhpZWNoZW5AaWdhbGlhLmNvbT4KKworICAgICAgICBNYWtlIHRoZSBsb2dp Y2FsIGhlaWdodC93aWR0aCBvZiBpbWcgZmxvYXQgaW5zdGVhZCBvZiByb3VuZGVkIGludAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MTYxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBjb21wdXRl UmVwbGFjZWRMb2dpY2FsV2lkdGgvSGVpZ2h0IHRoZSB2YWx1ZSBpcyByb3VuZGVkIGlmIHRoZSBl bGVtZW50IGNvbXB1dGVzIGl0cyB3aWR0aAorICAgICAgICBieSBpdHMgaW50cmluc2ljIGFzcGVj dC1yYXRpbyAqIGhlaWdodCwgdmljZSB2ZXJzYS4gVGhpcyBzaG91bGQgbm90IGJlIHJvdW5kZWQs IG90aGVyd2lzZSwKKyAgICAgICAgaXQgcmV0dXJucyBhIHJvdW5kZWQgdmFsdWUgYXMgdGhlIHdp ZHRoL2hlaWdodCB2YWx1ZSBvZiBDU1MgZGVjbGFyYXRpb24sIHdoaWNoIGlzIG5vIGV4cGVjdGVk LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclJlcGxhY2VkLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlclJlcGxhY2VkOjpjb21wdXRlUmVwbGFjZWRMb2dpY2FsV2lkdGggY29uc3Qp OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyUmVwbGFjZWQ6OmNvbXB1dGVSZXBsYWNlZExvZ2lj YWxIZWlnaHQgY29uc3QpOgorCiAyMDIwLTAxLTE2ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBh cHBsZS5jb20+CiAKICAgICAgICAgQ29tcGFjdCBzaXplb2YoSFRNTEFuY2hvckVsZW1lbnQpIGFu ZCBzaXplb2YoSFRNTExpbmtFbGVtZW50KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2Fj eS9tYWMvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCmluZGV4 IGM2YWQ0NWVmNzRjNjQwNWEwNjJlNDVlMWRkOTg1OGM0NGRiYjFlOGEuLmUzMWYwMTE3MzQ1NmNi YTZmNTJmNWJmOWRmYmE2ZWU1OGE2Mjk0ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdh Y3kvbWFjL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxMiBAQAorMjAyMC0wMS0xNyAgQ2F0aGllIENoZW4gIDxjYXRoaWVjaGVuQGln YWxpYS5jb20+CisKKyAgICAgICAgTWFrZSB0aGUgbG9naWNhbCBoZWlnaHQvd2lkdGggb2YgaW1n IGZsb2F0IGluc3RlYWQgb2Ygcm91bmRlZCBpbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjE2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmlldy9XZWJQcmVmZXJlbmNlS2V5c1ByaXZhdGUu aDogVGhlIHZhbHVlIHNob3VsZCBiZSAiV2ViS2l0QXNwZWN0UmF0aW9PZkltZ0Zyb21XaWR0aEFu ZEhlaWdodEVuYWJsZWQiLgorCiAyMDIwLTAxLTE2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBh cHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIC1XY29uZGl0aW9uYWwtdW5pbml0aWFsaXplZCBp biBXZWJJbnNwZWN0b3JVSSwgV2ViS2l0TGVnYWN5LCBXZWJLaXQgcHJvamVjdHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZXBsYWNlZC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQuY3BwCmluZGV4IGY0NzE5MDBhMjc1MDZl OTNmZmE0ZDcwMWY2Y2U1N2ExN2NiMzFkZTYuLjVhZWNlNjRmNzkxNTY1ZWVjZDcwM2NmNjYxMDFh MzdmYjVjNGUyMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJS ZXBsYWNlZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlcGxhY2Vk LmNwcApAQCAtNTEyLDcgKzUxMiw3IEBAIExheW91dFVuaXQgUmVuZGVyUmVwbGFjZWQ6OmNvbXB1 dGVSZXBsYWNlZExvZ2ljYWxXaWR0aChTaG91bGRDb21wdXRlUHJlZmVycmVkIHNoCiAgICAgICAg ICAgICBpZiAoaW50cmluc2ljUmF0aW8gJiYgKChjb21wdXRlZEhlaWdodElzQXV0byAmJiAhaGFz SW50cmluc2ljV2lkdGggJiYgaGFzSW50cmluc2ljSGVpZ2h0KSB8fCAhY29tcHV0ZWRIZWlnaHRJ c0F1dG8pKSB7CiAgICAgICAgICAgICAgICAgTGF5b3V0VW5pdCBlc3RpbWF0ZWRVc2VkV2lkdGgg PSBoYXNJbnRyaW5zaWNXaWR0aCA/IExheW91dFVuaXQoY29uc3RyYWluZWRTaXplLndpZHRoKCkp IDogY29tcHV0ZUNvbnN0cmFpbmVkTG9naWNhbFdpZHRoKHNob3VsZENvbXB1dGVQcmVmZXJyZWQp OwogICAgICAgICAgICAgICAgIExheW91dFVuaXQgbG9naWNhbEhlaWdodCA9IGNvbXB1dGVSZXBs YWNlZExvZ2ljYWxIZWlnaHQoT3B0aW9uYWw8TGF5b3V0VW5pdD4oZXN0aW1hdGVkVXNlZFdpZHRo KSk7Ci0gICAgICAgICAgICAgICAgcmV0dXJuIGNvbXB1dGVSZXBsYWNlZExvZ2ljYWxXaWR0aFJl c3BlY3RpbmdNaW5NYXhXaWR0aChyb3VuZFRvSW50KHJvdW5kKGxvZ2ljYWxIZWlnaHQgKiBpbnRy aW5zaWNSYXRpbykpLCBzaG91bGRDb21wdXRlUHJlZmVycmVkKTsKKyAgICAgICAgICAgICAgICBy ZXR1cm4gY29tcHV0ZVJlcGxhY2VkTG9naWNhbFdpZHRoUmVzcGVjdGluZ01pbk1heFdpZHRoKExh eW91dFVuaXQobG9naWNhbEhlaWdodCAqIGludHJpbnNpY1JhdGlvKSwgc2hvdWxkQ29tcHV0ZVBy ZWZlcnJlZCk7CiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIApAQCAtNTY1LDcgKzU2NSw3 IEBAIExheW91dFVuaXQgUmVuZGVyUmVwbGFjZWQ6OmNvbXB1dGVSZXBsYWNlZExvZ2ljYWxIZWln aHQoT3B0aW9uYWw8TGF5b3V0VW5pdD4gZXN0CiAgICAgLy8gKHVzZWQgd2lkdGgpIC8gKGludHJp bnNpYyByYXRpbykKICAgICBpZiAoaW50cmluc2ljUmF0aW8pIHsKICAgICAgICAgTGF5b3V0VW5p dCB1c2VkV2lkdGggPSBlc3RpbWF0ZWRVc2VkV2lkdGggPyBlc3RpbWF0ZWRVc2VkV2lkdGgudmFs dWUoKSA6IGF2YWlsYWJsZUxvZ2ljYWxXaWR0aCgpOwotICAgICAgICByZXR1cm4gY29tcHV0ZVJl cGxhY2VkTG9naWNhbEhlaWdodFJlc3BlY3RpbmdNaW5NYXhIZWlnaHQocm91bmRUb0ludChyb3Vu ZCh1c2VkV2lkdGggLyBpbnRyaW5zaWNSYXRpbykpKTsKKyAgICAgICAgcmV0dXJuIGNvbXB1dGVS ZXBsYWNlZExvZ2ljYWxIZWlnaHRSZXNwZWN0aW5nTWluTWF4SGVpZ2h0KExheW91dFVuaXQodXNl ZFdpZHRoIC8gaW50cmluc2ljUmF0aW8pKTsKICAgICB9CiAKICAgICAvLyBPdGhlcndpc2UsIGlm ICdoZWlnaHQnIGhhcyBhIGNvbXB1dGVkIHZhbHVlIG9mICdhdXRvJywgYW5kIHRoZSBlbGVtZW50 IGhhcyBhbiBpbnRyaW5zaWMgaGVpZ2h0LCB0aGVuIHRoYXQgaW50cmluc2ljIGhlaWdodCBpcyB0 aGUgdXNlZCB2YWx1ZSBvZiAnaGVpZ2h0Jy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdh Y3kvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZUtleXNQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0 TGVnYWN5L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VLZXlzUHJpdmF0ZS5oCmluZGV4IDg1Njdl MzllYTU3MGQ1NGJlZTdlMjY0N2U3ZWIzM2Y5NGJkOGM4MmUuLjYwOTc3MjhlNzZjYzM3MzY2N2E2 ZGE5YWQ3NjNkNGYzNTMxN2E0MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFj L1dlYlZpZXcvV2ViUHJlZmVyZW5jZUtleXNQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlS2V5c1ByaXZhdGUuaApAQCAtMjgyLDUgKzI4 Miw1IEBACiAjZGVmaW5lIFdlYktpdEFzeW5jQ2xpcGJvYXJkQVBJRW5hYmxlZFByZWZlcmVuY2VL ZXkgQCJXZWJLaXRBc3luY0NsaXBib2FyZEFQSUVuYWJsZWQiCiAjZGVmaW5lIFdlYktpdExpbmtQ cmVsb2FkUmVzcG9uc2l2ZUltYWdlc0VuYWJsZWRQcmVmZXJlbmNlS2V5IEAiV2ViS2l0TGlua1By ZWxvYWRSZXNwb25zaXZlSW1hZ2VzRW5hYmxlZCIKICNkZWZpbmUgV2ViS2l0SW5BcHBCcm93c2Vy UHJpdmFjeUVuYWJsZWRQcmVmZXJlbmNlS2V5IEAiV2ViS2l0SW5BcHBCcm93c2VyUHJpdmFjeUVu YWJsZWQiCi0jZGVmaW5lIFdlYktpdEFzcGVjdFJhdGlvT2ZJbWdGcm9tV2lkdGhBbmRIZWlnaHRF bmFibGVkUHJlZmVyZW5jZUtleSBAIkFzcGVjdFJhdGlvT2ZJbWdGcm9tV2lkdGhBbmRIZWlnaHRF bmFibGVkIgorI2RlZmluZSBXZWJLaXRBc3BlY3RSYXRpb09mSW1nRnJvbVdpZHRoQW5kSGVpZ2h0 RW5hYmxlZFByZWZlcmVuY2VLZXkgQCJXZWJLaXRBc3BlY3RSYXRpb09mSW1nRnJvbVdpZHRoQW5k SGVpZ2h0RW5hYmxlZCIKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggMzRkZmM0 MzdhMjJiNjZjYTUxZDNiMjhiMzIwODY1NmI5ZjdjZDE3MC4uZjdjMGZhNjQ2OWY4ZTc3YzYwZGEz OGM0OGUwYjBiOGE4NWRkOGZiMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMjAtMDEtMTcgIENhdGhpZSBDaGVuICA8Y2F0aGllY2hlbkBpZ2FsaWEu Y29tPgorCisgICAgICAgIE1ha2UgdGhlIGxvZ2ljYWwgaGVpZ2h0L3dpZHRoIG9mIGltZyBmbG9h dCBpbnN0ZWFkIG9mIHJvdW5kZWQgaW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDYxNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3JlbmRlcmluZy9yZXBs YWNlZC1lbGVtZW50cy9hdHRyaWJ1dGVzLWZvci1lbWJlZGRlZC1jb250ZW50LWFuZC1pbWFnZXMv aW1nLWFzcGVjdC1yYXRpby1leHBlY3RlZC50eHQ6CisKIDIwMjAtMDEtMTYgIFJvYiBCdWlzICA8 cmJ1aXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBGZXRjaDogVVJMIHBhcnNlciBub3QgYWx3YXlz IHVzaW5nIFVURi04CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL2h0bWwvcmVuZGVyaW5nL3JlcGxhY2VkLWVsZW1lbnRzL2F0dHJpYnV0ZXMt Zm9yLWVtYmVkZGVkLWNvbnRlbnQtYW5kLWltYWdlcy9pbWctYXNwZWN0LXJhdGlvLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9y ZW5kZXJpbmcvcmVwbGFjZWQtZWxlbWVudHMvYXR0cmlidXRlcy1mb3ItZW1iZWRkZWQtY29udGVu dC1hbmQtaW1hZ2VzL2ltZy1hc3BlY3QtcmF0aW8tZXhwZWN0ZWQudHh0CmluZGV4IDFkZDQ0OGRi MzMyZDlkYjI2ODUyNjg3YjQ0ZDcyNmNhNmRlOTIzMmIuLjBkZDdkYWE2M2Y5MjZiOGE3NmMzNjdi ZTZmNzFlZDVhYzNiZTYyOWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9yZW5kZXJpbmcvcmVwbGFjZWQtZWxlbWVudHMvYXR0cmli dXRlcy1mb3ItZW1iZWRkZWQtY29udGVudC1hbmQtaW1hZ2VzL2ltZy1hc3BlY3QtcmF0aW8tZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvaHRtbC9yZW5kZXJpbmcvcmVwbGFjZWQtZWxlbWVudHMvYXR0cmlidXRlcy1mb3ItZW1iZWRk ZWQtY29udGVudC1hbmQtaW1hZ2VzL2ltZy1hc3BlY3QtcmF0aW8tZXhwZWN0ZWQudHh0CkBAIC0x LDQgKzEsNCBAQAogICAgICAKIAotRkFJTCBJbWFnZSB3aWR0aCBhbmQgaGVpZ2h0IGF0dHJpYnV0 ZXMgYXJlIHVzZWQgdG8gaW5mZXIgYXNwZWN0LXJhdGlvIGFzc2VydF9hcHByb3hfZXF1YWxzOiBl eHBlY3RlZCAxLjI1NDcxNjk4MTEzMjA3NTUgKy8tIDAuMDAxIGJ1dCBnb3QgMS4yNQorUEFTUyBJ bWFnZSB3aWR0aCBhbmQgaGVpZ2h0IGF0dHJpYnV0ZXMgYXJlIHVzZWQgdG8gaW5mZXIgYXNwZWN0 LXJhdGlvIAogCg==