206141 2020-01-12 01:55:35 -0800 [WebCore] Reorganize JSType in WebCore to offer more bits to JSC 2020-01-12 16:03:35 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1605630 0 ysuzuki 2020-01-12 01:55:35 -0800 [WebCore] Reorganize JSType in WebCore to offer more bits to JSC 1605631 1 387464 ysuzuki 2020-01-12 01:56:12 -0800 Created attachment 387464 Patch 1605673 2 387464 keith_miller 2020-01-12 11:09:03 -0800 Comment on attachment 387464 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387464&action=review r=me. We have 128 types these days?!? O.o > Source/WebCore/bindings/js/JSDOMWrapper.h:32 > // JSC allows us to extend JSType. If the highest bit is set, we can add any Object types and they are Can you fix this comment to match the new rule. 1605701 3 387464 ysuzuki 2020-01-12 14:41:24 -0800 Comment on attachment 387464 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387464&action=review >> Source/WebCore/bindings/js/JSDOMWrapper.h:32 >> // JSC allows us to extend JSType. If the highest bit is set, we can add any Object types and they are > > Can you fix this comment to match the new rule. Fixed. 1605702 4 ysuzuki 2020-01-12 14:42:57 -0800 Committed r254416: <https://trac.webkit.org/changeset/254416> 1605703 5 webkit-bug-importer 2020-01-12 14:43:11 -0800 <rdar://problem/58515054> 1605717 6 387464 mark.lam 2020-01-12 16:03:35 -0800 Comment on attachment 387464 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387464&action=review > Source/JavaScriptCore/runtime/JSType.h:140 > +static_assert(LastJSCObjectType < 0b11100000, "Embedder can use 0b11100000 or upper."); I think you meant to say "above" instead of "upper". 387464 2020-01-12 01:56:12 -0800 2020-01-12 11:09:03 -0800 Patch bug-206141-20200112015612.patch text/plain 6783 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl NjNhMGJlZDFiODg5Mjg3N2M3NjVjMWU2YzRiNGZmMGNiMDNmMGUxLi5iNTViZTgwYWU1ODg0NWU1 ZTk3NTA5ZmMwMzM5NzlkNzllMjMxN2M3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAyMC0wMS0xMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtXZWJDb3JlXSBSZW9yZ2FuaXplIEpTVHlwZSBpbiBXZWJDb3JlIHRvIG9m ZmVyIG1vcmUgYml0cyB0byBKU0MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwNjE0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcnVudGltZS9KU1R5cGUuaDoKKwogMjAyMC0wMS0xMSAgWXVzdWtlIFN1 enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHN1cHByZXNz IHdhcm5pbmdzIGluIEdDQywgcGFydCAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODI5NDRlZjMwZDA4MWYyMTll NmNjYzMxMWRjNTk4YmNhNTNhMTlmMS4uYTYwOTc0YTM4NDQ2YzhlYzNkNTc1MjZlZDc4ODRjNmU3 ZTA4MjcyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAxLTEyICBZdXN1a2Ug U3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkNvcmVdIFJlb3JnYW5p emUgSlNUeXBlIGluIFdlYkNvcmUgdG8gb2ZmZXIgbW9yZSBiaXRzIHRvIEpTQworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MTQxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZW9yZ2Fu aXplIEpTVHlwZSBhIGJpdCB0byBvZmZlciBtb3JlIGJpdHMgdG8gSlNDLiBUaGVuIEpTQyBjYW4g dXNlIEpTVHlwZSBmb3IgdHlwZXMgZWFzaWx5LgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNE T01XcmFwcGVyLmg6CisgICAgICAgICogYmluZGluZ3MvanMvSlNFbGVtZW50Q3VzdG9tLmg6Cisg ICAgICAgIChKU0M6OkpTQ2FzdGluZ0hlbHBlcnM6OkluaGVyaXRzVHJhaXRzPFdlYkNvcmU6OkpT RWxlbWVudD46OmluaGVyaXRzKToKKyAgICAgICAgKiBkb21qaXQvRE9NSklUSGVscGVycy5oOgor ICAgICAgICAoV2ViQ29yZTo6RE9NSklUOjpicmFuY2hJZkVsZW1lbnQpOgorICAgICAgICAoV2Vi Q29yZTo6RE9NSklUOjpicmFuY2hJZk5vdEVsZW1lbnQpOgorCiAyMDIwLTAxLTExICBaYWxhbiBC dWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ10gSW50cm9kdWNlIHRoZSBj b25jZXB0IG9mIGluZGVwZW5kZW50IGZvcm1hdHRpbmcgY29udGV4dApkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNUeXBlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU1R5cGUuaAppbmRleCBkMjc5ZjAwZmZjY2JhMjQxYjliZDIyYjVmM2EzMDZk NzA5NjdkOTc5Li4yZDFkMzA4Nzg5MGQzMGY2YmE0ZjgyYjdmYzRlNTczMjM1NzMxNWQxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1R5cGUuaAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1R5cGUuaApAQCAtMTM3LDcgKzEzNyw3IEBAIHN0 YXRpYyBjb25zdGV4cHIgdWludDMyX3QgTnVtYmVyT2ZUeXBlZEFycmF5VHlwZXMgPSBMYXN0VHlw ZWRBcnJheVR5cGUgLSBGaXJzdFR5CiBzdGF0aWMgY29uc3RleHByIHVpbnQzMl90IE51bWJlck9m VHlwZWRBcnJheVR5cGVzRXhjbHVkaW5nRGF0YVZpZXcgPSBOdW1iZXJPZlR5cGVkQXJyYXlUeXBl cyAtIDE7CiAKIHN0YXRpY19hc3NlcnQoc2l6ZW9mKEpTVHlwZSkgPT0gc2l6ZW9mKHVpbnQ4X3Qp LCAic2l6ZW9mKEpTVHlwZSkgaXMgb25lIGJ5dGUuIik7Ci1zdGF0aWNfYXNzZXJ0KExhc3RKU0NP YmplY3RUeXBlIDwgMTI4LCAiVGhlIGhpZ2hlc3QgYml0IGlzIHJlc2VydmVkIGZvciBlbWJlZGRl cidzIGV4dGVuc2lvbi4iKTsKK3N0YXRpY19hc3NlcnQoTGFzdEpTQ09iamVjdFR5cGUgPCAwYjEx MTAwMDAwLCAiRW1iZWRkZXIgY2FuIHVzZSAwYjExMTAwMDAwIG9yIHVwcGVyLiIpOwogCiBpbmxp bmUgY29uc3RleHByIGJvb2wgaXNUeXBlZEFycmF5VHlwZShKU1R5cGUgdHlwZSkKIHsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV3JhcHBlci5oIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XcmFwcGVyLmgKaW5kZXggMGU4OTkxM2IzNWU0ZTVl YTllMGRjYTIxNzJjOTk5M2JiZTQyMDY5Zi4uZDgxNGM3MmE2N2VlNTRjYWM0ZDBlZDAwYTIyMjJk N2JhOGIxMWZhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01X cmFwcGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XcmFwcGVyLmgK QEAgLTMxLDE2ICszMSwxNiBAQCBjbGFzcyBTY3JpcHRFeGVjdXRpb25Db250ZXh0OwogCiAvLyBK U0MgYWxsb3dzIHVzIHRvIGV4dGVuZCBKU1R5cGUuIElmIHRoZSBoaWdoZXN0IGJpdCBpcyBzZXQs IHdlIGNhbiBhZGQgYW55IE9iamVjdCB0eXBlcyBhbmQgdGhleSBhcmUKIC8vIHJlY29nbml6ZWQg YXMgT3RoZXJPYmogaW4gSlNDLiBBbmQgd2UgZW5jb2RlIE5vZGUgdHlwZSBpbnRvIEpTVHlwZSBp ZiB0aGUgZ2l2ZW4gSlNUeXBlIGlzIHN1YmNsYXNzIG9mIE5vZGUuCi0vLyBvZmZzZXQgfCA3IHwg NiB8IDUgICA0IHwgMyAgIDIgICAxICAgMCAgfAotLy8gdmFsdWUgIHwgMSB8IDAgfCAgTm9uLW5v ZGUgRE9NIHR5cGVzICAgIHwKKy8vIG9mZnNldCB8IDcgfCA2IHwgNSB8IDQgICAzICAgMiAgIDEg ICAwICB8CisvLyB2YWx1ZSAgfCAxIHwgMSB8IDEgfCBOb24tbm9kZSBET00gdHlwZXMgfAogLy8g SWYgdGhlIGdpdmVuIEpTVHlwZSBpcyBhIHN1YmNsYXNzIG9mIE5vZGUsIHRoZSBmb3JtYXQgaXMg dGhlIGZvbGxvd2luZy4KLS8vIG9mZnNldCB8IDcgfCA2IHwgNSAgIDQgfCAzICAgMiAgIDEgICAw ICB8Ci0vLyB2YWx1ZSAgfCAxIHwgMSB8ICBLaW5kIHwgICAgICAgTm9kZVR5cGUgfAotc3RhdGlj IGNvbnN0IHVpbnQ4X3QgSlNOb2RlVHlwZU1hc2sgICAgICAgICAgICAgICAgICA9IDBiMDAwMDEx MTE7CisvLyBvZmZzZXQgfCA3IHwgNiB8IDUgfCA0IHwgMyAgIDIgICAxICAgMCAgfAorLy8gdmFs dWUgIHwgMSB8IDEgfCAxIHwgMSB8ICAgIE5vZGVUeXBlICAgIHwKIAotc3RhdGljIGNvbnN0IHVp bnQ4X3QgSlNET01XcmFwcGVyVHlwZSAgICAgICAgICAgICAgICA9IDBiMTAwMDAwMDA7Ci1zdGF0 aWMgY29uc3QgdWludDhfdCBKU0V2ZW50VHlwZSAgICAgICAgICAgICAgICAgICAgID0gMGIxMDAw MDAwMTsKLXN0YXRpYyBjb25zdCB1aW50OF90IEpTTm9kZVR5cGUgICAgICAgICAgICAgICAgICAg ICAgPSAwYjExMDAwMDAwOworc3RhdGljIGNvbnN0IHVpbnQ4X3QgSlNET01XcmFwcGVyVHlwZSAg ICAgICAgICAgICAgICA9IDBiMTExMDExMTA7CitzdGF0aWMgY29uc3QgdWludDhfdCBKU0V2ZW50 VHlwZSAgICAgICAgICAgICAgICAgICAgID0gMGIxMTEwMTExMTsKK3N0YXRpYyBjb25zdCB1aW50 OF90IEpTTm9kZVR5cGUgICAgICAgICAgICAgICAgICAgICAgPSAwYjExMTEwMDAwOworc3RhdGlj IGNvbnN0IHVpbnQ4X3QgSlNOb2RlVHlwZU1hc2sgICAgICAgICAgICAgICAgICA9IDBiMDAwMDEx MTE7CiBzdGF0aWMgY29uc3QgdWludDhfdCBKU1RleHROb2RlVHlwZSAgICAgICAgICAgICAgICAg ID0gSlNOb2RlVHlwZSB8IE5vZGVDb25zdGFudHM6OlRFWFRfTk9ERTsKIHN0YXRpYyBjb25zdCB1 aW50OF90IEpTUHJvY2Vzc2luZ0luc3RydWN0aW9uTm9kZVR5cGUgPSBKU05vZGVUeXBlIHwgTm9k ZUNvbnN0YW50czo6UFJPQ0VTU0lOR19JTlNUUlVDVElPTl9OT0RFOwogc3RhdGljIGNvbnN0IHVp bnQ4X3QgSlNEb2N1bWVudFR5cGVOb2RlVHlwZSAgICAgICAgICA9IEpTTm9kZVR5cGUgfCBOb2Rl Q29uc3RhbnRzOjpET0NVTUVOVF9UWVBFX05PREU7CkBAIC00OSw3ICs0OSw3IEBAIHN0YXRpYyBj b25zdCB1aW50OF90IEpTRG9jdW1lbnRXcmFwcGVyVHlwZSAgICAgICAgICAgPSBKU05vZGVUeXBl IHwgTm9kZUNvbnN0YW50CiBzdGF0aWMgY29uc3QgdWludDhfdCBKU0NvbW1lbnROb2RlVHlwZSAg ICAgICAgICAgICAgID0gSlNOb2RlVHlwZSB8IE5vZGVDb25zdGFudHM6OkNPTU1FTlRfTk9ERTsK IHN0YXRpYyBjb25zdCB1aW50OF90IEpTQ0RBVEFTZWN0aW9uTm9kZVR5cGUgICAgICAgICAgPSBK U05vZGVUeXBlIHwgTm9kZUNvbnN0YW50czo6Q0RBVEFfU0VDVElPTl9OT0RFOwogc3RhdGljIGNv bnN0IHVpbnQ4X3QgSlNBdHRyTm9kZVR5cGUgICAgICAgICAgICAgICAgICA9IEpTTm9kZVR5cGUg fCBOb2RlQ29uc3RhbnRzOjpBVFRSSUJVVEVfTk9ERTsKLXN0YXRpYyBjb25zdCB1aW50OF90IEpT RWxlbWVudFR5cGUgICAgICAgICAgICAgICAgICAgPSAwYjExMDEwMDAwIHwgTm9kZUNvbnN0YW50 czo6RUxFTUVOVF9OT0RFOworc3RhdGljIGNvbnN0IHVpbnQ4X3QgSlNFbGVtZW50VHlwZSAgICAg ICAgICAgICAgICAgICA9IDBiMTExMTAwMDAgfCBOb2RlQ29uc3RhbnRzOjpFTEVNRU5UX05PREU7 CiAKIHN0YXRpY19hc3NlcnQoSlNET01XcmFwcGVyVHlwZSA+IEpTQzo6TGFzdEpTQ09iamVjdFR5 cGUsICJKU0M6OkpTVHlwZSBvZmZlcnMgdGhlIGhpZ2hlc3QgYml0LiIpOwogc3RhdGljX2Fzc2Vy dChOb2RlQ29uc3RhbnRzOjpMYXN0Tm9kZVR5cGUgPD0gSlNOb2RlVHlwZU1hc2ssICJOb2RlVHlw ZSBzaG91bGQgYmUgcmVwcmVzZW50ZWQgaW4gNGJpdC4iKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTRWxlbWVudEN1c3RvbS5oIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSlNFbGVtZW50Q3VzdG9tLmgKaW5kZXggNzlmYzk0MzBiYzQ0YTk5YzEzYTE5ZTVl ZTFiY2MzYjRiNjk1ZjNmZi4uNWM2MTQ0NzdmNjMzYmUyZDdjMTMwNThjNjc5NzY2NmU4Mzc0NWY3 NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNFbGVtZW50Q3VzdG9t LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNFbGVtZW50Q3VzdG9tLmgKQEAg LTM3LDcgKzM3LDcgQEAgc3RydWN0IEluaGVyaXRzVHJhaXRzPFdlYkNvcmU6OkpTRWxlbWVudD4g ewogICAgIHRlbXBsYXRlPHR5cGVuYW1lIEZyb20+CiAgICAgc3RhdGljIGlubGluZSBib29sIGlu aGVyaXRzKFZNJiwgRnJvbSogZnJvbSkKICAgICB7Ci0gICAgICAgIHJldHVybiBmcm9tLT50eXBl KCkgPj0gV2ViQ29yZTo6SlNFbGVtZW50VHlwZTsKKyAgICAgICAgcmV0dXJuIGZyb20tPnR5cGUo KSA9PSBXZWJDb3JlOjpKU0VsZW1lbnRUeXBlOwogICAgIH0KIH07CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbWppdC9ET01KSVRIZWxwZXJzLmggYi9Tb3VyY2UvV2ViQ29yZS9kb21q aXQvRE9NSklUSGVscGVycy5oCmluZGV4IDZkNTY4ODY1ODFkYjRmZTc1NTY1NGM4ODYzMTI0ZTUy MTJiYmRjODAuLmFjODgzNTBhNjViYjEwMzI2MzA0MGU2MGM3MTMyZGY0OGY5ZjViOTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbWppdC9ET01KSVRIZWxwZXJzLmgKKysrIGIvU291cmNl L1dlYkNvcmUvZG9taml0L0RPTUpJVEhlbHBlcnMuaApAQCAtMTQxLDcgKzE0MSw3IEBAIGlubGlu ZSBDQ2FsbEhlbHBlcnM6Okp1bXAgYnJhbmNoSWZOb3ROb2RlKENDYWxsSGVscGVycyYgaml0LCBH UFJSZWcgdGFyZ2V0KQogaW5saW5lIENDYWxsSGVscGVyczo6SnVtcCBicmFuY2hJZkVsZW1lbnQo Q0NhbGxIZWxwZXJzJiBqaXQsIEdQUlJlZyB0YXJnZXQpCiB7CiAgICAgcmV0dXJuIGppdC5icmFu Y2g4KAotICAgICAgICBDQ2FsbEhlbHBlcnM6OkFib3ZlT3JFcXVhbCwKKyAgICAgICAgQ0NhbGxI ZWxwZXJzOjpFcXVhbCwKICAgICAgICAgQ0NhbGxIZWxwZXJzOjpBZGRyZXNzKHRhcmdldCwgSlND OjpKU0NlbGw6OnR5cGVJbmZvVHlwZU9mZnNldCgpKSwKICAgICAgICAgQ0NhbGxIZWxwZXJzOjpU cnVzdGVkSW1tMzIoSlNDOjpKU1R5cGUoSlNFbGVtZW50VHlwZSkpKTsKIH0KQEAgLTE0OSw3ICsx NDksNyBAQCBpbmxpbmUgQ0NhbGxIZWxwZXJzOjpKdW1wIGJyYW5jaElmRWxlbWVudChDQ2FsbEhl bHBlcnMmIGppdCwgR1BSUmVnIHRhcmdldCkKIGlubGluZSBDQ2FsbEhlbHBlcnM6Okp1bXAgYnJh bmNoSWZOb3RFbGVtZW50KENDYWxsSGVscGVycyYgaml0LCBHUFJSZWcgdGFyZ2V0KQogewogICAg IHJldHVybiBqaXQuYnJhbmNoOCgKLSAgICAgICAgQ0NhbGxIZWxwZXJzOjpCZWxvdywKKyAgICAg ICAgQ0NhbGxIZWxwZXJzOjpOb3RFcXVhbCwKICAgICAgICAgQ0NhbGxIZWxwZXJzOjpBZGRyZXNz KHRhcmdldCwgSlNDOjpKU0NlbGw6OnR5cGVJbmZvVHlwZU9mZnNldCgpKSwKICAgICAgICAgQ0Nh bGxIZWxwZXJzOjpUcnVzdGVkSW1tMzIoSlNDOjpKU1R5cGUoSlNFbGVtZW50VHlwZSkpKTsKIH0K