206131 2020-01-11 10:16:36 -0800 Object.preventExtensions should throw if not successful 2020-01-15 11:58:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Minor --- 1 ashvayka ashvayka commit-queue ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1605540 0 ashvayka 2020-01-11 10:16:36 -0800 Test case: Object.preventExtensions(new Proxy({}, { preventExtensions: () => false })) Expected: Throws TypeError Actual: Returns Proxy ECMA262: https://tc39.es/ecma262/#sec-object.preventextensions (step 3) Test262: https://test262.report/browse/built-ins/Object/preventExtensions/throws-when-false.js 1605556 1 387443 ashvayka 2020-01-11 12:30:34 -0800 Created attachment 387443 Patch 1606990 2 387443 ross.kirsling 2020-01-15 10:23:27 -0800 Comment on attachment 387443 Patch r=me 1607057 3 387443 commit-queue 2020-01-15 11:57:44 -0800 Comment on attachment 387443 Patch Clearing flags on attachment: 387443 Committed r254626: <https://trac.webkit.org/changeset/254626> 1607058 4 commit-queue 2020-01-15 11:57:45 -0800 All reviewed patches have been landed. Closing bug. 1607059 5 webkit-bug-importer 2020-01-15 11:58:17 -0800 <rdar://problem/58613904> 387443 2020-01-11 12:30:34 -0800 2020-01-15 11:57:44 -0800 Patch bug-206131-20200111223033.patch text/plain 3965 ashvayka U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0Mzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 MDZkODI2N2NlYzVkMmNmMGNhNTE5Njk5MmJlY2ViYTRlNzZlNmY1Li4xYTQyOGI5M2JiN2ZkMjY5 NmU3NDIxNTEwMTk5MDcxZjYxZjhiZmRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wMS0xMSAgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBnbWFp bC5jb20+CisKKyAgICAgICAgT2JqZWN0LnByZXZlbnRFeHRlbnNpb25zIHNob3VsZCB0aHJvdyBp ZiBub3Qgc3VjY2Vzc2Z1bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA2MTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2l0aCB0aGlzIGNoYW5nZSwgT2JqZWN0LnByZXZlbnRFeHRlbnNpb25zIHRocm93 cyBUeXBlRXJyb3IgaWYgW1tQcmV2ZW50RXh0ZW5zaW9uc11dCisgICAgICAgIHJldHVybnMgYGZh bHNlYC4gVGhpcyBpcyBwb3NzaWJsZSBpZiBPYmplY3QucHJldmVudEV4dGVuc2lvbnMgaXMgY2Fs bGVkIG9uIGEgUHJveHkgb2JqZWN0LgorICAgICAgICAoc3RlcCAzIG9mIGh0dHBzOi8vdGMzOS5l cy9lY21hMjYyLyNzZWMtb2JqZWN0LnByZXZlbnRleHRlbnNpb25zKQorCisgICAgICAgICogcnVu dGltZS9PYmplY3RDb25zdHJ1Y3Rvci5jcHA6CisgICAgICAgIChKU0M6Om9iamVjdENvbnN0cnVj dG9yUHJldmVudEV4dGVuc2lvbnMpOgorCiAyMDIwLTAxLTEwICBTYWFtIEJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgogCiAgICAgICAgIE9iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UgZG9l c24ndCBtb2RlbCBwb2ludGVycyB0byBhbGxvY2F0aW9ucyBpbiBjb250cm9sIGZsb3cgcHJvcGVy bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdENvbnN0 cnVjdG9yLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdENvbnN0cnVj dG9yLmNwcAppbmRleCA0MGU5OGI5YmFhZmMwNWRmYTVjY2VhNDk4YTE2NDYyNWIzY2IxOTJlLi42 YjkwODY2ZmVkMTY5YjE3MjlhNzYyMGI2OTM1MDY1NWRkZDkwZjhlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PYmplY3RDb25zdHJ1Y3Rvci5jcHAKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3BwCkBAIC04MzYs MTEgKzgzNiwxNiBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIG9iamVjdENvbnN0cnVj dG9yRnJlZXplKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplYwogRW5jb2RlZEpTVmFsdWUgSlND X0hPU1RfQ0FMTCBvYmplY3RDb25zdHJ1Y3RvclByZXZlbnRFeHRlbnNpb25zKEpTR2xvYmFsT2Jq ZWN0KiBnbG9iYWxPYmplY3QsIENhbGxGcmFtZSogY2FsbEZyYW1lKQogewogICAgIFZNJiB2bSA9 IGdsb2JhbE9iamVjdC0+dm0oKTsKKyAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9USFJPV19TQ09Q RSh2bSk7CisKICAgICBKU1ZhbHVlIGFyZ3VtZW50ID0gY2FsbEZyYW1lLT5hcmd1bWVudCgwKTsK ICAgICBpZiAoIWFyZ3VtZW50LmlzT2JqZWN0KCkpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjpl bmNvZGUoYXJndW1lbnQpOwogICAgIEpTT2JqZWN0KiBvYmplY3QgPSBhc09iamVjdChhcmd1bWVu dCk7Ci0gICAgb2JqZWN0LT5tZXRob2RUYWJsZSh2bSktPnByZXZlbnRFeHRlbnNpb25zKG9iamVj dCwgZ2xvYmFsT2JqZWN0KTsKKyAgICBib29sIHN0YXR1cyA9IG9iamVjdC0+bWV0aG9kVGFibGUo dm0pLT5wcmV2ZW50RXh0ZW5zaW9ucyhvYmplY3QsIGdsb2JhbE9iamVjdCk7CisgICAgUkVUVVJO X0lGX0VYQ0VQVElPTihzY29wZSwgeyB9KTsKKyAgICBpZiAoVU5MSUtFTFkoIXN0YXR1cykpCisg ICAgICAgIHJldHVybiB0aHJvd1ZNVHlwZUVycm9yKGdsb2JhbE9iamVjdCwgc2NvcGUsICJVbmFi bGUgdG8gcHJldmVudCBleHRlbnNpb24gaW4gT2JqZWN0LnByZXZlbnRFeHRlbnNpb25zIl9zKTsK ICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKG9iamVjdCk7CiB9CiAKZGlmZiAtLWdpdCBhL0pT VGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjFlMzBiMTNjN2QwMjIw NmU2MmRmODM4ZWMxMWY2ZmZjYzljMDBhNC4uYzAyYTYyZjZjMTM3ZTM2OWM3YjIwMTgwMDc5MzI1 NTdiMDkxYzMzNSAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMC0wMS0xMSAgQWxleGV5IFNodmF5a2EgIDxz aHZhaWthbGVzaEBnbWFpbC5jb20+CisKKyAgICAgICAgT2JqZWN0LnByZXZlbnRFeHRlbnNpb25z IHNob3VsZCB0aHJvdyBpZiBub3Qgc3VjY2Vzc2Z1bAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sOiBNYXJr IDIgdGVzdCBjYXNlcyBhcyBwYXNzaW5nLgorCiAyMDIwLTAxLTEwICBTYWFtIEJhcmF0aSAgPHNi YXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIE9iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2Ug ZG9lc24ndCBtb2RlbCBwb2ludGVycyB0byBhbGxvY2F0aW9ucyBpbiBjb250cm9sIGZsb3cgcHJv cGVybHkKZGlmZiAtLWdpdCBhL0pTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbCBiL0pT VGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbAppbmRleCBiYmJmOTJmZjRiMDJhOTljYWM1 MjUxYzU2MzFlZDNiMDYzNjlkYzg1Li5lYjQ5M2I2MWRhMzcxYzZmYTdlOTcwNThjYjc4YjZiNTY3 OGViNjFlIDEwMDY0NAotLS0gYS9KU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwKKysr IGIvSlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sCkBAIC0xMTY1LDkgKzExNjUsNiBA QCB0ZXN0L2J1aWx0LWlucy9PYmplY3QvaW50ZXJuYWxzL0RlZmluZU93blByb3BlcnR5L2NvbnNp c3RlbnQtdmFsdWUtZnVuY3Rpb24tY2FsbAogdGVzdC9idWlsdC1pbnMvT2JqZWN0L2ludGVybmFs cy9EZWZpbmVPd25Qcm9wZXJ0eS9jb25zaXN0ZW50LXZhbHVlLXJlZ2V4cC1kb2xsYXIxLmpzOgog ICBkZWZhdWx0OiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUowqvCuywgwqt4wrsp IHRvIGJlIHRydWUnCiAgIHN0cmljdCBtb2RlOiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1l VmFsdWUowqvCuywgwqt4wrspIHRvIGJlIHRydWUnCi10ZXN0L2J1aWx0LWlucy9PYmplY3QvcHJl dmVudEV4dGVuc2lvbnMvdGhyb3dzLXdoZW4tZmFsc2UuanM6Ci0gIGRlZmF1bHQ6ICdUZXN0MjYy RXJyb3I6IEV4cGVjdGVkIGEgVHlwZUVycm9yIHRvIGJlIHRocm93biBidXQgbm8gZXhjZXB0aW9u IHdhcyB0aHJvd24gYXQgYWxsJwotICBzdHJpY3QgbW9kZTogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0 ZWQgYSBUeXBlRXJyb3IgdG8gYmUgdGhyb3duIGJ1dCBubyBleGNlcHRpb24gd2FzIHRocm93biBh dCBhbGwnCiB0ZXN0L2J1aWx0LWlucy9PYmplY3QvcHJvdG8tZnJvbS1jdG9yLXJlYWxtLmpzOgog ICBkZWZhdWx0OiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUowqtbb2JqZWN0IE9i amVjdF3Cuywgwqtbb2JqZWN0IE9iamVjdF3CuykgdG8gYmUgdHJ1ZScKICAgc3RyaWN0IG1vZGU6 ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjCq1tvYmplY3QgT2JqZWN0XcK7LCDC q1tvYmplY3QgT2JqZWN0XcK7KSB0byBiZSB0cnVlJwo=