206114 2020-01-10 17:15:49 -0800 [iOS] Remove 'com.apple.diagnosticd' from WebContent process sandbox 2022-03-01 02:27:11 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206115 InRadar P2 Normal --- 205292 1 bfulgham bfulgham achristensen bfulgham pvollan webkit-bug-importer oldest_to_newest 1605420 0 bfulgham 2020-01-10 17:15:49 -0800 In Bug 205292 we began dynamically adding a sandbox extension for 'com.apple.diagnosticd' when needed. We should remove the blanket permission from the sandbox. 1605424 1 webkit-bug-importer 2020-01-10 17:19:38 -0800 <rdar://problem/58496791> 1605428 2 387404 bfulgham 2020-01-10 17:25:16 -0800 Created attachment 387404 Patch 1605430 3 387404 bfulgham 2020-01-10 17:28:42 -0800 Comment on attachment 387404 Patch Tests pass on device. 1605435 4 387404 pvollan 2020-01-10 17:35:06 -0800 Comment on attachment 387404 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387404&action=review > LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html:18 > + shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.diagnosticd\")"); I expected this to be true, since we always issue the extension for internal builds, but perhaps I am mistaken? 1605841 5 387404 pvollan 2020-01-13 07:54:16 -0800 Comment on attachment 387404 Patch R=me. Perhaps you could consider removing the test, since I expect there to always be access to diagnostics in internal builds, because an extension is issued in this case. 1605906 6 bfulgham 2020-01-13 09:38:20 -0800 (In reply to Per Arne Vollan from comment #5) > Comment on attachment 387404 [details] > Patch > > R=me. Perhaps you could consider removing the test, since I expect there to > always be access to diagnostics in internal builds, because an extension is > issued in this case. Yes -- you are right. We can't write a test that will work in Open Source and Internal environments. 1605907 7 bfulgham 2020-01-13 09:39:38 -0800 Committed r254436: <https://trac.webkit.org/changeset/254436> 387404 2020-01-10 17:25:16 -0800 2022-03-01 02:27:11 -0800 Patch bug-206114-20200110172515.patch text/plain 5324 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZjOTA1MTViMDc1Zjc2NzM0 MzUxODlhMzIxNGEzN2JmZTA0MzkxMGYuLjA3YjZhZjNjYjY1OTM2NDBjNjcwYjY2NmZhYjA3YjZi YWI5NWFjYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDEtMTAgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUmVtb3ZlICdjb20u YXBwbGUuZGlhZ25vc3RpY2QnIGZyb20gV2ViQ29udGVudCBwcm9jZXNzIHNhbmRib3gKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjExNAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNTg0OTY3OTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSW4gQnVnIDIwNTI5MiB3ZSBiZWdhbiBkeW5hbWljYWxseSBh ZGRpbmcgYSBzYW5kYm94IGV4dGVuc2lvbiBmb3IgJ2NvbS5hcHBsZS5kaWFnbm9zdGljZCcgd2hl biBuZWVkZWQuCisgICAgICAgIFdlIHNob3VsZCByZW1vdmUgdGhlIGJsYW5rZXQgcGVybWlzc2lv biBmcm9tIHRoZSBzYW5kYm94LgorCisgICAgICAgIFRlc3Q6IGZhc3Qvc2FuZGJveC9pb3Mvc2Fu ZGJveC1tYWNoLWxvb2t1cC5odG1sCisKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2Zp bGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2I6CisKIDIwMjAtMDEtMTAgIEJy ZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gUmVtb3Zl IHJlcG9ydGluZyBmb3Igc29tZSB3ZWxsLXVuZGVyc3Rvb2Qgc2FuZGJveCBydWxlcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBw bGUuV2ViS2l0LldlYkNvbnRlbnQuc2IgYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94 UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgppbmRleCBmYmM2ZGI0 OTliODMyNzQxYmI0NDM2ZmY3NzJiYzA2NTA2Y2Q2ODk4Li5mMDliNzQxNWZhOTNlZmM4YzQ0M2Iw NGFkZmJiZjU0Nzc5ZWE3ZmJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9T YW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgorKysgYi9T b3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJL aXQuV2ViQ29udGVudC5zYgpAQCAtNjY4LDkgKzY2OCw2IEBACiAoYWxsb3cgaXBjLXBvc2l4LXNo bS1yZWFkKgogICAgICAgIChpcGMtcG9zaXgtbmFtZSAiYXBwbGUuc2htLm5vdGlmaWNhdGlvbl9j ZW50ZXIiKSkKIAotKGFsbG93IG1hY2gtbG9va3VwICh3aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1l dHJ5KQotICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmRpYWdub3N0aWNkIikpCi0KIChsb2dk LWRpYWdub3N0aWMtY2xpZW50KQogCiAobWFuYWdlZC1jb25maWd1cmF0aW9uLXJlYWQtcHVibGlj KQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCmluZGV4IDdjMDhjNTVlNWY5ZDE0ZmEzMzRjODExZjQyNDVmODI1ZmI5ZDllZDIuLjMzMTc4 YzcxMzE5Zjg2MmE1ODdiOWVkZGM5OWQwZDdkMWQ4NjY2NDMgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBA QAorMjAyMC0wMS0xMCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KKworICAg ICAgICBbaU9TXSBSZW1vdmUgJ2NvbS5hcHBsZS5kaWFnbm9zdGljZCcgZnJvbSBXZWJDb250ZW50 IHByb2Nlc3Mgc2FuZGJveAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA2MTE0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODQ5Njc5MT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBCdWcgMjA1Mjky IHdlIGJlZ2FuIGR5bmFtaWNhbGx5IGFkZGluZyBhIHNhbmRib3ggZXh0ZW5zaW9uIGZvciAnY29t LmFwcGxlLmRpYWdub3N0aWNkJyB3aGVuIG5lZWRlZC4KKyAgICAgICAgV2Ugc2hvdWxkIHJlbW92 ZSB0aGUgYmxhbmtldCBwZXJtaXNzaW9uIGZyb20gdGhlIHNhbmRib3guCisKKyAgICAgICAgKiBm YXN0L3NhbmRib3gvaW9zL3NhbmRib3gtbWFjaC1sb29rdXAtZXhwZWN0ZWQudHh0OgorICAgICAg ICAqIGZhc3Qvc2FuZGJveC9pb3Mvc2FuZGJveC1tYWNoLWxvb2t1cC5odG1sOgorCiAyMDIwLTAx LTEwICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1Nd IFJlbW92ZSB1c2VkIG1lZGlhLXJlbGF0ZWQgbWFjaCBzZXJ2aWNlcyBmcm9tIHRoZSBXZWJDb250 ZW50IHByb2Nlc3Mgc2FuZGJveApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9zYW5kYm94 L2lvcy9zYW5kYm94LW1hY2gtbG9va3VwLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qv c2FuZGJveC9pb3Mvc2FuZGJveC1tYWNoLWxvb2t1cC1leHBlY3RlZC50eHQKaW5kZXggNDc2NTBm ZDkwM2U1OGU3ZTQ4Yzk1MDk1NjEyOGExM2JkYzMxYjI1My4uYTg1MGU5M2EwZjY1OWMyODUxZWYx NWRjZTc5Y2IwZTVhY2E5ZjkyZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9zYW5kYm94 L2lvcy9zYW5kYm94LW1hY2gtbG9va3VwLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L3NhbmRib3gvaW9zL3NhbmRib3gtbWFjaC1sb29rdXAtZXhwZWN0ZWQudHh0CkBAIC0xMiw2 ICsxMiw3IEBAIFBBU1MgaW50ZXJuYWxzLmhhc1NhbmRib3hNYWNoTG9va3VwQWNjZXNzVG9HbG9i YWxOYW1lKCJjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlCiBQQVNTIGludGVybmFscy5oYXNTYW5k Ym94TWFjaExvb2t1cEFjY2Vzc1RvR2xvYmFsTmFtZSgiY29tLmFwcGxlLldlYktpdC5XZWJDb250 ZW50IiwgImNvbS5hcHBsZS5jb3JlbWVkaWEuZmlnY29udGVudGtleXNlc3Npb24ueHBjIikgaXMg ZmFsc2UKIFBBU1MgaW50ZXJuYWxzLmhhc1NhbmRib3hNYWNoTG9va3VwQWNjZXNzVG9HbG9iYWxO YW1lKCJjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQiLCAiY29tLmFwcGxlLmNvcmVtZWRpYS5y b3V0aW5nc2Vzc2lvbm1hbmFnZXIueHBjIikgaXMgZmFsc2UKIFBBU1MgaW50ZXJuYWxzLmhhc1Nh bmRib3hNYWNoTG9va3VwQWNjZXNzVG9HbG9iYWxOYW1lKCJjb20uYXBwbGUuV2ViS2l0LldlYkNv bnRlbnQiLCAiY29tLmFwcGxlLmNvcmVtZWRpYS5zdHMiKSBpcyBmYWxzZQorUEFTUyBpbnRlcm5h bHMuaGFzU2FuZGJveE1hY2hMb29rdXBBY2Nlc3NUb0dsb2JhbE5hbWUoImNvbS5hcHBsZS5XZWJL aXQuV2ViQ29udGVudCIsICJjb20uYXBwbGUuZGlhZ25vc3RpY2QiKSBpcyBmYWxzZQogUEFTUyBp bnRlcm5hbHMuaGFzU2FuZGJveE1hY2hMb29rdXBBY2Nlc3NUb0dsb2JhbE5hbWUoImNvbS5hcHBs ZS5XZWJLaXQuV2ViQ29udGVudCIsICJjb20uYXBwbGUuaW9oaWRldmVudHN5c3RlbSIpIGlzIGZh bHNlCiBQQVNTIGludGVybmFscy5oYXNTYW5kYm94TWFjaExvb2t1cEFjY2Vzc1RvR2xvYmFsTmFt ZSgiY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50IiwgImNvbS5hcHBsZS5sb2NhdGlvbmQucmVn aXN0cmF0aW9uIikgaXMgZmFsc2UKIFBBU1MgaW50ZXJuYWxzLmhhc1NhbmRib3hNYWNoTG9va3Vw QWNjZXNzVG9HbG9iYWxOYW1lKCJjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQiLCAiY29tLmFw cGxlLm5laGVscGVyIikgaXMgZmFsc2UKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvc2Fu ZGJveC9pb3Mvc2FuZGJveC1tYWNoLWxvb2t1cC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9zYW5k Ym94L2lvcy9zYW5kYm94LW1hY2gtbG9va3VwLmh0bWwKaW5kZXggY2MyNTQ5YWVjNWM0OGI4Zjdj MTgwMGQxZGUxYTY2NGYxYjM2NTViZC4uYjNhMTQ1YmNiMGFjNjNhNDYzNjY1OTU4NzRiNTE3Njhl ZGFmYTM2MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9zYW5kYm94L2lvcy9zYW5kYm94 LW1hY2gtbG9va3VwLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9zYW5kYm94L2lvcy9zYW5k Ym94LW1hY2gtbG9va3VwLmh0bWwKQEAgLTE1LDYgKzE1LDcgQEAgaWYgKHdpbmRvdy5pbnRlcm5h bHMpIHsKICAgICBzaG91bGRCZUZhbHNlKCJpbnRlcm5hbHMuaGFzU2FuZGJveE1hY2hMb29rdXBB Y2Nlc3NUb0dsb2JhbE5hbWUoXCJjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnRcIiwgXCJjb20u YXBwbGUuY29yZW1lZGlhLmZpZ2NvbnRlbnRrZXlzZXNzaW9uLnhwY1wiKSIpOwogICAgIHNob3Vs ZEJlRmFsc2UoImludGVybmFscy5oYXNTYW5kYm94TWFjaExvb2t1cEFjY2Vzc1RvR2xvYmFsTmFt ZShcImNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudFwiLCBcImNvbS5hcHBsZS5jb3JlbWVkaWEu cm91dGluZ3Nlc3Npb25tYW5hZ2VyLnhwY1wiKSIpOwogICAgIHNob3VsZEJlRmFsc2UoImludGVy bmFscy5oYXNTYW5kYm94TWFjaExvb2t1cEFjY2Vzc1RvR2xvYmFsTmFtZShcImNvbS5hcHBsZS5X ZWJLaXQuV2ViQ29udGVudFwiLCBcImNvbS5hcHBsZS5jb3JlbWVkaWEuc3RzXCIpIik7CisgICAg c2hvdWxkQmVGYWxzZSgiaW50ZXJuYWxzLmhhc1NhbmRib3hNYWNoTG9va3VwQWNjZXNzVG9HbG9i YWxOYW1lKFwiY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50XCIsIFwiY29tLmFwcGxlLmRpYWdu b3N0aWNkXCIpIik7CiAgICAgc2hvdWxkQmVGYWxzZSgiaW50ZXJuYWxzLmhhc1NhbmRib3hNYWNo TG9va3VwQWNjZXNzVG9HbG9iYWxOYW1lKFwiY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50XCIs IFwiY29tLmFwcGxlLmlvaGlkZXZlbnRzeXN0ZW1cIikiKTsKICAgICBzaG91bGRCZUZhbHNlKCJp bnRlcm5hbHMuaGFzU2FuZGJveE1hY2hMb29rdXBBY2Nlc3NUb0dsb2JhbE5hbWUoXCJjb20uYXBw bGUuV2ViS2l0LldlYkNvbnRlbnRcIiwgXCJjb20uYXBwbGUubG9jYXRpb25kLnJlZ2lzdHJhdGlv blwiKSIpOwogICAgIHNob3VsZEJlRmFsc2UoImludGVybmFscy5oYXNTYW5kYm94TWFjaExvb2t1 cEFjY2Vzc1RvR2xvYmFsTmFtZShcImNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudFwiLCBcImNv bS5hcHBsZS5uZWhlbHBlclwiKSIpOwo=