206107 2020-01-10 16:20:59 -0800 Nullptr crash in WebCore::findPlaceForCounter with display: contents sibling 2020-01-28 09:05:44 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 shihchieh_lee webkit-unassigned bfulgham commit-queue esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan pdr rniwa simon.fraser zalan oldest_to_newest 1605375 0 shihchieh_lee 2020-01-10 16:20:59 -0800 <rdar://problem/56723217> 1611728 1 shihchieh_lee 2020-01-27 17:20:58 -0800 Root cause of the crash: In function “findPlaceForCounter”, function “previousSiblingOrParent” will skip all sliblings before a sibling that has display content and finds its parent. On the other hand, function “previousInPreOrder” will search through all the siblings. In this particular test case, when previousInPreOrder is inserting a counter for “SELECT”, previousSiblingOrParent function starts from TIME but jump to BODY since OL’s renderer is null. This root cause if verified by modifying function previousSiblingOrParent such that it will return the next slibling if previous one has display content. *BODY 0x60c00009a300 (renderer 0x61200004d740) SELECT 0x613000064f80 (renderer 0x6150000a0d00) OL 0x60e000058720 (renderer 0x0) TIME 0x60c00009a540 (renderer 0x6110000da240) Q 0x60c00009a600 (renderer 0x6110000da380) STYLE=counter-increment: c 1; #text 0x60800004c720 "\n" 1611739 2 shihchieh_lee 2020-01-27 17:35:14 -0800 Also verified the new patch against the test case attached in https://bugs.webkit.org/show_bug.cgi?id=205290. 1611760 3 388953 shihchieh_lee 2020-01-27 18:04:05 -0800 Created attachment 388953 Patch 1611835 4 388953 koivisto 2020-01-27 23:12:14 -0800 Comment on attachment 388953 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388953&action=review > Source/WebCore/rendering/RenderCounter.cpp:80 > + Element* previous = ElementTraversal::pseudoAwarePreviousSibling(*element); Could be auto* > Source/WebCore/rendering/RenderCounter.cpp:87 > + RenderElement* renderer = element->renderer(); auto* > Source/WebCore/rendering/RenderCounter.cpp:90 > + if (renderer && renderer->isPseudoElement()) { > + return renderer->generatingElement(); > } WebKit coding style doesn't use { } around single line blocks. > Source/WebCore/rendering/RenderCounter.cpp:104 > + Element* previous = previousSiblingOrParentElement(renderer.element()); auto* 1611837 5 388973 shihchieh_lee 2020-01-27 23:27:13 -0800 Created attachment 388973 Patch 1611969 6 388973 commit-queue 2020-01-28 09:05:42 -0800 Comment on attachment 388973 Patch Clearing flags on attachment: 388973 Committed r255244: <https://trac.webkit.org/changeset/255244> 1611970 7 commit-queue 2020-01-28 09:05:44 -0800 All reviewed patches have been landed. Closing bug. 388953 2020-01-27 18:04:05 -0800 2020-01-27 23:27:11 -0800 Patch bug-206107-20200127180404.patch text/plain 5409 shihchieh_lee U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2FhNTMwNmFiYmY1YTAz ODIzNmI3NmViOGRlMzgzMjhmZTE5MDRhYS4uYWIzOWU1YWRhMmUwNmUyYTgwNWZiMTkwMDBlYTRk ODZkZDVjN2VjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAxLTI3ICBKYWNr IExlZSAgPHNoaWhjaGllaF9sZWVAYXBwbGUuY29tPgorCisgICAgICAgIE51bGxwdHIgY3Jhc2gg aW4gV2ViQ29yZTo6ZmluZFBsYWNlRm9yQ291bnRlciB3aXRoIGRpc3BsYXk6IGNvbnRlbnRzIHNp YmxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NjEwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRl c3Q6IGZhc3QvY3NzL2NvdW50ZXJzL2ZpbmRQbGFjZUZvckNvdW50ZXItZGlzcGxheS1jb250ZW50 LXNpYmxpbmctY3Jhc2guaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckNvdW50ZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFyZW50T3JQc2V1ZG9Ib3N0RWxlbWVudCk6CisgICAg ICAgIChXZWJDb3JlOjpwcmV2aW91c1NpYmxpbmdPclBhcmVudEVsZW1lbnQpOgorICAgICAgICAo V2ViQ29yZTo6cHJldmlvdXNTaWJsaW5nT3JQYXJlbnQpOgorCiAyMDIwLTAxLTI3ICBEZXZpbiBS b3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBzcGVjdWxh dGl2ZSB3aW4gYnVpbGQgZml4IGFmdGVyIHIyNTUxOTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJDb3VudGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJDb3VudGVyLmNwcAppbmRleCA5ZWQ4YThiMmI5NjUzNjdhYzhjOTJlNWZjYjZmMGQ1 NjE0MmQxYjA5Li43OGM2OWJjZGU4YmFhOWJhMzkyYmU3ODg2NzJiMDMzZjMwNzdjODFjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ291bnRlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckNvdW50ZXIuY3BwCkBAIC03MiwxNSArNzIs MjcgQEAgc3RhdGljIGlubGluZSBFbGVtZW50KiBwYXJlbnRPclBzZXVkb0hvc3RFbGVtZW50KGNv bnN0IFJlbmRlckVsZW1lbnQmIHJlbmRlcmVyKQogewogICAgIGlmIChyZW5kZXJlci5pc1BzZXVk b0VsZW1lbnQoKSkKICAgICAgICAgcmV0dXJuIHJlbmRlcmVyLmdlbmVyYXRpbmdFbGVtZW50KCk7 CisgICAgcmV0dXJuIHJlbmRlcmVyLmVsZW1lbnQoKSA/IHJlbmRlcmVyLmVsZW1lbnQoKS0+cGFy ZW50RWxlbWVudCgpIDogbnVsbHB0cjsKK30KIAotICAgIEFTU0VSVChyZW5kZXJlci5lbGVtZW50 KCkpOwotICAgIGF1dG8gcGFyZW50ID0gbWFrZVJlZlB0cihyZW5kZXJlci5lbGVtZW50KCktPnBh cmVudEVsZW1lbnQoKSk7Ci0gICAgd2hpbGUgKHBhcmVudCkgewotICAgICAgICBpZiAoIXBhcmVu dC0+aGFzRGlzcGxheUNvbnRlbnRzKCkpCi0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgcGFy ZW50ID0gcGFyZW50LT5wYXJlbnRFbGVtZW50KCk7CitzdGF0aWMgRWxlbWVudCogcHJldmlvdXNT aWJsaW5nT3JQYXJlbnRFbGVtZW50KGNvbnN0IEVsZW1lbnQqIGVsZW1lbnQpCit7CisgICAgRWxl bWVudCogcHJldmlvdXMgPSBFbGVtZW50VHJhdmVyc2FsOjpwc2V1ZG9Bd2FyZVByZXZpb3VzU2li bGluZygqZWxlbWVudCk7CisgICAgd2hpbGUgKHByZXZpb3VzICYmICFwcmV2aW91cy0+cmVuZGVy ZXIoKSkKKyAgICAgICAgcHJldmlvdXMgPSBFbGVtZW50VHJhdmVyc2FsOjpwc2V1ZG9Bd2FyZVBy ZXZpb3VzU2libGluZygqcHJldmlvdXMpOworCisgICAgaWYgKHByZXZpb3VzKQorICAgICAgICBy ZXR1cm4gcHJldmlvdXM7CisKKyAgICBSZW5kZXJFbGVtZW50KiByZW5kZXJlciA9IGVsZW1lbnQt PnJlbmRlcmVyKCk7CisgICAgaWYgKHJlbmRlcmVyICYmIHJlbmRlcmVyLT5pc1BzZXVkb0VsZW1l bnQoKSkgeworICAgICAgICByZXR1cm4gcmVuZGVyZXItPmdlbmVyYXRpbmdFbGVtZW50KCk7CiAg ICAgfQotICAgIHJldHVybiBwYXJlbnQuZ2V0KCk7CisKKyAgICBwcmV2aW91cyA9IGVsZW1lbnQt PnBhcmVudEVsZW1lbnQoKTsKKyAgICBpZiAocHJldmlvdXMgJiYgIXByZXZpb3VzLT5yZW5kZXJl cigpKQorICAgICAgICBwcmV2aW91cyA9IHByZXZpb3VzU2libGluZ09yUGFyZW50RWxlbWVudChw cmV2aW91cyk7CisgICAgcmV0dXJuIHByZXZpb3VzOwogfQogCiAvLyBUaGlzIGZ1bmN0aW9uIHBy b2Nlc3NlcyB0aGUgcmVuZGVyZXIgdHJlZSBpbiB0aGUgb3JkZXIgb2YgdGhlIERPTSB0cmVlCkBA IC04OCwxMiArMTAwLDggQEAgc3RhdGljIGlubGluZSBFbGVtZW50KiBwYXJlbnRPclBzZXVkb0hv c3RFbGVtZW50KGNvbnN0IFJlbmRlckVsZW1lbnQmIHJlbmRlcmVyKQogc3RhdGljIFJlbmRlckVs ZW1lbnQqIHByZXZpb3VzU2libGluZ09yUGFyZW50KGNvbnN0IFJlbmRlckVsZW1lbnQmIHJlbmRl cmVyKQogewogICAgIEFTU0VSVChyZW5kZXJlci5lbGVtZW50KCkpOwotICAgIEVsZW1lbnQqIHBy ZXZpb3VzID0gRWxlbWVudFRyYXZlcnNhbDo6cHNldWRvQXdhcmVQcmV2aW91c1NpYmxpbmcoKnJl bmRlcmVyLmVsZW1lbnQoKSk7Ci0gICAgd2hpbGUgKHByZXZpb3VzICYmICFwcmV2aW91cy0+cmVu ZGVyZXIoKSkKLSAgICAgICAgcHJldmlvdXMgPSBFbGVtZW50VHJhdmVyc2FsOjpwc2V1ZG9Bd2Fy ZVByZXZpb3VzU2libGluZygqcHJldmlvdXMpOwotICAgIGlmIChwcmV2aW91cykKLSAgICAgICAg cmV0dXJuIHByZXZpb3VzLT5yZW5kZXJlcigpOwotICAgIHByZXZpb3VzID0gcGFyZW50T3JQc2V1 ZG9Ib3N0RWxlbWVudChyZW5kZXJlcik7CisKKyAgICBFbGVtZW50KiBwcmV2aW91cyA9IHByZXZp b3VzU2libGluZ09yUGFyZW50RWxlbWVudChyZW5kZXJlci5lbGVtZW50KCkpOwogICAgIHJldHVy biBwcmV2aW91cyA/IHByZXZpb3VzLT5yZW5kZXJlcigpIDogbnVsbHB0cjsKIH0KIApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IDU1NTZjN2IyOTFhMWQ3NjhjYzI3N2NjODFiOWE3NjZkNDJhODUwZTguLjMwMmU3MWY5NGQzMjdl MGQzODc2MDQ0MTRiNDI5YTM1YTQ0NWMzMGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0w MS0yNyAgSmFjayBMZWUgIDxzaGloY2hpZWhfbGVlQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs cHRyIGNyYXNoIGluIFdlYkNvcmU6OmZpbmRQbGFjZUZvckNvdW50ZXIgd2l0aCBkaXNwbGF5OiBj b250ZW50cyBzaWJsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDYxMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGZhc3QvY3NzL2NvdW50ZXJzL2ZpbmRQbGFjZUZvckNvdW50ZXItZGlzcGxheS1j b250ZW50LXNpYmxpbmctY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L2Nzcy9jb3VudGVycy9maW5kUGxhY2VGb3JDb3VudGVyLWRpc3BsYXktY29udGVudC1zaWJsaW5n LWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDIwLTAxLTI3ICBQZW5nIExpdSAgPHBlbmcubGl1NkBh cHBsZS5jb20+CiAKICAgICAgICAgUkVHUlNTSU9OOiBbIEhpZ2ggU2llcnJhIENhdGFsaW5hIF0g KHIyNTMzMTApIGNvbXBvc2l0aW5nL3ZpZGVvL3ZpZGVvLWJvcmRlci1yYWRpdXMtY2xpcHBpbmcu aHRtbCBpcyBmYWlsaW5nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9jb3VudGVy cy9maW5kUGxhY2VGb3JDb3VudGVyLWRpc3BsYXktY29udGVudC1zaWJsaW5nLWNyYXNoLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2NvdW50ZXJzL2ZpbmRQbGFjZUZvckNvdW50 ZXItZGlzcGxheS1jb250ZW50LXNpYmxpbmctY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjIyMTI1OTk0NDI0YmIxNDRiNjNmMmNjZjBiNWNjNWQ5Yjc4ZTAzOGQKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9jb3VudGVycy9maW5kUGxhY2VGb3JDb3VudGVyLWRp c3BsYXktY29udGVudC1zaWJsaW5nLWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDYgQEAK K1RoaXMgdGVzdHMgYW4gZWxlbWVudCB3aXRoIENTUyBjb3VudGVyIGhhdmluZyBhIHNpYmxpbmcg d2l0aCBkaXNwbGF5OiBjb250ZW50cy4KKworVGhlIHRlc3QgcGFzc2VzIGlmIFdlYktpdCBkb2Vz bid0IGNyYXNoIG9yIGhpdCBhbiBhc3NlcnRpb24uCisKKworCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2Nzcy9jb3VudGVycy9maW5kUGxhY2VGb3JDb3VudGVyLWRpc3BsYXktY29udGVu dC1zaWJsaW5nLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9jb3VudGVycy9maW5k UGxhY2VGb3JDb3VudGVyLWRpc3BsYXktY29udGVudC1zaWJsaW5nLWNyYXNoLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uYjcyYTIyMzVhYWVhYTk4YWExMGM5YzM0OWIzYzkxMTE1YWJhZjVjMwotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2NvdW50ZXJzL2ZpbmRQbGFjZUZvckNvdW50 ZXItZGlzcGxheS1jb250ZW50LXNpYmxpbmctY3Jhc2guaHRtbApAQCAtMCwwICsxLDE3IEBACis8 c3R5bGU+CisqIHsgY291bnRlci1yZXNldDogYzsgfQorb2wgeyBkaXNwbGF5OiBjb250ZW50czsg fQorPC9zdHlsZT4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1 bm5lci5kdW1wQXNUZXh0KCk7CisKK29ubG9hZCA9IGZ1bmN0aW9uIGZ1bigpIHsKKyAgICBRLnN0 eWxlLnNldFByb3BlcnR5KCJjb3VudGVyLWluY3JlbWVudCIsICJjIik7Cit9Cis8L3NjcmlwdD4K Kzxib2R5PgorPHA+VGhpcyB0ZXN0cyBhbiBlbGVtZW50IHdpdGggQ1NTIGNvdW50ZXIgaGF2aW5n IGEgc2libGluZyB3aXRoIGRpc3BsYXk6IGNvbnRlbnRzLjwvcD4KKzxwPlRoZSB0ZXN0IHBhc3Nl cyBpZiBXZWJLaXQgZG9lc24ndCBjcmFzaCBvciBoaXQgYW4gYXNzZXJ0aW9uLjwvcD4KKzwvYm9k eT4KKzxzZWxlY3Q+PC9zZWxlY3Q+PG9sPjx0aW1lPjwvb2w+PHEgaWQ9IlEiPjwvcT4K 388973 2020-01-27 23:27:13 -0800 2020-01-28 09:05:42 -0800 Patch bug-206107-20200127232712.patch text/plain 5391 shihchieh_lee U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2FhNTMwNmFiYmY1YTAz ODIzNmI3NmViOGRlMzgzMjhmZTE5MDRhYS4uYWIzOWU1YWRhMmUwNmUyYTgwNWZiMTkwMDBlYTRk ODZkZDVjN2VjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAxLTI3ICBKYWNr IExlZSAgPHNoaWhjaGllaF9sZWVAYXBwbGUuY29tPgorCisgICAgICAgIE51bGxwdHIgY3Jhc2gg aW4gV2ViQ29yZTo6ZmluZFBsYWNlRm9yQ291bnRlciB3aXRoIGRpc3BsYXk6IGNvbnRlbnRzIHNp YmxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NjEwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRl c3Q6IGZhc3QvY3NzL2NvdW50ZXJzL2ZpbmRQbGFjZUZvckNvdW50ZXItZGlzcGxheS1jb250ZW50 LXNpYmxpbmctY3Jhc2guaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckNvdW50ZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFyZW50T3JQc2V1ZG9Ib3N0RWxlbWVudCk6CisgICAg ICAgIChXZWJDb3JlOjpwcmV2aW91c1NpYmxpbmdPclBhcmVudEVsZW1lbnQpOgorICAgICAgICAo V2ViQ29yZTo6cHJldmlvdXNTaWJsaW5nT3JQYXJlbnQpOgorCiAyMDIwLTAxLTI3ICBEZXZpbiBS b3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBzcGVjdWxh dGl2ZSB3aW4gYnVpbGQgZml4IGFmdGVyIHIyNTUxOTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJDb3VudGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJDb3VudGVyLmNwcAppbmRleCA5ZWQ4YThiMmI5NjUzNjdhYzhjOTJlNWZjYjZmMGQ1 NjE0MmQxYjA5Li5mZTQ2YmQxOWRjZjQ5ZmI4ZDY1OWY2YjM1MGI4ZTllZWI1NThmYTUzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ291bnRlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckNvdW50ZXIuY3BwCkBAIC03MiwxNSArNzIs MjYgQEAgc3RhdGljIGlubGluZSBFbGVtZW50KiBwYXJlbnRPclBzZXVkb0hvc3RFbGVtZW50KGNv bnN0IFJlbmRlckVsZW1lbnQmIHJlbmRlcmVyKQogewogICAgIGlmIChyZW5kZXJlci5pc1BzZXVk b0VsZW1lbnQoKSkKICAgICAgICAgcmV0dXJuIHJlbmRlcmVyLmdlbmVyYXRpbmdFbGVtZW50KCk7 CisgICAgcmV0dXJuIHJlbmRlcmVyLmVsZW1lbnQoKSA/IHJlbmRlcmVyLmVsZW1lbnQoKS0+cGFy ZW50RWxlbWVudCgpIDogbnVsbHB0cjsKK30KIAotICAgIEFTU0VSVChyZW5kZXJlci5lbGVtZW50 KCkpOwotICAgIGF1dG8gcGFyZW50ID0gbWFrZVJlZlB0cihyZW5kZXJlci5lbGVtZW50KCktPnBh cmVudEVsZW1lbnQoKSk7Ci0gICAgd2hpbGUgKHBhcmVudCkgewotICAgICAgICBpZiAoIXBhcmVu dC0+aGFzRGlzcGxheUNvbnRlbnRzKCkpCi0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgcGFy ZW50ID0gcGFyZW50LT5wYXJlbnRFbGVtZW50KCk7Ci0gICAgfQotICAgIHJldHVybiBwYXJlbnQu Z2V0KCk7CitzdGF0aWMgRWxlbWVudCogcHJldmlvdXNTaWJsaW5nT3JQYXJlbnRFbGVtZW50KGNv bnN0IEVsZW1lbnQqIGVsZW1lbnQpCit7CisgICAgYXV0byogcHJldmlvdXMgPSBFbGVtZW50VHJh dmVyc2FsOjpwc2V1ZG9Bd2FyZVByZXZpb3VzU2libGluZygqZWxlbWVudCk7CisgICAgd2hpbGUg KHByZXZpb3VzICYmICFwcmV2aW91cy0+cmVuZGVyZXIoKSkKKyAgICAgICAgcHJldmlvdXMgPSBF bGVtZW50VHJhdmVyc2FsOjpwc2V1ZG9Bd2FyZVByZXZpb3VzU2libGluZygqcHJldmlvdXMpOwor CisgICAgaWYgKHByZXZpb3VzKQorICAgICAgICByZXR1cm4gcHJldmlvdXM7CisKKyAgICBhdXRv KiByZW5kZXJlciA9IGVsZW1lbnQtPnJlbmRlcmVyKCk7CisgICAgaWYgKHJlbmRlcmVyICYmIHJl bmRlcmVyLT5pc1BzZXVkb0VsZW1lbnQoKSkKKyAgICAgICAgcmV0dXJuIHJlbmRlcmVyLT5nZW5l cmF0aW5nRWxlbWVudCgpOworCisgICAgcHJldmlvdXMgPSBlbGVtZW50LT5wYXJlbnRFbGVtZW50 KCk7CisgICAgaWYgKHByZXZpb3VzICYmICFwcmV2aW91cy0+cmVuZGVyZXIoKSkKKyAgICAgICAg cHJldmlvdXMgPSBwcmV2aW91c1NpYmxpbmdPclBhcmVudEVsZW1lbnQocHJldmlvdXMpOworICAg IHJldHVybiBwcmV2aW91czsKIH0KIAogLy8gVGhpcyBmdW5jdGlvbiBwcm9jZXNzZXMgdGhlIHJl bmRlcmVyIHRyZWUgaW4gdGhlIG9yZGVyIG9mIHRoZSBET00gdHJlZQpAQCAtODgsMTIgKzk5LDgg QEAgc3RhdGljIGlubGluZSBFbGVtZW50KiBwYXJlbnRPclBzZXVkb0hvc3RFbGVtZW50KGNvbnN0 IFJlbmRlckVsZW1lbnQmIHJlbmRlcmVyKQogc3RhdGljIFJlbmRlckVsZW1lbnQqIHByZXZpb3Vz U2libGluZ09yUGFyZW50KGNvbnN0IFJlbmRlckVsZW1lbnQmIHJlbmRlcmVyKQogewogICAgIEFT U0VSVChyZW5kZXJlci5lbGVtZW50KCkpOwotICAgIEVsZW1lbnQqIHByZXZpb3VzID0gRWxlbWVu dFRyYXZlcnNhbDo6cHNldWRvQXdhcmVQcmV2aW91c1NpYmxpbmcoKnJlbmRlcmVyLmVsZW1lbnQo KSk7Ci0gICAgd2hpbGUgKHByZXZpb3VzICYmICFwcmV2aW91cy0+cmVuZGVyZXIoKSkKLSAgICAg ICAgcHJldmlvdXMgPSBFbGVtZW50VHJhdmVyc2FsOjpwc2V1ZG9Bd2FyZVByZXZpb3VzU2libGlu ZygqcHJldmlvdXMpOwotICAgIGlmIChwcmV2aW91cykKLSAgICAgICAgcmV0dXJuIHByZXZpb3Vz LT5yZW5kZXJlcigpOwotICAgIHByZXZpb3VzID0gcGFyZW50T3JQc2V1ZG9Ib3N0RWxlbWVudChy ZW5kZXJlcik7CisKKyAgICBhdXRvKiBwcmV2aW91cyA9IHByZXZpb3VzU2libGluZ09yUGFyZW50 RWxlbWVudChyZW5kZXJlci5lbGVtZW50KCkpOwogICAgIHJldHVybiBwcmV2aW91cyA/IHByZXZp b3VzLT5yZW5kZXJlcigpIDogbnVsbHB0cjsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDU1NTZjN2IyOTFhMWQ3Njhj YzI3N2NjODFiOWE3NjZkNDJhODUwZTguLjMwMmU3MWY5NGQzMjdlMGQzODc2MDQ0MTRiNDI5YTM1 YTQ0NWMzMGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wMS0yNyAgSmFjayBMZWUgIDxz aGloY2hpZWhfbGVlQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxscHRyIGNyYXNoIGluIFdlYkNv cmU6OmZpbmRQbGFjZUZvckNvdW50ZXIgd2l0aCBkaXNwbGF5OiBjb250ZW50cyBzaWJsaW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYxMDcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY3Nz L2NvdW50ZXJzL2ZpbmRQbGFjZUZvckNvdW50ZXItZGlzcGxheS1jb250ZW50LXNpYmxpbmctY3Jh c2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9jb3VudGVycy9maW5k UGxhY2VGb3JDb3VudGVyLWRpc3BsYXktY29udGVudC1zaWJsaW5nLWNyYXNoLmh0bWw6IEFkZGVk LgorCiAyMDIwLTAxLTI3ICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CiAKICAgICAg ICAgUkVHUlNTSU9OOiBbIEhpZ2ggU2llcnJhIENhdGFsaW5hIF0gKHIyNTMzMTApIGNvbXBvc2l0 aW5nL3ZpZGVvL3ZpZGVvLWJvcmRlci1yYWRpdXMtY2xpcHBpbmcuaHRtbCBpcyBmYWlsaW5nCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9jb3VudGVycy9maW5kUGxhY2VGb3JDb3Vu dGVyLWRpc3BsYXktY29udGVudC1zaWJsaW5nLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL2Zhc3QvY3NzL2NvdW50ZXJzL2ZpbmRQbGFjZUZvckNvdW50ZXItZGlzcGxheS1jb250ZW50 LXNpYmxpbmctY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjIyMTI1OTk0NDI0YmIxNDRi NjNmMmNjZjBiNWNjNWQ5Yjc4ZTAzOGQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L2Nzcy9jb3VudGVycy9maW5kUGxhY2VGb3JDb3VudGVyLWRpc3BsYXktY29udGVudC1zaWJs aW5nLWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDYgQEAKK1RoaXMgdGVzdHMgYW4gZWxl bWVudCB3aXRoIENTUyBjb3VudGVyIGhhdmluZyBhIHNpYmxpbmcgd2l0aCBkaXNwbGF5OiBjb250 ZW50cy4KKworVGhlIHRlc3QgcGFzc2VzIGlmIFdlYktpdCBkb2Vzbid0IGNyYXNoIG9yIGhpdCBh biBhc3NlcnRpb24uCisKKworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9jb3Vu dGVycy9maW5kUGxhY2VGb3JDb3VudGVyLWRpc3BsYXktY29udGVudC1zaWJsaW5nLWNyYXNoLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9jb3VudGVycy9maW5kUGxhY2VGb3JDb3VudGVyLWRp c3BsYXktY29udGVudC1zaWJsaW5nLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYjcyYTIyMzVhYWVh YTk4YWExMGM5YzM0OWIzYzkxMTE1YWJhZjVjMwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvY3NzL2NvdW50ZXJzL2ZpbmRQbGFjZUZvckNvdW50ZXItZGlzcGxheS1jb250ZW50 LXNpYmxpbmctY3Jhc2guaHRtbApAQCAtMCwwICsxLDE3IEBACis8c3R5bGU+CisqIHsgY291bnRl ci1yZXNldDogYzsgfQorb2wgeyBkaXNwbGF5OiBjb250ZW50czsgfQorPC9zdHlsZT4KKzxzY3Jp cHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7 CisKK29ubG9hZCA9IGZ1bmN0aW9uIGZ1bigpIHsKKyAgICBRLnN0eWxlLnNldFByb3BlcnR5KCJj b3VudGVyLWluY3JlbWVudCIsICJjIik7Cit9Cis8L3NjcmlwdD4KKzxib2R5PgorPHA+VGhpcyB0 ZXN0cyBhbiBlbGVtZW50IHdpdGggQ1NTIGNvdW50ZXIgaGF2aW5nIGEgc2libGluZyB3aXRoIGRp c3BsYXk6IGNvbnRlbnRzLjwvcD4KKzxwPlRoZSB0ZXN0IHBhc3NlcyBpZiBXZWJLaXQgZG9lc24n dCBjcmFzaCBvciBoaXQgYW4gYXNzZXJ0aW9uLjwvcD4KKzwvYm9keT4KKzxzZWxlY3Q+PC9zZWxl Y3Q+PG9sPjx0aW1lPjwvb2w+PHEgaWQ9IlEiPjwvcT4K