206105 2020-01-10 15:39:21 -0800 WTR::TestController::decidePolicyForPluginLoad() should output bundle identifier on release assert 2020-01-13 17:08:54 -0800 1 1 1 Unclassified WebKit Plug-ins WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer ap bfulgham commit-queue webkit-bug-importer oldest_to_newest 1605354 0 ddkilzer 2020-01-10 15:39:21 -0800 WTR::TestController::decidePolicyForPluginLoad() should output bundle identifier on release assert. This makes it easier to determine which installed plugin is causing this test to fail: imported/w3c/web-platform-tests/content-security-policy/plugin-types/plugintypes-nourl-allowed.html 1605356 1 ap 2020-01-10 15:42:49 -0800 Usually I was able to tell from test source. This one contains "application/x-shockwave-flash". 1605357 2 387386 ddkilzer 2020-01-10 15:43:10 -0800 Created attachment 387386 Patch v1 1605359 3 webkit-bug-importer 2020-01-10 15:43:24 -0800 <rdar://problem/58493937> 1605361 4 ddkilzer 2020-01-10 15:45:16 -0800 (In reply to Alexey Proskuryakov from comment #1) > Usually I was able to tell from test source. This one contains > "application/x-shockwave-flash". Okay, that's wasn't obvious to me from the comment in the source. 1605379 5 ddkilzer 2020-01-10 16:24:25 -0800 (In reply to David Kilzer (:ddkilzer) from comment #4) > (In reply to Alexey Proskuryakov from comment #1) > > Usually I was able to tell from test source. This one contains > > "application/x-shockwave-flash". > > Okay, that's wasn't obvious to me from the comment in the source. "source" here refers to the C++ source in Tools/WebKitTestRunner/TestController.cpp. 1605967 6 387386 bfulgham 2020-01-13 11:38:42 -0800 Comment on attachment 387386 Patch v1 Oh heck yes! r=me. 1605982 7 ddkilzer 2020-01-13 12:21:03 -0800 The ios-wk2 test failure appears to be unrelated. 1606151 8 commit-queue 2020-01-13 17:08:25 -0800 The commit-queue encountered the following flaky tests while processing attachment 387386: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1606152 9 387386 commit-queue 2020-01-13 17:08:53 -0800 Comment on attachment 387386 Patch v1 Clearing flags on attachment: 387386 Committed r254473: <https://trac.webkit.org/changeset/254473> 1606153 10 commit-queue 2020-01-13 17:08:54 -0800 All reviewed patches have been landed. Closing bug. 387386 2020-01-10 15:43:10 -0800 2020-01-13 17:08:53 -0800 Patch v1 bug-206105-20200110154309.patch text/plain 1797 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjI3OWIyMzk3ZTQ1ZWEwYjYwZmUyYWFkODJhOTdmMjE5 MDllMWQyMS4uODUwNTA3YzVhYjg4MjUzYjBhNzBhMDdiNTA2N2FhY2NiNTQxYWE3ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIwLTAxLTEwICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgV1RSOjpUZXN0Q29udHJvbGxlcjo6ZGVjaWRlUG9saWN5Rm9yUGx1Z2luTG9hZCgpIHNo b3VsZCBvdXRwdXQgYnVuZGxlIGlkZW50aWZpZXIgb24gcmVsZWFzZSBhc3NlcnQKKyAgICAgICAg PGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIwNjEwNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIu Y3BwOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6ZGVjaWRlUG9saWN5Rm9yUGx1Z2lu TG9hZCk6IENoYW5nZQorICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpIHRvCisg ICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEX1dJVEhfTUVTU0FHRSgpIHdpdGggYnVu ZGxlCisgICAgICAgIGlkZW50aWZpZXIuCisKIDIwMjAtMDEtMDkgIERhdmlkIEtpbHplciAgPGRk a2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1MaWJy YXJ5UGF0aEZvclRlc3RpbmcoKSByZXR1cm5zIGlubmVyIHBvaW50ZXIgdG8gYXV0b3JlbGVhc2Vk IE5TU3RyaW5nCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9s bGVyLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCmluZGV4 IDUyNmFhZmI1Nzc1M2E4MzE0NDg0ZWQ2ODRhYTQyZmE4MzlkYWIzMzEuLjk4OTQ1MGE2YThhZmUx YWViNGRiMDU2ZTZkYzZiOWMzNjM4MjViNDIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVz dENvbnRyb2xsZXIuY3BwCkBAIC0yMzA1LDcgKzIzMDUsOCBAQCBXS1BsdWdpbkxvYWRQb2xpY3kg VGVzdENvbnRyb2xsZXI6OmRlY2lkZVBvbGljeUZvclBsdWdpbkxvYWQoV0tQYWdlUmVmLCBXS1Bs dWdpbgogICAgIGlmIChXS1N0cmluZ0lzRXF1YWxUb1VURjhDU3RyaW5nKGJ1bmRsZUlkZW50aWZp ZXIsICJjb20uYXBwbGUudGVzdG5ldHNjYXBlcGx1Z2luIikpCiAgICAgICAgIHJldHVybiBjdXJy ZW50UGx1Z2luTG9hZFBvbGljeTsKIAotICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7 IC8vIFBsZWFzZSBkb24ndCB1c2UgYW55IG90aGVyIHBsdWctaW5zIGluIHRlc3RzLCBhcyB0aGV5 IHdpbGwgbm90IGJlIGluc3RhbGxlZCBvbiBhbGwgbWFjaGluZXMuCisgICAgLy8gUGxlYXNlIGRv bid0IHVzZSBhbnkgb3RoZXIgcGx1Zy1pbnMgaW4gdGVzdHMsIGFzIHRoZXkgd2lsbCBub3QgYmUg aW5zdGFsbGVkIG9uIGFsbCBtYWNoaW5lcy4KKyAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hF RF9XSVRIX01FU1NBR0UoIlVuZXhwZWN0ZWQgcGx1Z2luIGJ1bmRsZSBpZGVudGlmaWVyOiAlcyIs IHRvU1REKGJ1bmRsZUlkZW50aWZpZXIpLmNfc3RyKCkpOwogI2Vsc2UKICAgICByZXR1cm4gY3Vy cmVudFBsdWdpbkxvYWRQb2xpY3k7CiAjZW5kaWYK