206074 2020-01-10 10:44:32 -0800 [LFC][Integration] Update style for layout boxes 2020-01-10 16:14:19 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1605188 0 koivisto 2020-01-10 10:44:32 -0800 For simple style changes we may keep the existing layout boxes. In this case we need to update the style. 1605199 1 387353 koivisto 2020-01-10 10:56:00 -0800 Created attachment 387353 patch 1605369 2 387353 commit-queue 2020-01-10 16:13:21 -0800 Comment on attachment 387353 patch Clearing flags on attachment: 387353 Committed r254378: <https://trac.webkit.org/changeset/254378> 1605370 3 commit-queue 2020-01-10 16:13:23 -0800 All reviewed patches have been landed. Closing bug. 1605372 4 webkit-bug-importer 2020-01-10 16:14:19 -0800 <rdar://problem/58494945> 387353 2020-01-10 10:56:00 -0800 2020-01-10 16:13:21 -0800 patch lfc-style-update.patch text/plain 7132 koivisto ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjOTk3MjFkM2U0OS4uMDgyZjk5YjRjZTEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAyMC0wMS0xMCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CisKKyAgICAgICAg W0xGQ11bSW50ZWdyYXRpb25dIFVwZGF0ZSBzdHlsZSBmb3IgbGF5b3V0IGJveGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYwNzQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY3NzL3NpbXBs ZS1jb2xvci1jaGFuZ2UtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3Mv c2ltcGxlLWNvbG9yLWNoYW5nZS5odG1sOiBBZGRlZC4KKwogMjAyMC0wMS0xMCAgeW91ZW5uIGZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dUUl0gVXNlIHNob3J0IGhlYXJ0 IGJlYXQgdGltZXIgYXMgYSBUZXN0T3B0aW9uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9zaW1wbGUtY29sb3ItY2hhbmdlLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9zaW1wbGUtY29sb3ItY2hhbmdlLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAuLjU3Yzc0ZDdjNDQ5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9jc3Mvc2ltcGxlLWNvbG9yLWNoYW5nZS1leHBlY3RlZC5odG1sCkBAIC0w LDAgKzEsNCBAQAorPHN0eWxlPgorLmdyZWVuIHsgY29sb3I6IGdyZWVuOyB9Cis8L3N0eWxlPgor PGRpdiBjbGFzcz1ncmVlbj5HcmVlbjwvZGl2PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9jc3Mvc2ltcGxlLWNvbG9yLWNoYW5nZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mvc2lt cGxlLWNvbG9yLWNoYW5nZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwLi5kMmZjYjBkYThhMQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz L3NpbXBsZS1jb2xvci1jaGFuZ2UuaHRtbApAQCAtMCwwICsxLDE2IEBACis8c3R5bGU+CitkaXYg eyBjb2xvcjogcmVkOyB9CisuZ3JlZW4geyBjb2xvcjogZ3JlZW47IH0KKzwvc3R5bGU+Cis8ZGl2 IGlkPXRlc3Q+R3JlZW48L2Rpdj4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisg ICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisKK3NldFRpbWVvdXQoKCkgPT4geworICAg IHRlc3QuY2xhc3NMaXN0LmFkZCgiZ3JlZW4iKTsKKworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5l cikKKyAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cit9LCAyMCk7Cis8L3NjcmlwdD4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiNzkwMzViN2RlNy4uYjVhODBkNGM5ZDIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzNSBAQAorMjAyMC0wMS0xMCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgW0xGQ11bSW50ZWdyYXRpb25dIFVwZGF0ZSBzdHlsZSBmb3IgbGF5b3V0IGJv eGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYw NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0 OiBmYXN0L2Nzcy9zaW1wbGUtY29sb3ItY2hhbmdlLmh0bWwKKworICAgICAgICBGb3Igc2ltcGxl IHN0eWxlIGNoYW5nZXMgd2UgbWF5IGtlZXAgdGhlIGV4aXN0aW5nIGxheW91dCBib3hlcy4gSW4g dGhpcyBjYXNlIHdlIG5lZWQgdG8gdXBkYXRlIHRoZSBzdHlsZS4KKworICAgICAgICAqIGxheW91 dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TGF5b3V0SW50ZWdyYXRpb246OkxpbmVMYXlvdXQ6OnVwZGF0ZVN0eWxlKToKKwor ICAgICAgICBVcGRhdGUgc3R5bGUgaW4gbGF5b3V0IGJveGVzLgorCisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXRJbnRlZ3JhdGlvbjo6TGluZUxheW91dDo6cm9vdExheW91dEJveCk6CisgICAgICAg ICogbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5oOgorCisg ICAgICAgIE1ha2Ugcm9vdCBub24tY29uc3QuCisKKyAgICAgICAgKiBsYXlvdXQvbGF5b3V0dHJl ZS9MYXlvdXRCb3guaDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6Qm94OjpuZXh0U2libGlu Zyk6CisgICAgICAgICogbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Q29udGFpbmVyLmg6CisKKyAg ICAgICAgRXhwb3NlIG5vbi1jb25zdCBhY2Nlc3NvcnMuCisKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyQmxvY2tGbG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrRmxvdzo6 c3R5bGVEaWRDaGFuZ2UpOgorCisgICAgICAgIEludm9rZSBMaW5lTGF5b3V0Ojp1cGRhdGVTdHls ZQorCiAyMDIwLTAxLTEwICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAg ICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gRml4IGFjY2Vzc2liaWxpdHkvc2Nyb2xsLXRvLW1ha2Ut dmlzaWJsZS1pZnJhbWUtb2Zmc2NyZWVuLmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91 dC5jcHAKaW5kZXggMzA4NDc1ZDNhN2QuLjk3ZWI3ZjAxY2E2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRp b25MaW5lTGF5b3V0LmNwcApAQCAtNzYsNiArNzYsMTkgQEAgYm9vbCBMaW5lTGF5b3V0OjpjYW5V c2VGb3IoY29uc3QgUmVuZGVyQmxvY2tGbG93JiBmbG93KQogICAgIHJldHVybiB0cnVlOwogfQog Cit2b2lkIExpbmVMYXlvdXQ6OnVwZGF0ZVN0eWxlKCkKK3sKKyAgICBhdXRvJiByb290ID0gcm9v dExheW91dEJveCgpOworCisgICAgLy8gRklYTUU6IEVuY2Fwc3VsYXRlIHN0eWxlIHVwZGF0ZXMg YmV0dGVyLgorICAgIHJvb3QudXBkYXRlU3R5bGUobV9mbG93LnN0eWxlKCkpOworCisgICAgZm9y IChhdXRvKiBjaGlsZCA9IHJvb3QuZmlyc3RDaGlsZCgpOyBjaGlsZDsgY2hpbGQgPSBjaGlsZC0+ bmV4dFNpYmxpbmcoKSkgeworICAgICAgICBpZiAoY2hpbGQtPmlzQW5vbnltb3VzKCkpCisgICAg ICAgICAgICBjaGlsZC0+dXBkYXRlU3R5bGUoUmVuZGVyU3R5bGU6OmNyZWF0ZUFub255bW91c1N0 eWxlV2l0aERpc3BsYXkocm9vdC5zdHlsZSgpLCBEaXNwbGF5VHlwZTo6SW5saW5lKSk7CisgICAg fQorfQorCiB2b2lkIExpbmVMYXlvdXQ6OmxheW91dCgpCiB7CiAgICAgaWYgKCFtX2xheW91dFN0 YXRlKQpAQCAtMTk1LDYgKzIwOCwxMSBAQCBjb25zdCBMYXlvdXQ6OkNvbnRhaW5lciYgTGluZUxh eW91dDo6cm9vdExheW91dEJveCgpIGNvbnN0CiAgICAgcmV0dXJuIG1fdHJlZUNvbnRlbnQtPnJv b3RMYXlvdXRCb3goKTsKIH0KIAorTGF5b3V0OjpDb250YWluZXImIExpbmVMYXlvdXQ6OnJvb3RM YXlvdXRCb3goKQoreworICAgIHJldHVybiBtX3RyZWVDb250ZW50LT5yb290TGF5b3V0Qm94KCk7 Cit9CisKIHZvaWQgTGluZUxheW91dDo6cGFpbnQoUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0 IExheW91dFBvaW50JiBwYWludE9mZnNldCkKIHsKICAgICBpZiAoIWRpc3BsYXlJbmxpbmVDb250 ZW50KCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5 b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdy YXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmgKaW5kZXggMDIzZWJhZmJkZjcuLjZh ZjY3NjRhOTM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24v TGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5oCkBAIC02MCw2ICs2MCw3 IEBAIHB1YmxpYzoKIAogICAgIHN0YXRpYyBib29sIGNhblVzZUZvcihjb25zdCBSZW5kZXJCbG9j a0Zsb3cmKTsKIAorICAgIHZvaWQgdXBkYXRlU3R5bGUoKTsKICAgICB2b2lkIGxheW91dCgpOwog CiAgICAgTGF5b3V0VW5pdCBjb250ZW50TG9naWNhbEhlaWdodCgpIGNvbnN0IHsgcmV0dXJuIG1f Y29udGVudExvZ2ljYWxIZWlnaHQ7IH0KQEAgLTgwLDExICs4MSwxMiBAQCBwdWJsaWM6CiAKIHBy aXZhdGU6CiAgICAgY29uc3QgTGF5b3V0OjpDb250YWluZXImIHJvb3RMYXlvdXRCb3goKSBjb25z dDsKKyAgICBMYXlvdXQ6OkNvbnRhaW5lciYgcm9vdExheW91dEJveCgpOwogICAgIHZvaWQgcHJl cGFyZVJvb3RHZW9tZXRyeUZvckxheW91dCgpOwogICAgIFNoYWRvd0RhdGEqIGRlYnVnVGV4dFNo YWRvdygpOwogCiAgICAgY29uc3QgUmVuZGVyQmxvY2tGbG93JiBtX2Zsb3c7Ci0gICAgc3RkOjp1 bmlxdWVfcHRyPGNvbnN0IExheW91dDo6TGF5b3V0VHJlZUNvbnRlbnQ+IG1fdHJlZUNvbnRlbnQ7 CisgICAgc3RkOjp1bmlxdWVfcHRyPExheW91dDo6TGF5b3V0VHJlZUNvbnRlbnQ+IG1fdHJlZUNv bnRlbnQ7CiAgICAgc3RkOjp1bmlxdWVfcHRyPExheW91dDo6TGF5b3V0U3RhdGU+IG1fbGF5b3V0 U3RhdGU7CiAgICAgTGF5b3V0VW5pdCBtX2NvbnRlbnRMb2dpY2FsSGVpZ2h0OwogfTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5oIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmgKaW5kZXggYzNjODM0ZGRl ODYuLjkxZjY4ZTlkMjNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0 dHJlZS9MYXlvdXRCb3guaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9M YXlvdXRCb3guaApAQCAtMTMwLDYgKzEzMCw5IEBAIHB1YmxpYzoKICAgICBjb25zdCBCb3gqIHBy ZXZpb3VzSW5GbG93U2libGluZygpIGNvbnN0OwogICAgIGNvbnN0IEJveCogcHJldmlvdXNJbkZs b3dPckZsb2F0aW5nU2libGluZygpIGNvbnN0OwogCisgICAgLy8gRklYTUU6IFRoaXMgaXMgY3Vy cmVudGx5IG5lZWRlZCBmb3Igc3R5bGUgdXBkYXRlcy4KKyAgICBCb3gqIG5leHRTaWJsaW5nKCkg eyByZXR1cm4gbV9uZXh0U2libGluZzsgfQorCiAgICAgYm9vbCBpc0NvbnRhaW5lcigpIGNvbnN0 IHsgcmV0dXJuIG1fYmFzZVR5cGVGbGFncyAmIENvbnRhaW5lckZsYWc7IH0KICAgICBib29sIGlz QmxvY2tDb250YWluZXIoKSBjb25zdCB7IHJldHVybiBpc0Jsb2NrTGV2ZWxCb3goKSAmJiBpc0Nv bnRhaW5lcigpOyB9CiAgICAgYm9vbCBpc0lubGluZUNvbnRhaW5lcigpIGNvbnN0IHsgcmV0dXJu IGlzSW5saW5lTGV2ZWxCb3goKSAmJiBpc0NvbnRhaW5lcigpOyB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRDb250YWluZXIuaCBiL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dENvbnRhaW5lci5oCmluZGV4IGNiMjMwN2E1 ZmYxLi40ZTE4Yzk5MGEyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91 dHRyZWUvTGF5b3V0Q29udGFpbmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91 dHRyZWUvTGF5b3V0Q29udGFpbmVyLmgKQEAgLTQ4LDYgKzQ4LDkgQEAgcHVibGljOgogICAgIGNv bnN0IEJveCogbGFzdEluRmxvd0NoaWxkKCkgY29uc3Q7CiAgICAgY29uc3QgQm94KiBsYXN0SW5G bG93T3JGbG9hdGluZ0NoaWxkKCkgY29uc3Q7CiAKKyAgICAvLyBGSVhNRTogVGhpcyBpcyBjdXJy ZW50bHkgbmVlZGVkIGZvciBzdHlsZSB1cGRhdGVzLgorICAgIEJveCogZmlyc3RDaGlsZCgpIHsg cmV0dXJuIG1fZmlyc3RDaGlsZDsgfQorCiAgICAgYm9vbCBoYXNDaGlsZCgpIGNvbnN0IHsgcmV0 dXJuIGZpcnN0Q2hpbGQoKTsgfQogICAgIGJvb2wgaGFzSW5GbG93Q2hpbGQoKSBjb25zdCB7IHJl dHVybiBmaXJzdEluRmxvd0NoaWxkKCk7IH0KICAgICBib29sIGhhc0luRmxvd09yRmxvYXRpbmdD aGlsZCgpIGNvbnN0IHsgcmV0dXJuIGZpcnN0SW5GbG93T3JGbG9hdGluZ0NoaWxkKCk7IH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKaW5kZXggMmZiNjAy MmUyYzAuLjY0YTM4ZWUxOTY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQmxvY2tGbG93LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy QmxvY2tGbG93LmNwcApAQCAtMjEwNCw2ICsyMTA0LDExIEBAIHZvaWQgUmVuZGVyQmxvY2tGbG93 OjpzdHlsZURpZENoYW5nZShTdHlsZURpZmZlcmVuY2UgZGlmZiwgY29uc3QgUmVuZGVyU3R5bGUq IG9sCiAKICAgICBpZiAobXVsdGlDb2x1bW5GbG93KCkpCiAgICAgICAgIHVwZGF0ZVN0eWxlc0Zv ckNvbHVtbkNoaWxkcmVuKCk7CisKKyNpZiBFTkFCTEUoTEFZT1VUX0ZPUk1BVFRJTkdfQ09OVEVY VCkKKyAgICBpZiAobGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5b3V0KCkpCisgICAgICAg IGxheW91dEZvcm1hdHRpbmdDb250ZXh0TGluZUxheW91dCgpLT51cGRhdGVTdHlsZSgpOworI2Vu ZGlmCiB9CiAKIHZvaWQgUmVuZGVyQmxvY2tGbG93Ojp1cGRhdGVTdHlsZXNGb3JDb2x1bW5DaGls ZHJlbigpCg==