206069 2020-01-10 08:58:30 -0800 [GTK] compilation breaks if POINTER_LOCK is not enabled 2020-06-04 01:03:30 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID https://bugs.webkit.org/show_bug.cgi?id=202956 P2 Normal --- 1 vjaquez vjaquez aperez berto bugs-noreply cgarcia clopez ews-watchlist gustavo zan oldest_to_newest 1605128 0 vjaquez 2020-01-10 08:58:30 -0800 If POINT_LOCK is not enabled at configuration time, compilation breaks with /opt/webkit/WebKit/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1886:26: error: no member named 'didAllowPointerLock' in 'WebKit::WebPageProxy' priv->pageProxy->didAllowPointerLock(); ~~~~~~~~~~~~~~~ ^ /opt/webkit/WebKit/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1891:22: error: no member named 'didDenyPointerLock' in 'WebKit::WebPageProxy' priv->pageProxy->didDenyPointerLock(); ~~~~~~~~~~~~~~~ ^ 1605131 1 387342 vjaquez 2020-01-10 09:04:25 -0800 Created attachment 387342 Patch 1605132 2 ews-watchlist 2020-01-10 09:05:18 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1605278 3 aperez 2020-01-10 13:38:44 -0800 The POINTER_LOCK feature is intended to always be enabled for the GTK port. It is also a private option, which means that it must not be manually set when configuring a build — it's not supported :) The relevant bits: Source/cmake/WebKitFeatures.cmake 183: WEBKIT_OPTION_DEFINE(ENABLE_POINTER_LOCK "Toggle pointer lock support" PRIVATE OFF) Source/cmake/OptionsGTK.cmake 166:WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_POINTER_LOCK PRIVATE ON) I think this patch should not be needed, because POINTER_LOCK is enabled automatically. Out of curiosity… how did you reach this build problem? I suspect that maybe there was a stale “CMakeCache.txt” in a build directory manually configured some weeks ago before POINTER_LOCK was implemented in the GTK port, and trying to reuse that build directory did not regenerate the cache file (but I am just doing a wild guess here). 1605760 4 cgarcia 2020-01-13 01:18:49 -0800 (In reply to Adrian Perez from comment #3) > The POINTER_LOCK feature is intended to always be enabled for > the GTK port. It is also a private option, which means that it > must not be manually set when configuring a build — it's not > supported :) Exactly. > The relevant bits: > > Source/cmake/WebKitFeatures.cmake > 183: WEBKIT_OPTION_DEFINE(ENABLE_POINTER_LOCK "Toggle pointer lock > support" PRIVATE OFF) > > Source/cmake/OptionsGTK.cmake > 166:WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_POINTER_LOCK PRIVATE ON) > > I think this patch should not be needed, because POINTER_LOCK > is enabled automatically. > > Out of curiosity… how did you reach this build problem? I suspect > that maybe there was a stale “CMakeCache.txt” in a build directory > manually configured some weeks ago before POINTER_LOCK was implemented > in the GTK port, and trying to reuse that build directory did not > regenerate the cache file (but I am just doing a wild guess here). 1605777 5 vjaquez 2020-01-13 02:28:03 -0800 (In reply to Adrian Perez from comment #3) > > I think this patch should not be needed, because POINTER_LOCK > is enabled automatically. Indeed. > > Out of curiosity… how did you reach this build problem? I suspect > that maybe there was a stale “CMakeCache.txt” in a build directory > manually configured some weeks ago before POINTER_LOCK was implemented > in the GTK port, and trying to reuse that build directory did not > regenerate the cache file (but I am just doing a wild guess here). I pulled and compiled. It failed. Then I just ran the cmake command again in my old build directory and still failed. So I looked for the causes (forgetting completely the build system). Today I've removed the build directory and built all again and master compiles ok. Marking as invalid. Thanks! 387342 2020-01-10 09:04:25 -0800 2020-06-04 01:03:30 -0700 Patch bug-206069-20200110180635.patch text/plain 5226 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGViOTQxNGRmOTBlYTY2MWMw OTgzYzRhMGFlNmVjOWIzMzY3ZTFiNjUuLjRiNGZjOThiMTI1NmZkNDM4YmU0NTc1NTllYTlhMWM4 NWZmYzdlOTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDEtMTAgIFbDrWN0b3Ig TWFudWVsIErDoXF1ZXogTGVhbCAgPHZqYXF1ZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XSBjb21waWxhdGlvbiBicmVha3MgaWYgUE9JTlRfTE9DSyBpcyBub3QgZW5hYmxlZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MDY5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3VhcmQgcG9pbnRlciBs b2NrIG9wZXJhdGlvbnMuCisKKyAgICAgICAgTm8gZnVuY3Rpb25hbCBjaGFuZ2VzLgorCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFBvaW50ZXJMb2NrUGVybWlzc2lvblJlcXVl c3QuY3BwOgorICAgICAgICAod2Via2l0UG9pbnRlckxvY2tQZXJtaXNzaW9uUmVxdWVzdEFsbG93 KToKKyAgICAgICAgKHdlYmtpdFBvaW50ZXJMb2NrUGVybWlzc2lvblJlcXVlc3REZW55KToKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAg ICh3ZWJraXRXZWJWaWV3QmFzZURpc3Bvc2UpOgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VN b3Rpb25Ob3RpZnlFdmVudCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi Vmlld0Jhc2VQcml2YXRlLmg6CisKIDIwMjAtMDEtMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8 Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVwZGF0ZSBPcHRpb25z R1RLLmNtYWtlIGFuZCBORVdTIGZvciAyLjI3LjQgcmVsZWFzZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0UG9pbnRlckxvY2tQZXJtaXNzaW9uUmVx dWVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRQb2ludGVy TG9ja1Blcm1pc3Npb25SZXF1ZXN0LmNwcAppbmRleCAzMjYzNDgzZDk1OWI3MzYwZjkwNzRjMGEw ZWYwZGNlZmVjNjAwN2IzLi43NTdiMjBhYTE3ZDNkMjRhNGI5M2M0NWJhYjYzN2JlYjA0NjkzYzVk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRQb2lu dGVyTG9ja1Blcm1pc3Npb25SZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvZ2xpYi9XZWJLaXRQb2ludGVyTG9ja1Blcm1pc3Npb25SZXF1ZXN0LmNwcApAQCAtNjIs NyArNjIsOSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRQb2ludGVyTG9ja1Blcm1pc3Npb25SZXF1ZXN0 QWxsb3coV2ViS2l0UGVybWlzc2lvblJlcXVlc3QqIHJlcQogICAgIGlmIChwcml2LT5tYWRlRGVj aXNpb24pCiAgICAgICAgIHJldHVybjsKIAorI2lmIEVOQUJMRShQT0lOVEVSX0xPQ0spCiAgICAg d2Via2l0V2ViVmlld1JlcXVlc3RQb2ludGVyTG9jayhwcml2LT53ZWJWaWV3LmdldCgpKTsKKyNl bmRpZgogICAgIHByaXYtPm1hZGVEZWNpc2lvbiA9IHRydWU7CiB9CiAKQEAgLTc2LDcgKzc4LDkg QEAgc3RhdGljIHZvaWQgd2Via2l0UG9pbnRlckxvY2tQZXJtaXNzaW9uUmVxdWVzdERlbnkoV2Vi S2l0UGVybWlzc2lvblJlcXVlc3QqIHJlcXUKICAgICBpZiAocHJpdi0+bWFkZURlY2lzaW9uKQog ICAgICAgICByZXR1cm47CiAKKyNpZiBFTkFCTEUoUE9JTlRFUl9MT0NLKQogICAgIHdlYmtpdFdl YlZpZXdEZW55UG9pbnRlckxvY2tSZXF1ZXN0KHByaXYtPndlYlZpZXcuZ2V0KCkpOworI2VuZGlm CiAgICAgcHJpdi0+bWFkZURlY2lzaW9uID0gdHJ1ZTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAppbmRleCA0OTYz ZWMyOTM3ZGExNTIzYWZlNGRkNzhmYjQzNjA0YzBhM2U4NTAyLi40NjJmNDMyNjcwNmEyMWU2YmIx MmM0ZWRkYTk4MzE0ZGU0NzdiYTkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtMjMzLDcgKzIzMyw5IEBAIHN0 cnVjdCBfV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlIHsKICAgICBSdW5Mb29wOjpUaW1lcjxXZWJL aXRXZWJWaWV3QmFzZVByaXZhdGU+IHJlbGVhc2VFbW9qaUNob29zZXJUaW1lcjsKICNlbmRpZgog CisjaWYgRU5BQkxFKFBPSU5URVJfTE9DSykKICAgICBzdGQ6OnVuaXF1ZV9wdHI8UG9pbnRlckxv Y2tNYW5hZ2VyPiBwb2ludGVyTG9ja01hbmFnZXI7CisjZW5kaWYKIH07CiAKIFdFQktJVF9ERUZJ TkVfVFlQRShXZWJLaXRXZWJWaWV3QmFzZSwgd2Via2l0X3dlYl92aWV3X2Jhc2UsIEdUS19UWVBF X0NPTlRBSU5FUikKQEAgLTU2NSwxMCArNTY3LDEyIEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZp ZXdCYXNlRGlzcG9zZShHT2JqZWN0KiBnb2JqZWN0KQogI2lmIEdUS19DSEVDS19WRVJTSU9OKDMs IDI0LCAwKQogICAgIHdlYmtpdFdlYlZpZXdCYXNlQ29tcGxldGVFbW9qaUNob29zZXJSZXF1ZXN0 KHdlYlZpZXcsIGVtcHR5U3RyaW5nKCkpOwogI2VuZGlmCisjaWYgRU5BQkxFKFBPSU5URVJfTE9D SykKICAgICBpZiAod2ViVmlldy0+cHJpdi0+cG9pbnRlckxvY2tNYW5hZ2VyKSB7CiAgICAgICAg IHdlYlZpZXctPnByaXYtPnBvaW50ZXJMb2NrTWFuYWdlci0+dW5sb2NrKCk7CiAgICAgICAgIHdl YlZpZXctPnByaXYtPnBvaW50ZXJMb2NrTWFuYWdlciA9IG51bGxwdHI7CiAgICAgfQorI2VuZGlm CiAgICAgd2ViVmlldy0+cHJpdi0+aW5wdXRNZXRob2RGaWx0ZXIuc2V0Q29udGV4dChudWxscHRy KTsKICAgICB3ZWJWaWV3LT5wcml2LT5wYWdlUHJveHktPmNsb3NlKCk7CiAgICAgd2ViVmlldy0+ cHJpdi0+YWNjZWxlcmF0ZWRCYWNraW5nU3RvcmUgPSBudWxscHRyOwpAQCAtOTgwLDEwICs5ODQs MTIgQEAgc3RhdGljIGdib29sZWFuIHdlYmtpdFdlYlZpZXdCYXNlTW90aW9uTm90aWZ5RXZlbnQo R3RrV2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50TW8KICAgICAgICAgcmV0dXJuIHdpZGdldENsYXNz LT5tb3Rpb25fbm90aWZ5X2V2ZW50ID8gd2lkZ2V0Q2xhc3MtPm1vdGlvbl9ub3RpZnlfZXZlbnQo d2lkZ2V0LCBldmVudCkgOiBHREtfRVZFTlRfUFJPUEFHQVRFOwogICAgIH0KIAorI2lmIEVOQUJM RShQT0lOVEVSX0xPQ0spCiAgICAgaWYgKHByaXYtPnBvaW50ZXJMb2NrTWFuYWdlcikgewogICAg ICAgICBwcml2LT5wb2ludGVyTG9ja01hbmFnZXItPmRpZFJlY2VpdmVNb3Rpb25FdmVudChyZWlu dGVycHJldF9jYXN0PEdka0V2ZW50Kj4oZXZlbnQpKTsKICAgICAgICAgcmV0dXJuIEdES19FVkVO VF9TVE9QOwogICAgIH0KKyNlbmRpZgogCiAgICAgd2Via2l0V2ViVmlld0Jhc2VIYW5kbGVNb3Vz ZUV2ZW50KHdlYlZpZXdCYXNlLCByZWludGVycHJldF9jYXN0PEdka0V2ZW50Kj4oZXZlbnQpKTsK IApAQCAtMTg2Miw2ICsxODY4LDcgQEAgaW50IHdlYmtpdFdlYlZpZXdCYXNlUmVuZGVySG9zdEZp bGVEZXNjcmlwdG9yKFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJraXRXZWJWaWV3QmEKIH0KICNlbmRp ZgogCisjaWYgRU5BQkxFKFBPSU5URVJfTE9DSykKIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VSZXF1 ZXN0UG9pbnRlckxvY2soV2ViS2l0V2ViVmlld0Jhc2UqIHdlYlZpZXdCYXNlKQogewogICAgIFdl YktpdFdlYlZpZXdCYXNlUHJpdmF0ZSogcHJpdiA9IHdlYlZpZXdCYXNlLT5wcml2OwpAQCAtMTkw MCw2ICsxOTA3LDcgQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZURpZExvc2VQb2ludGVyTG9jayhX ZWJLaXRXZWJWaWV3QmFzZSogd2ViVmlld0Jhc2UpCiAgICAgcHJpdi0+cG9pbnRlckxvY2tNYW5h Z2VyLT51bmxvY2soKTsKICAgICBwcml2LT5wb2ludGVyTG9ja01hbmFnZXIgPSBudWxscHRyOwog fQorI2VuZGlmCiAKIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VTZXRJbnB1dE1ldGhvZENvbnRleHQo V2ViS2l0V2ViVmlld0Jhc2UqIHdlYlZpZXdCYXNlLCBXZWJLaXRJbnB1dE1ldGhvZENvbnRleHQq IGNvbnRleHQpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUuaAppbmRleCAxZGZlMTgxNmUyNjI4Y2QyOTE3 OTA5YWI4YzI0MDJjYmVjNjk2NWIxLi4yZTQ3Zjc1ODMxODU2ZDk2Zjk0MzVhNzFkOTQzOTE3YWRk ZGUxZmU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dFdlYlZpZXdCYXNlUHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmgKQEAgLTEwNSw4ICsxMDUsMTAgQEAgdm9pZCB3 ZWJraXRXZWJWaWV3QmFzZVNob3dFbW9qaUNob29zZXIoV2ViS2l0V2ViVmlld0Jhc2UqLCBjb25z dCBXZWJDb3JlOjpJbnRSZWMKIGludCB3ZWJraXRXZWJWaWV3QmFzZVJlbmRlckhvc3RGaWxlRGVz Y3JpcHRvcihXZWJLaXRXZWJWaWV3QmFzZSopOwogI2VuZGlmCiAKKyNpZiBFTkFCTEUoUE9JTlRF Ul9MT0NLKQogdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVJlcXVlc3RQb2ludGVyTG9jayhXZWJLaXRX ZWJWaWV3QmFzZSopOwogdm9pZCB3ZWJraXRXZWJWaWV3QmFzZURpZExvc2VQb2ludGVyTG9jayhX ZWJLaXRXZWJWaWV3QmFzZSopOworI2VuZGlmCiAKIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VTZXRJ bnB1dE1ldGhvZENvbnRleHQoV2ViS2l0V2ViVmlld0Jhc2UqLCBXZWJLaXRJbnB1dE1ldGhvZENv bnRleHQqKTsKIFdlYktpdElucHV0TWV0aG9kQ29udGV4dCogd2Via2l0V2ViVmlld0Jhc2VHZXRJ bnB1dE1ldGhvZENvbnRleHQoV2ViS2l0V2ViVmlld0Jhc2UqKTsK