206055 2020-01-10 02:26:14 -0800 Decoding an SVG off the main thread causes a crash 2021-05-03 02:30:18 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 183720 1 clord clord ap cdumez changseok darin dino esprehn+autocc ews-watchlist fmalita gyuyoung.kim pdr sabouhallawa schenney sergio simon.fraser webkit-bug-importer zimmermann oldest_to_newest 1605040 0 clord 2020-01-10 02:26:14 -0800 If you decode an SVG off the main thread via ImageBitmap, this results in a crash. You can test this by enabling offscreen-canvas and running either of these two tests: imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.svg.worker.html imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.zerosource.image.worker.html 1605951 1 simon.fraser 2020-01-13 11:05:20 -0800 None of the SVG code is thread safe. You'll need to bounce to the main thread for SVG. 1755650 2 427409 clord 2021-04-30 05:09:54 -0700 Created attachment 427409 Patch 1755665 3 427409 clord 2021-04-30 06:40:10 -0700 Comment on attachment 427409 Patch ImageBitmap obviously doesn't need an actual SVG document, it was only using Image to get the bitmap data. Instead, use BitmapImage directly and bypass the SVG and PDF document image loaders. 1755743 4 427409 darin 2021-04-30 10:33:11 -0700 Comment on attachment 427409 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427409&action=review > Source/WebCore/html/ImageBitmap.cpp:739 > + auto image = BitmapImage::create(&observer.get()); The better idiom here is observer.ptr(). > Source/WebCore/html/ImageBitmap.cpp:760 > + bitmapData->context().drawImage(image.get(), destRect, sourceRectangle.releaseReturnValue(), { interpolationQualityForResizeQuality(options.resizeQuality), imageOrientationForOrientation(options.imageOrientation) }); Not sure we need ".get()" here. Ref typically converts itself to a reference when passing it as an argument. > Source/WebCore/svg/graphics/SVGImage.cpp:83 > + ASSERT(isMainThread()); Consider also having this assertion in Image::create itself? The assertion without a comment seems a little mysterious; not that I’d want a long comment. 1756118 5 427544 clord 2021-05-03 01:33:46 -0700 Created attachment 427544 Patch 1756127 6 ews-feeder 2021-05-03 02:29:58 -0700 Committed r276895 (237241@main): <https://commits.webkit.org/237241@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427544. 1756128 7 webkit-bug-importer 2021-05-03 02:30:18 -0700 <rdar://problem/77448836> 427409 2021-04-30 05:09:54 -0700 2021-05-03 01:33:40 -0700 Patch bug-206055-20210430130953.patch text/plain 6906 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzVjOWJiYjMxNDJkYjU1 NGQ5MzAwNDg3ZWI5MTc1N2E4ZDVkOWUwNS4uZDNkNWQyMDdkYWJjZDNmNDRhMmZmODBjMGRhOGIw OTk4NmVmZmM3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTA0LTMwICBDaHJp cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBEZWNvZGluZyBhbiBTVkcgb2Zm IHRoZSBtYWluIHRocmVhZCBjYXVzZXMgYSBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MDU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIEJpdG1hcEltYWdlOjpjcmVhdGUgaW5zdGVhZCBv ZiBJbWFnZTo6Y3JlYXRlIGluIEltYWdlQml0bWFwLiBUaGlzCisgICAgICAgIGJ5cGFzc2VzIHVz ZSBvZiBTVkdJbWFnZSBhbmQgUERGRG9jdW1lbnRJbWFnZSwgd2hpY2ggYXJlIG5vdCBzYWZlIHRv CisgICAgICAgIHVzZSBvZmYgdGhlIG1haW4gdGhyZWFkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywgcmViYXNlbGluZWQgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBodG1sL0ltYWdlQml0 bWFwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlQml0bWFwOjpjcmVhdGVGcm9tQnVmZmVy KToKKyAgICAgICAgKiBzdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U1ZHSW1hZ2U6OlNWR0ltYWdlKToKKwogMjAyMS0wNC0yOSAgU2FpZCBBYm91LUhhbGxhd2Eg IDxzYWlkQGFwcGxlLmNvbT4KIAogICAgICAgICBbR1BVIFByb2Nlc3NdIFJFR1JFU1NJT04ocjI3 Mjg4OCk6IERvbid0IGFzc2VydCB0aGUgdmFsaWRpdHkgb2YgdGhlIGRhdGFVUkwgbWltZVR5cGUg aW5zaWRlIEdQVSBQcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0ltYWdl Qml0bWFwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW1hZ2VCaXRtYXAuY3BwCmluZGV4IDcx NjMyY2U4NTI5YWMwYmQ3YTgzNDBmNDUyYzU3NWIzZmRiYjcwZWMuLjYxMTE0OTA5M2YwMWMxZDQ5 NmRmYmMwMWZhMmZkNmM3OWVhMWJmMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SW1hZ2VCaXRtYXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW1hZ2VCaXRtYXAuY3Bw CkBAIC03MzYsMTIgKzczNiw3IEBAIHZvaWQgSW1hZ2VCaXRtYXA6OmNyZWF0ZUZyb21CdWZmZXIo U2NyaXB0RXhlY3V0aW9uQ29udGV4dCYgc2NyaXB0RXhlY3V0aW9uQ29udGV4CiAKICAgICBhdXRv IHNoYXJlZEJ1ZmZlciA9IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlKHN0YXRpY19jYXN0PGNvbnN0IGNo YXIqPihhcnJheUJ1ZmZlci0+ZGF0YSgpKSwgYXJyYXlCdWZmZXItPmJ5dGVMZW5ndGgoKSk7CiAg ICAgYXV0byBvYnNlcnZlciA9IEltYWdlQml0bWFwSW1hZ2VPYnNlcnZlcjo6Y3JlYXRlKG1pbWVU eXBlLCBleHBlY3RlZENvbnRlbnRMZW5ndGgsIHNvdXJjZVVSTCk7Ci0gICAgYXV0byBpbWFnZSA9 IEltYWdlOjpjcmVhdGUob2JzZXJ2ZXIuZ2V0KCkpOwotICAgIGlmICghaW1hZ2UpIHsKLSAgICAg ICAgcHJvbWlzZS5yZWplY3QoSW52YWxpZFN0YXRlRXJyb3IsICJUaGUgdHlwZSBvZiB0aGUgYXJn dW1lbnQgdG8gY3JlYXRlSW1hZ2VCaXRtYXAgaXMgbm90IHN1cHBvcnRlZCIpOwotICAgICAgICBy ZXR1cm47Ci0gICAgfQotCisgICAgYXV0byBpbWFnZSA9IEJpdG1hcEltYWdlOjpjcmVhdGUoJm9i c2VydmVyLmdldCgpKTsKICAgICBhdXRvIHJlc3VsdCA9IGltYWdlLT5zZXREYXRhKHNoYXJlZEJ1 ZmZlci5jb3B5UmVmKCksIHRydWUpOwogICAgIGlmIChyZXN1bHQgIT0gRW5jb2RlZERhdGFTdGF0 dXM6OkNvbXBsZXRlKSB7CiAgICAgICAgIHByb21pc2UucmVqZWN0KEludmFsaWRTdGF0ZUVycm9y LCAiQ2Fubm90IGRlY29kZSB0aGUgZGF0YSBpbiB0aGUgYXJndW1lbnQgdG8gY3JlYXRlSW1hZ2VC aXRtYXAiKTsKQEAgLTc2Miw3ICs3NTcsNyBAQCB2b2lkIEltYWdlQml0bWFwOjpjcmVhdGVGcm9t QnVmZmVyKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQmIHNjcmlwdEV4ZWN1dGlvbkNvbnRleAogICAg IH0KIAogICAgIEZsb2F0UmVjdCBkZXN0UmVjdChGbG9hdFBvaW50KCksIG91dHB1dFNpemUpOwot ICAgIGJpdG1hcERhdGEtPmNvbnRleHQoKS5kcmF3SW1hZ2UoKmltYWdlLCBkZXN0UmVjdCwgc291 cmNlUmVjdGFuZ2xlLnJlbGVhc2VSZXR1cm5WYWx1ZSgpLCB7IGludGVycG9sYXRpb25RdWFsaXR5 Rm9yUmVzaXplUXVhbGl0eShvcHRpb25zLnJlc2l6ZVF1YWxpdHkpLCBpbWFnZU9yaWVudGF0aW9u Rm9yT3JpZW50YXRpb24ob3B0aW9ucy5pbWFnZU9yaWVudGF0aW9uKSB9KTsKKyAgICBiaXRtYXBE YXRhLT5jb250ZXh0KCkuZHJhd0ltYWdlKGltYWdlLmdldCgpLCBkZXN0UmVjdCwgc291cmNlUmVj dGFuZ2xlLnJlbGVhc2VSZXR1cm5WYWx1ZSgpLCB7IGludGVycG9sYXRpb25RdWFsaXR5Rm9yUmVz aXplUXVhbGl0eShvcHRpb25zLnJlc2l6ZVF1YWxpdHkpLCBpbWFnZU9yaWVudGF0aW9uRm9yT3Jp ZW50YXRpb24ob3B0aW9ucy5pbWFnZU9yaWVudGF0aW9uKSB9KTsKIAogICAgIE9wdGlvblNldDxT ZXJpYWxpemF0aW9uU3RhdGU+IHNlcmlhbGl6YXRpb25TdGF0ZSA9IFNlcmlhbGl6YXRpb25TdGF0 ZTo6T3JpZ2luQ2xlYW47CiAgICAgaWYgKGFscGhhUHJlbXVsdGlwbGljYXRpb25Gb3JQcmVtdWx0 aXBseUFscGhhKG9wdGlvbnMucHJlbXVsdGlwbHlBbHBoYSkgPT0gQWxwaGFQcmVtdWx0aXBsaWNh dGlvbjo6UHJlbXVsdGlwbGllZCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFw aGljcy9TVkdJbWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2Uu Y3BwCmluZGV4IGNlMDg3MDE4ZjgyNTgyZThiMDM2NDg4YjE0NjJiZTAzN2RlOWE1YjguLjc2YzRi NzJlZDZiZWM0OGM0ZDkyNTQ2OGJmZWM2NjIxYzNjM2NhMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3Zn L2dyYXBoaWNzL1NWR0ltYWdlLmNwcApAQCAtODAsNiArODAsNyBAQCBTVkdJbWFnZTo6U1ZHSW1h Z2UoSW1hZ2VPYnNlcnZlciYgb2JzZXJ2ZXIpCiAgICAgOiBJbWFnZSgmb2JzZXJ2ZXIpCiAgICAg LCBtX3N0YXJ0QW5pbWF0aW9uVGltZXIoKnRoaXMsICZTVkdJbWFnZTo6c3RhcnRBbmltYXRpb25U aW1lckZpcmVkKQogeworICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CiB9CiAKIFNWR0ltYWdl Ojp+U1ZHSW1hZ2UoKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDZjMzljMjQ4ZTdiNTE3YjFiOTYyMGM1ZDVjMzU2MjI4NjE1 OGEyYTMuLjg4Mzg1OTM5Y2U5YjhkMTZhZWQ2Y2I2OGI1YTJkNjRjZTEwMWY2MTEgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAyMS0wNC0zMCAgQ2hyaXMgTG9yZCAgPGNsb3JkQGlnYWxpYS5jb20+ CisKKyAgICAgICAgRGVjb2RpbmcgYW4gU1ZHIG9mZiB0aGUgbWFpbiB0aHJlYWQgY2F1c2VzIGEg Y3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NjA1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVu YWJsZSBPZmZzY3JlZW5DYW52YXMgU1ZHIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ2xp Yi9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDIxLTA0LTI4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25f aHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIENvYWxlc2NlIGFkamFjZW50IHNlbGVj dGlvbiBnZW9tZXRyaWVzIHdoZW4gcmVuZGVyaW5nIGluZGl2aWR1YWwgc2VsZWN0aW9uIHF1YWRz CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCBjMDdiNGVkMDgyNmQ5YWYwZTJiM2Y2 YmM2MjhlZTdhYmFlNzViYmJiLi45ZWFjYTgyNmRjOTI4ODk5OTMzZTkzMDYyMWJlNzAyNzZjODQw NDEwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAy MS0wNC0zMCAgQ2hyaXMgTG9yZCAgPGNsb3JkQGlnYWxpYS5jb20+CisKKyAgICAgICAgRGVjb2Rp bmcgYW4gU1ZHIG9mZiB0aGUgbWFpbiB0aHJlYWQgY2F1c2VzIGEgY3Jhc2gKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjA1NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlYmFzZWxpbmUgT2Zmc2NyZWVu Q2FudmFzIFNWRyB0ZXN0cy4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2Nh bnZhcy9vZmZzY3JlZW4vZHJhd2luZy1pbWFnZXMtdG8tdGhlLWNhbnZhcy8yZC5kcmF3SW1hZ2Uu emVyb3NvdXJjZS5pbWFnZS53b3JrZXItZXhwZWN0ZWQudHh0OgorCiAyMDIxLTA0LTI4ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgW2FzcGVjdC1yYXRpb10gVHJlYXQg Ym9yZGVyL3BhZGRpbmcgY29ycmVjdGx5IGZvciBib3gtc2l6aW5nOiBib3JkZXItYm94CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwv Y2FudmFzL29mZnNjcmVlbi9kcmF3aW5nLWltYWdlcy10by10aGUtY2FudmFzLzJkLmRyYXdJbWFn ZS56ZXJvc291cmNlLmltYWdlLndvcmtlci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvY2FudmFzL29mZnNjcmVlbi9kcmF3aW5n LWltYWdlcy10by10aGUtY2FudmFzLzJkLmRyYXdJbWFnZS56ZXJvc291cmNlLmltYWdlLndvcmtl ci1leHBlY3RlZC50eHQKaW5kZXggY2M0ZTBhMDA3NmEyNzdkYTJhZjc5NWY1MjYwNjJjYzM0MWY5 NzAwNC4uNjk5NmY1MTQxYmEyOTk4MjAyNDQ0MjhlMjc5ZTE5NTA0MWI2ZWRmMCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZh cy9vZmZzY3JlZW4vZHJhd2luZy1pbWFnZXMtdG8tdGhlLWNhbnZhcy8yZC5kcmF3SW1hZ2UuemVy b3NvdXJjZS5pbWFnZS53b3JrZXItZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9jYW52YXMvb2Zmc2NyZWVuL2RyYXdpbmct aW1hZ2VzLXRvLXRoZS1jYW52YXMvMmQuZHJhd0ltYWdlLnplcm9zb3VyY2UuaW1hZ2Uud29ya2Vy LWV4cGVjdGVkLnR4dApAQCAtMSwzICsxLDMgQEAKIAotUEFTUyBkcmF3SW1hZ2Ugd2l0aCB6ZXJv LXNpemVkIHNvdXJjZSByZWN0YW5nbGUgZnJvbSBpbWFnZSB0aHJvd3MgSU5ERVhfU0laRV9FUlIK K1BBU1MgZHJhd0ltYWdlIHdpdGggemVyby1zaXplZCBzb3VyY2UgcmVjdGFuZ2xlIGZyb20gaW1h Z2UgZHJhd3Mgbm90aGluZyB3aXRob3V0IGV4Y2VwdGlvbgogCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggOGNiZTdiZTI5Mzk5OWEyYTI0MDJjY2MyNTE0 YTFiZThlYWUyMGJkYy4uYjUxNTc3MTQzMzdjYjJiY2EzM2Y0Y2RkZGZlYzY2OWZjZTMxOWQyMyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ2xpYi9UZXN0RXhwZWN0YXRpb25zCisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNzEwLDgg KzcxMCw2IEBAIHdlYmtpdC5vcmcvYi8yMjQxMTEgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9tYXRobWwvcHJlc2VudGF0aW9uLW1hcmt1cC9vCiB3ZWJraXQub3JnL2IvMjAzMTQ2IGZh c3QvY2FudmFzL29mZnNjcmVlbi1lbmFibGVkLmh0bWwgWyBQYXNzIF0KIHdlYmtpdC5vcmcvYi8y MDMxNDYgaHR0cC93cHQvb2Zmc2NyZWVuLWNhbnZhcyBbIFBhc3MgXQogd2Via2l0Lm9yZy9iLzIw MzE0NiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvY2FudmFzL29mZnNjcmVl biBbIFBhc3MgXQotd2Via2l0Lm9yZy9iLzIwNjA1NSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2h0bWwvY2FudmFzL29mZnNjcmVlbi9kcmF3aW5nLWltYWdlcy10by10aGUtY2FudmFz LzJkLmRyYXdJbWFnZS5zdmcud29ya2VyLmh0bWwgWyBTa2lwIF0KLXdlYmtpdC5vcmcvYi8yMDYw NTUgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4v ZHJhd2luZy1pbWFnZXMtdG8tdGhlLWNhbnZhcy8yZC5kcmF3SW1hZ2UuemVyb3NvdXJjZS5pbWFn ZS53b3JrZXIuaHRtbCBbIFNraXAgXQogCiAjIENvbnNvbGUgbG9nIGxpbmVzIG1heSBhcHBlYXIg aW4gYSBkaWZmZXJlbnQgb3JkZXIgc28gd2Ugc2lsZW5jZSB0aGVtLgogaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vY29udmVydC10by1ibG9iL29m ZnNjcmVlbmNhbnZhcy5jb252ZXJ0LnRvLmJsb2Iudy5odG1sIFsgRHVtcEpTQ29uc29sZUxvZ0lu U3RkRXJyIF0K 427544 2021-05-03 01:33:46 -0700 2021-05-03 02:30:00 -0700 Patch bug-206055-20210503093344.patch text/plain 7160 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzVjOWJiYjMxNDJkYjU1 NGQ5MzAwNDg3ZWI5MTc1N2E4ZDVkOWUwNS4uODY5NTI2NzNiZjAxZTVjZGQ2NDQ3Yjg1Y2NhM2Q1 ZWYyODVjNTRmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTA0LTMwICBDaHJp cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBEZWNvZGluZyBhbiBTVkcgb2Zm IHRoZSBtYWluIHRocmVhZCBjYXVzZXMgYSBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MDU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCisKKyAgICAgICAgVXNlIEJpdG1hcEltYWdlOjpjcmVhdGUgaW5zdGVhZCBvZiBJ bWFnZTo6Y3JlYXRlIGluIEltYWdlQml0bWFwLiBUaGlzCisgICAgICAgIGJ5cGFzc2VzIHVzZSBv ZiBTVkdJbWFnZSBhbmQgUERGRG9jdW1lbnRJbWFnZSwgd2hpY2ggYXJlIG5vdCBzYWZlIHRvCisg ICAgICAgIHVzZSBvZmYgdGhlIG1haW4gdGhyZWFkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg cmViYXNlbGluZWQgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBodG1sL0ltYWdlQml0bWFw LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlQml0bWFwOjpjcmVhdGVGcm9tQnVmZmVyKToK KyAgICAgICAgICBVc2UgQml0bWFwSW1hZ2UgaW5zdGVhZCBvZiBJbWFnZS4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlOjpj cmVhdGUpOgorICAgICAgICAgIEFkZCBtYWluLXRocmVhZCBhc3NlcnQgb24gSW1hZ2UgY3JlYXRp b24uCisKIDIwMjEtMDQtMjkgIFNhaWQgQWJvdS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CiAK ICAgICAgICAgW0dQVSBQcm9jZXNzXSBSRUdSRVNTSU9OKHIyNzI4ODgpOiBEb24ndCBhc3NlcnQg dGhlIHZhbGlkaXR5IG9mIHRoZSBkYXRhVVJMIG1pbWVUeXBlIGluc2lkZSBHUFUgUHJvY2Vzcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZUJpdG1hcC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0ltYWdlQml0bWFwLmNwcAppbmRleCA3MTYzMmNlODUyOWFjMGJkN2E4MzQw ZjQ1MmM1NzViM2ZkYmI3MGVjLi5iOGE5MDU0YWIwZjUzNDdkMDAxYTE4MzMxODQ0MjlkNDYyNDRk ZGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0ltYWdlQml0bWFwLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ltYWdlQml0bWFwLmNwcApAQCAtNzM2LDEyICs3MzYsNyBA QCB2b2lkIEltYWdlQml0bWFwOjpjcmVhdGVGcm9tQnVmZmVyKFNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQmIHNjcmlwdEV4ZWN1dGlvbkNvbnRleAogCiAgICAgYXV0byBzaGFyZWRCdWZmZXIgPSBTaGFy ZWRCdWZmZXI6OmNyZWF0ZShzdGF0aWNfY2FzdDxjb25zdCBjaGFyKj4oYXJyYXlCdWZmZXItPmRh dGEoKSksIGFycmF5QnVmZmVyLT5ieXRlTGVuZ3RoKCkpOwogICAgIGF1dG8gb2JzZXJ2ZXIgPSBJ bWFnZUJpdG1hcEltYWdlT2JzZXJ2ZXI6OmNyZWF0ZShtaW1lVHlwZSwgZXhwZWN0ZWRDb250ZW50 TGVuZ3RoLCBzb3VyY2VVUkwpOwotICAgIGF1dG8gaW1hZ2UgPSBJbWFnZTo6Y3JlYXRlKG9ic2Vy dmVyLmdldCgpKTsKLSAgICBpZiAoIWltYWdlKSB7Ci0gICAgICAgIHByb21pc2UucmVqZWN0KElu dmFsaWRTdGF0ZUVycm9yLCAiVGhlIHR5cGUgb2YgdGhlIGFyZ3VtZW50IHRvIGNyZWF0ZUltYWdl Qml0bWFwIGlzIG5vdCBzdXBwb3J0ZWQiKTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQorICAg IGF1dG8gaW1hZ2UgPSBCaXRtYXBJbWFnZTo6Y3JlYXRlKG9ic2VydmVyLnB0cigpKTsKICAgICBh dXRvIHJlc3VsdCA9IGltYWdlLT5zZXREYXRhKHNoYXJlZEJ1ZmZlci5jb3B5UmVmKCksIHRydWUp OwogICAgIGlmIChyZXN1bHQgIT0gRW5jb2RlZERhdGFTdGF0dXM6OkNvbXBsZXRlKSB7CiAgICAg ICAgIHByb21pc2UucmVqZWN0KEludmFsaWRTdGF0ZUVycm9yLCAiQ2Fubm90IGRlY29kZSB0aGUg ZGF0YSBpbiB0aGUgYXJndW1lbnQgdG8gY3JlYXRlSW1hZ2VCaXRtYXAiKTsKQEAgLTc2Miw3ICs3 NTcsNyBAQCB2b2lkIEltYWdlQml0bWFwOjpjcmVhdGVGcm9tQnVmZmVyKFNjcmlwdEV4ZWN1dGlv bkNvbnRleHQmIHNjcmlwdEV4ZWN1dGlvbkNvbnRleAogICAgIH0KIAogICAgIEZsb2F0UmVjdCBk ZXN0UmVjdChGbG9hdFBvaW50KCksIG91dHB1dFNpemUpOwotICAgIGJpdG1hcERhdGEtPmNvbnRl eHQoKS5kcmF3SW1hZ2UoKmltYWdlLCBkZXN0UmVjdCwgc291cmNlUmVjdGFuZ2xlLnJlbGVhc2VS ZXR1cm5WYWx1ZSgpLCB7IGludGVycG9sYXRpb25RdWFsaXR5Rm9yUmVzaXplUXVhbGl0eShvcHRp b25zLnJlc2l6ZVF1YWxpdHkpLCBpbWFnZU9yaWVudGF0aW9uRm9yT3JpZW50YXRpb24ob3B0aW9u cy5pbWFnZU9yaWVudGF0aW9uKSB9KTsKKyAgICBiaXRtYXBEYXRhLT5jb250ZXh0KCkuZHJhd0lt YWdlKGltYWdlLCBkZXN0UmVjdCwgc291cmNlUmVjdGFuZ2xlLnJlbGVhc2VSZXR1cm5WYWx1ZSgp LCB7IGludGVycG9sYXRpb25RdWFsaXR5Rm9yUmVzaXplUXVhbGl0eShvcHRpb25zLnJlc2l6ZVF1 YWxpdHkpLCBpbWFnZU9yaWVudGF0aW9uRm9yT3JpZW50YXRpb24ob3B0aW9ucy5pbWFnZU9yaWVu dGF0aW9uKSB9KTsKIAogICAgIE9wdGlvblNldDxTZXJpYWxpemF0aW9uU3RhdGU+IHNlcmlhbGl6 YXRpb25TdGF0ZSA9IFNlcmlhbGl6YXRpb25TdGF0ZTo6T3JpZ2luQ2xlYW47CiAgICAgaWYgKGFs cGhhUHJlbXVsdGlwbGljYXRpb25Gb3JQcmVtdWx0aXBseUFscGhhKG9wdGlvbnMucHJlbXVsdGlw bHlBbHBoYSkgPT0gQWxwaGFQcmVtdWx0aXBsaWNhdGlvbjo6UHJlbXVsdGlwbGllZCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmNwcAppbmRleCAzMDMwMjhmNDFmMGNh Y2ZmMjllNjg2NTRmMTdlNzRjMDViNmFjNTg5Li40NDBmNzI1MzU4MmNjNjQ5MzE1ZjI0NzNiMzkw MzIyYjBhNjYyMDg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9JbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2Uu Y3BwCkBAIC02NCw2ICs2NCwxMCBAQCBJbWFnZSYgSW1hZ2U6Om51bGxJbWFnZSgpCiAKIFJlZlB0 cjxJbWFnZT4gSW1hZ2U6OmNyZWF0ZShJbWFnZU9ic2VydmVyJiBvYnNlcnZlcikKIHsKKyAgICAv LyBTVkdJbWFnZSBhbmQgUERGRG9jdW1lbnRJbWFnZSBhcmUgbm90IHNhZmUgdG8gdXNlIG9mZiB0 aGUgbWFpbiB0aHJlYWQuCisgICAgLy8gV29ya2VycyBjYW4gdXNlIEJpdG1hcEltYWdlIGRpcmVj dGx5LgorICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CisKICAgICBhdXRvIG1pbWVUeXBlID0g b2JzZXJ2ZXIubWltZVR5cGUoKTsKICAgICBpZiAobWltZVR5cGUgPT0gImltYWdlL3N2Zyt4bWwi KQogICAgICAgICByZXR1cm4gU1ZHSW1hZ2U6OmNyZWF0ZShvYnNlcnZlcik7CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNmMz OWMyNDhlN2I1MTdiMWI5NjIwYzVkNWMzNTYyMjg2MTU4YTJhMy4uYzcyYjUwNjQwODM0ZmI0OGRj YWQwYmY0MzNkZjU4ZDc2YWQ3ZDdlMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA0LTMw ICBDaHJpcyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBEZWNvZGluZyBhbiBT Vkcgb2ZmIHRoZSBtYWluIHRocmVhZCBjYXVzZXMgYSBjcmFzaAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MDU1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgRW5hYmxlIE9mZnNjcmVlbkNhbnZhcyBTVkcgdGVz dHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMjEt MDQtMjggIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAg W2lPU10gQ29hbGVzY2UgYWRqYWNlbnQgc2VsZWN0aW9uIGdlb21ldHJpZXMgd2hlbiByZW5kZXJp bmcgaW5kaXZpZHVhbCBzZWxlY3Rpb24gcXVhZHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9n CmluZGV4IGMwN2I0ZWQwODI2ZDlhZjBlMmIzZjZiYzYyOGVlN2FiYWU3NWJiYmIuLjBmYzRlODk5 MDk0Y2VmMWY3ODliYjU3ODFmYjA4MmU3ZjEyMTZkOGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0No YW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA0LTMwICBDaHJpcyBMb3JkICA8Y2xvcmRA aWdhbGlhLmNvbT4KKworICAgICAgICBEZWNvZGluZyBhbiBTVkcgb2ZmIHRoZSBtYWluIHRocmVh ZCBjYXVzZXMgYSBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA2MDU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAg ICAgICAgUmViYXNlbGluZSBPZmZzY3JlZW5DYW52YXMgU1ZHIHRlc3RzLgorCisgICAgICAgICog d2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvY2FudmFzL29mZnNjcmVlbi9kcmF3aW5nLWltYWdlcy10 by10aGUtY2FudmFzLzJkLmRyYXdJbWFnZS56ZXJvc291cmNlLmltYWdlLndvcmtlci1leHBlY3Rl ZC50eHQ6CisKIDIwMjEtMDQtMjggIFJvYiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbYXNwZWN0LXJhdGlvXSBUcmVhdCBib3JkZXIvcGFkZGluZyBjb3JyZWN0bHkgZm9yIGJv eC1zaXppbmc6IGJvcmRlci1ib3gKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9jYW52YXMvb2Zmc2NyZWVuL2RyYXdpbmctaW1hZ2Vz LXRvLXRoZS1jYW52YXMvMmQuZHJhd0ltYWdlLnplcm9zb3VyY2UuaW1hZ2Uud29ya2VyLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRt bC9jYW52YXMvb2Zmc2NyZWVuL2RyYXdpbmctaW1hZ2VzLXRvLXRoZS1jYW52YXMvMmQuZHJhd0lt YWdlLnplcm9zb3VyY2UuaW1hZ2Uud29ya2VyLWV4cGVjdGVkLnR4dAppbmRleCBjYzRlMGEwMDc2 YTI3N2RhMmFmNzk1ZjUyNjA2MmNjMzQxZjk3MDA0Li42OTk2ZjUxNDFiYTI5OTgyMDI0NDQyOGUy NzllMTk1MDQxYjZlZGYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2h0bWwvY2FudmFzL29mZnNjcmVlbi9kcmF3aW5nLWltYWdlcy10by10 aGUtY2FudmFzLzJkLmRyYXdJbWFnZS56ZXJvc291cmNlLmltYWdlLndvcmtlci1leHBlY3RlZC50 eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1s L2NhbnZhcy9vZmZzY3JlZW4vZHJhd2luZy1pbWFnZXMtdG8tdGhlLWNhbnZhcy8yZC5kcmF3SW1h Z2UuemVyb3NvdXJjZS5pbWFnZS53b3JrZXItZXhwZWN0ZWQudHh0CkBAIC0xLDMgKzEsMyBAQAog Ci1QQVNTIGRyYXdJbWFnZSB3aXRoIHplcm8tc2l6ZWQgc291cmNlIHJlY3RhbmdsZSBmcm9tIGlt YWdlIHRocm93cyBJTkRFWF9TSVpFX0VSUgorUEFTUyBkcmF3SW1hZ2Ugd2l0aCB6ZXJvLXNpemVk IHNvdXJjZSByZWN0YW5nbGUgZnJvbSBpbWFnZSBkcmF3cyBub3RoaW5nIHdpdGhvdXQgZXhjZXB0 aW9uCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0 aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA4 Y2JlN2JlMjkzOTk5YTJhMjQwMmNjYzI1MTRhMWJlOGVhZTIwYmRjLi5iNTE1NzcxNDMzN2NiMmJj YTMzZjRjZGRkZmVjNjY5ZmNlMzE5ZDIzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ2xpYi9U ZXN0RXhwZWN0YXRpb25zCkBAIC03MTAsOCArNzEwLDYgQEAgd2Via2l0Lm9yZy9iLzIyNDExMSBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21hdGhtbC9wcmVzZW50YXRpb24tbWFya3Vw L28KIHdlYmtpdC5vcmcvYi8yMDMxNDYgZmFzdC9jYW52YXMvb2Zmc2NyZWVuLWVuYWJsZWQuaHRt bCBbIFBhc3MgXQogd2Via2l0Lm9yZy9iLzIwMzE0NiBodHRwL3dwdC9vZmZzY3JlZW4tY2FudmFz IFsgUGFzcyBdCiB3ZWJraXQub3JnL2IvMjAzMTQ2IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvaHRtbC9jYW52YXMvb2Zmc2NyZWVuIFsgUGFzcyBdCi13ZWJraXQub3JnL2IvMjA2MDU1 IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9jYW52YXMvb2Zmc2NyZWVuL2Ry YXdpbmctaW1hZ2VzLXRvLXRoZS1jYW52YXMvMmQuZHJhd0ltYWdlLnN2Zy53b3JrZXIuaHRtbCBb IFNraXAgXQotd2Via2l0Lm9yZy9iLzIwNjA1NSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2h0bWwvY2FudmFzL29mZnNjcmVlbi9kcmF3aW5nLWltYWdlcy10by10aGUtY2FudmFzLzJk LmRyYXdJbWFnZS56ZXJvc291cmNlLmltYWdlLndvcmtlci5odG1sIFsgU2tpcCBdCiAKICMgQ29u c29sZSBsb2cgbGluZXMgbWF5IGFwcGVhciBpbiBhIGRpZmZlcmVudCBvcmRlciBzbyB3ZSBzaWxl bmNlIHRoZW0uCiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvY2FudmFzL29m ZnNjcmVlbi9jb252ZXJ0LXRvLWJsb2Ivb2Zmc2NyZWVuY2FudmFzLmNvbnZlcnQudG8uYmxvYi53 Lmh0bWwgWyBEdW1wSlNDb25zb2xlTG9nSW5TdGRFcnIgXQo=