206036 2020-01-09 14:13:36 -0800 [WTF] Make MediaTime constructor constexpr 2020-01-14 07:56:15 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aboya aboya aperez benjamin cdumez cmarcelo commit-queue dbates ddkilzer eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1604851 0 aboya 2020-01-09 14:13:36 -0800 https://bugs.webkit.org/show_bug.cgi?id=205723 allowed to declare MediaTime variables as static inside functions without needing a global destructor. It did not eliminate the call to the MediaTime constructor on runtime though. This wasn't a problem for static variables inside functions, as the compiler adds a guard variable to call the constructor the first time the function is called. On the other hand, for variables defined outside of the scope of the function, for them to be initialized the MediaTime constructor would have to be called at runtime from a global constructor, something we're trying to avoid and which generates an error in clang. But again, MediaTime is a simple class with only integral values, we shouldn't need a runtime function call to initialize it! This patch makes the MediaTime constructor constexpr so that we don't need runtime initialization for static MediaTime variables. This allows us to declare them outside functions and enables the compiler to generate code without guard variables when static MediaTime variables are declared inside functions. A test has been added accessing a global const static MediaTime. The build should not produce any error stating the need for a global constructor. 1604914 1 387286 aboya 2020-01-09 16:10:18 -0800 Created attachment 387286 Patch 1605846 2 387527 aboya 2020-01-13 08:07:33 -0800 Created attachment 387527 Patch 1606360 3 387527 aperez 2020-01-14 06:09:45 -0800 Comment on attachment 387527 Patch Nice one :) 1606372 4 commit-queue 2020-01-14 07:21:50 -0800 The commit-queue encountered the following flaky tests while processing attachment 387527: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1606373 5 387527 commit-queue 2020-01-14 07:22:25 -0800 Comment on attachment 387527 Patch Clearing flags on attachment: 387527 Committed r254509: <https://trac.webkit.org/changeset/254509> 1606374 6 commit-queue 2020-01-14 07:22:26 -0800 All reviewed patches have been landed. Closing bug. 1606375 7 webkit-bug-importer 2020-01-14 07:23:14 -0800 <rdar://problem/58567175> 1606380 8 387527 ddkilzer 2020-01-14 07:35:57 -0800 Comment on attachment 387527 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387527&action=review > Source/WTF/ChangeLog:15 > + It did not eliminate the call to the MediaTime constructor on runtime > + though. This wasn't a problem for static variables inside functions, > + as the compiler adds a guard variable to call the constructor the > + first time the function is called. Note that Apple ports DISABLE thread-safe static variable initialization for performance reasons, so this statement may not be true for all ports. This Xcode variable is turned into a compiler switch that disables them: GCC_THREADSAFE_STATICS = NO; 1606391 9 387527 aboya 2020-01-14 07:56:15 -0800 Comment on attachment 387527 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387527&action=review >> Source/WTF/ChangeLog:15 >> + first time the function is called. > > Note that Apple ports DISABLE thread-safe static variable initialization for performance reasons, so this statement may not be true for all ports. > > This Xcode variable is turned into a compiler switch that disables them: > > GCC_THREADSAFE_STATICS = NO; Well, the guard variable would (if it were not for this patch) still be there, as the initialization would still be delayed to runtime... it would just be checked and set in a non thread-safe way. 387286 2020-01-09 16:10:18 -0800 2020-01-13 08:07:29 -0800 Patch bug-206036-20200110011016.patch text/plain 6056 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQyM2NiMGI2M2QyMTk2ZDhiYzZlZjg1 OWRjNTAxYzBkNTM4ZmQyZjguLjlhMzQ2YmNhM2QyYmQ4Y2VhNjc4ZGY4NWQ1Y2NiNWFkMTkzOTU4 OTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsNDEgQEAKKzIwMjAtMDEtMDkgIEFsaWNpYSBCb3lhIEdhcmPDrWEg IDxhYm95YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXVEZdIE1ha2UgTWVkaWFUaW1lIGNvbnN0 cnVjdG9yIGNvbnN0ZXhwcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA2MDM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTcyMyBh bGxvd2VkIHRvIGRlY2xhcmUKKyAgICAgICAgTWVkaWFUaW1lIHZhcmlhYmxlcyBhcyBzdGF0aWMg aW5zaWRlIGZ1bmN0aW9ucyB3aXRob3V0IG5lZWRpbmcgYQorICAgICAgICBnbG9iYWwgZGVzdHJ1 Y3Rvci4KKworICAgICAgICBJdCBkaWQgbm90IGVsaW1pbmF0ZSB0aGUgY2FsbCB0byB0aGUgTWVk aWFUaW1lIGNvbnN0cnVjdG9yIG9uIHJ1bnRpbWUKKyAgICAgICAgdGhvdWdoLiBUaGlzIHdhc24n dCBhIHByb2JsZW0gZm9yIHN0YXRpYyB2YXJpYWJsZXMgaW5zaWRlIGZ1bmN0aW9ucywKKyAgICAg ICAgYXMgdGhlIGNvbXBpbGVyIGFkZHMgYSBndWFyZCB2YXJpYWJsZSB0byBjYWxsIHRoZSBjb25z dHJ1Y3RvciB0aGUKKyAgICAgICAgZmlyc3QgdGltZSB0aGUgZnVuY3Rpb24gaXMgY2FsbGVkLgor CisgICAgICAgIE9uIHRoZSBvdGhlciBoYW5kLCBmb3IgdmFyaWFibGVzIGRlZmluZWQgb3V0c2lk ZSBvZiB0aGUgc2NvcGUgb2YgdGhlCisgICAgICAgIGZ1bmN0aW9uLCBmb3IgdGhlbSB0byBiZSBp bml0aWFsaXplZCB0aGUgTWVkaWFUaW1lIGNvbnN0cnVjdG9yIHdvdWxkCisgICAgICAgIGhhdmUg dG8gYmUgY2FsbGVkIGF0IHJ1bnRpbWUgZnJvbSBhIGdsb2JhbCBjb25zdHJ1Y3Rvciwgc29tZXRo aW5nCisgICAgICAgIHdlJ3JlIHRyeWluZyB0byBhdm9pZCBhbmQgd2hpY2ggZ2VuZXJhdGVzIGFu IGVycm9yIGluIGNsYW5nLgorCisgICAgICAgIEJ1dCBhZ2FpbiwgTWVkaWFUaW1lIGlzIGEgc2lt cGxlIGNsYXNzIHdpdGggb25seSBpbnRlZ3JhbCB2YWx1ZXMsIHdlCisgICAgICAgIHNob3VsZG4n dCBuZWVkIGEgcnVudGltZSBmdW5jdGlvbiBjYWxsIHRvIGluaXRpYWxpemUgaXQhCisKKyAgICAg ICAgVGhpcyBwYXRjaCBtYWtlcyB0aGUgTWVkaWFUaW1lIGNvbnN0cnVjdG9yIGNvbnN0ZXhwciBz byB0aGF0IHdlIGRvbid0CisgICAgICAgIG5lZWQgcnVudGltZSBpbml0aWFsaXphdGlvbiBmb3Ig c3RhdGljIE1lZGlhVGltZSB2YXJpYWJsZXMuIFRoaXMKKyAgICAgICAgYWxsb3dzIHVzIHRvIGRl Y2xhcmUgdGhlbSBvdXRzaWRlIGZ1bmN0aW9ucyBhbmQgZW5hYmxlcyB0aGUgY29tcGlsZXIKKyAg ICAgICAgdG8gZ2VuZXJhdGUgY29kZSB3aXRob3V0IGd1YXJkIHZhcmlhYmxlcyB3aGVuIHN0YXRp YyBNZWRpYVRpbWUKKyAgICAgICAgdmFyaWFibGVzIGFyZSBkZWNsYXJlZCBpbnNpZGUgZnVuY3Rp b25zLgorCisgICAgICAgIEEgdGVzdCBoYXMgYmVlbiBhZGRlZCBhY2Nlc3NpbmcgYSBnbG9iYWwg Y29uc3Qgc3RhdGljIE1lZGlhVGltZS4gVGhlCisgICAgICAgIGJ1aWxkIHNob3VsZCBub3QgcHJv ZHVjZSBhbnkgZXJyb3Igc3RhdGluZyB0aGUgbmVlZCBmb3IgYSBnbG9iYWwKKyAgICAgICAgY29u c3RydWN0b3IuCisKKyAgICAgICAgKiB3dGYvTWVkaWFUaW1lLmNwcDoKKyAgICAgICAgKiB3dGYv TWVkaWFUaW1lLmg6CisgICAgICAgIChXVEY6Ok1lZGlhVGltZTo6TWVkaWFUaW1lKToKKwogMjAy MC0wMS0wOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFJl ZHVjZSBiaW5hcnkgc2l6ZSBieSBwdXJnaW5nIEMrKyB0eXBlIGluZm9ybWF0aW9uIGluIE9iamVj dGl2ZS1DIGZpZWxkcyBhbmQgcGFyYW1ldGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv TWVkaWFUaW1lLmNwcCBiL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5jcHAKaW5kZXggODlkMmFi NzMzZDc2ZDZkODdlNjc5MTg4N2EwOWNkZmUwZDUwZWUxNS4uYTNmNjI1MmYxZTlmM2E0ZjBhMTM1 NzIzNDJjMDYwZTAxMzA1NmY2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWVkaWFUaW1l LmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9NZWRpYVRpbWUuY3BwCkBAIC03MiwyNCArNzIsNiBA QCBzdGF0aWMgaW50NjRfdCBzaWdudW0oaW50NjRfdCB2YWwpCiAKIGNvbnN0IHVpbnQzMl90IE1l ZGlhVGltZTo6TWF4aW11bVRpbWVTY2FsZSA9IDEwMDAwMDAwMDA7CiAKLU1lZGlhVGltZTo6TWVk aWFUaW1lKCkKLSAgICA6IG1fdGltZVZhbHVlKDApCi0gICAgLCBtX3RpbWVTY2FsZShEZWZhdWx0 VGltZVNjYWxlKQotICAgICwgbV90aW1lRmxhZ3MoVmFsaWQpCi17Ci19Ci0KLU1lZGlhVGltZTo6 TWVkaWFUaW1lKGludDY0X3QgdmFsdWUsIHVpbnQzMl90IHNjYWxlLCB1aW50OF90IGZsYWdzKQot ICAgIDogbV90aW1lVmFsdWUodmFsdWUpCi0gICAgLCBtX3RpbWVTY2FsZShzY2FsZSkKLSAgICAs IG1fdGltZUZsYWdzKGZsYWdzKQotewotICAgIGlmIChzY2FsZSB8fCBpc0ludmFsaWQoKSkKLSAg ICAgICAgcmV0dXJuOwotCi0gICAgKnRoaXMgPSB2YWx1ZSA8IDAgPyBuZWdhdGl2ZUluZmluaXRl VGltZSgpIDogcG9zaXRpdmVJbmZpbml0ZVRpbWUoKTsKLX0KLQogTWVkaWFUaW1lOjpNZWRpYVRp bWUoY29uc3QgTWVkaWFUaW1lJiByaHMpCiB7CiAgICAgKnRoaXMgPSByaHM7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9NZWRpYVRpbWUuaCBiL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5o CmluZGV4IGIyNmY1YTg2OTJmM2MyOWRlMTk3OTMyZjgyNjFjYTBlZThlOGM0MjguLmUyZWZlNzdj NDNhZGM2NWIyYWYyODQ2ZTEwYmZlODQ4YjU1ZDYxMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL01lZGlhVGltZS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5oCkBAIC01Myw4 ICs1Myw4IEBAIHB1YmxpYzoKICAgICAgICAgRG91YmxlVmFsdWUgPSAxIDw8IDUsCiAgICAgfTsK IAotICAgIE1lZGlhVGltZSgpOwotICAgIE1lZGlhVGltZShpbnQ2NF90IHZhbHVlLCB1aW50MzJf dCBzY2FsZSwgdWludDhfdCBmbGFncyA9IFZhbGlkKTsKKyAgICBjb25zdGV4cHIgTWVkaWFUaW1l KCk7CisgICAgY29uc3RleHByIE1lZGlhVGltZShpbnQ2NF90IHZhbHVlLCB1aW50MzJfdCBzY2Fs ZSwgdWludDhfdCBmbGFncyA9IFZhbGlkKTsKICAgICBNZWRpYVRpbWUoY29uc3QgTWVkaWFUaW1l JiByaHMpOwogCiAgICAgc3RhdGljIE1lZGlhVGltZSBjcmVhdGVXaXRoRmxvYXQoZmxvYXQgZmxv YXRUaW1lKTsKQEAgLTE0OCw2ICsxNDgsMjQgQEAgcHJpdmF0ZToKICAgICB1aW50OF90IG1fdGlt ZUZsYWdzOwogfTsKIAorY29uc3RleHByIE1lZGlhVGltZTo6TWVkaWFUaW1lKCkKKyAgICA6IG1f dGltZVZhbHVlKDApCisgICAgLCBtX3RpbWVTY2FsZShEZWZhdWx0VGltZVNjYWxlKQorICAgICwg bV90aW1lRmxhZ3MoVmFsaWQpCit7Cit9CisKK2NvbnN0ZXhwciBNZWRpYVRpbWU6Ok1lZGlhVGlt ZShpbnQ2NF90IHZhbHVlLCB1aW50MzJfdCBzY2FsZSwgdWludDhfdCBmbGFncykKKyAgICA6IG1f dGltZVZhbHVlKHZhbHVlKQorICAgICwgbV90aW1lU2NhbGUoc2NhbGUpCisgICAgLCBtX3RpbWVG bGFncyhmbGFncykKK3sKKyAgICBpZiAoc2NhbGUgfHwgaXNJbnZhbGlkKCkpCisgICAgICAgIHJl dHVybjsKKworICAgICp0aGlzID0gdmFsdWUgPCAwID8gbmVnYXRpdmVJbmZpbml0ZVRpbWUoKSA6 IHBvc2l0aXZlSW5maW5pdGVUaW1lKCk7Cit9CisKIGlubGluZSBNZWRpYVRpbWUgb3BlcmF0b3Iq KGludDMyX3QgbGhzLCBjb25zdCBNZWRpYVRpbWUmIHJocykgeyByZXR1cm4gcmhzLm9wZXJhdG9y KihsaHMpOyB9CiAKIFdURl9FWFBPUlRfUFJJVkFURSBleHRlcm4gTWVkaWFUaW1lIGFicyhjb25z dCBNZWRpYVRpbWUmIHJocyk7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9D aGFuZ2VMb2cKaW5kZXggMDU3YmE3ZDM1NTk4ZTJiY2RmNGQ0MGUyODM4ZjI3MzJiNTNkOGJhYy4u ZDQ4MzIxM2UzMTJhZDkxODRlMzZkNGQ2OGNjZmZiZDU5N2M2MTIwMSAxMDA2NDQKLS0tIGEvVG9v bHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIw LTAxLTA5ICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAg ICBbV1RGXSBNYWtlIE1lZGlhVGltZSBjb25zdHJ1Y3RvciBjb25zdGV4cHIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjAzNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHRlc3QgZm9yIGdsb2Jh bCBzdGF0aWMgTWVkaWFUaW1lIGNvbnN0YW50cy4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkv VGVzdHMvV1RGL01lZGlhVGltZS5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToK KwogMjAyMC0wMS0wOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYktpdFRlc3RSdW5uZXIgbGVha3Mgb2JqZWN0cyBpbiBhIHRvcC1sZXZlbCBhdXRvcmVs ZWFzZVBvb2wgdGhhdCdzIG5ldmVyIGNsZWFyZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV1RGL01lZGlhVGltZS5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dURi9NZWRpYVRpbWUuY3BwCmluZGV4IDk2MWJjMjZmMjBkOTZlNmQyYmJhNWQxZmEwYzE3Mzg2 YTIxNGQ4ZDEuLjIxY2RjZjA5OWMxNTI0MDRmMzgwZjVjYzgxZTEyYmRjNTE0OGQ4YjggMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01lZGlhVGltZS5jcHAKKysrIGIv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWVkaWFUaW1lLmNwcApAQCAtNTYsNiArNTYs MTMgQEAgc3RkOjpvc3RyZWFtJiBvcGVyYXRvcjw8KHN0ZDo6b3N0cmVhbSYgb3V0LCBjb25zdCBN ZWRpYVRpbWUmIHZhbCkKIAogbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkgewogCisvLyBNZWRpYVRp bWUgdmFsdWVzIHNob3VsZCBiZSBhYmxlIHRvIGJlIGRlY2xhcmVkIHN0YXRpYyBhbnl3aGVyZSwg anVzdCBsaWtlIHlvdSBjYW4gZG8gc28gd2l0aCBpbnRlZ2Vycy4KKy8vIFRoaXMgc2hvdWxkIG5v dCByZXF1aXJlIGdsb2JhbCBjb25zdHJ1Y3RvcnMgb3IgZGVzdHJ1Y3RvcnMuCisjcHJhZ21hIGNs YW5nIGRpYWdub3N0aWMgcHVzaAorI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIGVycm9yICItV2ds b2JhbC1jb25zdHJ1Y3RvcnMiCitzdGF0aWMgY29uc3QgTWVkaWFUaW1lIG9uZVNlY29uZCgxLCAx KTsKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKKwogVEVTVChXVEYsIE1lZGlhVGltZSkK IHsKICAgICAvLyBDb21wYXJpc29uIE9wZXJhdG9ycwpAQCAtOTcsNiArMTA0LDcgQEAgVEVTVChX VEYsIE1lZGlhVGltZSkKICAgICBFWFBFQ1RfVFJVRSghTWVkaWFUaW1lOjpjcmVhdGVXaXRoRG91 YmxlKDAuMCwgMSkpOwogICAgIEVYUEVDVF9GQUxTRSghTWVkaWFUaW1lKDEsIDEpKTsKICAgICBF WFBFQ1RfRkFMU0UoKGJvb2wpTWVkaWFUaW1lOjppbnZhbGlkVGltZSgpKTsKKyAgICBFWFBFQ1Rf RVEoTWVkaWFUaW1lKDEwLCAxMCksIG9uZVNlY29uZCk7CiAKICAgICAvLyBBZGRpdGlvbiBPcGVy YXRvcnMKICAgICBFWFBFQ1RfRVEoTWVkaWFUaW1lOjpwb3NpdGl2ZUluZmluaXRlVGltZSgpICsg TWVkaWFUaW1lOjpwb3NpdGl2ZUluZmluaXRlVGltZSgpLCBNZWRpYVRpbWU6OnBvc2l0aXZlSW5m aW5pdGVUaW1lKCkpOwo= 387527 2020-01-13 08:07:33 -0800 2020-01-14 07:22:25 -0800 Patch bug-206036-20200113170732.patch text/plain 6061 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQyM2NiMGI2M2QyMTk2ZDhiYzZlZjg1 OWRjNTAxYzBkNTM4ZmQyZjguLjlhMzQ2YmNhM2QyYmQ4Y2VhNjc4ZGY4NWQ1Y2NiNWFkMTkzOTU4 OTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsNDEgQEAKKzIwMjAtMDEtMDkgIEFsaWNpYSBCb3lhIEdhcmPDrWEg IDxhYm95YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXVEZdIE1ha2UgTWVkaWFUaW1lIGNvbnN0 cnVjdG9yIGNvbnN0ZXhwcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA2MDM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTcyMyBh bGxvd2VkIHRvIGRlY2xhcmUKKyAgICAgICAgTWVkaWFUaW1lIHZhcmlhYmxlcyBhcyBzdGF0aWMg aW5zaWRlIGZ1bmN0aW9ucyB3aXRob3V0IG5lZWRpbmcgYQorICAgICAgICBnbG9iYWwgZGVzdHJ1 Y3Rvci4KKworICAgICAgICBJdCBkaWQgbm90IGVsaW1pbmF0ZSB0aGUgY2FsbCB0byB0aGUgTWVk aWFUaW1lIGNvbnN0cnVjdG9yIG9uIHJ1bnRpbWUKKyAgICAgICAgdGhvdWdoLiBUaGlzIHdhc24n dCBhIHByb2JsZW0gZm9yIHN0YXRpYyB2YXJpYWJsZXMgaW5zaWRlIGZ1bmN0aW9ucywKKyAgICAg ICAgYXMgdGhlIGNvbXBpbGVyIGFkZHMgYSBndWFyZCB2YXJpYWJsZSB0byBjYWxsIHRoZSBjb25z dHJ1Y3RvciB0aGUKKyAgICAgICAgZmlyc3QgdGltZSB0aGUgZnVuY3Rpb24gaXMgY2FsbGVkLgor CisgICAgICAgIE9uIHRoZSBvdGhlciBoYW5kLCBmb3IgdmFyaWFibGVzIGRlZmluZWQgb3V0c2lk ZSBvZiB0aGUgc2NvcGUgb2YgdGhlCisgICAgICAgIGZ1bmN0aW9uLCBmb3IgdGhlbSB0byBiZSBp bml0aWFsaXplZCB0aGUgTWVkaWFUaW1lIGNvbnN0cnVjdG9yIHdvdWxkCisgICAgICAgIGhhdmUg dG8gYmUgY2FsbGVkIGF0IHJ1bnRpbWUgZnJvbSBhIGdsb2JhbCBjb25zdHJ1Y3Rvciwgc29tZXRo aW5nCisgICAgICAgIHdlJ3JlIHRyeWluZyB0byBhdm9pZCBhbmQgd2hpY2ggZ2VuZXJhdGVzIGFu IGVycm9yIGluIGNsYW5nLgorCisgICAgICAgIEJ1dCBhZ2FpbiwgTWVkaWFUaW1lIGlzIGEgc2lt cGxlIGNsYXNzIHdpdGggb25seSBpbnRlZ3JhbCB2YWx1ZXMsIHdlCisgICAgICAgIHNob3VsZG4n dCBuZWVkIGEgcnVudGltZSBmdW5jdGlvbiBjYWxsIHRvIGluaXRpYWxpemUgaXQhCisKKyAgICAg ICAgVGhpcyBwYXRjaCBtYWtlcyB0aGUgTWVkaWFUaW1lIGNvbnN0cnVjdG9yIGNvbnN0ZXhwciBz byB0aGF0IHdlIGRvbid0CisgICAgICAgIG5lZWQgcnVudGltZSBpbml0aWFsaXphdGlvbiBmb3Ig c3RhdGljIE1lZGlhVGltZSB2YXJpYWJsZXMuIFRoaXMKKyAgICAgICAgYWxsb3dzIHVzIHRvIGRl Y2xhcmUgdGhlbSBvdXRzaWRlIGZ1bmN0aW9ucyBhbmQgZW5hYmxlcyB0aGUgY29tcGlsZXIKKyAg ICAgICAgdG8gZ2VuZXJhdGUgY29kZSB3aXRob3V0IGd1YXJkIHZhcmlhYmxlcyB3aGVuIHN0YXRp YyBNZWRpYVRpbWUKKyAgICAgICAgdmFyaWFibGVzIGFyZSBkZWNsYXJlZCBpbnNpZGUgZnVuY3Rp b25zLgorCisgICAgICAgIEEgdGVzdCBoYXMgYmVlbiBhZGRlZCBhY2Nlc3NpbmcgYSBnbG9iYWwg Y29uc3Qgc3RhdGljIE1lZGlhVGltZS4gVGhlCisgICAgICAgIGJ1aWxkIHNob3VsZCBub3QgcHJv ZHVjZSBhbnkgZXJyb3Igc3RhdGluZyB0aGUgbmVlZCBmb3IgYSBnbG9iYWwKKyAgICAgICAgY29u c3RydWN0b3IuCisKKyAgICAgICAgKiB3dGYvTWVkaWFUaW1lLmNwcDoKKyAgICAgICAgKiB3dGYv TWVkaWFUaW1lLmg6CisgICAgICAgIChXVEY6Ok1lZGlhVGltZTo6TWVkaWFUaW1lKToKKwogMjAy MC0wMS0wOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFJl ZHVjZSBiaW5hcnkgc2l6ZSBieSBwdXJnaW5nIEMrKyB0eXBlIGluZm9ybWF0aW9uIGluIE9iamVj dGl2ZS1DIGZpZWxkcyBhbmQgcGFyYW1ldGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv TWVkaWFUaW1lLmNwcCBiL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5jcHAKaW5kZXggODlkMmFi NzMzZDc2ZDZkODdlNjc5MTg4N2EwOWNkZmUwZDUwZWUxNS4uYTNmNjI1MmYxZTlmM2E0ZjBhMTM1 NzIzNDJjMDYwZTAxMzA1NmY2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWVkaWFUaW1l LmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9NZWRpYVRpbWUuY3BwCkBAIC03MiwyNCArNzIsNiBA QCBzdGF0aWMgaW50NjRfdCBzaWdudW0oaW50NjRfdCB2YWwpCiAKIGNvbnN0IHVpbnQzMl90IE1l ZGlhVGltZTo6TWF4aW11bVRpbWVTY2FsZSA9IDEwMDAwMDAwMDA7CiAKLU1lZGlhVGltZTo6TWVk aWFUaW1lKCkKLSAgICA6IG1fdGltZVZhbHVlKDApCi0gICAgLCBtX3RpbWVTY2FsZShEZWZhdWx0 VGltZVNjYWxlKQotICAgICwgbV90aW1lRmxhZ3MoVmFsaWQpCi17Ci19Ci0KLU1lZGlhVGltZTo6 TWVkaWFUaW1lKGludDY0X3QgdmFsdWUsIHVpbnQzMl90IHNjYWxlLCB1aW50OF90IGZsYWdzKQot ICAgIDogbV90aW1lVmFsdWUodmFsdWUpCi0gICAgLCBtX3RpbWVTY2FsZShzY2FsZSkKLSAgICAs IG1fdGltZUZsYWdzKGZsYWdzKQotewotICAgIGlmIChzY2FsZSB8fCBpc0ludmFsaWQoKSkKLSAg ICAgICAgcmV0dXJuOwotCi0gICAgKnRoaXMgPSB2YWx1ZSA8IDAgPyBuZWdhdGl2ZUluZmluaXRl VGltZSgpIDogcG9zaXRpdmVJbmZpbml0ZVRpbWUoKTsKLX0KLQogTWVkaWFUaW1lOjpNZWRpYVRp bWUoY29uc3QgTWVkaWFUaW1lJiByaHMpCiB7CiAgICAgKnRoaXMgPSByaHM7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9NZWRpYVRpbWUuaCBiL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5o CmluZGV4IGIyNmY1YTg2OTJmM2MyOWRlMTk3OTMyZjgyNjFjYTBlZThlOGM0MjguLmNhOWE5MzU5 MDZkM2Q5MTAzODEzZTZiNjFkZTBmMzRhZjljYzgwYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL01lZGlhVGltZS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5oCkBAIC01Myw4 ICs1Myw4IEBAIHB1YmxpYzoKICAgICAgICAgRG91YmxlVmFsdWUgPSAxIDw8IDUsCiAgICAgfTsK IAotICAgIE1lZGlhVGltZSgpOwotICAgIE1lZGlhVGltZShpbnQ2NF90IHZhbHVlLCB1aW50MzJf dCBzY2FsZSwgdWludDhfdCBmbGFncyA9IFZhbGlkKTsKKyAgICBjb25zdGV4cHIgTWVkaWFUaW1l KCk7CisgICAgY29uc3RleHByIE1lZGlhVGltZShpbnQ2NF90IHZhbHVlLCB1aW50MzJfdCBzY2Fs ZSwgdWludDhfdCBmbGFncyA9IFZhbGlkKTsKICAgICBNZWRpYVRpbWUoY29uc3QgTWVkaWFUaW1l JiByaHMpOwogCiAgICAgc3RhdGljIE1lZGlhVGltZSBjcmVhdGVXaXRoRmxvYXQoZmxvYXQgZmxv YXRUaW1lKTsKQEAgLTE0OCw2ICsxNDgsMjQgQEAgcHJpdmF0ZToKICAgICB1aW50OF90IG1fdGlt ZUZsYWdzOwogfTsKIAorY29uc3RleHByIE1lZGlhVGltZTo6TWVkaWFUaW1lKCkKKyAgICA6IG1f dGltZVZhbHVlKDApCisgICAgLCBtX3RpbWVTY2FsZShEZWZhdWx0VGltZVNjYWxlKQorICAgICwg bV90aW1lRmxhZ3MoVmFsaWQpCit7Cit9CisKK2NvbnN0ZXhwciBNZWRpYVRpbWU6Ok1lZGlhVGlt ZShpbnQ2NF90IHZhbHVlLCB1aW50MzJfdCBzY2FsZSwgdWludDhfdCBmbGFncykKKyAgICA6IG1f dGltZVZhbHVlKHZhbHVlKQorICAgICwgbV90aW1lU2NhbGUoc2NhbGUpCisgICAgLCBtX3RpbWVG bGFncyhmbGFncykKK3sKKyAgICBpZiAoc2NhbGUgfHwgIShmbGFncyAmIFZhbGlkKSkKKyAgICAg ICAgcmV0dXJuOworCisgICAgKnRoaXMgPSB2YWx1ZSA8IDAgPyBuZWdhdGl2ZUluZmluaXRlVGlt ZSgpIDogcG9zaXRpdmVJbmZpbml0ZVRpbWUoKTsKK30KKwogaW5saW5lIE1lZGlhVGltZSBvcGVy YXRvciooaW50MzJfdCBsaHMsIGNvbnN0IE1lZGlhVGltZSYgcmhzKSB7IHJldHVybiByaHMub3Bl cmF0b3IqKGxocyk7IH0KIAogV1RGX0VYUE9SVF9QUklWQVRFIGV4dGVybiBNZWRpYVRpbWUgYWJz KGNvbnN0IE1lZGlhVGltZSYgcmhzKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCAwNTdiYTdkMzU1OThlMmJjZGY0ZDQwZTI4MzhmMjczMmI1M2Q4 YmFjLi5kNDgzMjEzZTMxMmFkOTE4NGUzNmQ0ZDY4Y2NmZmJkNTk3YzYxMjAxIDEwMDY0NAotLS0g YS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMjAtMDEtMDkgIEFsaWNpYSBCb3lhIEdhcmPDrWEgIDxhYm95YUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtXVEZdIE1ha2UgTWVkaWFUaW1lIGNvbnN0cnVjdG9yIGNvbnN0ZXhwcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2MDM2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGVzdCBmb3Ig Z2xvYmFsIHN0YXRpYyBNZWRpYVRpbWUgY29uc3RhbnRzLgorCisgICAgICAgICogVGVzdFdlYktp dEFQSS9UZXN0cy9XVEYvTWVkaWFUaW1lLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRF U1QpOgorCiAyMDIwLTAxLTA5ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViS2l0VGVzdFJ1bm5lciBsZWFrcyBvYmplY3RzIGluIGEgdG9wLWxldmVsIGF1 dG9yZWxlYXNlUG9vbCB0aGF0J3MgbmV2ZXIgY2xlYXJlZApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XVEYvTWVkaWFUaW1lLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV1RGL01lZGlhVGltZS5jcHAKaW5kZXggOTYxYmMyNmYyMGQ5NmU2ZDJiYmE1ZDFmYTBj MTczODZhMjE0ZDhkMS4uMjFjZGNmMDk5YzE1MjQwNGYzODBmNWNjODFlMTJiZGM1MTQ4ZDhiOCAx MDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWVkaWFUaW1lLmNwcAor KysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NZWRpYVRpbWUuY3BwCkBAIC01Niw2 ICs1NiwxMyBAQCBzdGQ6Om9zdHJlYW0mIG9wZXJhdG9yPDwoc3RkOjpvc3RyZWFtJiBvdXQsIGNv bnN0IE1lZGlhVGltZSYgdmFsKQogCiBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSSB7CiAKKy8vIE1l ZGlhVGltZSB2YWx1ZXMgc2hvdWxkIGJlIGFibGUgdG8gYmUgZGVjbGFyZWQgc3RhdGljIGFueXdo ZXJlLCBqdXN0IGxpa2UgeW91IGNhbiBkbyBzbyB3aXRoIGludGVnZXJzLgorLy8gVGhpcyBzaG91 bGQgbm90IHJlcXVpcmUgZ2xvYmFsIGNvbnN0cnVjdG9ycyBvciBkZXN0cnVjdG9ycy4KKyNwcmFn bWEgY2xhbmcgZGlhZ25vc3RpYyBwdXNoCisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgZXJyb3Ig Ii1XZ2xvYmFsLWNvbnN0cnVjdG9ycyIKK3N0YXRpYyBjb25zdCBNZWRpYVRpbWUgb25lU2Vjb25k KDEsIDEpOworI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHBvcAorCiBURVNUKFdURiwgTWVkaWFU aW1lKQogewogICAgIC8vIENvbXBhcmlzb24gT3BlcmF0b3JzCkBAIC05Nyw2ICsxMDQsNyBAQCBU RVNUKFdURiwgTWVkaWFUaW1lKQogICAgIEVYUEVDVF9UUlVFKCFNZWRpYVRpbWU6OmNyZWF0ZVdp dGhEb3VibGUoMC4wLCAxKSk7CiAgICAgRVhQRUNUX0ZBTFNFKCFNZWRpYVRpbWUoMSwgMSkpOwog ICAgIEVYUEVDVF9GQUxTRSgoYm9vbClNZWRpYVRpbWU6OmludmFsaWRUaW1lKCkpOworICAgIEVY UEVDVF9FUShNZWRpYVRpbWUoMTAsIDEwKSwgb25lU2Vjb25kKTsKIAogICAgIC8vIEFkZGl0aW9u IE9wZXJhdG9ycwogICAgIEVYUEVDVF9FUShNZWRpYVRpbWU6OnBvc2l0aXZlSW5maW5pdGVUaW1l KCkgKyBNZWRpYVRpbWU6OnBvc2l0aXZlSW5maW5pdGVUaW1lKCksIE1lZGlhVGltZTo6cG9zaXRp dmVJbmZpbml0ZVRpbWUoKSk7Cg==