206035 2020-01-09 14:12:06 -0800 Check the existence of the optional m_sessionID before using it in WebProcess::setResourceLoadStatisticsEnabled() 2020-01-16 15:02:01 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206100 InRadar P2 Normal --- 1 wilander wilander bfulgham commit-queue jbedard webkit-bug-importer oldest_to_newest 1604849 0 wilander 2020-01-09 14:12:06 -0800 Since m_sessionID is optional, we need to check that it exists before asking it whether the session is ephemeral. 1604850 1 wilander 2020-01-09 14:12:20 -0800 <rdar://problem/58455306> 1604852 2 387271 wilander 2020-01-09 14:14:42 -0800 Created attachment 387271 Patch 1604884 3 387271 bfulgham 2020-01-09 15:02:51 -0800 Comment on attachment 387271 Patch r=me 1604906 4 387271 commit-queue 2020-01-09 15:47:42 -0800 Comment on attachment 387271 Patch Clearing flags on attachment: 387271 Committed r254310: <https://trac.webkit.org/changeset/254310> 1604907 5 commit-queue 2020-01-09 15:47:43 -0800 All reviewed patches have been landed. Closing bug. 1605282 6 jbedard 2020-01-10 13:46:09 -0800 I'm not 100% sure this is the cause, but we have a flakey regression in a resource load statistics test, and this seems like a plausible candidate: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2FresourceLoadStatistics%2Fclassify-as-non-prevalent-based-on-sub-frame-under-top-frame-origins-database.html 1605285 7 jbedard 2020-01-10 13:47:23 -0800 Although <https://trac.webkit.org/changeset/254296> is also a plausible candidate. 1605328 8 wilander 2020-01-10 15:08:42 -0800 Thanks for flagging, Jonathan! I'm trying to address the flakiness in https://bugs.webkit.org/show_bug.cgi?id=206100. 1606476 9 wilander 2020-01-14 10:49:19 -0800 The flaky test looks all green after my latest change. 1606484 10 jbedard 2020-01-14 11:22:49 -0800 Looks good so far...still need a few more test runs to be confident. 1607688 11 jbedard 2020-01-16 15:02:01 -0800 I think we can pretty confidently say things are fixed now. 387271 2020-01-09 14:14:42 -0800 2020-01-09 15:47:42 -0800 Patch bug-206035-20200109141441.patch text/plain 1747 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0Mjk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGMwYjA1ODZhNjQwNDgxNWU3 MTUwYzFmMTM5MzhjYTI4N2Q0ZjQxMDUuLjJlMzVlMzViZTlmNmIyZTM1OTAzNzNkNmYxNDQxZGZi YmU0M2JiMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDEtMDkgIEpvaG4gV2ls YW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hlY2sgdGhlIGV4aXN0ZW5j ZSBvZiB0aGUgb3B0aW9uYWwgbV9zZXNzaW9uSUQgYmVmb3JlIHVzaW5nIGl0IGluIFdlYlByb2Nl c3M6OnNldFJlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkKCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjAzNQorICAgICAgICA8cmRhcjovL3By b2JsZW0vNTg0NTUzMDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNz LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6c2V0UmVzb3VyY2VMb2FkU3RhdGlz dGljc0VuYWJsZWQpOgorICAgICAgICAgICAgQWRkZWQgYSBjaGVjayB0aGF0IG1fc2Vzc2lvbklE IGV4aXN0cy4KKwogMjAyMC0wMS0wOSAgQW5kcmVzIEdvbnphbGV6ICA8YW5kcmVzZ18yMkBhcHBs ZS5jb20+CiAKICAgICAgICAgV0tBY2Nlc3NpYmlsaXR5V2ViUGFnZU9iamVjdCBzaG91bGQgdXNl IEFjY2Vzc2liaWxpdHk6OnJldHJpZXZlVmFsdWVGcm9tTWFpblRocmVhZC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAppbmRleCBjZWVjOTRlMzM3YzdhMzQ1MjRjZTU2Y2Q2 MzZhMzkyZDIyYTBkYmQ1Li4xNTYxZmZhZWUyNjk3ZThkZWI5YTc3MWYyNjhkN2U3ZWVkMTc1ZWQ2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKKysr IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCkBAIC0xNjMwLDcgKzE2 MzAsNyBAQCBTdG9yYWdlQXJlYU1hcCogV2ViUHJvY2Vzczo6c3RvcmFnZUFyZWFNYXAoU3RvcmFn ZUFyZWFJZGVudGlmaWVyIGlkZW50aWZpZXIpIGNvbgogCiB2b2lkIFdlYlByb2Nlc3M6OnNldFJl c291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkKGJvb2wgZW5hYmxlZCkKIHsKLSAgICBpZiAoV2Vi Q29yZTo6RGVwcmVjYXRlZEdsb2JhbFNldHRpbmdzOjpyZXNvdXJjZUxvYWRTdGF0aXN0aWNzRW5h YmxlZCgpID09IGVuYWJsZWQgfHwgbV9zZXNzaW9uSUQtPmlzRXBoZW1lcmFsKCkpCisgICAgaWYg KFdlYkNvcmU6OkRlcHJlY2F0ZWRHbG9iYWxTZXR0aW5nczo6cmVzb3VyY2VMb2FkU3RhdGlzdGlj c0VuYWJsZWQoKSA9PSBlbmFibGVkIHx8IChtX3Nlc3Npb25JRCAmJiBtX3Nlc3Npb25JRC0+aXNF cGhlbWVyYWwoKSkpCiAgICAgICAgIHJldHVybjsKICAgICBXZWJDb3JlOjpEZXByZWNhdGVkR2xv YmFsU2V0dGluZ3M6OnNldFJlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkKGVuYWJsZWQpOwog I2lmIEVOQUJMRShSRVNPVVJDRV9MT0FEX1NUQVRJU1RJQ1MpCg==