206031 2020-01-09 13:35:08 -0800 [macOS] Issue sandbox extension to "com.apple.nesessionmanager" prior to 10.15 2020-01-10 09:53:01 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 206025 1 pvollan bfulgham achristensen bfulgham pvollan webkit-bug-importer oldest_to_newest 1604822 0 pvollan 2020-01-09 13:35:08 -0800 We currently issue an extension to "com.apple.nesessionmanager.content-filter" on macOS, but this should be "com.apple.nesessionmanager" prior to macOS 10.15. 1604823 1 webkit-bug-importer 2020-01-09 13:35:38 -0800 <rdar://problem/58455467> 1604958 2 387298 bfulgham 2020-01-09 17:40:44 -0800 Created attachment 387298 Patch 1604960 3 bfulgham 2020-01-09 17:42:40 -0800 Note: A new test that covers this behavior is part of Bug 206025. 1605115 4 bfulgham 2020-01-10 08:37:10 -0800 WK1 failure is due to bot unable to download content. iOS-wk2 failure can't be related, since this code change is not compiled on iOS. 1605133 5 387298 pvollan 2020-01-10 09:05:29 -0800 Comment on attachment 387298 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387298&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:338 > + SandboxExtension::createHandleForMachLookup("com.apple.nesessionmanager", WTF::nullopt, handle); I believe you also need the sevice in the sandbox, in the mach lookup extension rule. 1605136 6 bfulgham 2020-01-10 09:10:38 -0800 (In reply to Per Arne Vollan from comment #5) > Comment on attachment 387298 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387298&action=review > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:338 > > + SandboxExtension::createHandleForMachLookup("com.apple.nesessionmanager", WTF::nullopt, handle); > > I believe you also need the sevice in the sandbox, in the mach lookup > extension rule. Ah! Yes, you are right. I'll fix that. 1605150 7 387347 bfulgham 2020-01-10 09:24:29 -0800 Created attachment 387347 Patch 1605152 8 387347 pvollan 2020-01-10 09:29:14 -0800 Comment on attachment 387347 Patch Great! R=me. 1605166 9 bfulgham 2020-01-10 09:53:01 -0800 Committed r254343: <https://trac.webkit.org/changeset/254343> 387298 2020-01-09 17:40:44 -0800 2020-01-10 09:24:28 -0800 Patch bug-206031-20200109174044.patch text/plain 2028 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVkYjkyY2Y3MWQ5MjUxODlm NjNlMDY4NmZkOWRiNWEwYzc1ZjE1OGQuLmJhYTkyNWFiMzc4YjU1ZDQzNjE0MmY3ZWQ1ZTk0YTA2 YTYwM2RjMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDEtMDkgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBJc3N1ZSBzYW5k Ym94IGV4dGVuc2lvbiB0byAiY29tLmFwcGxlLm5lc2Vzc2lvbm1hbmFnZXIiIHByaW9yIHRvIDEw LjE1IAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2 MDMxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODQ1NTQ2Nz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbWFjaCBuYW1lIG9mICdjb20uYXBw bGUubmVzZXNzaW9ubWFuYWdlcicgY2hhbmdlZCBiZXR3ZWVuIG1hY09TIDEwLjE0IGFuZCAxMC4x NS4KKyAgICAgICAgV2Ugc2hvdWxkIGNvbnRpbnVlIHRvIGlzc3VlIHRoZSBvbGQgbmFtZSB3aGVu IGJ1aWxkaW5nIGZvciBvbGRlciBvcGVyYXRpbmcgc3lzdGVtcy4iCisKKyAgICAgICAgQ292ZXJl ZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJQcm9j ZXNzUG9vbENvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6cGxhdGZv cm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMjAtMDEtMDkgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgLVtXS1dlYlZpZXcgX2lu aXRpYWxpemVXaXRoQ29uZmlndXJhdGlvbjpdCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENvY29hLm1tIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xDb2NvYS5tbQppbmRleCAzN2ExMGE3ZWRhMzM5NzA0 OTU0OTJjZWVjNzJhNzU1OGJiYzM3NGZjLi5iM2MxMTMyYmU5ZjI3NmU0YmM4OGU1YTdmOTQ0MjY3 ZGZkOWE5Yzk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQ cm9jZXNzUG9vbENvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dl YlByb2Nlc3NQb29sQ29jb2EubW0KQEAgLTMzNCw3ICszMzQsMTEgQEAgdm9pZCBXZWJQcm9jZXNz UG9vbDo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyhjb25zdCBXZWJQcm9jZXNzUHJveHkm IHByb2Nlc3MKICAgICAgICAgU2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlIGhhbmRsZTsKICAgICAg ICAgU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlRm9yTWFjaExvb2t1cCgiY29tLmFwcGxl Lm5laGVscGVyIiwgV1RGOjpudWxsb3B0LCBoYW5kbGUpOwogICAgICAgICBwYXJhbWV0ZXJzLm5l SGVscGVyRXh0ZW5zaW9uSGFuZGxlID0gV1RGTW92ZShoYW5kbGUpOworI2lmIFBMQVRGT1JNKE1B QykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTUwMAorICAgICAgICBT YW5kYm94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGVGb3JNYWNoTG9va3VwKCJjb20uYXBwbGUubmVz ZXNzaW9ubWFuYWdlciIsIFdURjo6bnVsbG9wdCwgaGFuZGxlKTsKKyNlbHNlCiAgICAgICAgIFNh bmRib3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZUZvck1hY2hMb29rdXAoImNvbS5hcHBsZS5uZXNl c3Npb25tYW5hZ2VyLmNvbnRlbnQtZmlsdGVyIiwgV1RGOjpudWxsb3B0LCBoYW5kbGUpOworI2Vu ZGlmCiAgICAgICAgIHBhcmFtZXRlcnMubmVTZXNzaW9uTWFuYWdlckV4dGVuc2lvbkhhbmRsZSA9 IFdURk1vdmUoaGFuZGxlKTsKICAgICB9CiAjZW5kaWYK 387347 2020-01-10 09:24:29 -0800 2020-01-10 09:29:14 -0800 Patch bug-206031-20200110092428.patch text/plain 2912 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVkYjkyY2Y3MWQ5MjUxODlm NjNlMDY4NmZkOWRiNWEwYzc1ZjE1OGQuLmJhYTkyNWFiMzc4YjU1ZDQzNjE0MmY3ZWQ1ZTk0YTA2 YTYwM2RjMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDEtMDkgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBJc3N1ZSBzYW5k Ym94IGV4dGVuc2lvbiB0byAiY29tLmFwcGxlLm5lc2Vzc2lvbm1hbmFnZXIiIHByaW9yIHRvIDEw LjE1IAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2 MDMxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODQ1NTQ2Nz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbWFjaCBuYW1lIG9mICdjb20uYXBw bGUubmVzZXNzaW9ubWFuYWdlcicgY2hhbmdlZCBiZXR3ZWVuIG1hY09TIDEwLjE0IGFuZCAxMC4x NS4KKyAgICAgICAgV2Ugc2hvdWxkIGNvbnRpbnVlIHRvIGlzc3VlIHRoZSBvbGQgbmFtZSB3aGVu IGJ1aWxkaW5nIGZvciBvbGRlciBvcGVyYXRpbmcgc3lzdGVtcy4iCisKKyAgICAgICAgQ292ZXJl ZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJQcm9j ZXNzUG9vbENvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6cGxhdGZv cm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMjAtMDEtMDkgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgLVtXS1dlYlZpZXcgX2lu aXRpYWxpemVXaXRoQ29uZmlndXJhdGlvbjpdCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENvY29hLm1tIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xDb2NvYS5tbQppbmRleCAzN2ExMGE3ZWRhMzM5NzA0 OTU0OTJjZWVjNzJhNzU1OGJiYzM3NGZjLi5iM2MxMTMyYmU5ZjI3NmU0YmM4OGU1YTdmOTQ0MjY3 ZGZkOWE5Yzk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQ cm9jZXNzUG9vbENvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dl YlByb2Nlc3NQb29sQ29jb2EubW0KQEAgLTMzNCw3ICszMzQsMTEgQEAgdm9pZCBXZWJQcm9jZXNz UG9vbDo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyhjb25zdCBXZWJQcm9jZXNzUHJveHkm IHByb2Nlc3MKICAgICAgICAgU2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlIGhhbmRsZTsKICAgICAg ICAgU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlRm9yTWFjaExvb2t1cCgiY29tLmFwcGxl Lm5laGVscGVyIiwgV1RGOjpudWxsb3B0LCBoYW5kbGUpOwogICAgICAgICBwYXJhbWV0ZXJzLm5l SGVscGVyRXh0ZW5zaW9uSGFuZGxlID0gV1RGTW92ZShoYW5kbGUpOworI2lmIFBMQVRGT1JNKE1B QykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTUwMAorICAgICAgICBT YW5kYm94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGVGb3JNYWNoTG9va3VwKCJjb20uYXBwbGUubmVz ZXNzaW9ubWFuYWdlciIsIFdURjo6bnVsbG9wdCwgaGFuZGxlKTsKKyNlbHNlCiAgICAgICAgIFNh bmRib3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZUZvck1hY2hMb29rdXAoImNvbS5hcHBsZS5uZXNl c3Npb25tYW5hZ2VyLmNvbnRlbnQtZmlsdGVyIiwgV1RGOjpudWxsb3B0LCBoYW5kbGUpOworI2Vu ZGlmCiAgICAgICAgIHBhcmFtZXRlcnMubmVTZXNzaW9uTWFuYWdlckV4dGVuc2lvbkhhbmRsZSA9 IFdURk1vdmUoaGFuZGxlKTsKICAgICB9CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbiBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgppbmRleCBmNzlhZGQzZWQzZjNk YmJjM2Y5NDc4NjU1YzNmZTQxODA3YTQ5NjAyLi5hZjA4MTE5MWY4MzQwMmMzMjdkOWNiZGRiMjlh MDYxM2E4MGViYzI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFw cGxlLldlYlByb2Nlc3Muc2IuaW4KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5h cHBsZS5XZWJQcm9jZXNzLnNiLmluCkBAIC04NjgsNyArODY4LDE2IEBACiAoYWxsb3cgbWFjaC1s b29rdXAKICAgICAocmVxdWlyZS1hbGwKICAgICAgICAgKGV4dGVuc2lvbiAiY29tLmFwcGxlLndl YmtpdC5leHRlbnNpb24ubWFjaCIpCi0gICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLm5l aGVscGVyIiAiY29tLmFwcGxlLm5lc2Vzc2lvbm1hbmFnZXIuY29udGVudC1maWx0ZXIiKSkpCisg ICAgICAgIChnbG9iYWwtbmFtZQorICAgICAgICAgICAgImNvbS5hcHBsZS5uZWhlbHBlciIKKyNp ZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTUwMCB8fCBQTEFURk9STShN QUNDQVRBTFlTVCkKKyAgICAgICAgICAgICJjb20uYXBwbGUubmVzZXNzaW9ubWFuYWdlci5jb250 ZW50LWZpbHRlciIKKyNlbHNlCisgICAgICAgICAgICAiY29tLmFwcGxlLm5lc2Vzc2lvbm1hbmFn ZXIiCisjZW5kaWYKKyAgICAgICAgKQorICAgICkKKykKIAogKHdoZW4gKGRlZmluZWQ/ICdzeXNj YWxsLXVuaXgpCiAgICAgKGRlbnkgc3lzY2FsbC11bml4ICh3aXRoIHNlbmQtc2lnbmFsIFNJR0tJ TEwpKQo=