206020 2020-01-09 11:44:12 -0800 Remove AGXCompilerService access from the WebContent sandbox 2020-01-09 15:18:14 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham achristensen bfulgham commit-queue pvollan webkit-bug-importer oldest_to_newest 1604747 0 bfulgham 2020-01-09 11:44:12 -0800 Now that we generate a dynamic extension for 'com.apple.AGXCompilerService', we should remove the blanket allow rule from the sandbox. 1604752 1 webkit-bug-importer 2020-01-09 11:47:25 -0800 <rdar://problem/58451395> 1604762 2 387251 bfulgham 2020-01-09 12:09:45 -0800 Created attachment 387251 Patch 1604805 3 pvollan 2020-01-09 13:21:48 -0800 Should we also add a test case for this in fast/sandbox/ios/sandbox-mach-lookup.html? 1604841 4 bfulgham 2020-01-09 14:06:05 -0800 (In reply to Per Arne Vollan from comment #3) > Should we also add a test case for this in > fast/sandbox/ios/sandbox-mach-lookup.html? Since this is hardware specific, will we have too many test failures? Is there a way to skip on specific hardware? I think we only support version and platform (not 2017 iPad versus 2018 iPad, for example). 1604847 5 pvollan 2020-01-09 14:11:28 -0800 (In reply to Brent Fulgham from comment #4) > (In reply to Per Arne Vollan from comment #3) > > Should we also add a test case for this in > > fast/sandbox/ios/sandbox-mach-lookup.html? > > Since this is hardware specific, will we have too many test failures? > > Is there a way to skip on specific hardware? I think we only support version > and platform (not 2017 iPad versus 2018 iPad, for example). You're right, I don't think there is a way to skip specific hardware. 1604848 6 387251 pvollan 2020-01-09 14:12:01 -0800 Comment on attachment 387251 Patch Great! R=me. 1604893 7 387251 commit-queue 2020-01-09 15:18:12 -0800 Comment on attachment 387251 Patch Clearing flags on attachment: 387251 Committed r254306: <https://trac.webkit.org/changeset/254306> 1604894 8 commit-queue 2020-01-09 15:18:14 -0800 All reviewed patches have been landed. Closing bug. 387251 2020-01-09 12:09:45 -0800 2020-01-09 15:18:12 -0800 Patch bug-206020-20200109120945.patch text/plain 1692 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGMyYmFhYTVkZDdmNjI1MTIz NDc0Y2UwNmVjNTFiOWVkMzVlMDRjYzUuLjJiODJiYTQzMDg5MGY0N2IwNDQ3MmViZWMzOTNiOGUz NzQzNThlMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDEtMDkgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIEFHWENvbXBpbGVy U2VydmljZSBhY2Nlc3MgZnJvbSB0aGUgV2ViQ29udGVudCBzYW5kYm94CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYwMjAKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzU4NDUxMzk1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vdyB0aGF0IHdlIGdlbmVyYXRlIGEgZHluYW1pYyBleHRlbnNpb24gZm9y ICdjb20uYXBwbGUuQUdYQ29tcGlsZXJTZXJ2aWNlJywgd2Ugc2hvdWxkIHJlbW92ZSB0aGUKKyAg ICAgICAgYmxhbmtldCBhbGxvdyBydWxlIGZyb20gdGhlIHNhbmRib3guCisKKyAgICAgICAgQ292 ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIFJlc291cmNlcy9TYW5kYm94UHJv ZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYjoKKwogMjAyMC0wMS0wOSAg eW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjog WyBNYWMgd2syIF0gZmFzdC9tZWRpYXN0cmVhbS9jYXB0dXJlSW5HUFVQcm9jZXNzLmh0bWwgaXMg YSBmbGFreSBmYWlsdXJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5k Ym94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYiBiL1NvdXJjZS9X ZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJD b250ZW50LnNiCmluZGV4IGZiMTc1YTBmMjk0MmE4MjBkMmIzODc4NWI5NTcwNDQ4MTU4N2MzYTku LjgxNTQ2MmYyNTQ2Nzk4ZGRlMWI5NzRkZjc0ZmEyMjMxYmE3YjQ5NjAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktp dC5XZWJDb250ZW50LnNiCisrKyBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9m aWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCkBAIC0yOTgsOSArMjk4LDYg QEAKICAgICAoYWxsb3cgc3lzY3RsLXJlYWQKICAgICAgICAgICAgKHN5c2N0bC1uYW1lICMia2Vy bi5ib290c2Vzc2lvbnV1aWQiKSkKIAotICAgIChhbGxvdyBtYWNoLWxvb2t1cCAod2l0aCByZXBv cnQpICh3aXRoIHRlbGVtZXRyeSkKLSAgICAgICAgKHhwYy1zZXJ2aWNlLW5hbWUtcHJlZml4ICJj b20uYXBwbGUuQUdYQ29tcGlsZXJTZXJ2aWNlIikpCi0KICAgICAoYWxsb3cgbWFjaC1sb29rdXAK ICAgICAgICA7OyA8cmRhcjovL3Byb2JsZW0vNDcyNjgxNjY+CiAgICAgICAgKHhwYy1zZXJ2aWNl LW5hbWUgImNvbS5hcHBsZS5NVExDb21waWxlclNlcnZpY2UiKSkK