206018 2020-01-09 11:03:15 -0800 TestController::platformLibraryPathForTesting() returns inner pointer to autoreleased NSString 2020-01-09 18:10:27 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205950 InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue darin joepeck webkit-bug-importer oldest_to_newest 1604726 0 ddkilzer 2020-01-09 11:03:15 -0800 TestController::platformLibraryPathForTesting() returns inner pointer to autoreleased NSString. This will result in a use-after-free if the const char* pointer is accessed after the NSString object has been released. This is not currently crashing because WTR::TestController::TestController() leaks autoreleased objects into a top-level autoreleasePool that's never cleared (which was NOT fixed by Bug 205950). 1604727 1 webkit-bug-importer 2020-01-09 11:05:06 -0800 <rdar://problem/58449733> 1604763 2 387252 ddkilzer 2020-01-09 12:09:49 -0800 Created attachment 387252 Patch v1 1604973 3 387252 commit-queue 2020-01-09 18:10:25 -0800 Comment on attachment 387252 Patch v1 Clearing flags on attachment: 387252 Committed r254318: <https://trac.webkit.org/changeset/254318> 1604974 4 commit-queue 2020-01-09 18:10:27 -0800 All reviewed patches have been landed. Closing bug. 387252 2020-01-09 12:09:49 -0800 2020-01-09 18:10:25 -0800 Patch v1 bug-206018-20200109120948.patch text/plain 3511 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDdkYzhmOTRkZjU2YzMyOWE2ZjE5NzhmODExMmRjN2E2 MzliNjI1MS4uZjI3OWIyMzk3ZTQ1ZWEwYjYwZmUyYWFkODJhOTdmMjE5MDllMWQyMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDIwLTAxLTA5ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgVGVzdENvbnRyb2xsZXI6OnBsYXRmb3JtTGlicmFyeVBhdGhGb3JUZXN0aW5nKCkgcmV0 dXJucyBpbm5lciBwb2ludGVyIHRvIGF1dG9yZWxlYXNlZCBOU1N0cmluZworICAgICAgICA8aHR0 cHM6Ly93ZWJraXQub3JnL2IvMjA2MDE4PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTg0NDk3 MzM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX ZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6VGVzdENv bnRyb2xsZXI6OmluaXRpYWxpemUpOgorICAgICAgICAtIFVzZSBXVEY6OkF1dG9kcmFpbmVkUG9v bCB0byBmaXggcmVtYWluaW5nIGF1dG9yZWxlYXNlUG9vbAorICAgICAgICAgIGxlYWtzLgorICAg ICAgICAqIFdlYktpdFRlc3RSdW5uZXIvaW9zL1Rlc3RDb250cm9sbGVySU9TLm1tOgorICAgICAg ICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1MaWJyYXJ5UGF0aEZvclRlc3RpbmcpOgor ICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvbWFjL1Rlc3RDb250cm9sbGVyTWFjLm1tOgorICAg ICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1MaWJyYXJ5UGF0aEZvclRlc3Rpbmcp OgorICAgICAgICAtIFJldGFpbiBOU1N0cmluZyBzaW5jZSB0aGVzZSBtZXRob2RzIHJldHVybiBh biBpbm5lciBwb2ludGVyLgorICAgICAgICAgIFRoaXMgYWxzbyBvbmx5IG5lZWRzIHRvIGJlIGlu aXRpYWxpemVkIG9uY2UuCisKIDIwMjAtMDEtMDggIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWJLaXRUZXN0UnVubmVyIGxlYWtzIG9iamVjdHMgaW4gYSB0 b3AtbGV2ZWwgYXV0b3JlbGVhc2VQb29sIHRoYXQncyBuZXZlciBjbGVhcmVkCmRpZmYgLS1naXQg YS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcCBiL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IDRiMGNlYzQ3ZGFkMmRkNjc4MmJi OGU3ZTJhNmVkMjY4MGE3YzFhYWIuLjUyNmFhZmI1Nzc1M2E4MzE0NDg0ZWQ2ODRhYTQyZmE4Mzlk YWIzMzEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIu Y3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCkBAIC00 NDIsNiArNDQyLDggQEAgY29uc3QgY2hhciogVGVzdENvbnRyb2xsZXI6OmxpYnJhcnlQYXRoRm9y VGVzdGluZygpCiAKIHZvaWQgVGVzdENvbnRyb2xsZXI6OmluaXRpYWxpemUoaW50IGFyZ2MsIGNv bnN0IGNoYXIqIGFyZ3ZbXSkKIHsKKyAgICBBdXRvZHJhaW5lZFBvb2wgcG9vbDsKKwogICAgIEpT Qzo6aW5pdGlhbGl6ZVRocmVhZGluZygpOwogICAgIFJ1bkxvb3A6OmluaXRpYWxpemVNYWluUnVu TG9vcCgpOwogICAgIFdURjo6c2V0UHJvY2Vzc1ByaXZpbGVnZXMoYWxsUHJpdmlsZWdlcygpKTsK ZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL1Rlc3RDb250cm9sbGVySU9T Lm1tIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvVGVzdENvbnRyb2xsZXJJT1MubW0KaW5k ZXggOGRhMmMxMzE1ZjNjOWY2NTRmNGZiNmFmNGU1OWExMmYzZTQ3ZWE5OS4uODFiZDFlOTkwNmQ3 MjEyZWNkZDc4NDgzNmUyOTU0OWJmNjQyNjcwOSAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9pb3MvVGVzdENvbnRyb2xsZXJJT1MubW0KKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9pb3MvVGVzdENvbnRyb2xsZXJJT1MubW0KQEAgLTI1MCw3ICsyNTAsMTIgQEAgdm9pZCBU ZXN0Q29udHJvbGxlcjo6YWJvcnRNb2RhbCgpCiAKIGNvbnN0IGNoYXIqIFRlc3RDb250cm9sbGVy OjpwbGF0Zm9ybUxpYnJhcnlQYXRoRm9yVGVzdGluZygpCiB7Ci0gICAgcmV0dXJuIFtbQCJ+L0xp YnJhcnkvQXBwbGljYXRpb24gU3VwcG9ydC9XZWJLaXRUZXN0UnVubmVyIiBzdHJpbmdCeUV4cGFu ZGluZ1RpbGRlSW5QYXRoXSBVVEY4U3RyaW5nXTsKKyAgICBzdGF0aWMgTlNTdHJpbmcgKnBsYXRm b3JtTGlicmFyeVBhdGggPSBuaWw7CisgICAgc3RhdGljIGRpc3BhdGNoX29uY2VfdCBvbmNlVG9r ZW47CisgICAgZGlzcGF0Y2hfb25jZSgmb25jZVRva2VuLCBeeworICAgICAgICBwbGF0Zm9ybUxp YnJhcnlQYXRoID0gW1tAIn4vTGlicmFyeS9BcHBsaWNhdGlvbiBTdXBwb3J0L1dlYktpdFRlc3RS dW5uZXIiIHN0cmluZ0J5RXhwYW5kaW5nVGlsZGVJblBhdGhdIHJldGFpbl07CisgICAgfSk7Cisg ICAgcmV0dXJuIHBsYXRmb3JtTGlicmFyeVBhdGguVVRGOFN0cmluZzsKIH0KIAogdm9pZCBUZXN0 Q29udHJvbGxlcjo6c2V0SGlkZGVuKGJvb2wpCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL21hYy9UZXN0Q29udHJvbGxlck1hYy5tbSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv bWFjL1Rlc3RDb250cm9sbGVyTWFjLm1tCmluZGV4IDIzMDM1OTA2MzI1OTg0YjE5OGIwNWQ2MzY1 N2EwZGNmZDJlNTFhMTQuLjNlNTRmMmI4ZDAyZDA4YTFkOGE2MjA2NmNkOTA5YmFhN2ZmYTE0NjEg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1Rlc3RDb250cm9sbGVyTWFj Lm1tCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1Rlc3RDb250cm9sbGVyTWFjLm1t CkBAIC0zNzcsNyArMzc3LDEyIEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6OmFib3J0TW9kYWwoKQog CiBjb25zdCBjaGFyKiBUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1MaWJyYXJ5UGF0aEZvclRlc3Rp bmcoKQogewotICAgIHJldHVybiBbW0Aifi9MaWJyYXJ5L0FwcGxpY2F0aW9uIFN1cHBvcnQvRHVt cFJlbmRlclRyZWUiIHN0cmluZ0J5RXhwYW5kaW5nVGlsZGVJblBhdGhdIFVURjhTdHJpbmddOwor ICAgIHN0YXRpYyBOU1N0cmluZyAqcGxhdGZvcm1MaWJyYXJ5UGF0aCA9IG5pbDsKKyAgICBzdGF0 aWMgZGlzcGF0Y2hfb25jZV90IG9uY2VUb2tlbjsKKyAgICBkaXNwYXRjaF9vbmNlKCZvbmNlVG9r ZW4sIF57CisgICAgICAgIHBsYXRmb3JtTGlicmFyeVBhdGggPSBbW0Aifi9MaWJyYXJ5L0FwcGxp Y2F0aW9uIFN1cHBvcnQvRHVtcFJlbmRlclRyZWUiIHN0cmluZ0J5RXhwYW5kaW5nVGlsZGVJblBh dGhdIHJldGFpbl07CisgICAgfSk7CisgICAgcmV0dXJuIHBsYXRmb3JtTGlicmFyeVBhdGguVVRG OFN0cmluZzsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV1RSCg==