205997 2020-01-09 06:19:08 -0800 WebDriver: pressed virtual keys not correctly handled in action sequences 2020-01-13 01:32:13 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg clopez dino webkit-bug-importer oldest_to_newest 1604576 0 cgarcia 2020-01-09 06:19:08 -0800 We are assuming that only one virtual key can be pressed and that a key up always releases the pressed virtual key if any. We should keep a list of pressed keys and remove them from the list when key up happens for them. 1604578 1 387216 cgarcia 2020-01-09 06:22:25 -0800 Created attachment 387216 Patch 1604716 2 387216 dino 2020-01-09 10:44:15 -0800 Comment on attachment 387216 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387216&action=review Can this be tested? > Source/WebDriver/Session.cpp:2613 > + virtualKeys->pushString(virtualKey); Where does currentState.pressedVirtualKeys get emptied? > Source/WebDriver/Session.h:206 > + HashSet<String> pressedVirtualKeys; Would this be better off as a Vector? Do you want the keys replayed in order? > Source/WebKit/ChangeLog:8 > + When modifiers are present we need to translate the keys that might be affected by the modifiers. I'm not sure how this is related. 1605032 3 cgarcia 2020-01-10 00:53:01 -0800 (In reply to Dean Jackson from comment #2) > Comment on attachment 387216 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387216&action=review > > Can this be tested? It's already tested, this fixes imported/w3c/webdriver/tests/perform_actions/key_modifiers.py::test_shift_modifier_generates_capital_letters[\ue008] and imported/w3c/webdriver/tests/perform_actions/key_modifiers.py::test_shift_modifier_generates_capital_letters[\ue050] > > Source/WebDriver/Session.cpp:2613 > > + virtualKeys->pushString(virtualKey); > > Where does currentState.pressedVirtualKeys get emptied? The keys are removed when the keyup happens for them. > > Source/WebDriver/Session.h:206 > > + HashSet<String> pressedVirtualKeys; > > Would this be better off as a Vector? Do you want the keys replayed in order? You can get keyDown(Shift), keyDown(Control), keyUp(Shift), keyUp(Control) for example. > > Source/WebKit/ChangeLog:8 > > + When modifiers are present we need to translate the keys that might be affected by the modifiers. > > I'm not sure how this is related. There are actually two issues the tests, one is that the virtual key pressed is lost when any other keyup happens, and the other is that we don't translate the keyvals when modifiers are present. I need both changes to fix those tests. I can split the patch, but I think they are related enough. 1605289 4 387216 bburg 2020-01-10 13:54:18 -0800 Comment on attachment 387216 Patch r=me 1605762 5 cgarcia 2020-01-13 01:31:35 -0800 Committed r254424: <https://trac.webkit.org/changeset/254424> 1605763 6 webkit-bug-importer 2020-01-13 01:32:13 -0800 <rdar://problem/58523183> 387216 2020-01-09 06:22:25 -0800 2020-01-10 13:54:18 -0800 Patch wd-virtual-keys.diff text/plain 6131 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggOGY2OGY3ZDUzOGUuLmUwMTkxOTJkMGNkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTAxLTA5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IHByZXNzZWQgdmlydHVhbCBr ZXlzIG5vdCBjb3JyZWN0bHkgaGFuZGxlZCBpbiBhY3Rpb24gc2VxdWVuY2VzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU5OTcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBhcmUgYXNzdW1pbmcgdGhh dCBvbmx5IG9uZSB2aXJ0dWFsIGtleSBjYW4gYmUgcHJlc3NlZCBhbmQgdGhhdCBhIGtleSB1cCBh bHdheXMgcmVsZWFzZXMgdGhlIHByZXNzZWQgdmlydHVhbAorICAgICAgICBrZXkgaWYgYW55LiBX ZSBzaG91bGQga2VlcCBhIGxpc3Qgb2YgcHJlc3NlZCBrZXlzIGFuZCByZW1vdmUgdGhlbSBmcm9t IHRoZSBsaXN0IHdoZW4ga2V5IHVwIGhhcHBlbnMgZm9yIHRoZW0uCisKKyAgICAgICAgRml4ZXM6 IGltcG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMvcGVyZm9ybV9hY3Rpb25zL2tleV9tb2RpZmll cnMucHk6OnRlc3Rfc2hpZnRfbW9kaWZpZXJfZ2VuZXJhdGVzX2NhcGl0YWxfbGV0dGVyc1tcdWUw MDhdCisgICAgICAgICAgICAgICBpbXBvcnRlZC93M2Mvd2ViZHJpdmVyL3Rlc3RzL3BlcmZvcm1f YWN0aW9ucy9rZXlfbW9kaWZpZXJzLnB5Ojp0ZXN0X3NoaWZ0X21vZGlmaWVyX2dlbmVyYXRlc19j YXBpdGFsX2xldHRlcnNbXHVlMDUwXQorCisgICAgICAgICogU2Vzc2lvbi5jcHA6CisgICAgICAg IChXZWJEcml2ZXI6OlNlc3Npb246OnBlcmZvcm1BY3Rpb25zKToKKyAgICAgICAgKiBTZXNzaW9u Lmg6CisKIDIwMjAtMDEtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEu Y29tPgogCiAgICAgICAgIEF1dG9tYXRpb246IGV2YWx1YXRlSmF2YVNjcmlwdEZ1bmN0aW9uIHNo b3VsZCB1c2UgUHJvbWlzZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5j cHAgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uY3BwCmluZGV4IGY3MTc1Yjg1MWVlLi45ZWNi MmM5NGM0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uLmNwcAorKysgYi9T b3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uY3BwCkBAIC0yNTc2LDE3ICsyNTc2LDIwIEBAIHZvaWQg U2Vzc2lvbjo6cGVyZm9ybUFjdGlvbnMoVmVjdG9yPFZlY3RvcjxBY3Rpb24+PiYmIGFjdGlvbnNC eVRpY2ssIEZ1bmN0aW9uPHZvCiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGNh c2UgQWN0aW9uOjpUeXBlOjpLZXk6CiAgICAgICAgICAgICAgICAgICAgIHN3aXRjaCAoYWN0aW9u LnN1YnR5cGUpIHsKLSAgICAgICAgICAgICAgICAgICAgY2FzZSBBY3Rpb246OlN1YnR5cGU6Oktl eVVwOgotICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGN1cnJlbnRTdGF0ZS5wcmVzc2VkVmly dHVhbEtleSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBjdXJyZW50U3RhdGUucHJlc3Nl ZFZpcnR1YWxLZXkgPSBXVEY6Om51bGxvcHQ7CisgICAgICAgICAgICAgICAgICAgIGNhc2UgQWN0 aW9uOjpTdWJ0eXBlOjpLZXlVcDogeworICAgICAgICAgICAgICAgICAgICAgICAgS2V5TW9kaWZp ZXIgbW9kaWZpZXI7CisgICAgICAgICAgICAgICAgICAgICAgICBhdXRvIHZpcnR1YWxLZXkgPSB2 aXJ0dWFsS2V5Rm9yS2V5KGFjdGlvbi5rZXkudmFsdWUoKVswXSwgbW9kaWZpZXIpOworICAgICAg ICAgICAgICAgICAgICAgICAgaWYgKCF2aXJ0dWFsS2V5LmlzTnVsbCgpKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGN1cnJlbnRTdGF0ZS5wcmVzc2VkVmlydHVhbEtleXMucmVtb3ZlKHZp cnR1YWxLZXkpOwogICAgICAgICAgICAgICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGN1cnJlbnRTdGF0ZS5wcmVzc2VkS2V5ID0gV1RGOjpudWxsb3B0OwogICAg ICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgICAgICAgICAgY2FzZSBBY3Rpb246OlN1YnR5cGU6OktleURvd246IHsKICAgICAgICAg ICAgICAgICAgICAgICAgIEtleU1vZGlmaWVyIG1vZGlmaWVyOwogICAgICAgICAgICAgICAgICAg ICAgICAgYXV0byB2aXJ0dWFsS2V5ID0gdmlydHVhbEtleUZvcktleShhY3Rpb24ua2V5LnZhbHVl KClbMF0sIG1vZGlmaWVyKTsKICAgICAgICAgICAgICAgICAgICAgICAgIGlmICghdmlydHVhbEtl eS5pc051bGwoKSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBjdXJyZW50U3RhdGUucHJl c3NlZFZpcnR1YWxLZXkgPSB2aXJ0dWFsS2V5OworICAgICAgICAgICAgICAgICAgICAgICAgICAg IGN1cnJlbnRTdGF0ZS5wcmVzc2VkVmlydHVhbEtleXMuYWRkKHZpcnR1YWxLZXkpOwogICAgICAg ICAgICAgICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGN1cnJl bnRTdGF0ZS5wcmVzc2VkS2V5ID0gYWN0aW9uLmtleS52YWx1ZSgpOwogICAgICAgICAgICAgICAg ICAgICAgICAgYnJlYWs7CkBAIC0yNjAzLDEwICsyNjA2LDExIEBAIHZvaWQgU2Vzc2lvbjo6cGVy Zm9ybUFjdGlvbnMoVmVjdG9yPFZlY3RvcjxBY3Rpb24+PiYmIGFjdGlvbnNCeVRpY2ssIEZ1bmN0 aW9uPHZvCiAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgaWYgKGN1 cnJlbnRTdGF0ZS5wcmVzc2VkS2V5KQogICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGUtPnNl dFN0cmluZygicHJlc3NlZENoYXJLZXkiX3MsIGN1cnJlbnRTdGF0ZS5wcmVzc2VkS2V5LnZhbHVl KCkpOwotICAgICAgICAgICAgICAgICAgICBpZiAoY3VycmVudFN0YXRlLnByZXNzZWRWaXJ0dWFs S2V5KSB7CisgICAgICAgICAgICAgICAgICAgIGlmICghY3VycmVudFN0YXRlLnByZXNzZWRWaXJ0 dWFsS2V5cy5pc0VtcHR5KCkpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBz dXBwb3J0IHBhcnNpbmcgYW5kIHRyYWNraW5nIG11bHRpcGxlIHZpcnR1YWwga2V5cy4KICAgICAg ICAgICAgICAgICAgICAgICAgIFJlZjxKU09OOjpBcnJheT4gdmlydHVhbEtleXMgPSBKU09OOjpB cnJheTo6Y3JlYXRlKCk7Ci0gICAgICAgICAgICAgICAgICAgICAgICB2aXJ0dWFsS2V5cy0+cHVz aFN0cmluZyhjdXJyZW50U3RhdGUucHJlc3NlZFZpcnR1YWxLZXkudmFsdWUoKSk7CisgICAgICAg ICAgICAgICAgICAgICAgICBmb3IgKGNvbnN0IGF1dG8mIHZpcnR1YWxLZXkgOiBjdXJyZW50U3Rh dGUucHJlc3NlZFZpcnR1YWxLZXlzKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZpcnR1 YWxLZXlzLT5wdXNoU3RyaW5nKHZpcnR1YWxLZXkpOwogICAgICAgICAgICAgICAgICAgICAgICAg c3RhdGUtPnNldEFycmF5KCJwcmVzc2VkVmlydHVhbEtleXMiX3MsIFdURk1vdmUodmlydHVhbEtl eXMpKTsKICAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICBicmVhazsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5oIGIvU291cmNlL1dlYkRyaXZl ci9TZXNzaW9uLmgKaW5kZXggZDQ5ZTdjMTFjYjQuLjg0NDlhYTg5ODhiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uaAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24u aApAQCAtMjksNiArMjksNyBAQAogI2luY2x1ZGUgIkNhcGFiaWxpdGllcy5oIgogI2luY2x1ZGUg PHd0Zi9Gb3J3YXJkLmg+CiAjaW5jbHVkZSA8d3RmL0Z1bmN0aW9uLmg+CisjaW5jbHVkZSA8d3Rm L0hhc2hTZXQuaD4KICNpbmNsdWRlIDx3dGYvSlNPTlZhbHVlcy5oPgogI2luY2x1ZGUgPHd0Zi9P cHRpb25TZXQuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgpAQCAtMjAyLDcgKzIwMyw3 IEBAIHByaXZhdGU6CiAgICAgICAgIFN0cmluZyBzdWJ0eXBlOwogICAgICAgICBPcHRpb25hbDxN b3VzZUJ1dHRvbj4gcHJlc3NlZEJ1dHRvbjsKICAgICAgICAgT3B0aW9uYWw8U3RyaW5nPiBwcmVz c2VkS2V5OwotICAgICAgICBPcHRpb25hbDxTdHJpbmc+IHByZXNzZWRWaXJ0dWFsS2V5OworICAg ICAgICBIYXNoU2V0PFN0cmluZz4gcHJlc3NlZFZpcnR1YWxLZXlzOwogICAgIH07CiAgICAgSW5w dXRTb3VyY2VTdGF0ZSYgaW5wdXRTb3VyY2VTdGF0ZShjb25zdCBTdHJpbmcmIGlkKTsKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxv ZwppbmRleCBiMjM2MjM2NmNmMi4uZGRhZDU2Njg1ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMjAtMDEtMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFdlYkRyaXZlcjogcHJlc3NlZCB2aXJ0dWFsIGtleXMgbm90IGNvcnJlY3Rs eSBoYW5kbGVkIGluIGFjdGlvbiBzZXF1ZW5jZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTk5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gbW9kaWZpZXJzIGFyZSBwcmVzZW50IHdlIG5lZWQg dG8gdHJhbnNsYXRlIHRoZSBrZXlzIHRoYXQgbWlnaHQgYmUgYWZmZWN0ZWQgYnkgdGhlIG1vZGlm aWVycy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BdXRvbWF0aW9uL2d0ay9XZWJBdXRvbWF0aW9u U2Vzc2lvbkd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OmRvS2V5U3Ryb2tlRXZlbnQpOgorCiAy MDIwLTAxLTA5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBBdXRvbWF0aW9uOiByZXNvbHZlQ2hpbGRGcmFtZVdpdGhOb2RlSGFuZGxlIHNob3Vs ZCByZXR1cm4gTm9kZU5vdEZvdW5kIHdoZW4gbm9kZSBkb2Vzbid0IGV4aXN0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXRvbWF0aW9uL2d0ay9XZWJBdXRvbWF0aW9uU2Vz c2lvbkd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXRvbWF0aW9uL2d0ay9XZWJB dXRvbWF0aW9uU2Vzc2lvbkd0ay5jcHAKaW5kZXggZWU2NjVjMmUzNDYuLjI4YzYxOGNiMWE5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXRvbWF0aW9uL2d0ay9XZWJBdXRv bWF0aW9uU2Vzc2lvbkd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0b21h dGlvbi9ndGsvV2ViQXV0b21hdGlvblNlc3Npb25HdGsuY3BwCkBAIC0xNTUsNiArMTU1LDExIEBA IHN0YXRpYyB2b2lkIGRvS2V5U3Ryb2tlRXZlbnQoR2RrRXZlbnRUeXBlIHR5cGUsIEd0a1dpZGdl dCogd2lkZ2V0LCB1bnNpZ25lZCBrZXlWCiAgICAgaWYgKGdka19rZXltYXBfZ2V0X2VudHJpZXNf Zm9yX2tleXZhbChnZGtfa2V5bWFwX2dldF9kZWZhdWx0KCksIGtleVZhbCwgJmtleXMub3V0UHRy KCksICZrZXlzQ291bnQpICYmIGtleXNDb3VudCkKICAgICAgICAgZXZlbnQtPmtleS5oYXJkd2Fy ZV9rZXljb2RlID0ga2V5cy5nZXQoKVswXS5rZXljb2RlOwogCisgICAgaWYgKHN0YXRlKSB7Cisg ICAgICAgIGdka19rZXltYXBfdHJhbnNsYXRlX2tleWJvYXJkX3N0YXRlKGdka19rZXltYXBfZ2V0 X2RlZmF1bHQoKSwgZXZlbnQtPmtleS5oYXJkd2FyZV9rZXljb2RlLCBzdGF0aWNfY2FzdDxHZGtN b2RpZmllclR5cGU+KHN0YXRlKSwKKyAgICAgICAgICAgIDAsICZldmVudC0+a2V5LmtleXZhbCwg bnVsbHB0ciwgbnVsbHB0ciwgbnVsbHB0cik7CisgICAgfQorCiAgICAgZ3RrX21haW5fZG9fZXZl bnQoZXZlbnQuZ2V0KCkpOwogICAgIGlmIChkb1JlbGVhc2VBZnRlclByZXNzKSB7CiAgICAgICAg IEFTU0VSVCh0eXBlID09IEdES19LRVlfUFJFU1MpOwo=