205995 2020-01-09 03:07:01 -0800 <iframe> attributes should be processed on "srcdoc" attribute removal 2020-01-13 23:56:15 -0800 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Trivial --- 1 ashvayka ashvayka cdumez commit-queue darin esprehn+autocc ews-watchlist ggaren gyuyoung.kim webkit-bug-importer oldest_to_newest 1604564 0 ashvayka 2020-01-09 03:07:01 -0800 Per spec, "srcdoc" attribute of an <iframe> takes precedence over "src". However, existing handling of "srcdoc" in HTMLFrameElementBase::parseAttribute does not check if the attribute was set or removed. As a result, removal of "srcdoc" attribute navigates the <iframe> to "about:srcdoc" instead of URL in value of "src" attribute. WHATWG HTML: https://html.spec.whatwg.org/multipage/iframe-embed-object.html#otherwise-steps-for-iframe-or-frame-elements 1604567 1 387212 ashvayka 2020-01-09 03:20:50 -0800 Created attachment 387212 Patch 1606283 2 commit-queue 2020-01-13 23:54:36 -0800 The commit-queue encountered the following flaky tests while processing attachment 387212: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1606284 3 387212 commit-queue 2020-01-13 23:55:06 -0800 Comment on attachment 387212 Patch Clearing flags on attachment: 387212 Committed r254498: <https://trac.webkit.org/changeset/254498> 1606285 4 commit-queue 2020-01-13 23:55:08 -0800 All reviewed patches have been landed. Closing bug. 1606286 5 webkit-bug-importer 2020-01-13 23:56:15 -0800 <rdar://problem/58559565> 387212 2020-01-09 03:20:50 -0800 2020-01-13 23:55:06 -0800 Patch bug-205995-20200109132049.patch text/plain 4396 ashvayka U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzllYjI1MjY1YWNjMjk4 NGYzOWRjMDY1NzI2ZjliZDRlODdhODgxYy4uZTNiYTg5NDJmN2MzY2MxZjhmYzE0NzBiZjgxNGNj MDdkYjdhYjEyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTAxLTA5ICBBbGV4 ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KKworICAgICAgICA8aWZyYW1lPiBh dHRyaWJ1dGVzIHNob3VsZCBiZSBwcm9jZXNzZWQgb24gInNyY2RvYyIgYXR0cmlidXRlIHJlbW92 YWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTk5 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6 IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQt Y29udGVudC90aGUtaWZyYW1lLWVsZW1lbnQvc3JjZG9jX3Byb2Nlc3NfYXR0cmlidXRlcy5odG1s CisKKyAgICAgICAgUGVyIHNwZWMsICJzcmNkb2MiIGF0dHJpYnV0ZSBvZiBhbiA8aWZyYW1lPiB0 YWtlcyBwcmVjZWRlbmNlIG92ZXIgInNyYyIgWzFdLgorICAgICAgICBCZWZvcmUgdGhpcyBjaGFu Z2UsICJzcmNkb2MiIGhhbmRsaW5nIGluIEhUTUxGcmFtZUVsZW1lbnRCYXNlOjpwYXJzZUF0dHJp YnV0ZSBkaWRuJ3QgY2hlY2sgd2hldGhlcgorICAgICAgICB0aGUgYXR0cmlidXRlIHdhcyBzZXQg b3IgcmVtb3ZlZC4gQXMgYSByZXN1bHQsIHJlbW92YWwgb2YgInNyY2RvYyIgYXR0cmlidXRlIG5h dmlnYXRlZCB0aGUgPGlmcmFtZT4KKyAgICAgICAgdG8gImFib3V0OnNyY2RvYyIgaW5zdGVhZCBv ZiBVUkwgaW4gdmFsdWUgb2YgInNyYyIgYXR0cmlidXRlLgorCisgICAgICAgIFdpdGggdGhpcyBj aGFuZ2UsIDxpZnJhbWU+IGF0dHJpYnV0ZXMgcHJvY2Vzc2luZyBtYXRjaGVzIENocm9tZSBhbmQg RmlyZWZveC4KKworICAgICAgICBbMV0gaHR0cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9yZy9tdWx0 aXBhZ2UvaWZyYW1lLWVtYmVkLW9iamVjdC5odG1sI3Byb2Nlc3MtdGhlLWlmcmFtZS1hdHRyaWJ1 dGVzCisKKyAgICAgICAgKiBodG1sL0hUTUxGcmFtZUVsZW1lbnRCYXNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxGcmFtZUVsZW1lbnRCYXNlOjpwYXJzZUF0dHJpYnV0ZSk6CisKIDIwMjAt MDEtMDggIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWR1 Y2UgYmluYXJ5IHNpemUgYnkgcHVyZ2luZyBDKysgdHlwZSBpbmZvcm1hdGlvbiBpbiBPYmplY3Rp dmUtQyBmaWVsZHMgYW5kIHBhcmFtZXRlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRnJh bWVFbGVtZW50QmFzZS5jcHAKaW5kZXggNTAwZjcxNTYyYjdkNjNjZTc1N2M3MzNhNzI1MWQ1ZjEz YzlmNDVkMS4uMzBiMWI0NGZkNGJjMjE0MmU5MWQ5NmM4Mjc5ZDk4ZThkNTQyOWFiYSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHAKQEAgLTEwMiw5ICsx MDIsMTQgQEAgdm9pZCBIVE1MRnJhbWVFbGVtZW50QmFzZTo6b3BlblVSTChMb2NrSGlzdG9yeSBs b2NrSGlzdG9yeSwgTG9ja0JhY2tGb3J3YXJkTGlzdAogCiB2b2lkIEhUTUxGcmFtZUVsZW1lbnRC YXNlOjpwYXJzZUF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lLCBjb25zdCBBdG9t U3RyaW5nJiB2YWx1ZSkKIHsKLSAgICBpZiAobmFtZSA9PSBzcmNkb2NBdHRyKQotICAgICAgICBz ZXRMb2NhdGlvbigiYWJvdXQ6c3JjZG9jIik7Ci0gICAgZWxzZSBpZiAobmFtZSA9PSBzcmNBdHRy ICYmICFoYXNBdHRyaWJ1dGVXaXRob3V0U3luY2hyb25pemF0aW9uKHNyY2RvY0F0dHIpKQorICAg IGlmIChuYW1lID09IHNyY2RvY0F0dHIpIHsKKyAgICAgICAgaWYgKHZhbHVlLmlzTnVsbCgpKSB7 CisgICAgICAgICAgICBjb25zdCBBdG9tU3RyaW5nJiBzcmNWYWx1ZSA9IGF0dHJpYnV0ZVdpdGhv dXRTeW5jaHJvbml6YXRpb24oc3JjQXR0cik7CisgICAgICAgICAgICBpZiAoIXNyY1ZhbHVlLmlz TnVsbCgpKQorICAgICAgICAgICAgICAgIHNldExvY2F0aW9uKHN0cmlwTGVhZGluZ0FuZFRyYWls aW5nSFRNTFNwYWNlcyhzcmNWYWx1ZSkpOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIHNl dExvY2F0aW9uKCJhYm91dDpzcmNkb2MiKTsKKyAgICB9IGVsc2UgaWYgKG5hbWUgPT0gc3JjQXR0 ciAmJiAhaGFzQXR0cmlidXRlV2l0aG91dFN5bmNocm9uaXphdGlvbihzcmNkb2NBdHRyKSkKICAg ICAgICAgc2V0TG9jYXRpb24oc3RyaXBMZWFkaW5nQW5kVHJhaWxpbmdIVE1MU3BhY2VzKHZhbHVl KSk7CiAgICAgZWxzZQogICAgICAgICBIVE1MRnJhbWVPd25lckVsZW1lbnQ6OnBhcnNlQXR0cmli dXRlKG5hbWUsIHZhbHVlKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IGYyNmU3 MjQzOTdjOWZmYzAwZWE2MmFmNTY1ZjU3YzdhM2MzOWQ3ZGEuLmFhZjlmMzZlYTY0MjJjMzg2YjUx YzZjZDhjMmI3OTUxOTc0MWQ0NzggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEyIEBACisyMDIwLTAxLTA5ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdt YWlsLmNvbT4KKworICAgICAgICA8aWZyYW1lPiBhdHRyaWJ1dGVzIHNob3VsZCBiZSBwcm9jZXNz ZWQgb24gInNyY2RvYyIgYXR0cmlidXRlIHJlbW92YWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTk5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50 aWNzL2VtYmVkZGVkLWNvbnRlbnQvdGhlLWlmcmFtZS1lbGVtZW50L3NyY2RvY19wcm9jZXNzX2F0 dHJpYnV0ZXMtZXhwZWN0ZWQudHh0OgorCiAyMDIwLTAxLTA4ICBOb2FtIFJvc2VudGhhbCAgPG5v YW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICA8aW1nPi5uYXR1cmFsV2lkdGggc2hvdWxkIHJldHVy biB0aGUgZGVuc2l0eS1jb3JyZWN0ZWQgaW50cmluc2ljIHdpZHRoCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2Vt YmVkZGVkLWNvbnRlbnQvdGhlLWlmcmFtZS1lbGVtZW50L3NyY2RvY19wcm9jZXNzX2F0dHJpYnV0 ZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9odG1sL3NlbWFudGljcy9lbWJlZGRlZC1jb250ZW50L3RoZS1pZnJhbWUtZWxlbWVudC9z cmNkb2NfcHJvY2Vzc19hdHRyaWJ1dGVzLWV4cGVjdGVkLnR4dAppbmRleCBkZTliNjdhMjE3Yjc5 Zjg2NjRlY2EzYWEwMjU5MTUwMzczNWUwYzJlLi4yMjc5ZWMyMWFhOWRjYmU4NzU1Y2NkNjlhMjZi YTdiMWRhYjllMmRhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2VtYmVkZGVkLWNvbnRlbnQvdGhlLWlmcmFtZS1l bGVtZW50L3NyY2RvY19wcm9jZXNzX2F0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1i ZWRkZWQtY29udGVudC90aGUtaWZyYW1lLWVsZW1lbnQvc3JjZG9jX3Byb2Nlc3NfYXR0cmlidXRl cy1leHBlY3RlZC50eHQKQEAgLTIsNSArMiw1IEBACiAKIFBBU1MgQWRkaW5nIGBzcmNkb2NgIGF0 dHJpYnV0ZSB0cmlnZ2VycyBhdHRyaWJ1dGVzIHByb2Nlc3NpbmcgCiBQQVNTIFNldHRpbmcgYHNy Y2RvY2AgKHZpYSBwcm9wZXJ0eSkgdHJpZ2dlcnMgYXR0cmlidXRlcyBwcm9jZXNzaW5nIAotRkFJ TCBSZW1vdmluZyBgc3JjZG9jYCBhdHRyaWJ1dGUgdHJpZ2dlcnMgYXR0cmlidXRlcyBwcm9jZXNz aW5nIGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkICJibG9iOiIgYnV0IGdvdCAiYWJvdXQ6IgorUEFT UyBSZW1vdmluZyBgc3JjZG9jYCBhdHRyaWJ1dGUgdHJpZ2dlcnMgYXR0cmlidXRlcyBwcm9jZXNz aW5nIAogCg==