205986 2020-01-08 21:31:31 -0800 Fullscreen videos do not enter PiP in first tap 2020-01-09 12:08:32 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build iPhone / iPad iOS 13 RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 commit-queue eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1604497 0 peng.liu6 2020-01-08 21:31:31 -0800 Fullscreen videos do not enter PiP in first tap 1604505 1 peng.liu6 2020-01-08 21:43:12 -0800 <rdar://problem/58384092> 1604506 2 387190 peng.liu6 2020-01-08 21:44:42 -0800 Created attachment 387190 Patch 1604760 3 387190 commit-queue 2020-01-09 12:08:30 -0800 Comment on attachment 387190 Patch Clearing flags on attachment: 387190 Committed r254287: <https://trac.webkit.org/changeset/254287> 1604761 4 commit-queue 2020-01-09 12:08:32 -0800 All reviewed patches have been landed. Closing bug. 387190 2020-01-08 21:44:42 -0800 2020-01-09 12:08:30 -0800 Patch bug-205986-20200108214442.patch text/plain 2636 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQxMDExNzg5NTljOGY5N2U4 ZjY4M2ZlMDdhOTE0OGQ1NjI5NTIzYmIuLjdmMjA5YjE1MmI5YmQ5ODk3YWZiNjY3ODRiMGFiY2Fi ZmZmNDQ1NTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDEtMDggIFBlbmcgTGl1 ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KKworICAgICAgICBGdWxsc2NyZWVuIHZpZGVvcyBkbyBu b3QgZW50ZXIgUGlQIGluIGZpcnN0IHRhcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA1OTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBlc3NlbnRpYWxseSByZXZlcnRzIHRoZSBmaXgg Zm9yIHdlYmtpdC5vcmcvYi8yMDQ0NjEuCisgICAgICAgIFRoZSBmaXggZm9yIHdlYmtpdC5vcmcv Yi8yMDQ0NjEgZGVwZW5kcyBvbiBhIGZpeCBpbiBBVktpdCBhbG9uZworICAgICAgICB3aXRoIGEg Y29ycmVzcG9uZGluZyB1cGRhdGUgaW4gV2ViS2l0ICh3ZWJraXQub3JnL2IvMjA0OTc5KS4KKyAg ICAgICAgV2Ugd2lsbCBuZWVkIHRvIHJlYXBwbHkgdGhlIGZpeCBmb3Igd2Via2l0Lm9yZy9iLzIw NDQ2MSBhZnRlciB0aGV5IGFyZSBsYW5kZWQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29h L1ZpZGVvRnVsbHNjcmVlbk1hbmFnZXIubW06CisgICAgICAgIChXZWJLaXQ6OlZpZGVvRnVsbHNj cmVlbk1hbmFnZXI6OmVudGVyVmlkZW9GdWxsc2NyZWVuRm9yVmlkZW9FbGVtZW50KToKKyAgICAg ICAgKFdlYktpdDo6VmlkZW9GdWxsc2NyZWVuTWFuYWdlcjo6ZXhpdFZpZGVvRnVsbHNjcmVlbkZv clZpZGVvRWxlbWVudCk6CisKIDIwMjAtMDEtMDggIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFw cGxlLmNvbT4KIAogICAgICAgICBSZWR1Y2UgYmluYXJ5IHNpemUgYnkgcHVyZ2luZyBDKysgdHlw ZSBpbmZvcm1hdGlvbiBpbiBPYmplY3RpdmUtQyBmaWVsZHMgYW5kIHBhcmFtZXRlcnMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9WaWRlb0Z1bGxzY3JlZW5NYW5h Z2VyLm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1ZpZGVvRnVsbHNjcmVlbk1h bmFnZXIubW0KaW5kZXggNTNhMDU2NDkzMjBhNTg4OGVjMTUzMzNkZjNhZGU4OTU4OGE0NzJlMS4u Njg0ZWJhYmFkMzZjZGYzOTEwZDdiNjJjYWNiMTY0OGE0YjliMjJmNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1ZpZGVvRnVsbHNjcmVlbk1hbmFnZXIubW0KKysr IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1ZpZGVvRnVsbHNjcmVlbk1hbmFnZXIu bW0KQEAgLTI0OSw4ICsyNDksNiBAQCB2b2lkIFZpZGVvRnVsbHNjcmVlbk1hbmFnZXI6OmVudGVy VmlkZW9GdWxsc2NyZWVuRm9yVmlkZW9FbGVtZW50KEhUTUxWaWRlb0VsZW1lbgogCiAgICAgYXV0 byBbbW9kZWwsIGludGVyZmFjZV0gPSBlbnN1cmVNb2RlbEFuZEludGVyZmFjZShjb250ZXh0SWQp OwogICAgIEhUTUxNZWRpYUVsZW1lbnRFbnVtczo6VmlkZW9GdWxsc2NyZWVuTW9kZSBvbGRNb2Rl ID0gaW50ZXJmYWNlLT5mdWxsc2NyZWVuTW9kZSgpOwotICAgIGlmIChvbGRNb2RlID09IG1vZGUp Ci0gICAgICAgIHJldHVybjsKIAogICAgIGFkZENsaWVudEZvckNvbnRleHQoY29udGV4dElkKTsK ICAgICBpZiAoIWludGVyZmFjZS0+bGF5ZXJIb3N0aW5nQ29udGV4dCgpKQpAQCAtMjk5LDE0ICsy OTcsMTAgQEAgdm9pZCBWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyOjpleGl0VmlkZW9GdWxsc2NyZWVu Rm9yVmlkZW9FbGVtZW50KFdlYkNvcmU6OkhUTUxWaWQKIAogICAgIHVpbnQ2NF90IGNvbnRleHRJ ZCA9IG1fdmlkZW9FbGVtZW50cy5nZXQoJnZpZGVvRWxlbWVudCk7CiAgICAgYXV0byYgaW50ZXJm YWNlID0gZW5zdXJlSW50ZXJmYWNlKGNvbnRleHRJZCk7Ci0gICAgSFRNTE1lZGlhRWxlbWVudEVu dW1zOjpWaWRlb0Z1bGxzY3JlZW5Nb2RlIG9sZE1vZGUgPSBpbnRlcmZhY2UuZnVsbHNjcmVlbk1v ZGUoKTsKLSAgICBpZiAob2xkTW9kZSA9PSBIVE1MTWVkaWFFbGVtZW50RW51bXM6OlZpZGVvRnVs bHNjcmVlbk1vZGVOb25lKQotICAgICAgICByZXR1cm47Ci0KICAgICBpbnRlcmZhY2Uuc2V0VGFy Z2V0SXNGdWxsc2NyZWVuKGZhbHNlKTsKLQogICAgIGlmIChpbnRlcmZhY2UuYW5pbWF0aW9uU3Rh dGUoKSAhPSBWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VDb250ZXh0OjpBbmltYXRpb25UeXBlOjpO b25lKQogICAgICAgICByZXR1cm47CisKICAgICBpbnRlcmZhY2Uuc2V0QW5pbWF0aW9uU3RhdGUo VmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQ29udGV4dDo6QW5pbWF0aW9uVHlwZTo6RnJvbUZ1bGxz Y3JlZW4pOwogICAgIG1fcGFnZS0+c2VuZChNZXNzYWdlczo6VmlkZW9GdWxsc2NyZWVuTWFuYWdl clByb3h5OjpFeGl0RnVsbHNjcmVlbihjb250ZXh0SWQsIGlubGluZVZpZGVvRnJhbWUodmlkZW9F bGVtZW50KSkpOwogfQo=