205984 2020-01-08 20:29:05 -0800 Reformat FrameView logging 2020-01-09 10:02:27 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205679 InRadar P2 Normal --- 1 krollin krollin bfulgham cdumez commit-queue webkit-bug-importer zalan oldest_to_newest 1604485 0 krollin 2020-01-08 20:29:05 -0800 Update the format used by FrameView in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form: <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values> So, for example: 0x4a1cf8010 - FrameView::fireLayoutRelatedMilestonesIfNeeded() - firing first visually non-empty layout milestone on the main frame becomes: 0x561be8010 - [frame=0x55d47e000, main=1] FrameView::fireLayoutRelatedMilestonesIfNeeded: Firing first visually non-empty layout milestone on the main frame 1604486 1 webkit-bug-importer 2020-01-08 20:29:13 -0800 <rdar://problem/58431722> 1604487 2 387184 krollin 2020-01-08 20:30:57 -0800 Created attachment 387184 Patch 1604662 3 387184 bfulgham 2020-01-09 09:01:31 -0800 Comment on attachment 387184 Patch r=me. The Mac-wk2 failures seem totally unrelated (and perhaps an error in the EWS system itself). 1604686 4 387184 commit-queue 2020-01-09 10:02:25 -0800 Comment on attachment 387184 Patch Clearing flags on attachment: 387184 Committed r254267: <https://trac.webkit.org/changeset/254267> 1604687 5 commit-queue 2020-01-09 10:02:27 -0800 All reviewed patches have been landed. Closing bug. 387184 2020-01-08 20:30:57 -0800 2020-01-09 10:02:25 -0800 Patch bug-205984-20200108203055.patch text/plain 3290 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDkwMjhlY2U1ZGZlM2Zi ODMwYmQwNWQ1OGI0NGIyNmRlZGVjZGU3YS4uMDU1ZWQ3OTgzMzVlNTJiNjc2Y2IzNWZhOWRlMGM3 YjdhMDZjNWQ2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDIwLTAxLTA4ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZWZvcm1hdCBGcmFtZVZp ZXcgbG9nZ2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA1OTg0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODQzMTcyMj4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGhlIGZvcm1hdCB1 c2VkIGJ5IEZyYW1lVmlldyBpbiBpdHMgUkVMRUFTRV9MT0cgbG9nZ2luZy4gVXNlCisgICAgICAg IHRoZSBmb3JtYXQgdXNlZCBieSBXZWJQYWdlUHJveHkgYW5kIE5ldHdvcmtSZXNvdXJjZUxvYWRl ciwgd2hpY2ggaXMKKyAgICAgICAgZ2VuZXJhbGx5IG9mIHRoZSBmb3JtOgorCisgICAgICAgICAg ICA8b2JqZWN0LWFkZHJlc3M+IC0gWzx2YWx1ZXMgdGhhdCBoZWxwIHRocmVhZCB0b2dldGhlciBv cGVyYXRpb25zPl0gPGNsYXNzPjo6PG1ldGhvZD46IDxtZXNzYWdlIGFuZCBvdGhlciB1c2VmdWwg dmFsdWVzPgorCisgICAgICAgIFNvLCBmb3IgZXhhbXBsZToKKworICAgICAgICAgICAgMHg0YTFj ZjgwMTAgLSBGcmFtZVZpZXc6OmZpcmVMYXlvdXRSZWxhdGVkTWlsZXN0b25lc0lmTmVlZGVkKCkg LSBmaXJpbmcgZmlyc3QgdmlzdWFsbHkgbm9uLWVtcHR5IGxheW91dCBtaWxlc3RvbmUgb24gdGhl IG1haW4gZnJhbWUKKworICAgICAgICBiZWNvbWVzOgorCisgICAgICAgICAgICAweDU2MWJlODAx MCAtIFtmcmFtZT0weDU1ZDQ3ZTAwMCwgbWFpbj0xXSBGcmFtZVZpZXc6OmZpcmVMYXlvdXRSZWxh dGVkTWlsZXN0b25lc0lmTmVlZGVkOiBGaXJpbmcgZmlyc3QgdmlzdWFsbHkgbm9uLWVtcHR5IGxh eW91dCBtaWxlc3RvbmUgb24gdGhlIG1haW4gZnJhbWUKKworICAgICAgICBObyBuZXcgdGVzdHMg LS0gbm8gbmV3IG9yIGNoYW5nZWQgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHBhZ2UvRnJh bWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6cGFpbnRDb250ZW50cyk6 CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmZpcmVMYXlvdXRSZWxhdGVkTWlsZXN0b25l c0lmTmVlZGVkKToKKwogMjAyMC0wMS0wNyAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdl YmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI1NDEzMi4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCA1YzI3Nzk3ZDY4N2U0ODlkZGZlYzA4OTEzYTYz MjIwNmY0YzE3ZWUxLi4yMjVhNWRhZWE1NWZjMDNmZDBlMThhNTI3ODc0MjEzOWRlYmYyMDg4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0xMzIsNyArMTMyLDcgQEAKICNpbmNsdWRl ICJMYXlvdXRDb250ZXh0LmgiCiAjZW5kaWYKIAotI2RlZmluZSBSRUxFQVNFX0xPR19JRl9BTExP V0VEKGZtdCwgLi4uKSBSRUxFQVNFX0xPR19JRihmcmFtZSgpLnBhZ2UoKSAmJiBmcmFtZSgpLnBh Z2UoKS0+aXNBbHdheXNPbkxvZ2dpbmdBbGxvd2VkKCksIExheW91dCwgIiVwIC0gRnJhbWVWaWV3 OjoiIGZtdCwgdGhpcywgIyNfX1ZBX0FSR1NfXykKKyNkZWZpbmUgRlJBTUVWSUVXX1JFTEVBU0Vf TE9HX0lGX0FMTE9XRUQoY2hhbm5lbCwgZm10LCAuLi4pIFJFTEVBU0VfTE9HX0lGKGZyYW1lKCku cGFnZSgpICYmIGZyYW1lKCkucGFnZSgpLT5pc0Fsd2F5c09uTG9nZ2luZ0FsbG93ZWQoKSwgY2hh bm5lbCwgIiVwIC0gW2ZyYW1lPSVwLCBtYWluPSVkXSBGcmFtZVZpZXc6OiIgZm10LCB0aGlzLCAm ZnJhbWUoKSwgZnJhbWUoKS5pc01haW5GcmFtZSgpLCAjI19fVkFfQVJHU19fKQogCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKQEAgLTQxODUsNyArNDE4NSw3IEBAIHZvaWQgRnJhbWVWaWV3OjpwYWlu dENvbnRlbnRzKEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgY29uc3QgSW50UmVjdCYgZGlydHlS ZWN0CiAKICAgICBBU1NFUlQoIW5lZWRzTGF5b3V0KCkpOwogICAgIGlmIChuZWVkc0xheW91dCgp KSB7Ci0gICAgICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoIkZyYW1lVmlldzo6cGFpbnRDb250 ZW50cygpIC0gbm90IHBhaW50aW5nIGJlY2F1c2UgcmVuZGVyIHRyZWUgbmVlZHMgbGF5b3V0IChp cyBtYWluIGZyYW1lICVkKSIsIGZyYW1lKCkuaXNNYWluRnJhbWUoKSk7CisgICAgICAgIEZSQU1F VklFV19SRUxFQVNFX0xPR19JRl9BTExPV0VEKExheW91dCwgInBhaW50Q29udGVudHM6IE5vdCBw YWludGluZyBiZWNhdXNlIHJlbmRlciB0cmVlIG5lZWRzIGxheW91dCIpOwogICAgICAgICByZXR1 cm47CiAgICAgfQogCkBAIC01MTU1LDcgKzUxNTUsNyBAQCB2b2lkIEZyYW1lVmlldzo6ZmlyZUxh eW91dFJlbGF0ZWRNaWxlc3RvbmVzSWZOZWVkZWQoKQogCiAgICAgaWYgKG1pbGVzdG9uZXNBY2hp ZXZlZCAmJiBmcmFtZSgpLmlzTWFpbkZyYW1lKCkpIHsKICAgICAgICAgaWYgKG1pbGVzdG9uZXNB Y2hpZXZlZC5jb250YWlucyhEaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXQpKQotICAgICAg ICAgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRCgiZmlyZUxheW91dFJlbGF0ZWRNaWxlc3RvbmVz SWZOZWVkZWQoKSAtIGZpcmluZyBmaXJzdCB2aXN1YWxseSBub24tZW1wdHkgbGF5b3V0IG1pbGVz dG9uZSBvbiB0aGUgbWFpbiBmcmFtZSIpOworICAgICAgICAgICAgRlJBTUVWSUVXX1JFTEVBU0Vf TE9HX0lGX0FMTE9XRUQoTGF5b3V0LCAiZmlyZUxheW91dFJlbGF0ZWRNaWxlc3RvbmVzSWZOZWVk ZWQ6IEZpcmluZyBmaXJzdCB2aXN1YWxseSBub24tZW1wdHkgbGF5b3V0IG1pbGVzdG9uZSBvbiB0 aGUgbWFpbiBmcmFtZSIpOwogICAgICAgICBmcmFtZSgpLmxvYWRlcigpLmRpZFJlYWNoTGF5b3V0 TWlsZXN0b25lKG1pbGVzdG9uZXNBY2hpZXZlZCk7CiAgICAgfQogfQo=