205983 2020-01-08 19:48:56 -0800 Object.keys should throw if called on module namespace object with uninitialized binding 2020-01-10 19:19:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=189034 InRadar P2 Trivial --- 1 ashvayka ashvayka caitp commit-queue ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1604481 0 ashvayka 2020-01-08 19:48:56 -0800 ECMA262: call stack is quite deep, please see "info" meta of the test ↓ Test262: https://test262.report/browse/language/module-code/namespace/internals/object-keys-binding-uninit.js 1604493 1 387186 ashvayka 2020-01-08 21:15:27 -0800 Created attachment 387186 Patch 1604495 2 ashvayka 2020-01-08 21:25:15 -0800 (In reply to Alexey Shvayka from comment #1) > Created attachment 387186 [details] > Patch All credit goes to Caitlin Potter: this patch was nicely extracted from her solution to https://bugs.webkit.org/show_bug.cgi?id=189034. 1604683 3 387186 ross.kirsling 2020-01-09 09:58:16 -0800 Comment on attachment 387186 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387186&action=review > Source/JavaScriptCore/ChangeLog:1 > +2020-01-08 Caitlin Potter <caitp@igalia.com> I recently learned (from r253987) that it's valid to insert two authors separated by "and" here -- might make sense in a case like this? > Source/JavaScriptCore/ChangeLog:10 > + If [[OwnPropertyKeys]] method of module namespace object is called by > + Object.keys or for/in loop, it should invoke [[GetOwnProperty]] on > + every binding so a ReferenceError is thrown if the binding is uninitialized. Wait, is [[OwnPropertyKeys]] directly relevant? It doesn't throw. Seems like [[GetOwnProperty]] is called from EnumerableOwnPropertyNames *after* [[OwnPropertyKeys]], no? https://tc39.es/ecma262/#sec-enumerableownpropertynames 1605338 4 387383 ashvayka 2020-01-10 15:18:09 -0800 Created attachment 387383 Patch Add myself as co-author and fix method name in ChangeLog. 1605343 5 ashvayka 2020-01-10 15:31:37 -0800 (In reply to Ross Kirsling from comment #3) > > I recently learned (from r253987) that it's valid to insert two authors > separated by "and" here -- might make sense in a case like this? Thank you for the tip. I think it makes sense to add myself there for bookkeeping purposes or so I could be contacted regarding the change. > Seems like [[GetOwnProperty]] is called from EnumerableOwnPropertyNames > *after* [[OwnPropertyKeys]], no? > https://tc39.es/ecma262/#sec-enumerableownpropertynames Nice catch! Indeed, throwing occurs after [[OwnPropertyKeys]]. I've replaced [[OwnPropertyKeys]] with JSModuleNamespaceObject::getOwnPropertyNames. 1605344 6 387383 ysuzuki 2020-01-10 15:31:54 -0800 Comment on attachment 387383 Patch r=me 1605345 7 ysuzuki 2020-01-10 15:32:53 -0800 (In reply to Yusuke Suzuki from comment #6) > Comment on attachment 387383 [details] > Patch > > r=me Land it after resolving Ross's comment :) 1605347 8 387383 ross.kirsling 2020-01-10 15:35:08 -0800 Comment on attachment 387383 Patch Alexey's comment came after his new patch, so it should be okay :D 1605468 9 387383 commit-queue 2020-01-10 19:18:06 -0800 Comment on attachment 387383 Patch Clearing flags on attachment: 387383 Committed r254390: <https://trac.webkit.org/changeset/254390> 1605469 10 commit-queue 2020-01-10 19:18:08 -0800 All reviewed patches have been landed. Closing bug. 1605470 11 webkit-bug-importer 2020-01-10 19:19:16 -0800 <rdar://problem/58499079> 387186 2020-01-08 21:15:27 -0800 2020-01-10 15:18:09 -0800 Patch bug-205983-20200109071526.patch text/plain 4790 ashvayka U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NjNjOWNkNGEyYmQwYzQwOWYwNzJlYzliY2I0YWI2N2IzNjgzMWY3Li5jN2E0Y2U2MDdhYmFiZDcw NjliOGRjMGIwOGU1NjUwOTI2YjllZTZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMC0wMS0wOCAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29t PgorCisgICAgICAgIE9iamVjdC5rZXlzIHNob3VsZCB0aHJvdyBpZiBjYWxsZWQgb24gbW9kdWxl IG5hbWVzcGFjZSBvYmplY3Qgd2l0aCB1bmluaXRpYWxpemVkIGJpbmRpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTk4MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIFtbT3duUHJvcGVydHlLZXlz XV0gbWV0aG9kIG9mIG1vZHVsZSBuYW1lc3BhY2Ugb2JqZWN0IGlzIGNhbGxlZCBieQorICAgICAg ICBPYmplY3Qua2V5cyBvciBmb3IvaW4gbG9vcCwgaXQgc2hvdWxkIGludm9rZSBbW0dldE93blBy b3BlcnR5XV0gb24KKyAgICAgICAgZXZlcnkgYmluZGluZyBzbyBhIFJlZmVyZW5jZUVycm9yIGlz IHRocm93biBpZiB0aGUgYmluZGluZyBpcyB1bmluaXRpYWxpemVkLgorCisgICAgICAgIENvbXBs ZXRlIGNhbGwgc3RhY2sgb2YgaW50ZXJuYWwgbWV0aG9kcyBhbmQgYWJzdHJhY3Qgb3BzIGlzIGlu ICJpbmZvIiBtZXRhIG9mCisgICAgICAgIEpTVGVzdHMvdGVzdDI2Mi90ZXN0L2xhbmd1YWdlL21v ZHVsZS1jb2RlL25hbWVzcGFjZS9pbnRlcm5hbHMvb2JqZWN0LWtleXMtYmluZGluZy11bmluaXQu anMKKworICAgICAgICAqIHJ1bnRpbWUvSlNNb2R1bGVOYW1lc3BhY2VPYmplY3QuY3BwOgorICAg ICAgICAoSlNDOjpKU01vZHVsZU5hbWVzcGFjZU9iamVjdDo6Z2V0T3duUHJvcGVydHlOYW1lcyk6 CisKIDIwMjAtMDEtMDYgIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgog CiAgICAgICAgIFN0cmluZy5wcm90b3R5cGUucmVwbGFjZSgpIGluY29ycmVjdGx5IGhhbmRsZXMg bmFtZWQgcmVmZXJlbmNlcyBvbiBSZWdFeHAgdy9vIG5hbWVkIGdyb3VwcwpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNNb2R1bGVOYW1lc3BhY2VPYmplY3QuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNNb2R1bGVOYW1lc3BhY2VPYmplY3Qu Y3BwCmluZGV4IDE3NTY4NmRjYzY4M2JlZjJmN2MzZGJkZDEwZDQ4MGEyMjg2MDc0YjIuLjJiZGIx MzA1ZWIwYzRiZTk2MDgwNjViZDM0ODU5YzdhZjE0OGIyYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTTW9kdWxlTmFtZXNwYWNlT2JqZWN0LmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU01vZHVsZU5hbWVzcGFjZU9iamVjdC5jcHAK QEAgLTIxMSwxMSArMjExLDIxIEBAIGJvb2wgSlNNb2R1bGVOYW1lc3BhY2VPYmplY3Q6OmRlbGV0 ZVByb3BlcnR5KEpTQ2VsbCogY2VsbCwgSlNHbG9iYWxPYmplY3QqIGdsb2JhCiAKIHZvaWQgSlNN b2R1bGVOYW1lc3BhY2VPYmplY3Q6OmdldE93blByb3BlcnR5TmFtZXMoSlNPYmplY3QqIGNlbGws IEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIFByb3BlcnR5TmFtZUFycmF5JiBwcm9wZXJ0 eU5hbWVzLCBFbnVtZXJhdGlvbk1vZGUgbW9kZSkKIHsKLSAgICAvLyBodHRwOi8vd3d3LmVjbWEt aW50ZXJuYXRpb25hbC5vcmcvZWNtYS0yNjIvNi4wLyNzZWMtbW9kdWxlLW5hbWVzcGFjZS1leG90 aWMtb2JqZWN0cy1vd25wcm9wZXJ0eWtleXMKKyAgICBWTSYgdm0gPSBnbG9iYWxPYmplY3QtPnZt KCk7CisgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOworCisgICAgLy8g aHR0cHM6Ly90YzM5LmVzL2VjbWEyNjIvI3NlYy1tb2R1bGUtbmFtZXNwYWNlLWV4b3RpYy1vYmpl Y3RzLW93bnByb3BlcnR5a2V5cwogICAgIEpTTW9kdWxlTmFtZXNwYWNlT2JqZWN0KiB0aGlzT2Jq ZWN0ID0ganNDYXN0PEpTTW9kdWxlTmFtZXNwYWNlT2JqZWN0Kj4oY2VsbCk7Ci0gICAgZm9yIChj b25zdCBhdXRvJiBuYW1lIDogdGhpc09iamVjdC0+bV9uYW1lcykKKyAgICBmb3IgKGNvbnN0IGF1 dG8mIG5hbWUgOiB0aGlzT2JqZWN0LT5tX25hbWVzKSB7CisgICAgICAgIGlmICghbW9kZS5pbmNs dWRlRG9udEVudW1Qcm9wZXJ0aWVzKCkpIHsKKyAgICAgICAgICAgIC8vIFBlcmZvcm0gW1tHZXRP d25Qcm9wZXJ0eV1dIHRvIHRocm93IFJlZmVyZW5jZUVycm9yIGlmIGJpbmRpbmcgaXMgdW5pbml0 aWFsaXplZC4KKyAgICAgICAgICAgIFByb3BlcnR5U2xvdCBzbG90KGNlbGwsIFByb3BlcnR5U2xv dDo6SW50ZXJuYWxNZXRob2RUeXBlOjpHZXRPd25Qcm9wZXJ0eSk7CisgICAgICAgICAgICB0aGlz T2JqZWN0LT5nZXRPd25Qcm9wZXJ0eVNsb3RDb21tb24oZ2xvYmFsT2JqZWN0LCBuYW1lLmltcGwo KSwgc2xvdCk7CisgICAgICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCB2b2lkKCkp OworICAgICAgICB9CiAgICAgICAgIHByb3BlcnR5TmFtZXMuYWRkKG5hbWUuaW1wbCgpKTsKLSAg ICByZXR1cm4gSlNPYmplY3Q6OmdldE93blByb3BlcnR5TmFtZXModGhpc09iamVjdCwgZ2xvYmFs T2JqZWN0LCBwcm9wZXJ0eU5hbWVzLCBtb2RlKTsKKyAgICB9CisgICAgSlNPYmplY3Q6OmdldE93 blByb3BlcnR5TmFtZXModGhpc09iamVjdCwgZ2xvYmFsT2JqZWN0LCBwcm9wZXJ0eU5hbWVzLCBt b2RlKTsKIH0KIAogYm9vbCBKU01vZHVsZU5hbWVzcGFjZU9iamVjdDo6ZGVmaW5lT3duUHJvcGVy dHkoSlNPYmplY3QqLCBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBQcm9wZXJ0eU5hbWUs IGNvbnN0IFByb3BlcnR5RGVzY3JpcHRvciYsIGJvb2wgc2hvdWxkVGhyb3cpCmRpZmYgLS1naXQg YS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg4M2VlN2RlZTE5 YWU2MDY5MjhhMWZiZDZhNjg5OWEwMmMxMzVhZjcuLmQ5YTRmMjM3NWZiOGMyNTJhNDU3YjgwZjFl ZDQ1ZTE4MjUwYzdjNDMgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDEtMDggIENhaXRsaW4gUG90dGVy ICA8Y2FpdHBAaWdhbGlhLmNvbT4KKworICAgICAgICBPYmplY3Qua2V5cyBzaG91bGQgdGhyb3cg aWYgY2FsbGVkIG9uIG1vZHVsZSBuYW1lc3BhY2Ugb2JqZWN0IHdpdGggdW5pbml0aWFsaXplZCBi aW5kaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDU5ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHRlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWw6IE1hcmsgMiB0ZXN0IGNhc2VzIGFzIHBhc3Npbmcu CisKIDIwMjAtMDEtMDYgIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgog CiAgICAgICAgIFN0cmluZy5wcm90b3R5cGUucmVwbGFjZSgpIGluY29ycmVjdGx5IGhhbmRsZXMg bmFtZWQgcmVmZXJlbmNlcyBvbiBSZWdFeHAgdy9vIG5hbWVkIGdyb3VwcwpkaWZmIC0tZ2l0IGEv SlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sIGIvSlNUZXN0cy90ZXN0MjYyL2V4cGVj dGF0aW9ucy55YW1sCmluZGV4IDlkYWUxODExYmYwMGIyOGVjNzNlNzkyYjQxNzcwYTc3YjlkMDM2 ODUuLjZhZGFmOTgyNDU4MjI3OTA2M2I0ZmIwYzE5OGIyNmEyNWYxNzgyYWIgMTAwNjQ0Ci0tLSBh L0pTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbAorKysgYi9KU1Rlc3RzL3Rlc3QyNjIv ZXhwZWN0YXRpb25zLnlhbWwKQEAgLTM1MDQsOCArMzUwNCw2IEBAIHRlc3QvbGFuZ3VhZ2UvbW9k dWxlLWNvZGUvbmFtZXNwYWNlL2ludGVybmFscy9nZXQtbmVzdGVkLW5hbWVzcGFjZS1kZmx0LXNr aXAuanM6CiAgIG1vZHVsZTogIlN5bnRheEVycm9yOiBVbmV4cGVjdGVkIGlkZW50aWZpZXIgJ2Fz Jy4gRXhwZWN0ZWQgJ2Zyb20nIGJlZm9yZSBleHBvcnRlZCBtb2R1bGUgbmFtZS4iCiB0ZXN0L2xh bmd1YWdlL21vZHVsZS1jb2RlL25hbWVzcGFjZS9pbnRlcm5hbHMvZ2V0LW5lc3RlZC1uYW1lc3Bh Y2UtcHJvcHMtbnJtbC5qczoKICAgbW9kdWxlOiAiU3ludGF4RXJyb3I6IFVuZXhwZWN0ZWQgaWRl bnRpZmllciAnYXMnLiBFeHBlY3RlZCAnZnJvbScgYmVmb3JlIGV4cG9ydGVkIG1vZHVsZSBuYW1l LiIKLXRlc3QvbGFuZ3VhZ2UvbW9kdWxlLWNvZGUvbmFtZXNwYWNlL2ludGVybmFscy9vYmplY3Qt a2V5cy1iaW5kaW5nLXVuaW5pdC5qczoKLSAgbW9kdWxlOiAnVGVzdDI2MkVycm9yOiBFeHBlY3Rl ZCBhIFJlZmVyZW5jZUVycm9yIHRvIGJlIHRocm93biBidXQgbm8gZXhjZXB0aW9uIHdhcyB0aHJv d24gYXQgYWxsJwogdGVzdC9sYW5ndWFnZS9tb2R1bGUtY29kZS9uYW1lc3BhY2UvaW50ZXJuYWxz L3NldC5qczoKICAgbW9kdWxlOiAnVGVzdDI2MkVycm9yOiBSZWZsZWN0LmRlZmluZVByb3BlcnR5 OiBsb2NhbDEgRXhwZWN0ZWQgU2FtZVZhbHVlKMKrZmFsc2XCuywgwqt0cnVlwrspIHRvIGJlIHRy dWUnCiB0ZXN0L2xhbmd1YWdlL21vZHVsZS1jb2RlL3BhcnNlLWVyci1ob2lzdC1sZXgtZnVuLmpz Ogo= 387383 2020-01-10 15:18:09 -0800 2020-01-10 19:18:06 -0800 Patch bug-205983-20200109071526-2.patch text/plain 4876 ashvayka U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NjNjOWNkNGEyYmQwYzQwOWYwNzJlYzliY2I0YWI2N2IzNjgzMWY3Li5jN2E0Y2U2MDdhYmFiZDcw NjliOGRjMGIwOGU1NjUwOTI2YjllZTZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMC0wMS0wOCAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29t PiBhbmQgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBnbWFpbC5jb20+CisKKyAgICAgICAg T2JqZWN0LmtleXMgc2hvdWxkIHRocm93IGlmIGNhbGxlZCBvbiBtb2R1bGUgbmFtZXNwYWNlIG9i amVjdCB3aXRoIHVuaW5pdGlhbGl6ZWQgYmluZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1OTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgSlNNb2R1bGVOYW1lc3BhY2VPYmplY3Q6OmdldE93 blByb3BlcnR5TmFtZXMgbWV0aG9kIGlzIGNhbGxlZCBieQorICAgICAgICBPYmplY3Qua2V5cyBv ciBmb3IvaW4gbG9vcCwgaXQgc2hvdWxkIGludm9rZSBbW0dldE93blByb3BlcnR5XV0gb24KKyAg ICAgICAgZXZlcnkgYmluZGluZyBzbyBhIFJlZmVyZW5jZUVycm9yIGlzIHRocm93biBpZiB0aGUg YmluZGluZyBpcyB1bmluaXRpYWxpemVkLgorCisgICAgICAgIENvbXBsZXRlIGNhbGwgc3RhY2sg b2YgaW50ZXJuYWwgbWV0aG9kcyBhbmQgYWJzdHJhY3Qgb3BzIGlzIGluICJpbmZvIiBtZXRhIG9m CisgICAgICAgIEpTVGVzdHMvdGVzdDI2Mi90ZXN0L2xhbmd1YWdlL21vZHVsZS1jb2RlL25hbWVz cGFjZS9pbnRlcm5hbHMvb2JqZWN0LWtleXMtYmluZGluZy11bmluaXQuanMKKworICAgICAgICAq IHJ1bnRpbWUvSlNNb2R1bGVOYW1lc3BhY2VPYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpKU01v ZHVsZU5hbWVzcGFjZU9iamVjdDo6Z2V0T3duUHJvcGVydHlOYW1lcyk6CisKIDIwMjAtMDEtMDYg IEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgogCiAgICAgICAgIFN0cmlu Zy5wcm90b3R5cGUucmVwbGFjZSgpIGluY29ycmVjdGx5IGhhbmRsZXMgbmFtZWQgcmVmZXJlbmNl cyBvbiBSZWdFeHAgdy9vIG5hbWVkIGdyb3VwcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNNb2R1bGVOYW1lc3BhY2VPYmplY3QuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNNb2R1bGVOYW1lc3BhY2VPYmplY3QuY3BwCmluZGV4IDE3NTY4 NmRjYzY4M2JlZjJmN2MzZGJkZDEwZDQ4MGEyMjg2MDc0YjIuLjJiZGIxMzA1ZWIwYzRiZTk2MDgw NjViZDM0ODU5YzdhZjE0OGIyYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTTW9kdWxlTmFtZXNwYWNlT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU01vZHVsZU5hbWVzcGFjZU9iamVjdC5jcHAKQEAgLTIxMSwxMSArMjEx LDIxIEBAIGJvb2wgSlNNb2R1bGVOYW1lc3BhY2VPYmplY3Q6OmRlbGV0ZVByb3BlcnR5KEpTQ2Vs bCogY2VsbCwgSlNHbG9iYWxPYmplY3QqIGdsb2JhCiAKIHZvaWQgSlNNb2R1bGVOYW1lc3BhY2VP YmplY3Q6OmdldE93blByb3BlcnR5TmFtZXMoSlNPYmplY3QqIGNlbGwsIEpTR2xvYmFsT2JqZWN0 KiBnbG9iYWxPYmplY3QsIFByb3BlcnR5TmFtZUFycmF5JiBwcm9wZXJ0eU5hbWVzLCBFbnVtZXJh dGlvbk1vZGUgbW9kZSkKIHsKLSAgICAvLyBodHRwOi8vd3d3LmVjbWEtaW50ZXJuYXRpb25hbC5v cmcvZWNtYS0yNjIvNi4wLyNzZWMtbW9kdWxlLW5hbWVzcGFjZS1leG90aWMtb2JqZWN0cy1vd25w cm9wZXJ0eWtleXMKKyAgICBWTSYgdm0gPSBnbG9iYWxPYmplY3QtPnZtKCk7CisgICAgYXV0byBz Y29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOworCisgICAgLy8gaHR0cHM6Ly90YzM5LmVz L2VjbWEyNjIvI3NlYy1tb2R1bGUtbmFtZXNwYWNlLWV4b3RpYy1vYmplY3RzLW93bnByb3BlcnR5 a2V5cwogICAgIEpTTW9kdWxlTmFtZXNwYWNlT2JqZWN0KiB0aGlzT2JqZWN0ID0ganNDYXN0PEpT TW9kdWxlTmFtZXNwYWNlT2JqZWN0Kj4oY2VsbCk7Ci0gICAgZm9yIChjb25zdCBhdXRvJiBuYW1l IDogdGhpc09iamVjdC0+bV9uYW1lcykKKyAgICBmb3IgKGNvbnN0IGF1dG8mIG5hbWUgOiB0aGlz T2JqZWN0LT5tX25hbWVzKSB7CisgICAgICAgIGlmICghbW9kZS5pbmNsdWRlRG9udEVudW1Qcm9w ZXJ0aWVzKCkpIHsKKyAgICAgICAgICAgIC8vIFBlcmZvcm0gW1tHZXRPd25Qcm9wZXJ0eV1dIHRv IHRocm93IFJlZmVyZW5jZUVycm9yIGlmIGJpbmRpbmcgaXMgdW5pbml0aWFsaXplZC4KKyAgICAg ICAgICAgIFByb3BlcnR5U2xvdCBzbG90KGNlbGwsIFByb3BlcnR5U2xvdDo6SW50ZXJuYWxNZXRo b2RUeXBlOjpHZXRPd25Qcm9wZXJ0eSk7CisgICAgICAgICAgICB0aGlzT2JqZWN0LT5nZXRPd25Q cm9wZXJ0eVNsb3RDb21tb24oZ2xvYmFsT2JqZWN0LCBuYW1lLmltcGwoKSwgc2xvdCk7CisgICAg ICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCB2b2lkKCkpOworICAgICAgICB9CiAg ICAgICAgIHByb3BlcnR5TmFtZXMuYWRkKG5hbWUuaW1wbCgpKTsKLSAgICByZXR1cm4gSlNPYmpl Y3Q6OmdldE93blByb3BlcnR5TmFtZXModGhpc09iamVjdCwgZ2xvYmFsT2JqZWN0LCBwcm9wZXJ0 eU5hbWVzLCBtb2RlKTsKKyAgICB9CisgICAgSlNPYmplY3Q6OmdldE93blByb3BlcnR5TmFtZXMo dGhpc09iamVjdCwgZ2xvYmFsT2JqZWN0LCBwcm9wZXJ0eU5hbWVzLCBtb2RlKTsKIH0KIAogYm9v bCBKU01vZHVsZU5hbWVzcGFjZU9iamVjdDo6ZGVmaW5lT3duUHJvcGVydHkoSlNPYmplY3QqLCBK U0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBQcm9wZXJ0eU5hbWUsIGNvbnN0IFByb3BlcnR5 RGVzY3JpcHRvciYsIGJvb2wgc2hvdWxkVGhyb3cpCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5n ZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg4M2VlN2RlZTE5YWU2MDY5MjhhMWZiZDZh Njg5OWEwMmMxMzVhZjcuLmQ5YTRmMjM3NWZiOGMyNTJhNDU3YjgwZjFlZDQ1ZTE4MjUwYzdjNDMg MTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMjAtMDEtMDggIENhaXRsaW4gUG90dGVyICA8Y2FpdHBAaWdhbGlh LmNvbT4gYW5kIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgorCisgICAg ICAgIE9iamVjdC5rZXlzIHNob3VsZCB0aHJvdyBpZiBjYWxsZWQgb24gbW9kdWxlIG5hbWVzcGFj ZSBvYmplY3Qgd2l0aCB1bmluaXRpYWxpemVkIGJpbmRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTk4MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbDog TWFyayAyIHRlc3QgY2FzZXMgYXMgcGFzc2luZy4KKwogMjAyMC0wMS0wNiAgQWxleGV5IFNodmF5 a2EgIDxzaHZhaWthbGVzaEBnbWFpbC5jb20+CiAKICAgICAgICAgU3RyaW5nLnByb3RvdHlwZS5y ZXBsYWNlKCkgaW5jb3JyZWN0bHkgaGFuZGxlcyBuYW1lZCByZWZlcmVuY2VzIG9uIFJlZ0V4cCB3 L28gbmFtZWQgZ3JvdXBzCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25z LnlhbWwgYi9KU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwKaW5kZXggOWRhZTE4MTFi ZjAwYjI4ZWM3M2U3OTJiNDE3NzBhNzdiOWQwMzY4NS4uNmFkYWY5ODI0NTgyMjc5MDYzYjRmYjBj MTk4YjI2YTI1ZjE3ODJhYiAxMDA2NDQKLS0tIGEvSlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0aW9u cy55YW1sCisrKyBiL0pTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbApAQCAtMzUwNCw4 ICszNTA0LDYgQEAgdGVzdC9sYW5ndWFnZS9tb2R1bGUtY29kZS9uYW1lc3BhY2UvaW50ZXJuYWxz L2dldC1uZXN0ZWQtbmFtZXNwYWNlLWRmbHQtc2tpcC5qczoKICAgbW9kdWxlOiAiU3ludGF4RXJy b3I6IFVuZXhwZWN0ZWQgaWRlbnRpZmllciAnYXMnLiBFeHBlY3RlZCAnZnJvbScgYmVmb3JlIGV4 cG9ydGVkIG1vZHVsZSBuYW1lLiIKIHRlc3QvbGFuZ3VhZ2UvbW9kdWxlLWNvZGUvbmFtZXNwYWNl L2ludGVybmFscy9nZXQtbmVzdGVkLW5hbWVzcGFjZS1wcm9wcy1ucm1sLmpzOgogICBtb2R1bGU6 ICJTeW50YXhFcnJvcjogVW5leHBlY3RlZCBpZGVudGlmaWVyICdhcycuIEV4cGVjdGVkICdmcm9t JyBiZWZvcmUgZXhwb3J0ZWQgbW9kdWxlIG5hbWUuIgotdGVzdC9sYW5ndWFnZS9tb2R1bGUtY29k ZS9uYW1lc3BhY2UvaW50ZXJuYWxzL29iamVjdC1rZXlzLWJpbmRpbmctdW5pbml0LmpzOgotICBt b2R1bGU6ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIGEgUmVmZXJlbmNlRXJyb3IgdG8gYmUgdGhy b3duIGJ1dCBubyBleGNlcHRpb24gd2FzIHRocm93biBhdCBhbGwnCiB0ZXN0L2xhbmd1YWdlL21v ZHVsZS1jb2RlL25hbWVzcGFjZS9pbnRlcm5hbHMvc2V0LmpzOgogICBtb2R1bGU6ICdUZXN0MjYy RXJyb3I6IFJlZmxlY3QuZGVmaW5lUHJvcGVydHk6IGxvY2FsMSBFeHBlY3RlZCBTYW1lVmFsdWUo wqtmYWxzZcK7LCDCq3RydWXCuykgdG8gYmUgdHJ1ZScKIHRlc3QvbGFuZ3VhZ2UvbW9kdWxlLWNv ZGUvcGFyc2UtZXJyLWhvaXN0LWxleC1mdW4uanM6Cg==