205980 2020-01-08 18:15:41 -0800 Set the title for images so it will be correctly displayed in UIContextMenus 2020-01-09 13:10:26 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner commit-queue dino thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1604440 0 megan_gardner 2020-01-08 18:15:41 -0800 Set the title for images so it will be correctly displayed in UIContextMenus 1604444 1 387175 megan_gardner 2020-01-08 18:16:51 -0800 Created attachment 387175 Patch 1604445 2 megan_gardner 2020-01-08 18:17:46 -0800 <rdar://problem/57701988> 1604529 3 387175 thorton 2020-01-08 23:02:59 -0800 Comment on attachment 387175 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387175&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8483 > + return [UIMenu menuWithTitle:[elementInfo title] children:actions]; I still maintain you should use positionInfo here, not the API wrapper :) 1604743 4 387248 megan_gardner 2020-01-09 11:30:44 -0800 Created attachment 387248 Patch for landing 1604798 5 387248 commit-queue 2020-01-09 13:10:24 -0800 Comment on attachment 387248 Patch for landing Clearing flags on attachment: 387248 Committed r254292: <https://trac.webkit.org/changeset/254292> 1604799 6 commit-queue 2020-01-09 13:10:26 -0800 All reviewed patches have been landed. Closing bug. 387175 2020-01-08 18:16:51 -0800 2020-01-09 11:30:43 -0800 Patch bug-205980-20200108181651.patch text/plain 1848 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNjZmFlM2Y4MjUzNjJkMWI3 YWRlN2Y1YWQxMzEzNjA5NTRiN2Y3MTEuLjg4Yjk3N2FhOTVmYmFlMGJmNDJlM2I2OTg4YTYxNmU5 YjgwNGJjMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMDggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBTZXQgdGhlIHRpdGxl IGZvciBpbWFnZXMgc28gaXQgd2lsbCBiZSBjb3JyZWN0bHkgZGlzcGxheWVkIGluIFVJQ29udGV4 dE1lbnVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDU5ODAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3NzAxOTg4PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5lZWQgdG8gc2V0IHRoZSB0aXRsZSB0 ZXh0IGZvciBpbWFnZXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBjb250aW51ZUNvbnRleHRN ZW51SW50ZXJhY3Rpb246XSk6CisKIDIwMjAtMDEtMDggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggc29tZSBJT1NfRkFNSUxZIGJ1aWxk cyBhZnRlciByMjU0MjEwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9z L1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggYjAxYjljNmJlMDE4NWY2MGEzMDll YTc5MTI2OWMzMmUwZmU2ZDI2Mi4uMzNhYjkzMTlkZDM5MjEyOGIyMDQ4Y2U5ZWQ5ODhjNDk1YjNi MDEzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC04NDgwLDcgKzg0ODAsNyBAQCAtICh2b2lkKWNvbnRp bnVlQ29udGV4dE1lbnVJbnRlcmFjdGlvbjoodm9pZCheKShVSUNvbnRleHRNZW51Q29uZmlndXJh dGlvbiAqKSljbwogCiAgICAgICAgICAgICAgICAgUmV0YWluUHRyPE5TQXJyYXk8X1dLRWxlbWVu dEFjdGlvbiAqPj4gZGVmYXVsdEFjdGlvbnNGcm9tQXNzaXN0YW50ID0gW3N0cm9uZ1NlbGYtPl9h Y3Rpb25TaGVldEFzc2lzdGFudCBkZWZhdWx0QWN0aW9uc0ZvckltYWdlU2hlZXQ6ZWxlbWVudElu Zm8uZ2V0KCldOwogICAgICAgICAgICAgICAgIGF1dG8gYWN0aW9ucyA9IG1lbnVFbGVtZW50c0Zy b21EZWZhdWx0QWN0aW9ucyhkZWZhdWx0QWN0aW9uc0Zyb21Bc3Npc3RhbnQsIGVsZW1lbnRJbmZv KTsKLSAgICAgICAgICAgICAgICByZXR1cm4gW1VJTWVudSBtZW51V2l0aFRpdGxlOkAiIiBjaGls ZHJlbjphY3Rpb25zXTsKKyAgICAgICAgICAgICAgICByZXR1cm4gW1VJTWVudSBtZW51V2l0aFRp dGxlOltlbGVtZW50SW5mbyB0aXRsZV0gY2hpbGRyZW46YWN0aW9uc107CiAgICAgICAgICAgICB9 OwogCiAgICAgICAgICAgICBVSUNvbnRleHRNZW51Q29udGVudFByZXZpZXdQcm92aWRlciBjb250 ZW50UHJldmlld1Byb3ZpZGVyID0gW3dlYWtTZWxmLCBjZ0ltYWdlLCBlbGVtZW50SW5mb10gKCkg LT4gVUlWaWV3Q29udHJvbGxlciAqIHsK 387248 2020-01-09 11:30:44 -0800 2020-01-09 13:10:24 -0800 Patch for landing bug-205980-20200109113044.patch text/plain 1865 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNjZmFlM2Y4MjUzNjJkMWI3 YWRlN2Y1YWQxMzEzNjA5NTRiN2Y3MTEuLjdmYzBhMzA0Zjk3NmExZTZiNzIxNzVlYmE4NjRmYWZk NWRiMGY3NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMDggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBTZXQgdGhlIHRpdGxl IGZvciBpbWFnZXMgc28gaXQgd2lsbCBiZSBjb3JyZWN0bHkgZGlzcGxheWVkIGluIFVJQ29udGV4 dE1lbnVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDU5ODAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3NzAxOTg4PgorCisgICAgICAgIFJldmll d2VkIGJ5IERlYW4gSmFja3Nvbi4KKworICAgICAgICBOZWVkIHRvIHNldCB0aGUgdGl0bGUgdGV4 dCBmb3IgaW1hZ2VzLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgY29udGludWVDb250ZXh0TWVu dUludGVyYWN0aW9uOl0pOgorCiAyMDIwLTAxLTA4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4IHNvbWUgSU9TX0ZBTUlMWSBidWlsZHMg YWZ0ZXIgcjI1NDIxMC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IGIwMWI5YzZiZTAxODVmNjBhMzA5ZWE3 OTEyNjljMzJlMGZlNmQyNjIuLmIzYzc0NGM4YTEzOWI3MzgzN2FlOTlmNzY3YTk5NTEzOGZjMTRk MzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtODQ4MCw3ICs4NDgwLDcgQEAgLSAodm9pZCljb250aW51 ZUNvbnRleHRNZW51SW50ZXJhY3Rpb246KHZvaWQoXikoVUlDb250ZXh0TWVudUNvbmZpZ3VyYXRp b24gKikpY28KIAogICAgICAgICAgICAgICAgIFJldGFpblB0cjxOU0FycmF5PF9XS0VsZW1lbnRB Y3Rpb24gKj4+IGRlZmF1bHRBY3Rpb25zRnJvbUFzc2lzdGFudCA9IFtzdHJvbmdTZWxmLT5fYWN0 aW9uU2hlZXRBc3Npc3RhbnQgZGVmYXVsdEFjdGlvbnNGb3JJbWFnZVNoZWV0OmVsZW1lbnRJbmZv LmdldCgpXTsKICAgICAgICAgICAgICAgICBhdXRvIGFjdGlvbnMgPSBtZW51RWxlbWVudHNGcm9t RGVmYXVsdEFjdGlvbnMoZGVmYXVsdEFjdGlvbnNGcm9tQXNzaXN0YW50LCBlbGVtZW50SW5mbyk7 Ci0gICAgICAgICAgICAgICAgcmV0dXJuIFtVSU1lbnUgbWVudVdpdGhUaXRsZTpAIiIgY2hpbGRy ZW46YWN0aW9uc107CisgICAgICAgICAgICAgICAgcmV0dXJuIFtVSU1lbnUgbWVudVdpdGhUaXRs ZTpzdHJvbmdTZWxmLT5fcG9zaXRpb25JbmZvcm1hdGlvbi50aXRsZSBjaGlsZHJlbjphY3Rpb25z XTsKICAgICAgICAgICAgIH07CiAKICAgICAgICAgICAgIFVJQ29udGV4dE1lbnVDb250ZW50UHJl dmlld1Byb3ZpZGVyIGNvbnRlbnRQcmV2aWV3UHJvdmlkZXIgPSBbd2Vha1NlbGYsIGNnSW1hZ2Us IGVsZW1lbnRJbmZvXSAoKSAtPiBVSVZpZXdDb250cm9sbGVyICogewo=