205976 2020-01-08 17:30:20 -0800 Web Inspector: suggest "color()" when defining color in CSS value 2020-01-09 17:25:18 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1604402 0 nvasilyev 2020-01-08 17:30:20 -0800 Suggest "color()" the same way we suggest "rgb()" or "hsl()". 1604404 1 387169 nvasilyev 2020-01-08 17:31:56 -0800 Created attachment 387169 Patch 1604446 2 387169 hi 2020-01-08 18:18:41 -0800 Comment on attachment 387169 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387169&action=review r=me > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:314 > + "wheat", "whitesmoke", "yellowgreen", "rgb()", "rgba()", "hsl()", "hsla()", "color()" Style: please add a trailing comma 1604919 3 387289 nvasilyev 2020-01-09 16:38:39 -0800 Created attachment 387289 Patch 1604940 4 387289 commit-queue 2020-01-09 17:24:33 -0800 Comment on attachment 387289 Patch Clearing flags on attachment: 387289 Committed r254316: <https://trac.webkit.org/changeset/254316> 1604941 5 commit-queue 2020-01-09 17:24:35 -0800 All reviewed patches have been landed. Closing bug. 1604942 6 webkit-bug-importer 2020-01-09 17:25:18 -0800 <rdar://problem/58464614> 387169 2020-01-08 17:31:56 -0800 2020-01-09 16:38:39 -0800 Patch patch.txt text/plain 1621 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDM5MWQwOWNlMjA0Li5mMDIyYzZjNDRkOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDEtMDggIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogc3VnZ2VzdCAiY29sb3IoKSIgd2hlbiBkZWZpbmluZyBjb2xvciBpbiBDU1MgdmFsdWUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTk3NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzOgorCiAyMDIwLTAxLTA4ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OOiAocjI1 NDE4NikgWyBNYWMgXSBpbnNwZWN0b3IvY3NzL2FkZC1ydWxlLmh0bWwgaXMgZmFpbGluZwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tl eXdvcmRDb21wbGV0aW9ucy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L01vZGVscy9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMKaW5kZXggMzkwMGYxNjExNTIuLmZhNTRi NTBmNmM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9N b2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMKQEAgLTMxMSw3 ICszMTEsNyBAQCBXSS5DU1NLZXl3b3JkQ29tcGxldGlvbnMuX2NvbG9ycyA9IFsKICAgICAicGFs ZXR1cnF1b2lzZSIsICJwYWxldmlvbGV0cmVkIiwgInBhcGF5YXdoaXAiLCAicGVhY2hwdWZmIiwg InBlcnUiLCAicGluayIsICJwbHVtIiwgInBvd2RlcmJsdWUiLCAicmViZWNjYXB1cnBsZSIsICJy b3N5YnJvd24iLAogICAgICJyb3lhbGJsdWUiLCAic2FkZGxlYnJvd24iLCAic2FsbW9uIiwgInNh bmR5YnJvd24iLCAic2VhZ3JlZW4iLCAic2Vhc2hlbGwiLCAic2llbm5hIiwgInNreWJsdWUiLCAi c2xhdGVibHVlIiwKICAgICAic2xhdGVncmF5IiwgInNsYXRlZ3JleSIsICJzbm93IiwgInNwcmlu Z2dyZWVuIiwgInN0ZWVsYmx1ZSIsICJ0YW4iLCAidGhpc3RsZSIsICJ0b21hdG8iLCAidHVycXVv aXNlIiwgInZpb2xldCIsCi0gICAgIndoZWF0IiwgIndoaXRlc21va2UiLCAieWVsbG93Z3JlZW4i LCAicmdiKCkiLCAicmdiYSgpIiwgImhzbCgpIiwgImhzbGEoKSIKKyAgICAid2hlYXQiLCAid2hp dGVzbW9rZSIsICJ5ZWxsb3dncmVlbiIsICJyZ2IoKSIsICJyZ2JhKCkiLCAiaHNsKCkiLCAiaHNs YSgpIiwgImNvbG9yKCkiCiBdOwogCiBXSS5DU1NLZXl3b3JkQ29tcGxldGlvbnMuX2NvbG9yQXdh cmVQcm9wZXJ0aWVzID0gbmV3IFNldChbCg== 387289 2020-01-09 16:38:39 -0800 2020-01-09 17:24:33 -0800 Patch patch.txt text/plain 1620 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDM5MWQwOWNlMjA0Li5iNDBjYTA1ZWI2NSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDEtMDkgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogc3VnZ2VzdCAiY29sb3IoKSIgd2hlbiBkZWZpbmluZyBjb2xvciBpbiBDU1MgdmFsdWUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTk3NgorCisg ICAgICAgIFJldmlld2VkIGJ5IERldmluIFJvdXNzby4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qczoKKwogMjAyMC0wMS0wOCAgRGV2aW4g Um91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogKHIyNTQx ODYpIFsgTWFjIF0gaW5zcGVjdG9yL2Nzcy9hZGQtcnVsZS5odG1sIGlzIGZhaWxpbmcKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3 b3JkQ29tcGxldGlvbnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9N b2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzCmluZGV4IDM5MDBmMTYxMTUyLi4zZjcwNmRj MWNmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9k ZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzCkBAIC0zMTEsNyAr MzExLDcgQEAgV0kuQ1NTS2V5d29yZENvbXBsZXRpb25zLl9jb2xvcnMgPSBbCiAgICAgInBhbGV0 dXJxdW9pc2UiLCAicGFsZXZpb2xldHJlZCIsICJwYXBheWF3aGlwIiwgInBlYWNocHVmZiIsICJw ZXJ1IiwgInBpbmsiLCAicGx1bSIsICJwb3dkZXJibHVlIiwgInJlYmVjY2FwdXJwbGUiLCAicm9z eWJyb3duIiwKICAgICAicm95YWxibHVlIiwgInNhZGRsZWJyb3duIiwgInNhbG1vbiIsICJzYW5k eWJyb3duIiwgInNlYWdyZWVuIiwgInNlYXNoZWxsIiwgInNpZW5uYSIsICJza3libHVlIiwgInNs YXRlYmx1ZSIsCiAgICAgInNsYXRlZ3JheSIsICJzbGF0ZWdyZXkiLCAic25vdyIsICJzcHJpbmdn cmVlbiIsICJzdGVlbGJsdWUiLCAidGFuIiwgInRoaXN0bGUiLCAidG9tYXRvIiwgInR1cnF1b2lz ZSIsICJ2aW9sZXQiLAotICAgICJ3aGVhdCIsICJ3aGl0ZXNtb2tlIiwgInllbGxvd2dyZWVuIiwg InJnYigpIiwgInJnYmEoKSIsICJoc2woKSIsICJoc2xhKCkiCisgICAgIndoZWF0IiwgIndoaXRl c21va2UiLCAieWVsbG93Z3JlZW4iLCAicmdiKCkiLCAicmdiYSgpIiwgImhzbCgpIiwgImhzbGEo KSIsICJjb2xvcigpIiwKIF07CiAKIFdJLkNTU0tleXdvcmRDb21wbGV0aW9ucy5fY29sb3JBd2Fy ZVByb3BlcnRpZXMgPSBuZXcgU2V0KFsK