205960 2020-01-08 14:42:39 -0800 build-jsc should invoke make instead of calling xcodebuild directly 2020-01-09 08:46:09 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 206011 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1604297 0 saam 2020-01-08 14:42:39 -0800 ... 1604389 1 387166 saam 2020-01-08 17:17:59 -0800 Created attachment 387166 patch 1604396 2 387166 keith_miller 2020-01-08 17:22:52 -0800 Comment on attachment 387166 patch r=me. 1604463 3 387166 commit-queue 2020-01-08 18:33:51 -0800 Comment on attachment 387166 patch Clearing flags on attachment: 387166 Committed r254248: <https://trac.webkit.org/changeset/254248> 1604464 4 commit-queue 2020-01-08 18:33:53 -0800 All reviewed patches have been landed. Closing bug. 1604465 5 webkit-bug-importer 2020-01-08 18:34:18 -0800 <rdar://problem/58429911> 1604645 6 commit-queue 2020-01-09 08:43:59 -0800 Re-opened since this is blocked by bug 206011 1604648 7 ap 2020-01-09 08:46:09 -0800 This is not being rolled back. The change just had an incorrect ChangeLog. 387166 2020-01-08 17:17:59 -0800 2020-01-08 18:33:51 -0800 patch c-backup.diff text/plain 6704 saam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI1NDIz NykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDIwLTAx LTA4ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIGJ1aWxkLWpz YyBzaG91bGQgaW52b2tlIG1ha2UgaW5zdGVhZCBvZiBjYWxsaW5nIHhjb2RlYnVpbGQgZGlyZWN0 bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTk2 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWFr ZWZpbGUuc2hhcmVkOgorCiAyMDIwLTAxLTA4ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgogCiAgICAgICAgIGJ1aWxkLWpzYyBzaG91bGQgaW52b2tlIG1ha2UgaW5zdGVhZCBvZiBj YWxsaW5nIHhjb2RlYnVpbGQgZGlyZWN0bHkKSW5kZXg6IE1ha2VmaWxlLnNoYXJlZAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBNYWtlZmlsZS5zaGFyZWQJKHJldmlzaW9uIDI1NDIzNykKKysrIE1ha2VmaWxlLnNo YXJlZAkod29ya2luZyBjb3B5KQpAQCAtOTEsMzAgKzkxLDMwIEBAIGV4cG9ydCBEU1lNVVRJTF9O VU1fVEhSRUFEUyA9ICQoc2hlbGwgc3kKIGV4cG9ydCBQQVRIID0gJChzaGVsbCBnZXRjb25mIFBB VEgpCiAKIGFsbDogc2V0X2FzYW5fY29uZmlndXJhdGlvbgotCSggJChTRVRfQ09MT1JfRElBR05P U1RJQ1NfQVJHKTsgeGNvZGVidWlsZCAkKE9USEVSX09QVElPTlMpICQoWENPREVfT1BUSU9OUykg fCAkKE9VVFBVVF9GSUxURVIpICYmIGV4aXQgJCR7UElQRVNUQVRVU1swXX0gKQorCSggJChTRVRf Q09MT1JfRElBR05PU1RJQ1NfQVJHKTsgeGNvZGVidWlsZCAkKE9USEVSX09QVElPTlMpICQoWENP REVfT1BUSU9OUykgR0NDX1BSRVBST0NFU1NPUl9ERUZJTklUSU9OUz0nJChHQ0NfUFJFUFJPQ0VT U09SX0FERElUSU9OUykgJCQoaW5oZXJpdGVkKScgfCAkKE9VVFBVVF9GSUxURVIpICYmIGV4aXQg JCR7UElQRVNUQVRVU1swXX0gKQogCiBkZWJ1ZyBkIGRldmVsb3BtZW50IGRldiBkZXZlbG9wOiBm b3JjZQogCSQoU0NSSVBUU19QQVRIKS9zZXQtd2Via2l0LWNvbmZpZ3VyYXRpb24gLS1kZWJ1ZyAk KEFTQU5fT1BUSU9OKSAkKFdLX0xUT19PUFRJT04pCi0JKCAkKFNFVF9DT0xPUl9ESUFHTk9TVElD U19BUkcpOyB4Y29kZWJ1aWxkICQoT1RIRVJfT1BUSU9OUykgJChYQ09ERV9PUFRJT05TKSB8ICQo T1VUUFVUX0ZJTFRFUikgJiYgZXhpdCAkJHtQSVBFU1RBVFVTWzBdfSApCisJKCAkKFNFVF9DT0xP Ul9ESUFHTk9TVElDU19BUkcpOyB4Y29kZWJ1aWxkICQoT1RIRVJfT1BUSU9OUykgJChYQ09ERV9P UFRJT05TKSBHQ0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TPSckKEdDQ19QUkVQUk9DRVNTT1Jf QURESVRJT05TKSAkJChpbmhlcml0ZWQpJyB8ICQoT1VUUFVUX0ZJTFRFUikgJiYgZXhpdCAkJHtQ SVBFU1RBVFVTWzBdfSApCiAKIHJlbGVhc2UgciBkZXBsb3ltZW50IGRlcCBkZXBsb3k6IGZvcmNl CiAJJChTQ1JJUFRTX1BBVEgpL3NldC13ZWJraXQtY29uZmlndXJhdGlvbiAtLXJlbGVhc2UgJChB U0FOX09QVElPTikgJChXS19MVE9fT1BUSU9OKQotCSggJChTRVRfQ09MT1JfRElBR05PU1RJQ1Nf QVJHKTsgeGNvZGVidWlsZCAkKE9USEVSX09QVElPTlMpICQoWENPREVfT1BUSU9OUykgfCAkKE9V VFBVVF9GSUxURVIpICYmIGV4aXQgJCR7UElQRVNUQVRVU1swXX0gKQorCSggJChTRVRfQ09MT1Jf RElBR05PU1RJQ1NfQVJHKTsgeGNvZGVidWlsZCAkKE9USEVSX09QVElPTlMpICQoWENPREVfT1BU SU9OUykgR0NDX1BSRVBST0NFU1NPUl9ERUZJTklUSU9OUz0nJChHQ0NfUFJFUFJPQ0VTU09SX0FE RElUSU9OUykgJCQoaW5oZXJpdGVkKScgfCAkKE9VVFBVVF9GSUxURVIpICYmIGV4aXQgJCR7UElQ RVNUQVRVU1swXX0gKQogCiByZWxlYXNlK2Fzc2VydCByYTogZm9yY2UKIAkkKFNDUklQVFNfUEFU SCkvc2V0LXdlYmtpdC1jb25maWd1cmF0aW9uIC0tcmVsZWFzZSAkKEFTQU5fT1BUSU9OKSAkKFdL X0xUT19PUFRJT04pCi0JKCAkKFNFVF9DT0xPUl9ESUFHTk9TVElDU19BUkcpOyB4Y29kZWJ1aWxk ICQoT1RIRVJfT1BUSU9OUykgJChYQ09ERV9PUFRJT05TKSBHQ0NfUFJFUFJPQ0VTU09SX0RFRklO SVRJT05TPSdBU1NFUlRfRU5BQkxFRD0xICQkKGluaGVyaXRlZCknIHwgJChPVVRQVVRfRklMVEVS KSAmJiBleGl0ICQke1BJUEVTVEFUVVNbMF19ICkKKwkoICQoU0VUX0NPTE9SX0RJQUdOT1NUSUNT X0FSRyk7IHhjb2RlYnVpbGQgJChPVEhFUl9PUFRJT05TKSAkKFhDT0RFX09QVElPTlMpIEdDQ19Q UkVQUk9DRVNTT1JfREVGSU5JVElPTlM9JyQoR0NDX1BSRVBST0NFU1NPUl9BRERJVElPTlMpIEFT U0VSVF9FTkFCTEVEPTEgJCQoaW5oZXJpdGVkKScgfCAkKE9VVFBVVF9GSUxURVIpICYmIGV4aXQg JCR7UElQRVNUQVRVU1swXX0gKQogCiB0ZXN0aW5nIHQ6IGZvcmNlCiAJJChTQ1JJUFRTX1BBVEgp L3NldC13ZWJraXQtY29uZmlndXJhdGlvbiAtLWRlYnVnICQoQVNBTl9PUFRJT04pICQoV0tfTFRP X09QVElPTikgLS1mb3JjZS1vcHRpbWl6YXRpb24tbGV2ZWw9TzMKLQkoICQoU0VUX0NPTE9SX0RJ QUdOT1NUSUNTX0FSRyk7IHhjb2RlYnVpbGQgJChPVEhFUl9PUFRJT05TKSAkKFhDT0RFX09QVElP TlMpIHwgJChPVVRQVVRfRklMVEVSKSAmJiBleGl0ICQke1BJUEVTVEFUVVNbMF19ICkKKwkoICQo U0VUX0NPTE9SX0RJQUdOT1NUSUNTX0FSRyk7IHhjb2RlYnVpbGQgJChPVEhFUl9PUFRJT05TKSAk KFhDT0RFX09QVElPTlMpIEdDQ19QUkVQUk9DRVNTT1JfREVGSU5JVElPTlM9JyQoR0NDX1BSRVBS T0NFU1NPUl9BRERJVElPTlMpICQkKGluaGVyaXRlZCknIHwgJChPVVRQVVRfRklMVEVSKSAmJiBl eGl0ICQke1BJUEVTVEFUVVNbMF19ICkKIAogYW5hbHl6ZToKIAkkKFNDUklQVFNfUEFUSCkvc2V0 LXdlYmtpdC1jb25maWd1cmF0aW9uIC0tZGVidWcgJChBU0FOX09QVElPTikgJChXS19MVE9fT1BU SU9OKQogaWZuZGVmIFBBVEhfVE9fU0NBTl9CVUlMRAotCSggJChTRVRfQ09MT1JfRElBR05PU1RJ Q1NfQVJHKTsgeGNvZGVidWlsZCAkKE9USEVSX09QVElPTlMpICQoWENPREVfT1BUSU9OUykgUlVO X0NMQU5HX1NUQVRJQ19BTkFMWVpFUj1ZRVMgfCAkKE9VVFBVVF9GSUxURVIpICYmIGV4aXQgJCR7 UElQRVNUQVRVU1swXX0gKQorCSggJChTRVRfQ09MT1JfRElBR05PU1RJQ1NfQVJHKTsgeGNvZGVi dWlsZCAkKE9USEVSX09QVElPTlMpICQoWENPREVfT1BUSU9OUykgR0NDX1BSRVBST0NFU1NPUl9E RUZJTklUSU9OUz0nJChHQ0NfUFJFUFJPQ0VTU09SX0FERElUSU9OUykgJCQoaW5oZXJpdGVkKScg UlVOX0NMQU5HX1NUQVRJQ19BTkFMWVpFUj1ZRVMgfCAkKE9VVFBVVF9GSUxURVIpICYmIGV4aXQg JCR7UElQRVNUQVRVU1swXX0gKQogZWxzZQotCSggJChTRVRfQ09MT1JfRElBR05PU1RJQ1NfQVJH KTsgJChQQVRIX1RPX1NDQU5fQlVJTEQpIHhjb2RlYnVpbGQgJChPVEhFUl9PUFRJT05TKSAkKFhD T0RFX09QVElPTlMpIHwgJChPVVRQVVRfRklMVEVSKSAmJiBleGl0ICQke1BJUEVTVEFUVVNbMF19 ICkKKwkoICQoU0VUX0NPTE9SX0RJQUdOT1NUSUNTX0FSRyk7ICQoUEFUSF9UT19TQ0FOX0JVSUxE KSB4Y29kZWJ1aWxkICQoT1RIRVJfT1BUSU9OUykgJChYQ09ERV9PUFRJT05TKSBHQ0NfUFJFUFJP Q0VTU09SX0RFRklOSVRJT05TPSckKEdDQ19QUkVQUk9DRVNTT1JfQURESVRJT05TKSAkJChpbmhl cml0ZWQpJyB8ICQoT1VUUFVUX0ZJTFRFUikgJiYgZXhpdCAkJHtQSVBFU1RBVFVTWzBdfSApCiBl bmRpZgogCiBzZXRfYXNhbl9jb25maWd1cmF0aW9uOgpJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMjU0MjM3KQorKysgVG9vbHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjAtMDEtMDggIFNh YW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAgICAgICAgYnVpbGQtanNjIHNob3Vs ZCBpbnZva2UgbWFrZSBpbnN0ZWFkIG9mIGNhbGxpbmcgeGNvZGVidWlsZCBkaXJlY3RseQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1OTYwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBtYWtlcyBi dWlsZC1qc2MgaW52b2tlIG1ha2UgaW5zdGVhZCBvZiBkaXJlY3RseSBpbnZva2luZyB4Y29kZWJ1 aWxkLgorICAgICAgICBUaGVyZSBhcmUgc29tZSBiZW5lZml0cyBoZXJlOgorICAgICAgICAtICdt YWtlJyBpcyBhIG1vcmUgc3RhbmRhcmQgd2F5IHRvIGJ1aWxkIHRoYW4gYnVpbGQtanNjLCBzbyBh cyB3ZSBtYWtlCisgICAgICAgIGltcHJvdmVtZW50cyB0byB0aGUgbWFrZSBidWlsZCAoZS5nIHIy NTQyMzQpLCB3ZSdsbCBnZXQgdGhlIHNhbWUgaW1wcm92ZW1lbnRzCisgICAgICAgIGluIGJ1aWxk LWpzYy4KKyAgICAgICAgCisgICAgICAgIC0gVGhlcmUgaGFzIGJlZW4gYSBsb25nc3RhbmRpbmcg YnVnIHdoZXJlIGlmIHlvdSBkaWQgaWYgeW91IGRpZAorICAgICAgICBgYnVpbGQtanNjIC0tcmVs ZWFzZSAmJiBjZCBTb3VyY2UvSmF2YVNjcmlwdENvcmUgJiYgbWFrZSByZWxlYXNlYAorICAgICAg ICB0aGVuIHRoZSBgbWFrZSByZWxlYXNlYCBjYWxsIHdvdWxkIHJlYnVpbGQgYWxsIG9mIEphdmFT Y3JpcHRDb3JlLgorICAgICAgICBJZiBidWlsZC1qc2MgZGlyZWN0bHkgaW52b2tlcyBtYWtlLCB0 aGlzIGlzc3VlIGdvZXMgYXdheSBhbmQgYWxsb3dzCisgICAgICAgIHRoZSB0d28gdG8gaW50ZXJv cGVyYXRlIGFzIGV4cGVjdGVkLgorCisgICAgICAgICogU2NyaXB0cy9idWlsZC1qc2M6CisgICAg ICAgIChidWlsZE15UHJvamVjdCk6CisKIDIwMjAtMDEtMDggIEpvbmF0aGFuIEJlZGFyZCAgPGpi ZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIHJ1bi13ZWJraXQtdGVzdHM6IGNsb2JiZXItb2xk LXJlc3VsdHMgc2hvdWxkIHJlbW92ZSB0aGUgZW50aXJlIHJlc3VsdHMgZm9sZGVyCkluZGV4OiBU b29scy9TY3JpcHRzL2J1aWxkLWpzYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2J1aWxk LWpzYwkocmV2aXNpb24gMjU0MjM3KQorKysgVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MJKHdvcmtp bmcgY29weSkKQEAgLTIwMSw3ICsyMDEsMTkgQEAgc3ViIGJ1aWxkTXlQcm9qZWN0CiAgICAgbXkg JHJlc3VsdDsKICAgICBjaGRpciAkcHJvamVjdERpcmVjdG9yeSBvciBkaWUgIkNhbid0IGZpbmQg JHByb2plY3ROYW1lIGRpcmVjdG9yeSB0byBidWlsZCBmcm9tIjsKICAgICBpZiAoaXNBcHBsZUNv Y29hV2ViS2l0KCkpIHsKLSAgICAgICAgJHJlc3VsdCA9IHN5c3RlbSAic2giLCAiLWMiLCAoJ3hj b2RlYnVpbGQgLXByb2plY3QgJyAuICRwcm9qZWN0TmFtZSAuICcueGNvZGVwcm9qICIkQCIgfCBn cmVwIC12IHNldGVudiAmJiBleGl0ICR7UElQRVNUQVRVU1swXX0nKSwgInhjb2RlYnVpbGQiLCAg QG9wdGlvbnMsIEBBUkdWLCBAYWRkaXRpb25hbFN1cHBvcnRPcHRpb25zOworICAgICAgICBteSAk Y29tcGlsZXJGbGFncyA9ICdHQ0NfUFJFUFJPQ0VTU09SX0FERElUSU9OUz0iJzsKKyAgICAgICAg aWYgKCRmb3JjZUNMb29wKSB7CisgICAgICAgICAgICAkY29tcGlsZXJGbGFncyAuPSAiRU5BQkxF X0pJVD0wIEVOQUJMRV9DX0xPT1A9MSI7CisgICAgICAgIH0KKyAgICAgICAgJGNvbXBpbGVyRmxh Z3MgLj0gJyInOworCisgICAgICAgIG15ICRjb21tYW5kID0gIm1ha2UgIiAuIChsYyBjb25maWd1 cmF0aW9uKCkpIC4gIiAiIC4gJGNvbXBpbGVyRmxhZ3MgLiAiICIgLiBqb2luKCIgIiwgQEFSR1Yp OworCisgICAgICAgIHByaW50ICJcbiI7CisgICAgICAgIHByaW50ICJidWlsZGluZyAiLCAkcHJv amVjdE5hbWUsICJcbiI7CisgICAgICAgIHByaW50ICJydW5uaW5nIGJ1aWxkIGNvbW1hbmQgJyIs ICRjb21tYW5kLCAiJyBpbiAiLCAkcHJvamVjdERpcmVjdG9yeSwgIlxuXG4iOworCisgICAgICAg ICRyZXN1bHQgPSBzeXN0ZW0gJGNvbW1hbmQ7CiAgICAgfSBlbHNlIHsKICAgICAgICAgZGllICJC dWlsZGluZyBub3QgZGVmaW5lZCBmb3IgdGhpcyBwbGF0Zm9ybSFcbiI7CiAgICAgfQpAQCAtMjIz LDYgKzIzNSw5IEBAIHN1YiB3cml0ZUNvbmdyYXRzKCkKIGJ1aWxkTXlQcm9qZWN0KCJTb3VyY2Uv Ym1hbGxvYyIsICJibWFsbG9jIik7CiBidWlsZE15UHJvamVjdCgiU291cmNlL1dURiIsICJXVEYi KTsKIGJ1aWxkTXlQcm9qZWN0KCJTb3VyY2UvSmF2YVNjcmlwdENvcmUiLCAiSmF2YVNjcmlwdENv cmUiKTsKK2lmIChpc0FwcGxlQ29jb2FXZWJLaXQoKSkgeworICAgIHdyaXRlQ29uZ3JhdHMoKTsK K30KIGlmIChpc0FwcGxlQ29jb2FXZWJLaXQoKSAmJiAkY2xpKSB7CiAgICAgYnVpbGRNeVByb2pl Y3QoIlRvb2xzL2pzYy1jbGkiLCAianNjLWNsaSIpOwogfQo=