205950 2020-01-08 12:14:37 -0800 WebKitTestRunner leaks objects in a top-level autoreleasePool that's never cleared 2020-01-09 11:35:12 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206018 InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue darin joepeck webkit-bug-importer oldest_to_newest 1604226 0 ddkilzer 2020-01-08 12:14:37 -0800 WebKitTestRunner leaks objects in a top-level autoreleasePool that's never cleared. This occurs on both iOS and macOS. <rdar://problem/50987831> 1604307 1 387145 ddkilzer 2020-01-08 15:05:56 -0800 Created attachment 387145 Patch v1 1604381 2 387145 joepeck 2020-01-08 17:10:55 -0800 Comment on attachment 387145 Patch v1 Nice! r=me 1604570 3 387145 commit-queue 2020-01-09 03:47:38 -0800 Comment on attachment 387145 Patch v1 Clearing flags on attachment: 387145 Committed r254254: <https://trac.webkit.org/changeset/254254> 1604571 4 commit-queue 2020-01-09 03:47:40 -0800 All reviewed patches have been landed. Closing bug. 1604710 5 387145 darin 2020-01-09 10:36:21 -0800 Comment on attachment 387145 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=387145&action=review > Tools/WebKitTestRunner/ios/mainIOS.mm:73 > UIApplicationMain(argc, (char**)argv, @"WebKitTestRunnerApp", @"WebKitTestRunnerApp"); No need for an autorelease pool around this? > Tools/WebKitTestRunner/mac/main.mm:68 > + WTR::TestController controller(argc, argv); No need for an autorelease pool around this? 1604711 6 387145 darin 2020-01-09 10:38:00 -0800 Comment on attachment 387145 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=387145&action=review >> Tools/WebKitTestRunner/ios/mainIOS.mm:73 >> UIApplicationMain(argc, (char**)argv, @"WebKitTestRunnerApp", @"WebKitTestRunnerApp"); > > No need for an autorelease pool around this? I guess it would never be drained, so it would be bad if it was needed, but I’m still wonder if we might start getting diagnostics about things being autoreleased without a pool. Although those would be leaks, I guess. >> Tools/WebKitTestRunner/mac/main.mm:68 >> + WTR::TestController controller(argc, argv); > > No need for an autorelease pool around this? Same. 1604717 7 387145 ddkilzer 2020-01-09 10:45:12 -0800 Comment on attachment 387145 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=387145&action=review >>> Tools/WebKitTestRunner/ios/mainIOS.mm:73 >>> UIApplicationMain(argc, (char**)argv, @"WebKitTestRunnerApp", @"WebKitTestRunnerApp"); >> >> No need for an autorelease pool around this? > > I guess it would never be drained, so it would be bad if it was needed, but I’m still wonder if we might start getting diagnostics about things being autoreleased without a pool. Although those would be leaks, I guess. Any autoreleasePool "leaks" inside UIApplicationMain() need to be handled in a localized manner. As you note, adding an @autoreleasepool block around UIApplicationMain() would never be drained. >>> Tools/WebKitTestRunner/mac/main.mm:68 >>> + WTR::TestController controller(argc, argv); >> >> No need for an autorelease pool around this? > > Same. Same, but there are some additional autoreleasePool "leaks" under WTR::TestController::TestController() during initialization, so a follow-up patch is warranted. 1604746 8 ddkilzer 2020-01-09 11:35:12 -0800 Additional improvements to autoreleasePool leaks tracked in Bug 206018. 387145 2020-01-08 15:05:56 -0800 2020-01-09 03:47:38 -0800 Patch v1 bug-205950-20200108150555.patch text/plain 5749 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZhNzI2ZWVhMzFkYjBlMWNh Mzk0YTQzYzZlOWQ3YTViMzBkZjhjOWQuLmUyZGRhMGEwYjFlNTRjZWFhZDVjYTFlODIwOTc5YjY4 YmVkZDM4MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDEtMDggIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXRUZXN0UnVubmVyIGxl YWtzIG9iamVjdHMgaW4gYSB0b3AtbGV2ZWwgYXV0b3JlbGVhc2VQb29sIHRoYXQncyBuZXZlciBj bGVhcmVkCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMDU5NTA+CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS81MDk4NzgzMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViUHJlZmVyZW5jZXNNYWMubW06Cisg ICAgICAgIChXZWJLaXQ6OldlYlByZWZlcmVuY2VzOjpwbGF0Zm9ybUluaXRpYWxpemVTdG9yZSk6 CisgICAgICAgIC0gQWRkIGFuIEBhdXRvcmVsZWFzZXBvb2wgYmxvY2sgYXJvdW5kIHRoZSBjb250 ZW50cyBvZgorICAgICAgICAgIHRoaXMgbWV0aG9kIHNpbmNlIGl0IGdlbmVyYXRlcyBudW1lcm91 cyBhdXRvcmVsZWFzZWQKKyAgICAgICAgICBvYmplY3RzIHdoZW4gcnVuLgorCiAyMDE5LTEyLTE4 ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBH UFUgcHJvY2VzcyBzaG91bGQgbG9nIElQQyBtZXNzYWdlIG5hbWUgYmVmb3JlIGNyYXNoaW5nIGZy b20gaW52YWxpZCBXZWJDb250ZW50IG1lc3NhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL21hYy9XZWJQcmVmZXJlbmNlc01hYy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL21hYy9XZWJQcmVmZXJlbmNlc01hYy5tbQppbmRleCBhYjRhZDAwYjI2YmRiOTE3Y2EzYjEy MzU1ZWI5OTBmMWVhNDU4YjE1Li5iOGQyNmJmMDM4MzAxOTM0MWI3Yzc0NmYzZDU4ZWRhNzNhNjQy NzM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV2ViUHJlZmVyZW5j ZXNNYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dlYlByZWZlcmVuY2Vz TWFjLm1tCkBAIC0xMzgsMjQgKzEzOCwyNiBAQCBzdGF0aWMgdm9pZCBzZXREZWJ1Z1VJbnQzMlZh bHVlSWZJblVzZXJEZWZhdWx0cyhjb25zdCBTdHJpbmcmIGlkZW50aWZpZXIsIGNvbnN0CiAKIHZv aWQgV2ViUHJlZmVyZW5jZXM6OnBsYXRmb3JtSW5pdGlhbGl6ZVN0b3JlKCkKIHsKKyAgICBAYXV0 b3JlbGVhc2Vwb29sIHsKICNkZWZpbmUgSU5JVElBTElaRV9ERUJVR19QUkVGRVJFTkNFX0ZST01f TlNVU0VSREVGQVVMVFMoS2V5VXBwZXIsIEtleUxvd2VyLCBUeXBlTmFtZSwgVHlwZSwgRGVmYXVs dFZhbHVlLCBIdW1hblJlYWRhYmxlTmFtZSwgSHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uKSBcCi0g ICAgc2V0RGVidWcjI1R5cGVOYW1lIyNWYWx1ZUlmSW5Vc2VyRGVmYXVsdHMobV9pZGVudGlmaWVy LCBtX2tleVByZWZpeCwgbV9nbG9iYWxEZWJ1Z0tleVByZWZpeCwgV2ViUHJlZmVyZW5jZXNLZXk6 OktleUxvd2VyIyNLZXkoKSwgbV9zdG9yZSk7CisgICAgICAgIHNldERlYnVnIyNUeXBlTmFtZSMj VmFsdWVJZkluVXNlckRlZmF1bHRzKG1faWRlbnRpZmllciwgbV9rZXlQcmVmaXgsIG1fZ2xvYmFs RGVidWdLZXlQcmVmaXgsIFdlYlByZWZlcmVuY2VzS2V5OjpLZXlMb3dlciMjS2V5KCksIG1fc3Rv cmUpOwogCi0gICAgRk9SX0VBQ0hfV0VCS0lUX0RFQlVHX1BSRUZFUkVOQ0UoSU5JVElBTElaRV9E RUJVR19QUkVGRVJFTkNFX0ZST01fTlNVU0VSREVGQVVMVFMpCisgICAgICAgIEZPUl9FQUNIX1dF QktJVF9ERUJVR19QUkVGRVJFTkNFKElOSVRJQUxJWkVfREVCVUdfUFJFRkVSRU5DRV9GUk9NX05T VVNFUkRFRkFVTFRTKQogCiAjdW5kZWYgSU5JVElBTElaRV9ERUJVR19QUkVGRVJFTkNFX0ZST01f TlNVU0VSREVGQVVMVFMKIAotICAgIGlmICghbV9pZGVudGlmaWVyKQotICAgICAgICByZXR1cm47 CisgICAgICAgIGlmICghbV9pZGVudGlmaWVyKQorICAgICAgICAgICAgcmV0dXJuOwogCiAjZGVm aW5lIElOSVRJQUxJWkVfUFJFRkVSRU5DRV9GUk9NX05TVVNFUkRFRkFVTFRTKEtleVVwcGVyLCBL ZXlMb3dlciwgVHlwZU5hbWUsIFR5cGUsIERlZmF1bHRWYWx1ZSwgSHVtYW5SZWFkYWJsZU5hbWUs IEh1bWFuUmVhZGFibGVEZXNjcmlwdGlvbikgXAotICAgIFR5cGUgdXNlciMjS2V5VXBwZXIjI1Zh bHVlOyBcCi0gICAgaWYgKHBsYXRmb3JtR2V0IyNUeXBlTmFtZSMjVXNlclZhbHVlRm9yS2V5KFdl YlByZWZlcmVuY2VzS2V5OjpLZXlMb3dlciMjS2V5KCksIHVzZXIjI0tleVVwcGVyIyNWYWx1ZSkp IFwKLSAgICAgICAgbV9zdG9yZS5zZXQjI1R5cGVOYW1lIyNWYWx1ZUZvcktleShXZWJQcmVmZXJl bmNlc0tleTo6S2V5TG93ZXIjI0tleSgpLCB1c2VyIyNLZXlVcHBlciMjVmFsdWUpOworICAgICAg ICBUeXBlIHVzZXIjI0tleVVwcGVyIyNWYWx1ZTsgXAorICAgICAgICBpZiAocGxhdGZvcm1HZXQj I1R5cGVOYW1lIyNVc2VyVmFsdWVGb3JLZXkoV2ViUHJlZmVyZW5jZXNLZXk6OktleUxvd2VyIyNL ZXkoKSwgdXNlciMjS2V5VXBwZXIjI1ZhbHVlKSkgXAorICAgICAgICAgICAgbV9zdG9yZS5zZXQj I1R5cGVOYW1lIyNWYWx1ZUZvcktleShXZWJQcmVmZXJlbmNlc0tleTo6S2V5TG93ZXIjI0tleSgp LCB1c2VyIyNLZXlVcHBlciMjVmFsdWUpOwogCi0gICAgRk9SX0VBQ0hfV0VCS0lUX1BSRUZFUkVO Q0UoSU5JVElBTElaRV9QUkVGRVJFTkNFX0ZST01fTlNVU0VSREVGQVVMVFMpCisgICAgICAgIEZP Ul9FQUNIX1dFQktJVF9QUkVGRVJFTkNFKElOSVRJQUxJWkVfUFJFRkVSRU5DRV9GUk9NX05TVVNF UkRFRkFVTFRTKQogCiAjdW5kZWYgSU5JVElBTElaRV9QUkVGRVJFTkNFX0ZST01fTlNVU0VSREVG QVVMVFMKKyAgICB9CiB9CiAKIHZvaWQgV2ViUHJlZmVyZW5jZXM6OnBsYXRmb3JtVXBkYXRlU3Ry aW5nVmFsdWVGb3JLZXkoY29uc3QgU3RyaW5nJiBrZXksIGNvbnN0IFN0cmluZyYgdmFsdWUpCmRp ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTg1ZmEx M2E1MTJiYWUyYjhmMjliMDY0OGU2NWI1MzBiOTJkMDVmOS4uMDdkYzhmOTRkZjU2YzMyOWE2ZjE5 NzhmODExMmRjN2E2MzliNjI1MSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rv b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTAxLTA4ICBEYXZpZCBLaWx6ZXIg IDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViS2l0VGVzdFJ1bm5lciBsZWFrcyBv YmplY3RzIGluIGEgdG9wLWxldmVsIGF1dG9yZWxlYXNlUG9vbCB0aGF0J3MgbmV2ZXIgY2xlYXJl ZAorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjA1OTUwPgorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTA5ODc4MzE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2lvcy9tYWluSU9TLm1tOgorICAgICAgICAo bWFpbik6CisgICAgICAgIC0gQWRkIGFuIEBhdXRvcmVsZWFzZXBvb2wgYmxvY2sgYXJvdW5kIGEg bGluZSBvZiBjb2RlCisgICAgICAgICAgdGhhdCBnZW5lcmF0ZXMgYXV0b3JlbGVhc2VkIG9iamVj dHMuICBUaGVzZSBvYmplY3RzCisgICAgICAgICAgd291bGQgbmV2ZXIgYmUgcmVsZWFzZWQgZm9y IHRoZSBsaWZlIG9mIHRoZSBwcm9jZXNzCisgICAgICAgICAgcHJpb3IgdG8gdGhpcyBjaGFuZ2Uu CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9tYWMvbWFpbi5tbToKKyAgICAgICAgKG1haW4p OgorICAgICAgICAtIE1vdmUgaW5zdGFudGlhdGlvbiBvZiBXVFI6OlRlc3RDb250cm9sbGVyIG91 dHNpZGUgb2YKKyAgICAgICAgICBAYXV0b3JlbGVhc2Vwb29sIGJsb2NrIHNvIHRoZSBwb29sIGNh biBiZSBkcmFpbmVkCisgICAgICAgICAgd2hpbGUgcnVubmluZyB0ZXN0cy4gIFByaW9yIHRvIHRo aXMgY2hhbmdlLCB0aGlzCisgICAgICAgICAgYXV0b3JlbGVhc2VQb29sIHdvdWxkIG5ldmVyIGJl IGRyYWluZWQuCisKIDIwMjAtMDEtMDggIFBhdWxvIE1hdG9zICA8cG1hdG9zQGlnYWxpYS5jb20+ CiAKICAgICAgICAgQWxsb3cgbXVsdGlwbGUgY21ha2VhcmdzIGluc2lkZSBpbnNpZGUgZW52dmFy CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9tYWluSU9TLm1tIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvbWFpbklPUy5tbQppbmRleCA5YTVhMDEyZjYxZDJjMzRk NmY5YjZhNDg3NjI2MWZlOTY3ODI0ODlhLi44MTFjYmRjMjAzZDQyOTFlM2VhOWVkMDM4ODY3YmEy NmQyOGRlNTg2IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9tYWluSU9T Lm1tCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL21haW5JT1MubW0KQEAgLTY2LDcg KzY2LDkgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNvbnN0IGNoYXIqIGFyZ3ZbXSkKICAgICBfYXJn YyA9IGFyZ2M7CiAgICAgX2FyZ3YgPSBhcmd2OwogCi0gICAgW1tOU1VzZXJEZWZhdWx0cyBzdGFu ZGFyZFVzZXJEZWZhdWx0c10gc2V0Qm9vbDpZRVMgZm9yS2V5OkAiV2ViS2l0TGlua2VkT25PckFm dGVyRXZlcnl0aGluZyJdOworICAgIEBhdXRvcmVsZWFzZXBvb2wgeworICAgICAgICBbW05TVXNl ckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBzZXRCb29sOllFUyBmb3JLZXk6QCJXZWJL aXRMaW5rZWRPbk9yQWZ0ZXJFdmVyeXRoaW5nIl07CisgICAgfQogCiAgICAgVUlBcHBsaWNhdGlv bk1haW4oYXJnYywgKGNoYXIqKilhcmd2LCBAIldlYktpdFRlc3RSdW5uZXJBcHAiLCBAIldlYktp dFRlc3RSdW5uZXJBcHAiKTsKICAgICByZXR1cm4gMDsKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvbWFjL21haW4ubW0gYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9tYWlu Lm1tCmluZGV4IGMxMTJjYjExYzAzNTk0MTk1YjhlZmY1ZTc5ZTM1NWEwZWU2MzJmYWYuLmY2NTA4 Y2JhMmM2ZjI2NTdlNjQ3YjQ5MWJlMjBlMDExZDY5ZDc0NGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvbWFjL21haW4ubW0KKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9t YWMvbWFpbi5tbQpAQCAtNjQsOCArNjQsOCBAQCBpbnQgbWFpbihpbnQgYXJnYywgY29uc3QgY2hh ciogYXJndltdKQogICAgICAgICBbTlNBcHBsaWNhdGlvbiBzaGFyZWRBcHBsaWNhdGlvbl07CiAg ICAgICAgIHNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzRm9yVGVzdGluZygpOwogICAgICAg ICBkaXNhYmxlQXBwTmFwSW5VSVByb2Nlc3MoKTsgLy8gRm9yIHNlY29uZGFyeSBwcm9jZXNzZXMs IGFwcCBuYXAgaXMgZGlzYWJsZWQgdXNpbmcgV0tQcmVmZXJlbmNlc1NldFBhZ2VWaXNpYmlsaXR5 QmFzZWRQcm9jZXNzU3VwcHJlc3Npb25FbmFibGVkKCkuCi0gICAgICAgIFdUUjo6VGVzdENvbnRy b2xsZXIgY29udHJvbGxlcihhcmdjLCBhcmd2KTsKICAgICB9CisgICAgV1RSOjpUZXN0Q29udHJv bGxlciBjb250cm9sbGVyKGFyZ2MsIGFyZ3YpOwogICAgIHJldHVybiAwOwogfQogCg==