205947 2020-01-08 11:52:39 -0800 TypeProfiler.h: Multiplication result converted to larger type 2020-01-08 14:04:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff commit-queue ews-watchlist keith_miller mark.lam saam tzagallo webkit-bug-importer oldest_to_newest 1604198 0 msaboff 2020-01-08 11:52:39 -0800 Summary: TypeProfiler.h: Multiplication result converted to larger type: Multiplication result may overflow 'unsigned int' before it is converted to 'unsigned long'. unsigned hash() const { unsigned hash = m_sourceID + m_divot * m_searchDescriptor; Multiplication result may overflow 'unsigned int' before it is converted to 'long'. return hash; } fix: fix cast m_sourceID to unsigned or cast the whole result to unsigned. 1604199 1 msaboff 2020-01-08 11:52:47 -0800 <rdar://problem/58383288> 1604251 2 387131 msaboff 2020-01-08 13:25:23 -0800 Created attachment 387131 Patch 1604274 3 387131 commit-queue 2020-01-08 14:04:16 -0800 Comment on attachment 387131 Patch Clearing flags on attachment: 387131 Committed r254224: <https://trac.webkit.org/changeset/254224> 1604275 4 commit-queue 2020-01-08 14:04:17 -0800 All reviewed patches have been landed. Closing bug. 387131 2020-01-08 13:25:23 -0800 2020-01-08 14:04:16 -0800 Patch 205947.patch text/plain 1230 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjU0MjE5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDIwLTAxLTA4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFR5cGVQcm9maWxlci5oOiBNdWx0aXBsaWNhdGlvbiByZXN1bHQgY29udmVydGVkIHRvIGxh cmdlciB0eXBlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDU5NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGRlZCBjYXN0IHRvIGtlZXAgdGhlIGhhc2goKSBjYWxjdWxhdGlvbiB1bnNpZ25lZC4KKwor ICAgICAgICAqIHJ1bnRpbWUvVHlwZVByb2ZpbGVyLmg6CisgICAgICAgIChKU0M6OlF1ZXJ5S2V5 OjpoYXNoIGNvbnN0KToKKwogMjAyMC0wMS0wOCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFw cGxlLmNvbT4KIAogICAgICAgICBKU0FycmF5QnVmZmVyVmlldy5oOiBNdWx0aXBsaWNhdGlvbiBy ZXN1bHQgY29udmVydGVkIHRvIGxhcmdlciB0eXBlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9UeXBlUHJvZmlsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9UeXBlUHJvZmlsZXIuaAkocmV2aXNpb24gMjU0MjEwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVHlwZVByb2ZpbGVyLmgJKHdvcmtpbmcgY29weSkKQEAg LTc4LDcgKzc4LDcgQEAgc3RydWN0IFF1ZXJ5S2V5IHsKIAogICAgIHVuc2lnbmVkIGhhc2goKSBj b25zdCAKICAgICB7IAotICAgICAgICB1bnNpZ25lZCBoYXNoID0gbV9zb3VyY2VJRCArIG1fZGl2 b3QgKiBtX3NlYXJjaERlc2NyaXB0b3I7CisgICAgICAgIHVuc2lnbmVkIGhhc2ggPSBzdGF0aWNf Y2FzdDx1bnNpZ25lZD4obV9zb3VyY2VJRCkgKyBtX2Rpdm90ICogbV9zZWFyY2hEZXNjcmlwdG9y OwogICAgICAgICByZXR1cm4gaGFzaDsKICAgICB9CiAK