205938 2020-01-08 10:46:56 -0800 REGRESSION: (r254186) [ Mac ] inspector/css/add-rule.html is failing 2020-01-08 14:22:20 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell hi bburg commit-queue ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1604151 0 tsavell 2020-01-08 10:46:56 -0800 inspector/css/add-rule.html Description: This test began failing after the changes in https://trac.webkit.org/changeset/254186/webkit History: https://results.webkit.org/?suite=layout-tests&test=inspector%2Fcss%2Fadd-rule.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/inspector/css/add-rule-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/inspector/css/add-rule-actual.txt @@ -4,14 +4,12 @@ == Running test suite: CSS.addRule -- Running test case: CSS.addRule.InNonExistingInspectorStyleSheet PASS: Should not have any inspector style sheets for the main frame. -PASS: Rule selector should be "body" -PASS: Rule range should be [0:0,0:4] -PASS: Rule origin should be "inspector" +!! EXCEPTION: NotFoundError +Stack Trace: #0: (anonymous) ((unknown)) -- Running test case: CSS.addRule.InExistingInspectorStyleSheet -PASS: Rule selector should be "div" -PASS: Rule range should be [1:0,1:3] -PASS: Rule origin should be "inspector" +!! EXCEPTION: NotFoundError +Stack Trace: #0: (anonymous) ((unknown)) -- Running test case: CSS.addRule.ExternalStyleSheet PASS: Rule selector should be "div" 1604152 1 webkit-bug-importer 2020-01-08 10:47:10 -0800 <rdar://problem/58413597> 1604209 2 387124 hi 2020-01-08 11:57:34 -0800 Created attachment 387124 Patch 1604233 3 387124 bburg 2020-01-08 12:28:46 -0800 Comment on attachment 387124 Patch =mews 1604288 4 387124 commit-queue 2020-01-08 14:22:18 -0800 Comment on attachment 387124 Patch Clearing flags on attachment: 387124 Committed r254228: <https://trac.webkit.org/changeset/254228> 1604289 5 commit-queue 2020-01-08 14:22:20 -0800 All reviewed patches have been landed. Closing bug. 387124 2020-01-08 11:57:34 -0800 2020-01-08 14:22:18 -0800 Patch bug-205938-20200108125733.patch text/plain 4899 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwMjVlYTEyNDJkYzdkODZmNTg4ODhiZTZmYTU0NTVlZDhmYmY5ZjliLi43 MmJjN2NjMjJmN2I2ZGI0NDVmNGMzZTc3ZThmZjY0NTA4MjM2Nzg3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjIgQEAKKzIwMjAtMDEtMDggIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT046IChyMjU0MTg2KSBbIE1hYyBdIGluc3BlY3Rvci9jc3Mv YWRkLXJ1bGUuaHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDU5MzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4NDEzNTk3 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVy ZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yU3R5 bGVTaGVldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JTdHlsZVNoZWV0Ojpvcmln aW5hbFN0eWxlU2hlZXRUZXh0IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclN0 eWxlU2hlZXQ6OnJlc291cmNlU3R5bGVTaGVldFRleHQgY29uc3QpOgorICAgICAgICAoV2ViQ29y ZTo6SW5zcGVjdG9yU3R5bGVTaGVldDo6aW5saW5lU3R5bGVTaGVldFRleHQgY29uc3QpOgorICAg ICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yU3R5bGVTaGVldDo6ZXh0ZW5zaW9uU3R5bGVTaGVldFRl eHQgY29uc3QpOgorICAgICAgICBUaGUgSW5zcGVjdG9yIFN0eWxlIFNoZWV0IGlzIGFuIGlubGlu ZSBzdHlsZSBzaGVldCwgc28gaXQgZ29lcyB0aHJvdWdoIGBpbmxpbmVTdHlsZVNoZWV0VGV4dGAK KyAgICAgICAgaW5zdGVhZCBvZiBgcmVzb3VyY2VTdHlsZVNoZWV0VGV4dGAuIFN0eWxlIHNoZWV0 cyBhcmUgb25seSBiZSBzb3VyY2VkIGZyb20gb25lIHBsYWNlIGFueXdheXMKKyAgICAgICAgc28g dGhlcmUncyBubyByZWFzb24gdG8gZ2F0ZSBlYWNoIGZ1bmN0aW9uIGJhc2VkIG9uIHRoZSBgb3Jp Z2luYC4KKwogMjAyMC0wMS0wOCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNv bT4KIAogICAgICAgICBBZGQgZW5jb2RpbmcvZGVjb2Rpbmcgc3VwcG9ydCBmb3IgZGF0YSBzdHJ1 Y3R1cmVzIGluIFRleHRGbGFncy5oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv Q2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBmNmQ1OTQ1 NGExZTI2MjJkOGFjYWZjZDk1NzU0YzAwMWI0MTZiMDY4Li4zNWY2ZWMxZWY3MjNhOTRhYjU5OWM5 YjgzNGNhNDYwMzVkMWM3MGI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NSBAQAorMjAyMC0wMS0wOCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAg ICAgICAgUkVHUkVTU0lPTjogKHIyNTQxODYpIFsgTWFjIF0gaW5zcGVjdG9yL2Nzcy9hZGQtcnVs ZS5odG1sIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwNTkzOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTg0MTM1OTc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL01vZGVscy9DU1NTdHlsZVNoZWV0LmpzOgorICAgICAgICAoV0kuQ1NTU3R5bGVTaGVldC5w cm90b3R5cGUuZ2V0IGluamVjdGVkKToKKyAgICAgICAgYHNjaGVtZWAgY2FuIGJlIGBudWxsYCwg c28gY2hlY2sgdGhhdCBpdCBleGlzdHMgYmVmb3JlIGNhbGxpbmcgYFN0cmluZy5wcm90b3R5cGVg IGZ1bmN0aW9ucy4KKwogMjAyMC0wMS0wNyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogdW5hYmxlIHRvIGVkaXQgb3IgdmlldyB0aGUg c291cmNlIG9mIHN0eWxlIHNoZWV0cyBpbmplY3RlZCBieSBzYWZhcmkgYXBwIGV4dGVuc2lvbnMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcApp bmRleCBlZWZhM2QxNjAxYWNjMDA1ZjdhNzk1MzMxZmU2YmFjZjNmZTg2NWY0Li5mZTY2ODQwOTBk NWNmNTc2NjQzZjgzZWYzNDA5ZDZlMDIyMmEwNjc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwCkBAIC0xNDA0LDE1ICsxNDA0LDE0IEBA IEluc3BlY3RvckNTU0lkIEluc3BlY3RvclN0eWxlU2hlZXQ6OnJ1bGVJZChDU1NTdHlsZVJ1bGUq IHJ1bGUpIGNvbnN0CiAKIGJvb2wgSW5zcGVjdG9yU3R5bGVTaGVldDo6b3JpZ2luYWxTdHlsZVNo ZWV0VGV4dChTdHJpbmcqIHJlc3VsdCkgY29uc3QKIHsKKyAgICBpZiAoIW1fcGFnZVN0eWxlU2hl ZXQgfHwgbV9vcmlnaW4gPT0gSW5zcGVjdG9yOjpQcm90b2NvbDo6Q1NTOjpTdHlsZVNoZWV0T3Jp Z2luOjpVc2VyQWdlbnQpCisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICByZXR1cm4gaW5saW5l U3R5bGVTaGVldFRleHQocmVzdWx0KSB8fCByZXNvdXJjZVN0eWxlU2hlZXRUZXh0KHJlc3VsdCkg fHwgZXh0ZW5zaW9uU3R5bGVTaGVldFRleHQocmVzdWx0KTsKIH0KIAogYm9vbCBJbnNwZWN0b3JT dHlsZVNoZWV0OjpyZXNvdXJjZVN0eWxlU2hlZXRUZXh0KFN0cmluZyogcmVzdWx0KSBjb25zdAog ewotICAgIGlmIChtX29yaWdpbiAhPSBJbnNwZWN0b3I6OlByb3RvY29sOjpDU1M6OlN0eWxlU2hl ZXRPcmlnaW46OlJlZ3VsYXIgJiYgbV9vcmlnaW4gIT0gSW5zcGVjdG9yOjpQcm90b2NvbDo6Q1NT OjpTdHlsZVNoZWV0T3JpZ2luOjpJbnNwZWN0b3IpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQot ICAgIGlmICghbV9wYWdlU3R5bGVTaGVldCB8fCAhb3duZXJEb2N1bWVudCgpIHx8ICFvd25lckRv Y3VtZW50KCktPmZyYW1lKCkpCisgICAgaWYgKCFvd25lckRvY3VtZW50KCkgfHwgIW93bmVyRG9j dW1lbnQoKS0+ZnJhbWUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgU3RyaW5nIGVy cm9yOwpAQCAtMTQyMywxMiArMTQyMiw2IEBAIGJvb2wgSW5zcGVjdG9yU3R5bGVTaGVldDo6cmVz b3VyY2VTdHlsZVNoZWV0VGV4dChTdHJpbmcqIHJlc3VsdCkgY29uc3QKIAogYm9vbCBJbnNwZWN0 b3JTdHlsZVNoZWV0OjppbmxpbmVTdHlsZVNoZWV0VGV4dChTdHJpbmcqIHJlc3VsdCkgY29uc3QK IHsKLSAgICBpZiAobV9vcmlnaW4gIT0gSW5zcGVjdG9yOjpQcm90b2NvbDo6Q1NTOjpTdHlsZVNo ZWV0T3JpZ2luOjpSZWd1bGFyKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICBpZiAoIW1f cGFnZVN0eWxlU2hlZXQpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQogICAgIGF1dG8qIG93bmVy Tm9kZSA9IG1fcGFnZVN0eWxlU2hlZXQtPm93bmVyTm9kZSgpOwogICAgIGlmICghaXM8RWxlbWVu dD4ob3duZXJOb2RlKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMTQ0MywxMCArMTQzNiw3 IEBAIGJvb2wgSW5zcGVjdG9yU3R5bGVTaGVldDo6aW5saW5lU3R5bGVTaGVldFRleHQoU3RyaW5n KiByZXN1bHQpIGNvbnN0CiAKIGJvb2wgSW5zcGVjdG9yU3R5bGVTaGVldDo6ZXh0ZW5zaW9uU3R5 bGVTaGVldFRleHQoU3RyaW5nKiByZXN1bHQpIGNvbnN0CiB7Ci0gICAgaWYgKG1fb3JpZ2luICE9 IEluc3BlY3Rvcjo6UHJvdG9jb2w6OkNTUzo6U3R5bGVTaGVldE9yaWdpbjo6VXNlcikKLSAgICAg ICAgcmV0dXJuIGZhbHNlOwotCi0gICAgaWYgKCFtX3BhZ2VTdHlsZVNoZWV0IHx8ICFvd25lckRv Y3VtZW50KCkpCisgICAgaWYgKCFvd25lckRvY3VtZW50KCkpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKIAogICAgIGF1dG8gY29udGVudCA9IG93bmVyRG9jdW1lbnQoKS0+ZXh0ZW5zaW9uU3R5bGVT aGVldHMoKS5jb250ZW50Rm9ySW5qZWN0ZWRTdHlsZVNoZWV0KG1fcGFnZVN0eWxlU2hlZXQpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NT U1N0eWxlU2hlZXQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2Rl bHMvQ1NTU3R5bGVTaGVldC5qcwppbmRleCBmMzUwZmRhMTFhYzE0MWRiNGZkN2Y1ZGM4N2RkNDNj ZGQ0YTY5MDhiLi5jMjAwODM1NjIxNzEwMjI2YzI4MjBkZDFiMTBiMjRjMzIzNmI5MmQzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTU3R5 bGVTaGVldC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2Rl bHMvQ1NTU3R5bGVTaGVldC5qcwpAQCAtNzAsNyArNzAsNyBAQCBXSS5DU1NTdHlsZVNoZWV0ID0g Y2xhc3MgQ1NTU3R5bGVTaGVldCBleHRlbmRzIFdJLlNvdXJjZUNvZGUKIAogICAgIGdldCBpbmpl Y3RlZCgpCiAgICAgewotICAgICAgICByZXR1cm4gdGhpcy51cmxDb21wb25lbnRzICYmIHRoaXMu dXJsQ29tcG9uZW50cy5zY2hlbWUuZW5kc1dpdGgoImV4dGVuc2lvbiIpOworICAgICAgICByZXR1 cm4gdGhpcy51cmxDb21wb25lbnRzLnNjaGVtZSAmJiB0aGlzLnVybENvbXBvbmVudHMuc2NoZW1l LmVuZHNXaXRoKCJleHRlbnNpb24iKTsKICAgICB9CiAKICAgICBnZXQgYW5vbnltb3VzKCkK