20592 2008-09-01 12:35:50 -0700 The focus ring is not shown while navigating on some pages, css handling bug is possible 2008-10-11 23:51:00 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC Other RESOLVED FIXED Cairo, GoogleBug, Gtk P2 Normal --- 15608 1 anatoly.borodin webkit-unassigned alp anatoly.borodin oldest_to_newest 89868 0 anatoly.borodin 2008-09-01 12:35:50 -0700 The focus ring disappears on some Internet pages, for example https://www.google.com/accounts/ServiceLogin : the focus ring disappears after passing the "Sign in" button and appears again at the "create one for free" link after a few tabs. The analyze of the page's source has given a simple test case, the focus ring is not shown on the "bad" page. The bug appears in the gtk branch built under FreeBSD (e.g. git f676a7ee078a079bc3bd9781d4d7c9ca5fd1d79c). 89869 1 23100 anatoly.borodin 2008-09-01 12:38:20 -0700 Created attachment 23100 correct behavior 89870 2 23101 anatoly.borodin 2008-09-01 12:38:58 -0700 Created attachment 23101 incorrect behavior 91158 3 alp 2008-09-14 17:12:24 -0700 This seems to be due to the focus ring function in GraphicsContextCairo relying on the GraphicsContext to paint the focus ring, whereas other ports just use a platform focus ring paint function. 92245 4 23684 alp 2008-09-22 17:09:27 -0700 Created attachment 23684 Fix focus ring painting 92247 5 23684 eric 2008-09-22 17:35:34 -0700 Comment on attachment 23684 Fix focus ring painting This seems like the wrong fix. Why would Gtk want to ignore the color parameter and use the stroke color instead? Shouldn't whatever callers be fixed to pass the strokeColor() in the necessary cases for gtk? I'm just not even sure why that change would be needed. This seems like the wrong layer to abstract at. 92255 6 alp 2008-09-22 18:15:16 -0700 (In reply to comment #5) > (From update of attachment 23684 [edit]) > This seems like the wrong fix. Why would Gtk want to ignore the color > parameter and use the stroke color instead? Shouldn't whatever callers be > fixed to pass the strokeColor() in the necessary cases for gtk? I'm just not > even sure why that change would be needed. This seems like the wrong layer to > abstract at. > The color passed in always seems to be the same which isn't what we want. It looks OK when the focus ring is rounded, thick and transparent, but the GTK+ focus ring is a single pixel dotted rectangle which usually has the text/foreground color, and is used for anchors as well as controls. Not sure how to get the desired color passed in here except by using the stroke or fill colors. Any suggestions? 92264 7 hyatt 2008-09-22 19:44:33 -0700 Don't we use a special keyword for the focus ring color? Doesn't the value of that color come from the RenderTheme? 92269 8 alp 2008-09-22 20:18:24 -0700 (In reply to comment #7) > Don't we use a special keyword for the focus ring color? Doesn't the value of > that color come from the RenderTheme? > I didn't notice a way to adjust the appearance of focused anchor elements (the most common user of drawFocusRing() since RenderTheme handles all controls itself). Looking at RenderTheme/RenderStyleConstants.h the EAppearance values are mostly concerned with widgets/controls which doesn't seem to help. 92270 9 alp 2008-09-22 20:22:00 -0700 (In reply to comment #7) > Don't we use a special keyword for the focus ring color? Doesn't the value of > that color come from the RenderTheme? > I missed the question! Yes, the color does come from RenderTheme but it's constant, whereas the GTK+ focus ring works best when it either uses the current foreground color of the context (ie. matching the color of the text), or otherwise contrasts with the background it's painted on. (In older applications, the focus ring would XOR, but still was never stuck to a single color.) 92271 10 alp 2008-09-22 20:24:36 -0700 (In reply to comment #9) > (In reply to comment #7) > > Don't we use a special keyword for the focus ring color? Doesn't the value of > > that color come from the RenderTheme? > > > > I missed the question! Yes, the color does come from RenderTheme but it's > constant, whereas the GTK+ focus ring works best when it either uses the > current foreground color of the context (ie. matching the color of the text), > or otherwise contrasts with the background it's painted on. (In older > applications, the focus ring would XOR, but still was never stuck to a single > color.) > Indeed, a little testing shows that the value of strokeColor() doesn't _always_ contrast with the background, so the technique in my patch isn't perfect but passable. Any thoughts? 92596 11 hyatt 2008-09-24 14:49:52 -0700 Don't we just need to support invert when painting outlines? http://www.w3.org/TR/2004/CR-css3-ui-20040511/#outline-color0 That seems to be the bug here. 92598 12 hyatt 2008-09-24 14:50:46 -0700 If you want to use the current foreground color, then currentColor is the right keyword. Not sure we support that yet though. Either way I think the CSS spec covers what you need. We just have to add the right support for it. 92624 13 23771 alp 2008-09-24 16:52:34 -0700 Created attachment 23771 Fix focus ring painting, take two Fixed to use the color passed in to drawFocusRing() 92626 14 23771 alp 2008-09-24 16:57:28 -0700 Comment on attachment 23771 Fix focus ring painting, take two >+ // We prefer the stroke color for focus rings in GTK+. >+ setColor(cr, color); Above comment isn't necessary any more, of course. 95003 15 23771 darin 2008-10-11 16:23:57 -0700 Comment on attachment 23771 Fix focus ring painting, take two Seems fine, r=me 95029 16 alp 2008-10-11 23:51:00 -0700 Landed in r37521. 23100 2008-09-01 12:38:20 -0700 2008-09-01 12:39:38 -0700 correct behavior good.html text/html 290 anatoly.borodin PGh0bWw+Cgk8aGVhZD4KCQk8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9 InRleHQvaHRtbDsgY2hhcnNldD1VVEYtOCI+Cgk8L2hlYWQ+Cgk8Ym9keT4KCQk8dGFibGU+CgkJ CTx0cj4KCQkJCTx0ZD4KCQkJCQk8YSBocmVmPSJodHRwOi8vZ29vZ2xlLmNvbS8iPkE8L2E+CgkJ CQk8L3RkPgoJCQk8L3RyPgoJCTwvdGFibGU+CgkJPGEgaHJlZj0iaHR0cDovL2dvb2dsZS5jb20v Ij5CPC9hPgoJCTxhIGhyZWY9Imh0dHA6Ly9nb29nbGUuY29tLyI+QzwvYT4KCTwvYm9keT4KPC9o dG1sPgo= 23101 2008-09-01 12:38:58 -0700 2008-09-01 12:38:58 -0700 incorrect behavior bad.html text/html 313 anatoly.borodin PGh0bWw+Cgk8aGVhZD4KCQk8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9 InRleHQvaHRtbDsgY2hhcnNldD1VVEYtOCI+Cgk8L2hlYWQ+Cgk8Ym9keT4KCQk8dGFibGUgc3R5 bGU9ImJvcmRlcjogc29saWQ7Ij4KCQkJPHRyPgoJCQkJPHRkPgoJCQkJCTxhIGhyZWY9Imh0dHA6 Ly9nb29nbGUuY29tLyI+QTwvYT4KCQkJCTwvdGQ+CgkJCTwvdHI+CgkJPC90YWJsZT4KCQk8YSBo cmVmPSJodHRwOi8vZ29vZ2xlLmNvbS8iPkI8L2E+CgkJPGEgaHJlZj0iaHR0cDovL2dvb2dsZS5j b20vIj5DPC9hPgoJPC9ib2R5Pgo8L2h0bWw+Cg== 23684 2008-09-22 17:09:27 -0700 2008-09-24 16:52:34 -0700 Fix focus ring painting nuanti-focus-ring.patch text/plain 3431 alp SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNjc4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDgtMDktMjIgIEFscCBUb2tlciAgPGFscEBudWFudGkuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU5MgorICAgICAgICBUaGUgZm9jdXMg cmluZyBpcyBub3Qgc2hvd24gd2hpbGUgbmF2aWdhdGluZyBvbiBzb21lIHBhZ2VzCisKKyAgICAg ICAgRml4IGRyYXdGb2N1c1JpbmcoKSBzbyBpdCBkb2Vzbid0IGRlcGVuZCBvbiB0aGUgY3VycmVu dCBncmFwaGljcworICAgICAgICBzdGF0ZSwgdGh1cyBtYXRjaGluZyBvdGhlciBwbGF0Zm9ybXMg d2hpY2ggYWxyZWFkeSB3b3JrIHRoaXMgd2F5LgorCisgICAgICAgIFRoaXMgcGF0Y2ggcHJvdmlk ZXMgdHdvIGNvZGUgcGF0aHM6IG9uZSB1c2luZyBzdHJhaWdodCBDYWlybyBhbmQKKyAgICAgICAg b25lIHNwZWNpYWxpc2VkIGZvciB0aGUgR1RLKyBwb3J0IHdpdGggYSBtb3JlIGNvbnZlbnRpb25h bCBhcHBlYXJhbmNlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhp Y3NDb250ZXh0Q2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0Ojpk cmF3Rm9jdXNSaW5nKToKKwogMjAwOC0wOS0yMiAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5j b20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx MDA3CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4 dENhaXJvLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJv L0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAkocmV2aXNpb24gMzY3ODUpCisrKyBXZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMiw2ICsyLDcgQEAKICAqIENvcHlyaWdodCAoQykgMjAwNiBBcHBsZSBDb21wdXRl ciwgSW5jLiAgQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAoQykgMjAwNyBBbHAg VG9rZXIgPGFscEBhdG9rZXIuY29tPgogICogQ29weXJpZ2h0IChDKSAyMDA4IERpcmsgU2NodWx6 ZSA8dmJzODVAZ214LmRlPgorICogQ29weXJpZ2h0IChDKSAyMDA4IE51YW50aSBMdGQuCiAgKgog ICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0 aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhh dCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTUzNCwyMiArNTM1LDQ2IEBAIHZvaWQgR3Jh cGhpY3NDb250ZXh0OjpkcmF3Rm9jdXNSaW5nKGNvbnMKIAogICAgIGNvbnN0IFZlY3RvcjxJbnRS ZWN0PiYgcmVjdHMgPSBmb2N1c1JpbmdSZWN0cygpOwogICAgIHVuc2lnbmVkIHJlY3RDb3VudCA9 IHJlY3RzLnNpemUoKTsKLSAgICBJbnRSZWN0IGZpbmFsRm9jdXNSZWN0OwotICAgIGZvciAodW5z aWduZWQgaSA9IDA7IGkgPCByZWN0Q291bnQ7IGkrKykgewotICAgICAgICBJbnRSZWN0IGZvY3Vz UmVjdCA9IHJlY3RzW2ldOwotICAgICAgICBmb2N1c1JlY3QuaW5mbGF0ZShvZmZzZXQpOwotICAg ICAgICBmaW5hbEZvY3VzUmVjdC51bml0ZShmb2N1c1JlY3QpOwotICAgIH0KIAogICAgIGNhaXJv X3QqIGNyID0gbV9kYXRhLT5jcjsKICAgICBjYWlyb19zYXZlKGNyKTsKLSAgICAvLyBGSVhNRTog VGhlc2UgcmVjdHMgc2hvdWxkIGJlIHJvdW5kZWQKLSAgICBjYWlyb19yZWN0YW5nbGUoY3IsIGZp bmFsRm9jdXNSZWN0LngoKSwgZmluYWxGb2N1c1JlY3QueSgpLCBmaW5hbEZvY3VzUmVjdC53aWR0 aCgpLCBmaW5hbEZvY3VzUmVjdC5oZWlnaHQoKSk7CisgICAgY2Fpcm9fcHVzaF9ncm91cChjcik7 CisgICAgY2Fpcm9fbmV3X3BhdGgoY3IpOworCisjaWYgUExBVEZPUk0oR1RLKQorICAgIEdka1Jl Z2lvbiogcmVnID0gZ2RrX3JlZ2lvbl9uZXcoKTsKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBp IDwgcmVjdENvdW50OyBpKyspIHsKKyAgICAgICAgR2RrUmVjdGFuZ2xlIHJlY3QgPSByZWN0c1tp XTsKKyAgICAgICAgZ2RrX3JlZ2lvbl91bmlvbl93aXRoX3JlY3QocmVnLCAmcmVjdCk7CisgICAg fQorICAgIGdka19jYWlyb19yZWdpb24oY3IsIHJlZyk7CisgICAgZ2RrX3JlZ2lvbl9kZXN0cm95 KHJlZyk7CisKKyAgICAvLyBXZSBwcmVmZXIgdGhlIHN0cm9rZSBjb2xvciBmb3IgZm9jdXMgcmlu Z3MgaW4gR1RLKy4KKyAgICBzZXRDb2xvcihjciwgc3Ryb2tlQ29sb3IoKSk7CisgICAgY2Fpcm9f c2V0X2xpbmVfd2lkdGgoY3IsIDIuMGYpOworICAgIHNldFBsYXRmb3JtU3Ryb2tlU3R5bGUoRG90 dGVkU3Ryb2tlKTsKKyNlbHNlCisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHJlY3RDb3Vu dDsgaSsrKQorICAgICAgICBhZGRQYXRoKFBhdGg6OmNyZWF0ZVJvdW5kZWRSZWN0YW5nbGUocmVj dHNbaV0sIEZsb2F0U2l6ZShyYWRpdXMsIHJhZGl1cykpKTsKIAogICAgIC8vIEZvcmNlIHRoZSBh bHBoYSB0byA1MCUuICBUaGlzIG1hdGNoZXMgd2hhdCB0aGUgTWFjIGRvZXMgd2l0aCBvdXRsaW5l IHJpbmdzLgogICAgIENvbG9yIHJpbmdDb2xvcihjb2xvci5yZWQoKSwgY29sb3IuZ3JlZW4oKSwg Y29sb3IuYmx1ZSgpLCAxMjcpOwogICAgIHNldENvbG9yKGNyLCByaW5nQ29sb3IpOwotICAgIGNh aXJvX3N0cm9rZShjcik7CisgICAgY2Fpcm9fc2V0X2xpbmVfd2lkdGgoY3IsIGZvY3VzUmluZ1dp ZHRoKCkpOworICAgIHNldFBsYXRmb3JtU3Ryb2tlU3R5bGUoU29saWRTdHJva2UpOworI2VuZGlm CisKKyAgICBjYWlyb19zZXRfb3BlcmF0b3IoY3IsIENBSVJPX09QRVJBVE9SX09WRVIpOworICAg IGNhaXJvX3N0cm9rZV9wcmVzZXJ2ZShjcik7CisKKyAgICBjYWlyb19zZXRfb3BlcmF0b3IoY3Is IENBSVJPX09QRVJBVE9SX0NMRUFSKTsKKyAgICBjYWlyb19zZXRfZmlsbF9ydWxlKGNyLCBDQUlS T19GSUxMX1JVTEVfV0lORElORyk7CisgICAgY2Fpcm9fZmlsbChjcik7CisKKyAgICBjYWlyb19w b3BfZ3JvdXBfdG9fc291cmNlKGNyKTsKKyAgICBjYWlyb19zZXRfb3BlcmF0b3IoY3IsIENBSVJP X09QRVJBVE9SX09WRVIpOworICAgIGNhaXJvX3BhaW50KGNyKTsKICAgICBjYWlyb19yZXN0b3Jl KGNyKTsKIH0KIAo= 23771 2008-09-24 16:52:34 -0700 2008-10-11 16:23:57 -0700 Fix focus ring painting, take two nuanti-focus-ring-2.patch text/plain 4245 alp SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNjg3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjUgQEAKKzIwMDgtMDktMjQgIEFscCBUb2tlciAgPGFscEBudWFudGkuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU5MgorICAgICAgICBUaGUgZm9jdXMg cmluZyBpcyBub3Qgc2hvd24gd2hpbGUgbmF2aWdhdGluZyBvbiBzb21lIHBhZ2VzCisKKyAgICAg ICAgRml4IGRyYXdGb2N1c1JpbmcoKSBzbyBpdCBkb2Vzbid0IGRlcGVuZCBvbiB0aGUgY3VycmVu dCBncmFwaGljcworICAgICAgICBzdGF0ZSwgdGh1cyBtYXRjaGluZyBvdGhlciBwbGF0Zm9ybXMg d2hpY2ggYWxyZWFkeSB3b3JrIHRoaXMgd2F5LgorCisgICAgICAgIFRoaXMgcGF0Y2ggcHJvdmlk ZXMgdHdvIGNvZGUgcGF0aHM6IG9uZSB1c2luZyBzdHJhaWdodCBDYWlybyBhbmQKKyAgICAgICAg b25lIHNwZWNpYWxpc2VkIGZvciB0aGUgR1RLKyBwb3J0IHdpdGggYSBtb3JlIGNvbnZlbnRpb25h bCBhcHBlYXJhbmNlLgorCisgICAgICAgIEFsc28gY2hhbmdlIGZvY3VzUmluZ0NvbG9yKCkgdG8g cmV0dXJuIGEgbnVsbCBjb2xvciwgYWxsb3dpbmcgdGhlCisgICAgICAgIGZvY3VzIHJpbmcgdG8g cGljayB1cCB0aGUgc3R5bGUncyBjdXJyZW50IGNvbG9yIGlmIGl0IGlzbid0IG92ZXJyaWRkZW4K KyAgICAgICAgd2l0aCBDU1MuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9H cmFwaGljc0NvbnRleHRDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRl eHQ6OmRyYXdGb2N1c1JpbmcpOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZW1wb3JhcnlMaW5r U3R1YnMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Zm9jdXNSaW5nQ29sb3IpOgorCiAyMDA4LTA5 LTI0ICBKZXJlbXkgTW9za292aWNoICA8amVyZW15QGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAJKHJldmlzaW9u IDM2ODczKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRl eHRDYWlyby5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIsNiArMiw3IEBACiAgKiBDb3B5cmlnaHQg KEMpIDIwMDYgQXBwbGUgQ29tcHV0ZXIsIEluYy4gIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKiBD b3B5cmlnaHQgKEMpIDIwMDcgQWxwIFRva2VyIDxhbHBAYXRva2VyLmNvbT4KICAqIENvcHlyaWdo dCAoQykgMjAwOCBEaXJrIFNjaHVsemUgPHZiczg1QGdteC5kZT4KKyAqIENvcHlyaWdodCAoQykg MjAwOCBOdWFudGkgTHRkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNl IGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUg cGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC01MzQs MjIgKzUzNSw0NiBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZHJhd0ZvY3VzUmluZyhjb25zCiAK ICAgICBjb25zdCBWZWN0b3I8SW50UmVjdD4mIHJlY3RzID0gZm9jdXNSaW5nUmVjdHMoKTsKICAg ICB1bnNpZ25lZCByZWN0Q291bnQgPSByZWN0cy5zaXplKCk7Ci0gICAgSW50UmVjdCBmaW5hbEZv Y3VzUmVjdDsKLSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgcmVjdENvdW50OyBpKyspIHsK LSAgICAgICAgSW50UmVjdCBmb2N1c1JlY3QgPSByZWN0c1tpXTsKLSAgICAgICAgZm9jdXNSZWN0 LmluZmxhdGUob2Zmc2V0KTsKLSAgICAgICAgZmluYWxGb2N1c1JlY3QudW5pdGUoZm9jdXNSZWN0 KTsKLSAgICB9CiAKICAgICBjYWlyb190KiBjciA9IG1fZGF0YS0+Y3I7CiAgICAgY2Fpcm9fc2F2 ZShjcik7Ci0gICAgLy8gRklYTUU6IFRoZXNlIHJlY3RzIHNob3VsZCBiZSByb3VuZGVkCi0gICAg Y2Fpcm9fcmVjdGFuZ2xlKGNyLCBmaW5hbEZvY3VzUmVjdC54KCksIGZpbmFsRm9jdXNSZWN0Lnko KSwgZmluYWxGb2N1c1JlY3Qud2lkdGgoKSwgZmluYWxGb2N1c1JlY3QuaGVpZ2h0KCkpOworICAg IGNhaXJvX3B1c2hfZ3JvdXAoY3IpOworICAgIGNhaXJvX25ld19wYXRoKGNyKTsKKworI2lmIFBM QVRGT1JNKEdUSykKKyAgICBHZGtSZWdpb24qIHJlZyA9IGdka19yZWdpb25fbmV3KCk7CisgICAg Zm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHJlY3RDb3VudDsgaSsrKSB7CisgICAgICAgIEdka1Jl Y3RhbmdsZSByZWN0ID0gcmVjdHNbaV07CisgICAgICAgIGdka19yZWdpb25fdW5pb25fd2l0aF9y ZWN0KHJlZywgJnJlY3QpOworICAgIH0KKyAgICBnZGtfY2Fpcm9fcmVnaW9uKGNyLCByZWcpOwor ICAgIGdka19yZWdpb25fZGVzdHJveShyZWcpOworCisgICAgLy8gV2UgcHJlZmVyIHRoZSBzdHJv a2UgY29sb3IgZm9yIGZvY3VzIHJpbmdzIGluIEdUSysuCisgICAgc2V0Q29sb3IoY3IsIGNvbG9y KTsKKyAgICBjYWlyb19zZXRfbGluZV93aWR0aChjciwgMi4wZik7CisgICAgc2V0UGxhdGZvcm1T dHJva2VTdHlsZShEb3R0ZWRTdHJva2UpOworI2Vsc2UKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAw OyBpIDwgcmVjdENvdW50OyBpKyspCisgICAgICAgIGFkZFBhdGgoUGF0aDo6Y3JlYXRlUm91bmRl ZFJlY3RhbmdsZShyZWN0c1tpXSwgRmxvYXRTaXplKHJhZGl1cywgcmFkaXVzKSkpOwogCiAgICAg Ly8gRm9yY2UgdGhlIGFscGhhIHRvIDUwJS4gIFRoaXMgbWF0Y2hlcyB3aGF0IHRoZSBNYWMgZG9l cyB3aXRoIG91dGxpbmUgcmluZ3MuCiAgICAgQ29sb3IgcmluZ0NvbG9yKGNvbG9yLnJlZCgpLCBj b2xvci5ncmVlbigpLCBjb2xvci5ibHVlKCksIDEyNyk7CiAgICAgc2V0Q29sb3IoY3IsIHJpbmdD b2xvcik7Ci0gICAgY2Fpcm9fc3Ryb2tlKGNyKTsKKyAgICBjYWlyb19zZXRfbGluZV93aWR0aChj ciwgZm9jdXNSaW5nV2lkdGgoKSk7CisgICAgc2V0UGxhdGZvcm1TdHJva2VTdHlsZShTb2xpZFN0 cm9rZSk7CisjZW5kaWYKKworICAgIGNhaXJvX3NldF9vcGVyYXRvcihjciwgQ0FJUk9fT1BFUkFU T1JfT1ZFUik7CisgICAgY2Fpcm9fc3Ryb2tlX3ByZXNlcnZlKGNyKTsKKworICAgIGNhaXJvX3Nl dF9vcGVyYXRvcihjciwgQ0FJUk9fT1BFUkFUT1JfQ0xFQVIpOworICAgIGNhaXJvX3NldF9maWxs X3J1bGUoY3IsIENBSVJPX0ZJTExfUlVMRV9XSU5ESU5HKTsKKyAgICBjYWlyb19maWxsKGNyKTsK KworICAgIGNhaXJvX3BvcF9ncm91cF90b19zb3VyY2UoY3IpOworICAgIGNhaXJvX3NldF9vcGVy YXRvcihjciwgQ0FJUk9fT1BFUkFUT1JfT1ZFUik7CisgICAgY2Fpcm9fcGFpbnQoY3IpOwogICAg IGNhaXJvX3Jlc3RvcmUoY3IpOwogfQogCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2d0ay9UZW1w b3JhcnlMaW5rU3R1YnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1Rl bXBvcmFyeUxpbmtTdHVicy5jcHAJKHJldmlzaW9uIDM2ODczKQorKysgV2ViQ29yZS9wbGF0Zm9y bS9ndGsvVGVtcG9yYXJ5TGlua1N0dWJzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTgsNyArNTgs NyBAQCBWZWN0b3I8Y2hhcj4gbG9hZFJlc291cmNlSW50b0FycmF5KGNvbnN0CiAKIHZvaWQgUGx1 Z2luVmlldzo6aW52YWxpZGF0ZVJlZ2lvbihOUFJlZ2lvbikgeyBub3RJbXBsZW1lbnRlZCgpOyB9 CiAKLUNvbG9yIFdlYkNvcmU6OmZvY3VzUmluZ0NvbG9yKCkgeyByZXR1cm4gMHhGRjAwMDBGRjsg fQorQ29sb3IgV2ViQ29yZTo6Zm9jdXNSaW5nQ29sb3IoKSB7IHJldHVybiBDb2xvcigpOyB9CiB2 b2lkIFdlYkNvcmU6OnNldEZvY3VzUmluZ0NvbG9yQ2hhbmdlRnVuY3Rpb24odm9pZCAoKikoKSkg eyB9CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK