205894 2020-01-07 16:02:59 -0800 [LFC][BFC] BlockFormattingContext::layoutFormattingContextRoot should take the horizontal constraints 2020-01-09 09:54:13 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1603847 0 zalan 2020-01-07 16:02:59 -0800 ssia 1603848 1 webkit-bug-importer 2020-01-07 16:03:33 -0800 <rdar://problem/58391798> 1603856 2 387050 zalan 2020-01-07 16:16:30 -0800 Created attachment 387050 Patch 1604681 3 zalan 2020-01-09 09:54:13 -0800 Committed r254265: <https://trac.webkit.org/changeset/254265> 387050 2020-01-07 16:16:30 -0800 2020-01-09 07:19:31 -0800 Patch bug-205894-20200107161628.patch text/plain 6434 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDg4NTcxZDBmZjMwOGEz MGVhNjU4ZDhlZmMxZjViOTQ5ZTk4MmQ0OC4uYTFhYjFjMzM0YTcxNGQ4NWFlY2Y2ZTg3MTlmODY3 NjNlM2I0ZTQzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAxLTA3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXSBCbG9ja0Zv cm1hdHRpbmdDb250ZXh0OjpsYXlvdXRGb3JtYXR0aW5nQ29udGV4dFJvb3Qgc2hvdWxkIHRha2Ug dGhlIGhvcml6b250YWwgY29uc3RyYWludHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwNTg5NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTgzOTE3 OTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbGF5 b3V0Rm9ybWF0dGluZ0NvbnRleHRSb290IHNob3VsZCBub3QgbmVlZCB0byByZWFkIHRoZSBjb250 YWluaW5nIGJsb2NrJ3MgZ2VvbWV0cnkgZm9yIGNvbnN0cmFpbnRzIGluZm9ybWF0aW9uLgorCisg ICAgICAgICogbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6QmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6bGF5 b3V0SW5GbG93Q29udGVudCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJsb2NrRm9ybWF0 dGluZ0NvbnRleHQ6OmxheW91dEZvcm1hdHRpbmdDb250ZXh0Um9vdCk6CisgICAgICAgICogbGF5 b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0Lmg6CisKIDIwMjAtMDEt MDcgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXSBGb3Jt YXR0aW5nQ29udGV4dDo6bGF5b3V0T3V0T2ZGbG93Q29udGVudCBzaG91bGQgdGFrZSBob3Jpem9u dGFsIGFuZCB2ZXJ0aWNhbCBjb25zdHJhaW50cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQu Y3BwCmluZGV4IGYxZDRhYWQ3ZDAwYTE5MTIxMDZlYTk0ZmNiZTkwZjEzYjEyNTk3MjIuLmM4ZmUx OWZmNTI4YzE0NjJjZDViOGQ1YmI3ZWZkZDYyOTY2YjJkMTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRp bmdDb250ZXh0LmNwcApAQCAtMTA3LDIyICsxMDcsMTkgQEAgdm9pZCBCbG9ja0Zvcm1hdHRpbmdD b250ZXh0OjpsYXlvdXRJbkZsb3dDb250ZW50KEludmFsaWRhdGlvblN0YXRlJiBpbnZhbGlkYXRp b24KICAgICAgICAgLy8gVHJhdmVyc2UgZG93biBvbiB0aGUgZGVzY2VuZGFudHMgYW5kIGNvbXB1 dGUgd2lkdGgvc3RhdGljIHBvc2l0aW9uIHVudGlsIHdlIGZpbmQgYSBsZWFmIG5vZGUuCiAgICAg ICAgIHdoaWxlICh0cnVlKSB7CiAgICAgICAgICAgICBhdXRvJiBsYXlvdXRCb3ggPSAqbGF5b3V0 UXVldWUubGFzdCgpOworICAgICAgICAgICAgYXV0byBob3Jpem9udGFsQ29uc3RyYWludHMgPSBo b3Jpem9udGFsQ29uc3RyYWludHNGb3JMYXlvdXRCb3gobGF5b3V0Qm94KTsKIAogICAgICAgICAg ICAgaWYgKGxheW91dEJveC5lc3RhYmxpc2hlc0Zvcm1hdHRpbmdDb250ZXh0KCkpIHsKICAgICAg ICAgICAgICAgICAvLyBsYXlvdXRGb3JtYXR0aW5nQ29udGV4dFJvb3QoKSB0YWtlcyBjYXJlIG9m IHRoZSBsYXlvdXRCb3ggaXRzZWxmIGFuZCBpdHMgZGVzY2VuZGFudHMuCi0gICAgICAgICAgICAg ICAgbGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRSb290KGZsb2F0aW5nQ29udGV4dCwgbGF5b3V0Qm94 LCBpbnZhbGlkYXRpb25TdGF0ZSk7CisgICAgICAgICAgICAgICAgbGF5b3V0Rm9ybWF0dGluZ0Nv bnRleHRSb290KGxheW91dEJveCwgZmxvYXRpbmdDb250ZXh0LCBpbnZhbGlkYXRpb25TdGF0ZSwg aG9yaXpvbnRhbENvbnN0cmFpbnRzKTsKICAgICAgICAgICAgICAgICBsYXlvdXRRdWV1ZS5yZW1v dmVMYXN0KCk7CiAgICAgICAgICAgICAgICAgaWYgKCFhcHBlbmROZXh0VG9MYXlvdXRRdWV1ZShs YXlvdXRCb3gsIExheW91dERpcmVjdGlvbjo6U2libGluZykpCiAgICAgICAgICAgICAgICAgICAg IGJyZWFrOwogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgfQotICAgICAg ICAgICAgewotICAgICAgICAgICAgICAgIGF1dG8gaG9yaXpvbnRhbENvbnN0cmFpbnRzID0gaG9y aXpvbnRhbENvbnN0cmFpbnRzRm9yTGF5b3V0Qm94KGxheW91dEJveCk7Ci0gICAgICAgICAgICAg ICAgY29tcHV0ZUJvcmRlckFuZFBhZGRpbmcobGF5b3V0Qm94LCBob3Jpem9udGFsQ29uc3RyYWlu dHMpOwotICAgICAgICAgICAgICAgIGNvbXB1dGVXaWR0aEFuZE1hcmdpbihsYXlvdXRCb3gsIGhv cml6b250YWxDb25zdHJhaW50cyk7Ci0gICAgICAgICAgICAgICAgY29tcHV0ZVN0YXRpY1Bvc2l0 aW9uKGZsb2F0aW5nQ29udGV4dCwgbGF5b3V0Qm94LCBob3Jpem9udGFsQ29uc3RyYWludHMpOwot ICAgICAgICAgICAgfQotCisgICAgICAgICAgICBjb21wdXRlQm9yZGVyQW5kUGFkZGluZyhsYXlv dXRCb3gsIGhvcml6b250YWxDb25zdHJhaW50cyk7CisgICAgICAgICAgICBjb21wdXRlV2lkdGhB bmRNYXJnaW4obGF5b3V0Qm94LCBob3Jpem9udGFsQ29uc3RyYWludHMpOworICAgICAgICAgICAg Y29tcHV0ZVN0YXRpY1Bvc2l0aW9uKGZsb2F0aW5nQ29udGV4dCwgbGF5b3V0Qm94LCBob3Jpem9u dGFsQ29uc3RyYWludHMpOwogICAgICAgICAgICAgaWYgKCFhcHBlbmROZXh0VG9MYXlvdXRRdWV1 ZShsYXlvdXRCb3gsIExheW91dERpcmVjdGlvbjo6Q2hpbGQpKQogICAgICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICB9CkBAIC0xNzksMjMgKzE3NiwyMSBAQCBPcHRpb25hbDxMYXlvdXRVbml0 PiBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0Ojp1c2VkQXZhaWxhYmxlV2lkdGhGb3JGbG9hdEF2b2lk ZXIoYwogICAgIHJldHVybiBhdmFpbGFibGVXaWR0aDsKIH0KIAotdm9pZCBCbG9ja0Zvcm1hdHRp bmdDb250ZXh0OjpsYXlvdXRGb3JtYXR0aW5nQ29udGV4dFJvb3QoRmxvYXRpbmdDb250ZXh0JiBm bG9hdGluZ0NvbnRleHQsIGNvbnN0IEJveCYgbGF5b3V0Qm94LCBJbnZhbGlkYXRpb25TdGF0ZSYg aW52YWxpZGF0aW9uU3RhdGUpCit2b2lkIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OmxheW91dEZv cm1hdHRpbmdDb250ZXh0Um9vdChjb25zdCBCb3gmIGxheW91dEJveCwgRmxvYXRpbmdDb250ZXh0 JiBmbG9hdGluZ0NvbnRleHQsIEludmFsaWRhdGlvblN0YXRlJiBpbnZhbGlkYXRpb25TdGF0ZSwg Y29uc3QgVXNlZEhvcml6b250YWxWYWx1ZXM6OkNvbnN0cmFpbnRzJiBob3Jpem9udGFsQ29uc3Ry YWludHMpCiB7CiAgICAgQVNTRVJUKGxheW91dEJveC5lc3RhYmxpc2hlc0Zvcm1hdHRpbmdDb250 ZXh0KCkpOwogICAgIC8vIFN0YXJ0IGxheWluZyBvdXQgdGhpcyBmb3JtYXR0aW5nIHJvb3QgaW4g dGhlIGZvcm1hdHRpbmcgY29udGVueHQgaXQgbGl2ZXMgaW4uCiAgICAgTE9HX1dJVEhfU1RSRUFN KEZvcm1hdHRpbmdDb250ZXh0TGF5b3V0LCBzdHJlYW0gPDwgIltDb21wdXRlXSAtPiBbUG9zaXRp b25dW0JvcmRlcl1bUGFkZGluZ11bV2lkdGhdW01hcmdpbl0gLT4gZm9yIGxheW91dEJveCgiIDw8 ICZsYXlvdXRCb3ggPDwgIikiKTsKLQotICAgIE9wdGlvbmFsPExheW91dFVuaXQ+IHVzZWRBdmFp bGFibGVXaWR0aEZvckZsb2F0QXZvaWRlcjsKKyAgICBhdXRvIGFkanVzdGVkSG9yaXpvbnRhbENv bnN0cmFpbnRzID0gaG9yaXpvbnRhbENvbnN0cmFpbnRzOwogICAgIGF1dG8gaG9yaXpvbnRhbEF2 YWlsYWJsZVNwYWNlSXNDb25zdHJhaW5lZEJ5RXhpc3RpbmdGbG9hdHMgPSBsYXlvdXRCb3guaXNG bG9hdEF2b2lkZXIoKSAmJiAhbGF5b3V0Qm94LmlzRmxvYXRpbmdQb3NpdGlvbmVkKCk7CiAgICAg aWYgKGhvcml6b250YWxBdmFpbGFibGVTcGFjZUlzQ29uc3RyYWluZWRCeUV4aXN0aW5nRmxvYXRz KQotICAgICAgICB1c2VkQXZhaWxhYmxlV2lkdGhGb3JGbG9hdEF2b2lkZXIgPSB0aGlzLT51c2Vk QXZhaWxhYmxlV2lkdGhGb3JGbG9hdEF2b2lkZXIoZmxvYXRpbmdDb250ZXh0LCBsYXlvdXRCb3gp OwotICAgIGF1dG8gY29udGFpbmluZ0Jsb2NrR2VvbWV0cnkgPSBnZW9tZXRyeUZvckJveCgqbGF5 b3V0Qm94LmNvbnRhaW5pbmdCbG9jaygpKTsKLSAgICBhdXRvIGhvcml6b250YWxBdmFpbGFibGVT cGFjZSA9IHVzZWRBdmFpbGFibGVXaWR0aEZvckZsb2F0QXZvaWRlci52YWx1ZU9yKGNvbnRhaW5p bmdCbG9ja0dlb21ldHJ5LmNvbnRlbnRCb3hXaWR0aCgpKTsKLSAgICBhdXRvIGhvcml6b250YWxD b25zdHJhaW50cyA9IFVzZWRIb3Jpem9udGFsVmFsdWVzOjpDb25zdHJhaW50cyB7IGNvbnRhaW5p bmdCbG9ja0dlb21ldHJ5LmNvbnRlbnRCb3hMZWZ0KCksIGhvcml6b250YWxBdmFpbGFibGVTcGFj ZSB9OwotICAgIGNvbXB1dGVCb3JkZXJBbmRQYWRkaW5nKGxheW91dEJveCwgaG9yaXpvbnRhbENv bnN0cmFpbnRzKTsKKyAgICAgICAgYWRqdXN0ZWRIb3Jpem9udGFsQ29uc3RyYWludHMud2lkdGgg PSB1c2VkQXZhaWxhYmxlV2lkdGhGb3JGbG9hdEF2b2lkZXIoZmxvYXRpbmdDb250ZXh0LCBsYXlv dXRCb3gpLnZhbHVlT3IoaG9yaXpvbnRhbENvbnN0cmFpbnRzLndpZHRoKTsKKworICAgIGNvbXB1 dGVCb3JkZXJBbmRQYWRkaW5nKGxheW91dEJveCwgYWRqdXN0ZWRIb3Jpem9udGFsQ29uc3RyYWlu dHMpOwogICAgIGNvbXB1dGVTdGF0aWNWZXJ0aWNhbFBvc2l0aW9uKGZsb2F0aW5nQ29udGV4dCwg bGF5b3V0Qm94KTsKLSAgICBjb21wdXRlV2lkdGhBbmRNYXJnaW4obGF5b3V0Qm94LCBob3Jpem9u dGFsQ29uc3RyYWludHMpOwotICAgIGNvbXB1dGVTdGF0aWNIb3Jpem9udGFsUG9zaXRpb24obGF5 b3V0Qm94LCBob3Jpem9udGFsQ29uc3RyYWludHMpOworICAgIGNvbXB1dGVXaWR0aEFuZE1hcmdp bihsYXlvdXRCb3gsIGFkanVzdGVkSG9yaXpvbnRhbENvbnN0cmFpbnRzKTsKKyAgICBjb21wdXRl U3RhdGljSG9yaXpvbnRhbFBvc2l0aW9uKGxheW91dEJveCwgYWRqdXN0ZWRIb3Jpem9udGFsQ29u c3RyYWludHMpOworCiAgICAgaWYgKGlzPENvbnRhaW5lcj4obGF5b3V0Qm94KSkgewogICAgICAg ICAvLyBTd2ljaCBvdmVyIHRvIHRoZSBuZXcgZm9ybWF0dGluZyBjb250ZXh0ICh0aGUgb25lIHRo YXQgdGhlIHJvb3QgY3JlYXRlcykuCiAgICAgICAgIGF1dG8mIHJvb3RDb250YWluZXIgPSBkb3du Y2FzdDxDb250YWluZXI+KGxheW91dEJveCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuaCBiL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5oCmlu ZGV4IDhlMjAyZDNhOTVmODNjNTk2ODlmNTZlNzY5MTUyODcxNWZmOWZjZGYuLjg3NDViNjQ3Y2Zl OWQzNzg1MjYwOTBjYzg0MjRlNGRjMGUyNzAwN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4 dC5oCkBAIC01MSw3ICs1MSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGxheW91dEluRmxvd0NvbnRl bnQoSW52YWxpZGF0aW9uU3RhdGUmLCBjb25zdCBVc2VkSG9yaXpvbnRhbFZhbHVlczo6Q29uc3Ry YWludHMmKSBvdmVycmlkZTsKIAogcHJpdmF0ZToKLSAgICB2b2lkIGxheW91dEZvcm1hdHRpbmdD b250ZXh0Um9vdChGbG9hdGluZ0NvbnRleHQmLCBjb25zdCBCb3gmLCBJbnZhbGlkYXRpb25TdGF0 ZSYpOworICAgIHZvaWQgbGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRSb290KGNvbnN0IEJveCYsIEZs b2F0aW5nQ29udGV4dCYsIEludmFsaWRhdGlvblN0YXRlJiwgY29uc3QgVXNlZEhvcml6b250YWxW YWx1ZXM6OkNvbnN0cmFpbnRzJik7CiAgICAgdm9pZCBwbGFjZUluRmxvd1Bvc2l0aW9uZWRDaGls ZHJlbihjb25zdCBCb3gmKTsKIAogICAgIHZvaWQgY29tcHV0ZVdpZHRoQW5kTWFyZ2luKGNvbnN0 IEJveCYsIGNvbnN0IFVzZWRIb3Jpem9udGFsVmFsdWVzOjpDb25zdHJhaW50cyYpOwo=