205893 2020-01-07 15:42:05 -0800 REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure 2020-01-30 14:39:09 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=207001 InRadar P2 Normal --- 1 tsavell youennf commit-queue eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1603837 0 tsavell 2020-01-07 15:42:05 -0800 webrtc/video-autoplay.html Description: This test is a flaky failure on Mac. It looks like this may have begun with the changes in https://trac.webkit.org/changeset/253825/webkit History: https://results.webkit.org/?suite=layout-tests&test=webrtc%2Fvideo-autoplay.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/webrtc/video-autoplay-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/webrtc/video-autoplay-actual.txt @@ -6,7 +6,7 @@ PASS Local media stream autoplay PASS Remote media stream autoplay PASS Granting getUserMedia should not start paused media 1 -PASS Granting getUserMedia should not start paused media 2 +FAIL Granting getUserMedia should not start paused media 2 assert_true: out of DOM video expected true got false PASS Granting getUserMedia should not start paused media 3 PASS Granting getUserMedia should not start paused media or media that cannot autoplay due to autoplay restrictions 1603838 1 webkit-bug-importer 2020-01-07 15:42:24 -0800 <rdar://problem/58391046> 1604541 2 youennf 2020-01-09 00:23:59 -0800 Unable to repro locally. One possibility is that the removal of the video from the DOM is triggering pausing asynchronously, or is not always updating paused. I'll update the test to wait for video2 to be paused before calling getUserMedia. 1604543 3 387198 youennf 2020-01-09 00:35:08 -0800 Created attachment 387198 Patch 1604613 4 387198 eric.carlson 2020-01-09 07:22:30 -0800 Comment on attachment 387198 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387198&action=review > LayoutTests/ChangeLog:11 > + Hypothesis is that removing from DOM the video element is supposed to pause asynchronously the video element. s/removing from DOM the video element is supposed to pause asynchronously/removing the video element from the DOM is supposed to asynchronously pause/ 1604630 5 387230 youennf 2020-01-09 08:04:32 -0800 Created attachment 387230 Patch for landing 1604637 6 387230 commit-queue 2020-01-09 08:23:01 -0800 Comment on attachment 387230 Patch for landing Clearing flags on attachment: 387230 Committed r254260: <https://trac.webkit.org/changeset/254260> 1604638 7 commit-queue 2020-01-09 08:23:02 -0800 All reviewed patches have been landed. Closing bug. 387198 2020-01-09 00:35:08 -0800 2020-01-09 08:04:28 -0800 Patch bug-205893-20200109093507.patch text/plain 1977 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjUyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTkwMGIzYWE3ODlmNDY5MDQ2MTY5 OTE3OTE3ZjY5ZWFlMDcyOTU4MS4uNDE4ZTNmNGI2YzIyYTIxNWU4MTI4NmU4ZjgzODNkMDJiN2I0 MzQwZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTA5ICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBbIE1hYyBdIHdlYnJ0Yy92 aWRlby1hdXRvcGxheS5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1ODkzCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS81ODM5MTA0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHdlYnJ0Yy92aWRlby1hdXRvcGxheS5odG1sOgorICAgICAgICBTcGVjdWxhdGl2 ZSBmaXggYXMgSSBhbSBub3QgYWJsZSB0byByZXByb2R1Y2UgbG9jYWxseS4KKyAgICAgICAgSHlw b3RoZXNpcyBpcyB0aGF0IHJlbW92aW5nIGZyb20gRE9NIHRoZSB2aWRlbyBlbGVtZW50IGlzIHN1 cHBvc2VkIHRvIHBhdXNlIGFzeW5jaHJvbm91c2x5IHRoZSB2aWRlbyBlbGVtZW50LgorICAgICAg ICBXZSBzaG91bGQgdGhlcmVmb3JlIGVuc3VyZSB0aGF0IHRoZSB2aWRlbyBlbGVtZW50IGlzIHBh dXNlZCBiZWZvcmUgY2FsbGluZyBnZXRVc2VyTWVkaWEuCisKIDIwMjAtMDEtMDggIEtlaXRoIE1p bGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gSW50cm9kdWNl IEpTQXJyYXlJdGVyYXRvcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2VicnRjL3ZpZGVvLWF1 dG9wbGF5Lmh0bWwgYi9MYXlvdXRUZXN0cy93ZWJydGMvdmlkZW8tYXV0b3BsYXkuaHRtbAppbmRl eCBlZmE0OTU2ZTQ1ZTAyNmRkODU3ZGZiZmY3NTI2MDUxYmI4NTY0ODgyLi5hNTc2ZmUyNDZlYmQ3 MDNkZTJiODc0Y2M0NTQyZTA2Y2JjOTExYTc2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy93ZWJy dGMvdmlkZW8tYXV0b3BsYXkuaHRtbAorKysgYi9MYXlvdXRUZXN0cy93ZWJydGMvdmlkZW8tYXV0 b3BsYXkuaHRtbApAQCAtMTAyLDEyICsxMDIsMTcgQEAgcHJvbWlzZV90ZXN0KGFzeW5jICh0ZXN0 KSA9PiB7CiAgICAgbGV0IHJlbW92ZWRWaWRlbzIgPSB2aWRlbzI7CiAgICAgcmVtb3ZlZFZpZGVv Mi5yZW1vdmUoKTsKIAorICAgIGxldCBjcHRyID0gMDsKKyAgICB3aGlsZSAoKytjcHRyIDwgMjAg JiYgIXJlbW92ZWRWaWRlbzIucGF1c2VkKQorICAgICAgICBhd2FpdCBuZXcgUHJvbWlzZShyZXNv bHZlID0+IHNldFRpbWVvdXQocmVzb2x2ZSwgNTApKTsKKyAgICBhc3NlcnRfdHJ1ZShyZW1vdmVk VmlkZW8yLnBhdXNlZCwgIm91dCBvZiBET00gdmlkZW8gc2hvdWxkIGdldCBwYXVzZWQiKTsKKwog ICAgIHZpZGVvNC5zcmNPYmplY3QgPSBhd2FpdCBuYXZpZ2F0b3IubWVkaWFEZXZpY2VzLmdldFVz ZXJNZWRpYSh7IHZpZGVvIDogdHJ1ZSB9KTsKIAogICAgIHdoaWxlICh2aWRlbzQucGF1c2VkKQog ICAgICAgICBhd2FpdCBuZXcgUHJvbWlzZShyZXNvbHZlID0+IHNldFRpbWVvdXQocmVzb2x2ZSwg NTApKTsKIAotICAgIGFzc2VydF90cnVlKHJlbW92ZWRWaWRlbzIucGF1c2VkLCAib3V0IG9mIERP TSB2aWRlbyIpOworICAgIGFzc2VydF90cnVlKHJlbW92ZWRWaWRlbzIucGF1c2VkLCAib3V0IG9m IERPTSB2aWRlbyBzaG91bGQgbm90IHJlc3RhcnQgYWZ0ZXIgZ2V0VXNlck1lZGlhIGNhbGwiKTsK IH0sICJHcmFudGluZyBnZXRVc2VyTWVkaWEgc2hvdWxkIG5vdCBzdGFydCBwYXVzZWQgbWVkaWEg MiIpOwogCiBwcm9taXNlX3Rlc3QoYXN5bmMgKHRlc3QpID0+IHsK 387230 2020-01-09 08:04:32 -0800 2020-01-09 08:23:01 -0800 Patch for landing bug-205893-20200109170431.patch text/plain 2036 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjUzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTcyZWMzYjYwNTA4MDE3ODIwMWQw NGMyZDhkZDk1ZTVjZGM1MDQxNi4uMTg0MjExYjEyNGJmYzc0Zjc3ZTk2ODg1MTAzNWQ1NDFmN2I3 M2M1NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTA5ICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBbIE1hYyBdIHdlYnJ0Yy92 aWRlby1hdXRvcGxheS5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1ODkzCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS81ODM5MTA0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCisKKyAg ICAgICAgKiB3ZWJydGMvdmlkZW8tYXV0b3BsYXkuaHRtbDoKKyAgICAgICAgU3BlY3VsYXRpdmUg Zml4IGFzIEkgYW0gbm90IGFibGUgdG8gcmVwcm9kdWNlIGxvY2FsbHkuCisgICAgICAgIEh5cG90 aGVzaXMgaXMgdGhhdCByZW1vdmluZyBmcm9tIERPTSB0aGUgdmlkZW8gZWxlbWVudCBpcyBzdXBw b3NlZCB0byBhc3luY2hyb25vdXNseSBwYXVzZSB0aGUgdmlkZW8gZWxlbWVudC4KKyAgICAgICAg V2Ugc2hvdWxkIHRoZXJlZm9yZSBlbnN1cmUgdGhhdCB0aGUgdmlkZW8gZWxlbWVudCBpcyBwYXVz ZWQgYmVmb3JlIGNhbGxpbmcgZ2V0VXNlck1lZGlhLgorCiAyMDIwLTAxLTA5ICB5b3Vlbm4gZmFi bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OOiBbIE1hYyB3azIg XSBodHRwL3dwdC9zZXJ2aWNlLXdvcmtlcnMvcGVyc2lzdGVudC1pbXBvcnRTY3JpcHRzLmh0bWwg aXMgYSBmbGFreSBmYWlsdXJlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJydGMvdmlkZW8t YXV0b3BsYXkuaHRtbCBiL0xheW91dFRlc3RzL3dlYnJ0Yy92aWRlby1hdXRvcGxheS5odG1sCmlu ZGV4IGVmYTQ5NTZlNDVlMDI2ZGQ4NTdkZmJmZjc1MjYwNTFiYjg1NjQ4ODIuLmE1NzZmZTI0NmVi ZDcwM2RlMmI4NzRjYzQ1NDJlMDZjYmM5MTFhNzYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dl YnJ0Yy92aWRlby1hdXRvcGxheS5odG1sCisrKyBiL0xheW91dFRlc3RzL3dlYnJ0Yy92aWRlby1h dXRvcGxheS5odG1sCkBAIC0xMDIsMTIgKzEwMiwxNyBAQCBwcm9taXNlX3Rlc3QoYXN5bmMgKHRl c3QpID0+IHsKICAgICBsZXQgcmVtb3ZlZFZpZGVvMiA9IHZpZGVvMjsKICAgICByZW1vdmVkVmlk ZW8yLnJlbW92ZSgpOwogCisgICAgbGV0IGNwdHIgPSAwOworICAgIHdoaWxlICgrK2NwdHIgPCAy MCAmJiAhcmVtb3ZlZFZpZGVvMi5wYXVzZWQpCisgICAgICAgIGF3YWl0IG5ldyBQcm9taXNlKHJl c29sdmUgPT4gc2V0VGltZW91dChyZXNvbHZlLCA1MCkpOworICAgIGFzc2VydF90cnVlKHJlbW92 ZWRWaWRlbzIucGF1c2VkLCAib3V0IG9mIERPTSB2aWRlbyBzaG91bGQgZ2V0IHBhdXNlZCIpOwor CiAgICAgdmlkZW80LnNyY09iamVjdCA9IGF3YWl0IG5hdmlnYXRvci5tZWRpYURldmljZXMuZ2V0 VXNlck1lZGlhKHsgdmlkZW8gOiB0cnVlIH0pOwogCiAgICAgd2hpbGUgKHZpZGVvNC5wYXVzZWQp CiAgICAgICAgIGF3YWl0IG5ldyBQcm9taXNlKHJlc29sdmUgPT4gc2V0VGltZW91dChyZXNvbHZl LCA1MCkpOwogCi0gICAgYXNzZXJ0X3RydWUocmVtb3ZlZFZpZGVvMi5wYXVzZWQsICJvdXQgb2Yg RE9NIHZpZGVvIik7CisgICAgYXNzZXJ0X3RydWUocmVtb3ZlZFZpZGVvMi5wYXVzZWQsICJvdXQg b2YgRE9NIHZpZGVvIHNob3VsZCBub3QgcmVzdGFydCBhZnRlciBnZXRVc2VyTWVkaWEgY2FsbCIp OwogfSwgIkdyYW50aW5nIGdldFVzZXJNZWRpYSBzaG91bGQgbm90IHN0YXJ0IHBhdXNlZCBtZWRp YSAyIik7CiAKIHByb21pc2VfdGVzdChhc3luYyAodGVzdCkgPT4gewo=