205880 2020-01-07 12:14:43 -0800 [JSC] Remove vm accessor in JSVirtualMachine to reduce binary size 2020-01-07 13:14:19 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 205877 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1603715 0 ysuzuki 2020-01-07 12:14:43 -0800 ... 1603725 1 ysuzuki 2020-01-07 12:22:59 -0800 Let's do it right now since it is the largest. 1603729 2 387019 ysuzuki 2020-01-07 12:30:58 -0800 Created attachment 387019 Patch 1603731 3 387019 ysuzuki 2020-01-07 12:32:30 -0800 Comment on attachment 387019 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387019&action=review > Source/JavaScriptCore/API/JSVirtualMachine.mm:301 > +- (JSContextGroupRef)JSContextGroupRef This style is following `JSContext JSContextRef` accessor. 1603733 4 387019 mark.lam 2020-01-07 12:35:28 -0800 Comment on attachment 387019 Patch Nice. r=me if bots are green. Please also run testapi locally to make sure there are no bad surprises (not expecting any). 1603751 5 ysuzuki 2020-01-07 13:10:47 -0800 (In reply to Mark Lam from comment #4) > Comment on attachment 387019 [details] > Patch > > Nice. r=me if bots are green. Please also run testapi locally to make sure > there are no bad surprises (not expecting any). OK, ensured locally. 1603754 6 ysuzuki 2020-01-07 13:13:29 -0800 Committed r254152: <https://trac.webkit.org/changeset/254152> 1603755 7 webkit-bug-importer 2020-01-07 13:14:19 -0800 <rdar://problem/58385111> 387019 2020-01-07 12:30:58 -0800 2020-01-07 12:35:28 -0800 Patch bug-205880-20200107123058.patch text/plain 5596 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZDQ1ZmQ5MWFhYjMyZjVkMzJlYzgxMDg3MTk1MGZjZWJlMmUxNGRjLi4yYWFiODA3M2MxZGVkZmVh MzMyYzE4OTBiM2U2YmRjZmQ2YzdkZWRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMyBAQAorMjAyMC0wMS0wNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFJlbW92ZSB2bSBhY2Nlc3NvciBpbiBKU1ZpcnR1YWxNYWNoaW5l IHRvIHJlZHVjZSBiaW5hcnkgc2l6ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA1ODgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgT2JqZWN0aXZlLUMgaGFzIHJlZmxlY3Rpb24gbWVjaGFuaXNtLiBUaGlz IG1lYW5zIHRoYXQgZmllbGRzLCBtZXRob2RzLCBhbmQgdGhlaXIgdHlwZXMKKyAgICAgICAgbmVl ZCB0byBob2xkIGl0cyBzdHJpbmcgcmVwcmVzZW50YXRpb25zIGluIGJpbmFyeSBldmVuIGlmIHdl IGFyZSB1c2luZyByZWxlYXNlIGJ1aWxkLgorICAgICAgICBXaGlsZSB0eXBpY2FsIE9iamVjdGl2 ZS1DIGNsYXNzIGRvZXMgbm90IGhhdmUgbGFyZ2Ugc2l6ZSBvZiB0eXBlIG5hbWVzLCBDKysgc3Ry dWN0IC8gY2xhc3MKKyAgICAgICAgaGFzIHZlcnkgbGFyZ2Ugb25lLCBhbmQgcHV0dGluZyB0aGVt IGluIE9iamVjdGl2ZS1DIG1ldGhvZCBuYW1lcywgcGFyYW1ldGVyIHR5cGVzLCBvciBmaWVsZHMK KyAgICAgICAgbWFrZXMgYmluYXJ5IHNpemUgdmVyeSBsYXJnZS4KKworICAgICAgICBCeSBhbmFs eXppbmcgSmF2YVNjcmlwdENvcmUgYmluYXJ5LCBJIGZvdW5kIHRoYXQgT2JqZWN0aXZlLUMgbWV0 aG9kIHR5cGUgc3ltYm9scyBhcmUgdGFraW5nIDIwMH5LQgorICAgICAgICBiaW5hcnkgc2l6ZS4g KFNlY3Rpb24gX19vYmpjX21ldGh0eXBlOiAyMzUwODEgKGFkZHIgMHgxMDVlOWEzIG9mZnNldCAx NzE2NDcwNykpLiBBbmQgaXQgaXMgZHVlIHRvCisgICAgICAgIEpTQzo6Vk0gdHlwZSBpbmNsdWRl ZCBpbiBgW0pTVmlydHVhbE1hY2hpbmUgdm1dYCBhY2Nlc3Nvci4KKworICAgICAgICBUaGlzIHBh dGNoIHJlbW92ZXMgdGhpcyBhY2Nlc3NvciBhbmQgZ2V0cyAyMDBLQiBiaW5hcnkgc2l6ZSByZWR1 Y3Rpb24uCisKKyAgICAgICAgKiBBUEkvSlNTY3JpcHQubW06CisgICAgICAgICgtW0pTU2NyaXB0 IHJlYWRDYWNoZV0pOgorICAgICAgICAoLVtKU1NjcmlwdCBzb3VyY2VDb2RlXSk6CisgICAgICAg ICgtW0pTU2NyaXB0IGpzU291cmNlQ29kZV0pOgorICAgICAgICAoLVtKU1NjcmlwdCB3cml0ZUNh Y2hlOl0pOgorICAgICAgICAqIEFQSS9KU1ZpcnR1YWxNYWNoaW5lLm1tOgorICAgICAgICAoLVtK U1ZpcnR1YWxNYWNoaW5lIEpTQ29udGV4dEdyb3VwUmVmXSk6CisgICAgICAgICgtW0pTVmlydHVh bE1hY2hpbmUgaXNXZWJUaHJlYWRBd2FyZV0pOgorICAgICAgICAoLVtKU1ZpcnR1YWxNYWNoaW5l IHZtXSk6IERlbGV0ZWQuCisgICAgICAgICogQVBJL0pTVmlydHVhbE1hY2hpbmVJbnRlcm5hbC5o OgorCiAyMDIwLTAxLTA3ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAK ICAgICAgICAgQVg6IEVuYWJsZSBBQ0NFU1NJQklMSVRZX0lTT0xBVEVEX1RSRUUKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNTY3JpcHQubW0gYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQVBJL0pTU2NyaXB0Lm1tCmluZGV4IDNjYzA0MTIxYTRhOWMzMmI5YTMxYTBiMWZk MmU1MmNmNzM3YzRiZTkuLmRjMTFjMmZiY2MwODA0ZjljOWM0ZTE5Mzg2M2Q3NTk1ZGQzMjkyOGEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNTY3JpcHQubW0KKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1NjcmlwdC5tbQpAQCAtMTY3LDcgKzE2Nyw3IEBA IC0gKHZvaWQpcmVhZENhY2hlCiAKICAgICBSZWY8SlNDOjpDYWNoZWRCeXRlY29kZT4gY2FjaGVk Qnl0ZWNvZGUgPSBKU0M6OkNhY2hlZEJ5dGVjb2RlOjpjcmVhdGUoV1RGTW92ZShtYXBwZWRGaWxl KSk7CiAKLSAgICBKU0M6OlZNJiB2bSA9IFttX3ZpcnR1YWxNYWNoaW5lIHZtXTsKKyAgICBKU0M6 OlZNJiB2bSA9ICp0b0pTKFttX3ZpcnR1YWxNYWNoaW5lIEpTQ29udGV4dEdyb3VwUmVmXSk7CiAg ICAgSlNDOjpTb3VyY2VDb2RlIHNvdXJjZUNvZGUgPSBbc2VsZiBzb3VyY2VDb2RlXTsKICAgICBK U0M6OlNvdXJjZUNvZGVLZXkga2V5ID0gbV90eXBlID09IGtKU1NjcmlwdFR5cGVQcm9ncmFtID8g c291cmNlQ29kZUtleUZvclNlcmlhbGl6ZWRQcm9ncmFtKHZtLCBzb3VyY2VDb2RlKSA6IHNvdXJj ZUNvZGVLZXlGb3JTZXJpYWxpemVkTW9kdWxlKHZtLCBzb3VyY2VDb2RlKTsKICAgICBpZiAoaXND YWNoZWRCeXRlY29kZVN0aWxsVmFsaWQodm0sIGNhY2hlZEJ5dGVjb2RlLmNvcHlSZWYoKSwga2V5 LCBtX3R5cGUgPT0ga0pTU2NyaXB0VHlwZVByb2dyYW0gPyBKU0M6OlNvdXJjZUNvZGVUeXBlOjpQ cm9ncmFtVHlwZSA6IEpTQzo6U291cmNlQ29kZVR5cGU6Ok1vZHVsZVR5cGUpKQpAQCAtMjM1LDcg KzIzNSw3IEBAIC0gKFJlZlB0cjxKU0M6OkNhY2hlZEJ5dGVjb2RlPiljYWNoZWRCeXRlY29kZQog CiAtIChKU0M6OlNvdXJjZUNvZGUpc291cmNlQ29kZQogewotICAgIEpTQzo6Vk0mIHZtID0gW21f dmlydHVhbE1hY2hpbmUgdm1dOworICAgIEpTQzo6Vk0mIHZtID0gKnRvSlMoW21fdmlydHVhbE1h Y2hpbmUgSlNDb250ZXh0R3JvdXBSZWZdKTsKICAgICBKU0M6OkpTTG9ja0hvbGRlciBsb2NrZXIo dm0pOwogCiAgICAgVGV4dFBvc2l0aW9uIHN0YXJ0UG9zaXRpb24geyB9OwpAQCAtMjQ4LDcgKzI0 OCw3IEBAIC0gKEpTQzo6U291cmNlQ29kZSlzb3VyY2VDb2RlCiAKIC0gKEpTQzo6SlNTb3VyY2VD b2RlKilqc1NvdXJjZUNvZGUKIHsKLSAgICBKU0M6OlZNJiB2bSA9IFttX3ZpcnR1YWxNYWNoaW5l IHZtXTsKKyAgICBKU0M6OlZNJiB2bSA9ICp0b0pTKFttX3ZpcnR1YWxNYWNoaW5lIEpTQ29udGV4 dEdyb3VwUmVmXSk7CiAgICAgSlNDOjpKU0xvY2tIb2xkZXIgbG9ja2VyKHZtKTsKICAgICBKU0M6 OkpTU291cmNlQ29kZSoganNTb3VyY2VDb2RlID0gSlNDOjpKU1NvdXJjZUNvZGU6OmNyZWF0ZSh2 bSwgW3NlbGYgc291cmNlQ29kZV0pOwogICAgIHJldHVybiBqc1NvdXJjZUNvZGU7CkBAIC0yNzcs MTIgKzI3NywxMyBAQCAtIChCT09MKXdyaXRlQ2FjaGU6KFN0cmluZyYpZXJyb3IKIAogICAgIEpT Qzo6Qnl0ZWNvZGVDYWNoZUVycm9yIGNhY2hlRXJyb3I7CiAgICAgSlNDOjpTb3VyY2VDb2RlIHNv dXJjZUNvZGUgPSBbc2VsZiBzb3VyY2VDb2RlXTsKKyAgICBKU0M6OlZNJiB2bSA9ICp0b0pTKFtt X3ZpcnR1YWxNYWNoaW5lIEpTQ29udGV4dEdyb3VwUmVmXSk7CiAgICAgc3dpdGNoIChtX3R5cGUp IHsKICAgICBjYXNlIGtKU1NjcmlwdFR5cGVNb2R1bGU6Ci0gICAgICAgIG1fY2FjaGVkQnl0ZWNv ZGUgPSBKU0M6OmdlbmVyYXRlTW9kdWxlQnl0ZWNvZGUoW21fdmlydHVhbE1hY2hpbmUgdm1dLCBz b3VyY2VDb2RlLCBmZCwgY2FjaGVFcnJvcik7CisgICAgICAgIG1fY2FjaGVkQnl0ZWNvZGUgPSBK U0M6OmdlbmVyYXRlTW9kdWxlQnl0ZWNvZGUodm0sIHNvdXJjZUNvZGUsIGZkLCBjYWNoZUVycm9y KTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBrSlNTY3JpcHRUeXBlUHJvZ3JhbToKLSAgICAg ICAgbV9jYWNoZWRCeXRlY29kZSA9IEpTQzo6Z2VuZXJhdGVQcm9ncmFtQnl0ZWNvZGUoW21fdmly dHVhbE1hY2hpbmUgdm1dLCBzb3VyY2VDb2RlLCBmZCwgY2FjaGVFcnJvcik7CisgICAgICAgIG1f Y2FjaGVkQnl0ZWNvZGUgPSBKU0M6OmdlbmVyYXRlUHJvZ3JhbUJ5dGVjb2RlKHZtLCBzb3VyY2VD b2RlLCBmZCwgY2FjaGVFcnJvcik7CiAgICAgICAgIGJyZWFrOwogICAgIH0KIApkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZpcnR1YWxNYWNoaW5lLm1tIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZpcnR1YWxNYWNoaW5lLm1tCmluZGV4IGI5YWQyZjYyOTUy N2U2MTliZmQ3N2QwMTVhMjU4MjAyZDNlMGIyN2YuLjBkMDA4MjkwOTZlMWY5YTM1MzQ2ZDA2NTQw ODRkYzI0ZjlkOTk1NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNW aXJ0dWFsTWFjaGluZS5tbQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmlydHVh bE1hY2hpbmUubW0KQEAgLTI5OCwxNCArMjk4LDE1IEBAICsgKE5TVUludGVnZXIpc2V0TnVtYmVy T2ZGVExDb21waWxlclRocmVhZHM6KE5TVUludGVnZXIpbnVtYmVyT2ZUaHJlYWRzCiAKICNlbmRp ZiAvLyBFTkFCTEUoREZHX0pJVCkKIAotLSAoSlNDOjpWTSYpdm0KKy0gKEpTQ29udGV4dEdyb3Vw UmVmKUpTQ29udGV4dEdyb3VwUmVmCiB7Ci0gICAgcmV0dXJuICp0b0pTKG1fZ3JvdXApOworICAg IHJldHVybiBtX2dyb3VwOwogfQogCiAtIChCT09MKWlzV2ViVGhyZWFkQXdhcmUKIHsKLSAgICBy ZXR1cm4gW3NlbGYgdm1dLmFwaUxvY2soKS5pc1dlYlRocmVhZEF3YXJlKCk7CisgICAgSlNDOjpW TSogdm0gPSB0b0pTKG1fZ3JvdXApOworICAgIHJldHVybiB2bS0+YXBpTG9jaygpLmlzV2ViVGhy ZWFkQXdhcmUoKTsKIH0KIAogKyAodm9pZClzZXRDcmFzaE9uVk1DcmVhdGlvbjooQk9PTClzaG91 bGRDcmFzaApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZpcnR1YWxN YWNoaW5lSW50ZXJuYWwuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNWaXJ0dWFsTWFj aGluZUludGVybmFsLmgKaW5kZXggYjUzMzQ4MmFjOWYyZmJmNzcwMjM1ZDhjY2ZkMzYzZWRjNDk1 ZjYwMS4uYWRiMGEzN2RhZTE3YjJiOWUxMTQzZjFiNjdiOTdmOTkyODcxOTk3MyAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZpcnR1YWxNYWNoaW5lSW50ZXJuYWwuaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmVJbnRlcm5hbC5o CkBAIC00NiwxMCArNDYsMTAgQEAgSlNDb250ZXh0R3JvdXBSZWYgZ2V0R3JvdXBGcm9tVmlydHVh bE1hY2hpbmUoSlNWaXJ0dWFsTWFjaGluZSAqKTsKIAogLSAoSlNDb250ZXh0ICopY29udGV4dEZv ckdsb2JhbENvbnRleHRSZWY6KEpTR2xvYmFsQ29udGV4dFJlZilnbG9iYWxDb250ZXh0OwogLSAo dm9pZClhZGRDb250ZXh0OihKU0NvbnRleHQgKil3cmFwcGVyIGZvckdsb2JhbENvbnRleHRSZWY6 KEpTR2xvYmFsQ29udGV4dFJlZilnbG9iYWxDb250ZXh0OwotLSAoSlNDOjpWTSYpdm07Ci0KIC0g KEJPT0wpaXNXZWJUaHJlYWRBd2FyZTsKIAorQHByb3BlcnR5IChyZWFkb25seSkgSlNDb250ZXh0 R3JvdXBSZWYgSlNDb250ZXh0R3JvdXBSZWY7CisKIEBlbmQKIAogI2VuZGlmIC8vIGRlZmluZWQo X19PQkpDX18pCg==