205871 2020-01-07 10:53:00 -0800 Bytecode checkpoint fixes for arm64(e) 2020-01-07 11:59:30 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1603654 0 keith_miller 2020-01-07 10:53:00 -0800 Bytecode checkpoint fixes for arm64(e) 1603659 1 386998 keith_miller 2020-01-07 10:57:34 -0800 Created attachment 386998 Patch 1603660 2 386998 msaboff 2020-01-07 11:01:16 -0800 Comment on attachment 386998 Patch r=me 1603661 3 keith_miller 2020-01-07 11:02:15 -0800 rdar://problem/58310178 1603662 4 386998 saam 2020-01-07 11:03:06 -0800 Comment on attachment 386998 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386998&action=review > Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:150 > + return LLInt::getCodePtr<NoPtrTag>(checkpoint_osr_exit_from_inlined_call_trampoline).executableAddress(); why not make this function return a typed value instead of void*, and then caller's can unbox as needed? 1603663 5 saam 2020-01-07 11:03:18 -0800 r=me too 1603691 6 386998 keith_miller 2020-01-07 11:42:04 -0800 Comment on attachment 386998 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386998&action=review >> Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:150 >> + return LLInt::getCodePtr<NoPtrTag>(checkpoint_osr_exit_from_inlined_call_trampoline).executableAddress(); > > why not make this function return a typed value instead of void*, and then caller's can unbox as needed? Done, I went with MacroAssemblerCodePtr<JSEntryPtrTag> as the type. 1603693 7 keith_miller 2020-01-07 11:44:06 -0800 Committed r254142: <https://trac.webkit.org/changeset/254142> 1603700 8 keith_miller 2020-01-07 11:59:30 -0800 Non-arm64e build fix in: https://trac.webkit.org/changeset/254143. 386998 2020-01-07 10:57:34 -0800 2020-01-07 11:01:16 -0800 Patch bug-205871-20200107105733.patch text/plain 4104 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZDQ1ZmQ5MWFhYjMyZjVkMzJlYzgxMDg3MTk1MGZjZWJlMmUxNGRjLi5lMmQ2NWU4MmY4YjJlMzFk M2YxZDMwZGFmNDMwZTI4NTgyNTBhOThlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAyMC0wMS0wNyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBCeXRlY29kZSBjaGVja3BvaW50IGZpeGVzIGZvciBhcm02NChlKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1ODcxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG9yaWdp bmFsIGJ5dGVjb2RlIGNoZWNrcG9pbnQgcGF0Y2ggaGFkIGEgY291cGxlIG9mIGJ1Z3Mgb24KKyAg ICAgICAgYXJtNjQoZSkuIEZvciBhcm02NCBnZW5lcmFsbHksIHdoZW4gb3NyIGV4aXRpbmcgdG8g YW4gaW5saW5lCisgICAgICAgIHZhcmFyZ3MgZnJhbWUgd2UgZGlkbid0IHNldCB0aGUgcmV0dXJu IHZhbHVlIG9mIGNhbGxlZSBiZWZvcmUKKyAgICAgICAgbW92aW5nIHRoZSBjYWxsIGZyYW1lIHJl Z2lzdGVyIGludG8gYTAgZm9yIHRoZSBzbG93IHBhdGgKKyAgICAgICAgY2FsbC4gVGhpcyBtZWFu dCB3ZSBjbG9iYmVyIHRoZSByZXR1cm4gdmFsdWUgb24gYXJtNjQgYXMgYTAgPT0gcjAuCisKKyAg ICAgICAgT24gYXJtNjRlIHRoZSBvc3IgZXhpdCBjb21waWxlciBzZXQgdGhlIHRhZyBmb3IgdGhl IHJldHVybiBwYyBmb3IKKyAgICAgICAgYW4gaW5saW5lIGZyYW1lIHRvIEpTRW50cnlUYWcgYnV0 IHRoZSBjb2RlIGV4cGVjdGVkCisgICAgICAgIE5vVGFnLiBBZGRpdGlvbmFsbHksIGluIHRoZSBz dGFjayB1bndpbmRlciwgd2Ugd2VyZSB1c2luZyB0aGUKKyAgICAgICAgSlNFbnRyeVRhZyBidXQg d2Ugc2hvdWxkIGhhdmUgYmVlbiBzdHJpcHBpbmcgdGhlIHRhZyBmcm9tIHRoZQorICAgICAgICBz dGFjayB2YWx1ZS4KKworICAgICAgICAqIGRmZy9ERkdPU1JFeGl0Q29tcGlsZXJDb21tb24uY3Bw OgorICAgICAgICAoSlNDOjpERkc6OmNhbGxlclJldHVyblBDKToKKyAgICAgICAgKiBpbnRlcnBy ZXRlci9JbnRlcnByZXRlci5jcHA6CisgICAgICAgIChKU0M6OlVud2luZEZ1bmN0b3I6Om9wZXJh dG9yKCkgY29uc3QpOgorICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtOgor CiAyMDIwLTAxLTA3ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAg ICAgICAgQVg6IEVuYWJsZSBBQ0NFU1NJQklMSVRZX0lTT0xBVEVEX1RSRUUKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdENvbXBpbGVyQ29tbW9uLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdENvbXBpbGVyQ29tbW9uLmNwcApp bmRleCA3OTVlOGRkMTdhNTQ0YTQ3MTdlZjNhZWQ3NTkwYzVlZjM0ZmEwZWRmLi4zNWE0NWE0NGZm OTM1MzlkZWE1ZDQ4Y2MzMDk4YmM0ZTMyNDhmYjA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR09TUkV4aXRDb21waWxlckNvbW1vbi5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0Q29tcGlsZXJDb21tb24uY3BwCkBAIC0xNDcsNyAr MTQ3LDcgQEAgdm9pZCogY2FsbGVyUmV0dXJuUEMoQ29kZUJsb2NrKiBiYXNlbGluZUNvZGVCbG9j a0ZvckNhbGxlciwgQnl0ZWNvZGVJbmRleCBjYWxsQnkKICAgICBjYWxsZXJJc0xMSW50ID0gT3B0 aW9uczo6Zm9yY2VPU1JFeGl0VG9MTEludCgpIHx8IGJhc2VsaW5lQ29kZUJsb2NrRm9yQ2FsbGVy LT5qaXRUeXBlKCkgPT0gSklUVHlwZTo6SW50ZXJwcmV0ZXJUaHVuazsKIAogICAgIGlmIChjYWxs Qnl0ZWNvZGVJbmRleC5jaGVja3BvaW50KCkpCi0gICAgICAgIHJldHVybiBMTEludDo6Z2V0Q29k ZVB0cjxKU0VudHJ5UHRyVGFnPihjaGVja3BvaW50X29zcl9leGl0X2Zyb21faW5saW5lZF9jYWxs X3RyYW1wb2xpbmUpLmV4ZWN1dGFibGVBZGRyZXNzKCk7CisgICAgICAgIHJldHVybiBMTEludDo6 Z2V0Q29kZVB0cjxOb1B0clRhZz4oY2hlY2twb2ludF9vc3JfZXhpdF9mcm9tX2lubGluZWRfY2Fs bF90cmFtcG9saW5lKS5leGVjdXRhYmxlQWRkcmVzcygpOwogCiAgICAgdm9pZCoganVtcFRhcmdl dDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVy cHJldGVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRl ci5jcHAKaW5kZXggZTdlMGU0NDVkMDk4OTU2ZTMwZTQyYzk1NDI5ZTNiOTRhYjE2NzBiNy4uYzFj ODdmODYyNWRhMDM4NTBjMGU0NTYxNWNjZDg5MWMxNGM3OTJlMyAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCkBAIC01NDQsNyArNTQ0 LDcgQEAgcHVibGljOgogICAgICAgICBpZiAobV9jb2RlQmxvY2spIHsKICAgICAgICAgICAgIC8v IEZJWE1FOiBXZSBzaG91bGQgc3VwcG9ydCBleGNlcHRpb24gaGFuZGxpbmcgaW4gY2hlY2twb2lu dHMuCiAjaWYgRU5BQkxFKERGR19KSVQpCi0gICAgICAgICAgICBpZiAobV9yZXR1cm5QQyA9PSBM TEludDo6Z2V0Q29kZVB0cjxKU0VudHJ5UHRyVGFnPihjaGVja3BvaW50X29zcl9leGl0X2Zyb21f aW5saW5lZF9jYWxsX3RyYW1wb2xpbmUpLmV4ZWN1dGFibGVBZGRyZXNzKCkpCisgICAgICAgICAg ICBpZiAocmVtb3ZlQ29kZVB0clRhZyhtX3JldHVyblBDKSA9PSBMTEludDo6Z2V0Q29kZVB0cjxO b1B0clRhZz4oY2hlY2twb2ludF9vc3JfZXhpdF9mcm9tX2lubGluZWRfY2FsbF90cmFtcG9saW5l KS5leGVjdXRhYmxlQWRkcmVzcygpKQogICAgICAgICAgICAgICAgIG1fY29kZUJsb2NrLT52bSgp LmZpbmRDaGVja3BvaW50T1NSU2lkZVN0YXRlKG1fY2FsbEZyYW1lKTsKICNlbmRpZgogICAgICAg ICAgICAgaWYgKCFtX2lzVGVybWluYXRpb24pIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbSBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQppbmRleCBlYWU1MzdjNjc1MzNiNzMz MjA3MDM3M2M2YmU0ZDZjMTlkNWZlZDdhLi44YWZlYWIxMzkyNjA5ZmIxODgxY2JiZDRiNzhkYzM3 NDhiZTM0OGNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2 ZWxJbnRlcnByZXRlci5hc20KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXIuYXNtCkBAIC0yMDE5LDggKzIwMTksOSBAQCBvcChjaGVja3BvaW50X29z cl9leGl0X2Zyb21faW5saW5lZF9jYWxsX3RyYW1wb2xpbmUsIG1hY3JvICgpCiAgICAgaWYgSlNW QUxVRTY0IGFuZCBub3QgKENfTE9PUCBvciBDX0xPT1BfV0lOKQogICAgICAgICByZXN0b3JlU3Rh Y2tQb2ludGVyQWZ0ZXJDYWxsKCkKIAotICAgICAgICBtb3ZlIGNmciwgYTAKKyAgICAgICAgIyBN YWtlIHN1cmUgd2UgbW92ZSByMCB0byBhMSBmaXJzdCBzaW5jZSByMCBtaWdodCBiZSB0aGUgc2Ft ZSBhcyBhMCwgZm9yIGluc3RhbmNlIG9uIGFybS4KICAgICAgICAgbW92ZSByMCwgYTEKKyAgICAg ICAgbW92ZSBjZnIsIGEwCiAgICAgICAgICMgV2UgZG9uJ3QgY2FsbCBzYXZlU3RhdGVGb3JDQ2Fs bCgpIGJlY2F1c2Ugd2UgYXJlIGdvaW5nIHRvIHVzZSB0aGUgYnl0ZWNvZGVJbmRleCBmcm9tIG91 ciBzaWRlIHN0YXRlLgogICAgICAgICBjQ2FsbDIoX3Nsb3dfcGF0aF9jaGVja3BvaW50X29zcl9l eGl0X2Zyb21faW5saW5lZF9jYWxsKQogICAgICAgICByZXN0b3JlU3RhdGVBZnRlckNDYWxsKCkK