205849 2020-01-07 01:16:16 -0800 Improve logging of creating a service worker 2020-01-08 02:30:14 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf cdumez commit-queue webkit-bug-importer oldest_to_newest 1603485 0 youennf 2020-01-07 01:16:16 -0800 Improve logging of creating a service worker 1603487 1 386949 youennf 2020-01-07 01:17:41 -0800 Created attachment 386949 Patch 1603562 2 386949 cdumez 2020-01-07 07:53:24 -0800 Comment on attachment 386949 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386949&action=review > Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:158 > + RELEASE_LOG(ServiceWorker, "Created service worker %s in process PID %i", data.serviceWorkerIdentifier.loggingString().utf8().data(), getCurrentProcessID()); %s -> %{public}s Note that personally I prefer using data.serviceWorkerIdentifier.toUInt64() rather than constructing a string. I would actually recommend that instead. 1604004 3 387086 youennf 2020-01-08 01:42:06 -0800 Created attachment 387086 Patch for landing 1604012 4 387086 commit-queue 2020-01-08 02:29:48 -0800 Comment on attachment 387086 Patch for landing Clearing flags on attachment: 387086 Committed r254191: <https://trac.webkit.org/changeset/254191> 1604013 5 commit-queue 2020-01-08 02:29:49 -0800 All reviewed patches have been landed. Closing bug. 1604014 6 webkit-bug-importer 2020-01-08 02:30:14 -0800 <rdar://problem/58403666> 386949 2020-01-07 01:17:41 -0800 2020-01-08 01:42:02 -0800 Patch bug-205849-20200107101739.patch text/plain 2016 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI1YzFjNGZkODk4MjM5OWMz NjY2MTQyNzBlMTIzNDk5NWM4ZThhNTQuLjhlZGJmNDQ5M2MyYzgwYTI0ZTVjNmE4NzZiZTU1Njg5 ZTNkNDYyNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMDcgIHlvdWVubiBm YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIEltcHJvdmUgbG9nZ2luZyBvZiBj cmVhdGluZyBhIHNlcnZpY2Ugd29ya2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDU4NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgc29tZSByZWxlYXNlIGxvZ2dpbmcgdG8gaWRlbnRpZnkgd2hp Y2ggc2VydmljZSB3b3JrZXIgaXMgY3JlYXRlZCBpbiB3aGljaCBwcm9jZXNzLgorICAgICAgICBO byBjaGFuZ2Ugb2Ygb2JzZXJ2YWJsZSBiZWhhdmlvci4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv U3RvcmFnZS9XZWJTV0NvbnRleHRNYW5hZ2VyQ29ubmVjdGlvbi5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYlNXQ29udGV4dE1hbmFnZXJDb25uZWN0aW9uOjppbnN0YWxsU2VydmljZVdvcmtlcik6 CisKIDIwMjAtMDEtMDYgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFtpT1NdIEdldCBkaXNwbGF5IGxldmVsIGluIHRoZSBVSSBwcm9jZXNzIGZvciBhbGwg aU9TIHBsYXRmb3JtcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1N0b3Jh Z2UvV2ViU1dDb250ZXh0TWFuYWdlckNvbm5lY3Rpb24uY3BwIGIvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1N0b3JhZ2UvV2ViU1dDb250ZXh0TWFuYWdlckNvbm5lY3Rpb24uY3BwCmluZGV4IGI3 NGE2ZWYyNWU2ODk3ZDhjZDljZmI5OTFkZWRjZDRjNzhlMGMwYTcuLjYzOGY1ZGFiMDM3NDlmN2Zl NDhmMzc3ZTJiZWVhZTY2Y2ZmNTEyNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9TdG9yYWdlL1dlYlNXQ29udGV4dE1hbmFnZXJDb25uZWN0aW9uLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvU3RvcmFnZS9XZWJTV0NvbnRleHRNYW5hZ2VyQ29ubmVjdGlv bi5jcHAKQEAgLTE1NSw3ICsxNTUsNyBAQCB2b2lkIFdlYlNXQ29udGV4dE1hbmFnZXJDb25uZWN0 aW9uOjppbnN0YWxsU2VydmljZVdvcmtlcihjb25zdCBTZXJ2aWNlV29ya2VyQ29udAogICAgIGF1 dG8gc2VydmljZVdvcmtlclRocmVhZFByb3h5ID0gU2VydmljZVdvcmtlclRocmVhZFByb3h5Ojpj cmVhdGUoV1RGTW92ZShwYWdlQ29uZmlndXJhdGlvbiksIGRhdGEsIFdURk1vdmUoZWZmZWN0aXZl VXNlckFnZW50KSwgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkuY2FjaGVTdG9yYWdlUHJvdmlkZXIo KSwgbV9zdG9yYWdlQmxvY2tpbmdQb2xpY3kpOwogICAgIFNXQ29udGV4dE1hbmFnZXI6OnNpbmds ZXRvbigpLnJlZ2lzdGVyU2VydmljZVdvcmtlclRocmVhZEZvckluc3RhbGwoV1RGTW92ZShzZXJ2 aWNlV29ya2VyVGhyZWFkUHJveHkpKTsKIAotICAgIExPRyhTZXJ2aWNlV29ya2VyLCAiQ29udGV4 dCBwcm9jZXNzIFBJRDogJWkgY3JlYXRlZCB3b3JrZXIgdGhyZWFkXG4iLCBnZXRDdXJyZW50UHJv Y2Vzc0lEKCkpOworICAgIFJFTEVBU0VfTE9HKFNlcnZpY2VXb3JrZXIsICJDcmVhdGVkIHNlcnZp Y2Ugd29ya2VyICVzIGluIHByb2Nlc3MgUElEICVpIiwgZGF0YS5zZXJ2aWNlV29ya2VySWRlbnRp Zmllci5sb2dnaW5nU3RyaW5nKCkudXRmOCgpLmRhdGEoKSwgZ2V0Q3VycmVudFByb2Nlc3NJRCgp KTsKIH0KIAogdm9pZCBXZWJTV0NvbnRleHRNYW5hZ2VyQ29ubmVjdGlvbjo6c2V0VXNlckFnZW50 KFN0cmluZyYmIHVzZXJBZ2VudCkK 387086 2020-01-08 01:42:06 -0800 2020-01-08 02:29:48 -0800 Patch for landing bug-205849-20200108104205.patch text/plain 2609 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY1ODM0OTdmYzM3YWE2OThi ZDVjMjc0Mjk1NzQ2NDc1OWYwM2EzZTYuLjFhNTY2NTU5MGQwMzUzMDRjMjc4ODI0OTdkZmI5YmI1 MjRlYzc2MzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMDggIHlvdWVubiBm YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIEltcHJvdmUgbG9nZ2luZyBvZiBj cmVhdGluZyBhIHNlcnZpY2Ugd29ya2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDU4NDkKKworICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBEdW1l ei4KKworICAgICAgICBBZGQgc29tZSByZWxlYXNlIGxvZ2dpbmcgdG8gaWRlbnRpZnkgd2hpY2gg c2VydmljZSB3b3JrZXIgaXMgY3JlYXRlZCBpbiB3aGljaCBwcm9jZXNzLgorICAgICAgICBObyBj aGFuZ2Ugb2Ygb2JzZXJ2YWJsZSBiZWhhdmlvci4KKworICAgICAgICAqIFdlYlByb2Nlc3MvU3Rv cmFnZS9XZWJTV0NvbnRleHRNYW5hZ2VyQ29ubmVjdGlvbi5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYlNXQ29udGV4dE1hbmFnZXJDb25uZWN0aW9uOjppbnN0YWxsU2VydmljZVdvcmtlcik6CisK IDIwMjAtMDEtMDggIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAg IEFkZCBhbiBvcHRpb24gdG8gbWFrZSB2aWRlbyBjYXB0dXJlIGluIEdQVVByb2Nlc3MKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9TdG9yYWdlL1dlYlNXQ29udGV4dE1hbmFn ZXJDb25uZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9TdG9yYWdlL1dlYlNX Q29udGV4dE1hbmFnZXJDb25uZWN0aW9uLmNwcAppbmRleCBiNzRhNmVmMjVlNjg5N2Q4Y2Q5Y2Zi OTkxZGVkY2Q0Yzc4ZTBjMGE3Li42NDc3NmEwYzRmOTRmYTZiZTBiZTY5NDFlOWQ4YWQ1ZWNhOTIy NzQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvU3RvcmFnZS9XZWJTV0Nv bnRleHRNYW5hZ2VyQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L1N0b3JhZ2UvV2ViU1dDb250ZXh0TWFuYWdlckNvbm5lY3Rpb24uY3BwCkBAIC0xMzEsNyArMTMx LDcgQEAgdm9pZCBXZWJTV0NvbnRleHRNYW5hZ2VyQ29ubmVjdGlvbjo6dXBkYXRlUHJlZmVyZW5j ZXNTdG9yZShjb25zdCBXZWJQcmVmZXJlbmNlc1MKIAogdm9pZCBXZWJTV0NvbnRleHRNYW5hZ2Vy Q29ubmVjdGlvbjo6aW5zdGFsbFNlcnZpY2VXb3JrZXIoY29uc3QgU2VydmljZVdvcmtlckNvbnRl eHREYXRhJiBkYXRhLCBTdHJpbmcmJiB1c2VyQWdlbnQpCiB7Ci0gICAgTE9HKFNlcnZpY2VXb3Jr ZXIsICJXZWJTV0NvbnRleHRNYW5hZ2VyQ29ubmVjdGlvbjo6aW5zdGFsbFNlcnZpY2VXb3JrZXIg Zm9yIHdvcmtlciAlcyIsIGRhdGEuc2VydmljZVdvcmtlcklkZW50aWZpZXIubG9nZ2luZ1N0cmlu ZygpLnV0ZjgoKS5kYXRhKCkpOworICAgIExPRyhTZXJ2aWNlV29ya2VyLCAiV2ViU1dDb250ZXh0 TWFuYWdlckNvbm5lY3Rpb246Omluc3RhbGxTZXJ2aWNlV29ya2VyIGZvciB3b3JrZXIgJSIgUFJJ dTY0LCBkYXRhLnNlcnZpY2VXb3JrZXJJZGVudGlmaWVyLnRvVUludDY0KCkpOwogCiAgICAgYXV0 byBwYWdlQ29uZmlndXJhdGlvbiA9IHBhZ2VDb25maWd1cmF0aW9uV2l0aEVtcHR5Q2xpZW50cyhX ZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5zZXNzaW9uSUQoKSk7CiAKQEAgLTE1NSw3ICsxNTUsNyBA QCB2b2lkIFdlYlNXQ29udGV4dE1hbmFnZXJDb25uZWN0aW9uOjppbnN0YWxsU2VydmljZVdvcmtl cihjb25zdCBTZXJ2aWNlV29ya2VyQ29udAogICAgIGF1dG8gc2VydmljZVdvcmtlclRocmVhZFBy b3h5ID0gU2VydmljZVdvcmtlclRocmVhZFByb3h5OjpjcmVhdGUoV1RGTW92ZShwYWdlQ29uZmln dXJhdGlvbiksIGRhdGEsIFdURk1vdmUoZWZmZWN0aXZlVXNlckFnZW50KSwgV2ViUHJvY2Vzczo6 c2luZ2xldG9uKCkuY2FjaGVTdG9yYWdlUHJvdmlkZXIoKSwgbV9zdG9yYWdlQmxvY2tpbmdQb2xp Y3kpOwogICAgIFNXQ29udGV4dE1hbmFnZXI6OnNpbmdsZXRvbigpLnJlZ2lzdGVyU2VydmljZVdv cmtlclRocmVhZEZvckluc3RhbGwoV1RGTW92ZShzZXJ2aWNlV29ya2VyVGhyZWFkUHJveHkpKTsK IAotICAgIExPRyhTZXJ2aWNlV29ya2VyLCAiQ29udGV4dCBwcm9jZXNzIFBJRDogJWkgY3JlYXRl ZCB3b3JrZXIgdGhyZWFkXG4iLCBnZXRDdXJyZW50UHJvY2Vzc0lEKCkpOworICAgIFJFTEVBU0Vf TE9HKFNlcnZpY2VXb3JrZXIsICJDcmVhdGVkIHNlcnZpY2Ugd29ya2VyICUiIFBSSXU2NCAiIGlu IHByb2Nlc3MgUElEICVpIiwgZGF0YS5zZXJ2aWNlV29ya2VySWRlbnRpZmllci50b1VJbnQ2NCgp LCBnZXRDdXJyZW50UHJvY2Vzc0lEKCkpOwogfQogCiB2b2lkIFdlYlNXQ29udGV4dE1hbmFnZXJD b25uZWN0aW9uOjpzZXRVc2VyQWdlbnQoU3RyaW5nJiYgdXNlckFnZW50KQo=