205833 2020-01-06 14:25:00 -0800 Add a move constructor to IDBResultData 2020-01-08 16:07:21 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu aakash_jain achristensen alecflett beidson cdumez commit-queue ews-watchlist ggaren jsbell webkit-bug-importer youennf ysuzuki oldest_to_newest 1603276 0 sihui_liu 2020-01-06 14:25:00 -0800 <rdar://problem/58146233> 1603278 1 386887 sihui_liu 2020-01-06 14:29:41 -0800 Created attachment 386887 Patch 1603305 2 386887 youennf 2020-01-06 15:02:04 -0800 Comment on attachment 386887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386887&action=review > Source/WebCore/Modules/indexeddb/shared/IDBResultData.h:91 > + WEBCORE_EXPORT IDBResultData(IDBResultData&&); Can we just do IDBResultData(IDBResultData&&) = default given we do this for operator=(&&)? Or simply remove IDBResultData(const IDBResultData&)? 1603321 3 386899 sihui_liu 2020-01-06 15:34:50 -0800 Created attachment 386899 Patch 1603323 4 sihui_liu 2020-01-06 15:35:40 -0800 (In reply to youenn fablet from comment #2) > Comment on attachment 386887 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386887&action=review > > > Source/WebCore/Modules/indexeddb/shared/IDBResultData.h:91 > > + WEBCORE_EXPORT IDBResultData(IDBResultData&&); > > Can we just do IDBResultData(IDBResultData&&) = default given we do this for > operator=(&&)? Yes. > Or simply remove IDBResultData(const IDBResultData&)? Compile error. 1603776 5 commit-queue 2020-01-07 14:06:56 -0800 The commit-queue encountered the following flaky tests while processing attachment 386899: imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html bug 201481 (authors: shvaikalesh@gmail.com and youennf@gmail.com) The commit-queue is continuing to process your patch. 1603778 6 386899 commit-queue 2020-01-07 14:07:49 -0800 Comment on attachment 386899 Patch Clearing flags on attachment: 386899 Committed r254155: <https://trac.webkit.org/changeset/254155> 1603779 7 commit-queue 2020-01-07 14:07:51 -0800 All reviewed patches have been landed. Closing bug. 1604345 8 sihui_liu 2020-01-08 16:07:21 -0800 *** Bug 205816 has been marked as a duplicate of this bug. *** 386887 2020-01-06 14:29:41 -0800 2020-01-06 15:34:49 -0800 Patch bug-205833-20200106142903.patch text/plain 2866 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTJmMjAyOWUyNzhjMmIz NWRlNWE0YmExYWFmNDAyODBmZDdmOTBlNy4uZDExNDU3ZDNjMDhmOGU4YjQzYTQ2NWY1ZTVjOTJj ZmVhZGEyN2I3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAxLTA2ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBhIG1vdmUgY29uc3Ry dWN0b3IgdG8gSURCUmVzdWx0RGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA1ODMzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODE0NjIzMz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1vZHVs ZXMvaW5kZXhlZGRiL3NoYXJlZC9JREJSZXN1bHREYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OklEQlJlc3VsdERhdGE6OklEQlJlc3VsdERhdGEpOgorICAgICAgICAqIE1vZHVsZXMvaW5kZXhl ZGRiL3NoYXJlZC9JREJSZXN1bHREYXRhLmg6CisKIDIwMjAtMDEtMDYgIE1hcmsgTGFtICA8bWFy ay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENvbnZlcnQgQVNTRVJUX0RJU0FCTEVEIHRvIEFT U0VSVF9FTkFCTEVELCBhbmQgZml4IHNvbWUgdGVzdHMgb2YgTkRFQlVHIHRoYXQgc2hvdWxkIGFj dHVhbGx5IHRlc3QgZm9yIEFTU0VSVF9FTkFCTEVELgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9pbmRleGVkZGIvc2hhcmVkL0lEQlJlc3VsdERhdGEuY3BwIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2hhcmVkL0lEQlJlc3VsdERhdGEuY3BwCmluZGV4IDRj YmQ1ZDliZGYwYTg1MjNiZjdmNTJhYzViYzVjYjRiN2VkMTA0NzcuLmVjZjMzOWI0ODc3Njg3MjNi YmFiNjU5NzQyNmRiMjhkOWVjYjI3NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvaW5kZXhlZGRiL3NoYXJlZC9JREJSZXN1bHREYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL2luZGV4ZWRkYi9zaGFyZWQvSURCUmVzdWx0RGF0YS5jcHAKQEAgLTY4LDYgKzY4 LDI1IEBAIElEQlJlc3VsdERhdGE6OklEQlJlc3VsdERhdGEoY29uc3QgSURCUmVzdWx0RGF0YSYg b3RoZXIpCiAgICAgICAgIG1fZ2V0QWxsUmVzdWx0ID0gbWFrZVVuaXF1ZTxJREJHZXRBbGxSZXN1 bHQ+KCpvdGhlci5tX2dldEFsbFJlc3VsdCk7CiB9CiAKK0lEQlJlc3VsdERhdGE6OklEQlJlc3Vs dERhdGEoSURCUmVzdWx0RGF0YSYmIG90aGVyKQorICAgIDogbV90eXBlKG90aGVyLm1fdHlwZSkK KyAgICAsIG1fcmVxdWVzdElkZW50aWZpZXIob3RoZXIubV9yZXF1ZXN0SWRlbnRpZmllcikKKyAg ICAsIG1fZXJyb3Iob3RoZXIubV9lcnJvcikKKyAgICAsIG1fZGF0YWJhc2VDb25uZWN0aW9uSWRl bnRpZmllcihvdGhlci5tX2RhdGFiYXNlQ29ubmVjdGlvbklkZW50aWZpZXIpCisgICAgLCBtX3Jl c3VsdEludGVnZXIob3RoZXIubV9yZXN1bHRJbnRlZ2VyKQoreworICAgIGlmIChvdGhlci5tX2Rh dGFiYXNlSW5mbykKKyAgICAgICAgbV9kYXRhYmFzZUluZm8gPSBXVEZNb3ZlKG90aGVyLm1fZGF0 YWJhc2VJbmZvKTsKKyAgICBpZiAob3RoZXIubV90cmFuc2FjdGlvbkluZm8pCisgICAgICAgIG1f dHJhbnNhY3Rpb25JbmZvID0gV1RGTW92ZShvdGhlci5tX3RyYW5zYWN0aW9uSW5mbyk7CisgICAg aWYgKG90aGVyLm1fcmVzdWx0S2V5KQorICAgICAgICBtX3Jlc3VsdEtleSA9IFdURk1vdmUob3Ro ZXIubV9yZXN1bHRLZXkpOworICAgIGlmIChvdGhlci5tX2dldFJlc3VsdCkKKyAgICAgICAgbV9n ZXRSZXN1bHQgPSBXVEZNb3ZlKG90aGVyLm1fZ2V0UmVzdWx0KTsKKyAgICBpZiAob3RoZXIubV9n ZXRBbGxSZXN1bHQpCisgICAgICAgIG1fZ2V0QWxsUmVzdWx0ID0gV1RGTW92ZShvdGhlci5tX2dl dEFsbFJlc3VsdCk7Cit9CisKIElEQlJlc3VsdERhdGE6OklEQlJlc3VsdERhdGEoY29uc3QgSURC UmVzdWx0RGF0YSYgdGhhdCwgSXNvbGF0ZWRDb3B5VGFnKQogewogICAgIGlzb2xhdGVkQ29weSh0 aGF0LCAqdGhpcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRk Yi9zaGFyZWQvSURCUmVzdWx0RGF0YS5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVk ZGIvc2hhcmVkL0lEQlJlc3VsdERhdGEuaAppbmRleCAzNGIwMzc2MjhmNDIwZTE3N2M5ODIzZTY5 NmI5YTNkNmQyYmRmNzZjLi4xZjMzMDFjMGNmMmViY2VkYzY4MjJiNDA3MzRlNGZmYjRjMmVhMDJj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zaGFyZWQvSURC UmVzdWx0RGF0YS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NoYXJl ZC9JREJSZXN1bHREYXRhLmgKQEAgLTg4LDYgKzg4LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBJ REJSZXN1bHREYXRhIGl0ZXJhdGVDdXJzb3JTdWNjZXNzKGNvbnN0IElEQlJlc291cmNlSWRlbnRp ZmllciYsIGNvbnN0IElEQkdldFJlc3VsdCYpOwogCiAgICAgV0VCQ09SRV9FWFBPUlQgSURCUmVz dWx0RGF0YShjb25zdCBJREJSZXN1bHREYXRhJik7CisgICAgV0VCQ09SRV9FWFBPUlQgSURCUmVz dWx0RGF0YShJREJSZXN1bHREYXRhJiYpOwogICAgIElEQlJlc3VsdERhdGEmIG9wZXJhdG9yPShJ REJSZXN1bHREYXRhJiYpID0gZGVmYXVsdDsKIAogICAgIGVudW0gSXNvbGF0ZWRDb3B5VGFnIHsg SXNvbGF0ZWRDb3B5IH07Cg== 386899 2020-01-06 15:34:50 -0800 2020-01-07 14:07:49 -0800 Patch bug-205833-20200106153449.patch text/plain 1400 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2NhNWY1YTk0MGFjYjI5 NWJlOTg2MjRmYWUyMDlkOTRjNTNjYmViYS4uMTkxNjBmZjhlYzczMmQ5ZmZhZWJkMTYxYzBkOTMy MWQ1OTVlNjI3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAxLTA2ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBhIG1vdmUgY29uc3Ry dWN0b3IgdG8gSURCUmVzdWx0RGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA1ODMzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODE0NjIzMz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1vZHVs ZXMvaW5kZXhlZGRiL3NoYXJlZC9JREJSZXN1bHREYXRhLmg6CisKIDIwMjAtMDEtMDUgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAo cjI1MjcyNCk6IFVuYWJsZSB0byB0YXAgb24gcGxheSBidXR0b24gb24gZ29vZ2xlIHZpZGVvICdT ZWUgdGhlIHRvcCBzZWFyY2ggdHJlbmRzIG9mIDIwMTknCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zaGFyZWQvSURCUmVzdWx0RGF0YS5oIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2hhcmVkL0lEQlJlc3VsdERhdGEuaAppbmRleCAzNGIw Mzc2MjhmNDIwZTE3N2M5ODIzZTY5NmI5YTNkNmQyYmRmNzZjLi45OTA0OGVlYjkyYmJiNjg4Yzlh ODQ3ZjRhYWYzYjAwMjVlYmFhM2ZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2luZGV4ZWRkYi9zaGFyZWQvSURCUmVzdWx0RGF0YS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvaW5kZXhlZGRiL3NoYXJlZC9JREJSZXN1bHREYXRhLmgKQEAgLTg4LDYgKzg4LDcgQEAg cHVibGljOgogICAgIHN0YXRpYyBJREJSZXN1bHREYXRhIGl0ZXJhdGVDdXJzb3JTdWNjZXNzKGNv bnN0IElEQlJlc291cmNlSWRlbnRpZmllciYsIGNvbnN0IElEQkdldFJlc3VsdCYpOwogCiAgICAg V0VCQ09SRV9FWFBPUlQgSURCUmVzdWx0RGF0YShjb25zdCBJREJSZXN1bHREYXRhJik7CisgICAg SURCUmVzdWx0RGF0YShJREJSZXN1bHREYXRhJiYpID0gZGVmYXVsdDsKICAgICBJREJSZXN1bHRE YXRhJiBvcGVyYXRvcj0oSURCUmVzdWx0RGF0YSYmKSA9IGRlZmF1bHQ7CiAKICAgICBlbnVtIElz b2xhdGVkQ29weVRhZyB7IElzb2xhdGVkQ29weSB9Owo=