<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>205826</bug_id>
          
          <creation_ts>2020-01-06 12:55:21 -0800</creation_ts>
          <short_desc>Web Inspector: remove legacy code for replacing the Resources Tab and Debugger Tab with the Sources Tab</short_desc>
          <delta_ts>2020-08-24 11:14:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>WebKit Local Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=203719</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>202341</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Devin Rousso">hi</reporter>
          <assigned_to name="Devin Rousso">hi</assigned_to>
          <cc>hi</cc>
    
    <cc>inspector-bugzilla-changes</cc>
    
    <cc>joepeck</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1603224</commentid>
    <comment_count>0</comment_count>
    <who name="Devin Rousso">hi</who>
    <bug_when>2020-01-06 12:55:21 -0800</bug_when>
    <thetext>Right now, we&apos;re replacing any instances of &quot;resources&quot; and &quot;debugger&quot; with &quot;sources&quot; in `WI._openTabsSetting`.  Eventually, we should be able to drop this code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1680180</commentid>
    <comment_count>1</comment_count>
      <attachid>406562</attachid>
    <who name="Devin Rousso">hi</who>
    <bug_when>2020-08-13 18:26:04 -0700</bug_when>
    <thetext>Created attachment 406562
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1680483</commentid>
    <comment_count>2</comment_count>
      <attachid>406562</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2020-08-14 15:41:22 -0700</bug_when>
    <thetext>Comment on attachment 406562
Patch

Soooooo nice</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1682382</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-08-24 10:30:48 -0700</bug_when>
    <thetext>Tools/Scripts/svn-apply failed to apply attachment 406562 to trunk.
Please resolve the conflicts and upload a new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1682392</commentid>
    <comment_count>4</comment_count>
      <attachid>407110</attachid>
    <who name="Devin Rousso">hi</who>
    <bug_when>2020-08-24 10:41:23 -0700</bug_when>
    <thetext>Created attachment 407110
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1682402</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-08-24 11:13:08 -0700</bug_when>
    <thetext>Committed r266076: &lt;https://trac.webkit.org/changeset/266076&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407110.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1682403</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-08-24 11:14:14 -0700</bug_when>
    <thetext>&lt;rdar://problem/67689086&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>406562</attachid>
            <date>2020-08-13 18:26:04 -0700</date>
            <delta_ts>2020-08-24 10:41:21 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>205826.diff</filename>
            <type>text/plain</type>
            <size>2312</size>
            <attacher name="Devin Rousso">hi</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi
SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY1N2Q2NzJhY2IyMS4uYTc4MzgzY2ZiMTk4IDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X
ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wOC0xMyAgRGV2
aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog
cmVtb3ZlIGxlZ2FjeSBjb2RlIGZvciByZXBsYWNpbmcgdGhlIFJlc291cmNlcyBUYWIgYW5kIERl
YnVnZ2VyIFRhYiB3aXRoIHRoZSBTb3VyY2VzIFRhYgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1ODI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoKKyAg
ICAgICAgKFdJLmxvYWRlZCk6CisKIDIwMjAtMDgtMTIgIERldmluIFJvdXNzbyAgPGRyb3Vzc29A
YXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT04ocjI1OTE3MCk6
IHRleHQgaW5wdXRzIGluIGJveC1zaGFkb3cgZWRpdG9yIHB1c2ggc2xpZGVycyBvZmZzY3JlZW4K
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFp
bi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpp
bmRleCA2ODI3ZTU2ODE2M2QuLjc5MmNmYTI4YjA2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu
c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw
ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtMTU4LDI2ICsxNTgsNiBAQCBX
SS5sb2FkZWQgPSBmdW5jdGlvbigpCiAgICAgXSk7CiAgICAgV0kuX3NlbGVjdGVkVGFiSW5kZXhT
ZXR0aW5nID0gbmV3IFdJLlNldHRpbmcoInNlbGVjdGVkLXRhYi1pbmRleCIsIDApOwogCi0gICAg
Ly8gRklYTUU6IDxodHRwczovL3dlYmtpdC5vcmcvYi8yMDU4MjY+IFdlYiBJbnNwZWN0b3I6IHJl
bW92ZSBsZWdhY3kgY29kZSBmb3IgcmVwbGFjaW5nIHRoZSBSZXNvdXJjZXMgVGFiIGFuZCBEZWJ1
Z2dlciBUYWIgd2l0aCB0aGUgU291cmNlcyBUYWIKLSAgICBsZXQgZGVidWdnZXJJbmRleCA9IFdJ
Ll9vcGVuVGFic1NldHRpbmcudmFsdWUuaW5kZXhPZigiZGVidWdnZXIiKTsKLSAgICBsZXQgcmVz
b3VyY2VzSW5kZXggPSBXSS5fb3BlblRhYnNTZXR0aW5nLnZhbHVlLmluZGV4T2YoInJlc291cmNl
cyIpOwotICAgIGlmIChkZWJ1Z2dlckluZGV4ID49IDAgfHwgcmVzb3VyY2VzSW5kZXggPj0gMCkg
ewotICAgICAgICBXSS5fb3BlblRhYnNTZXR0aW5nLnZhbHVlLnJlbW92ZSgiZGVidWdnZXIiKTsK
LSAgICAgICAgV0kuX29wZW5UYWJzU2V0dGluZy52YWx1ZS5yZW1vdmUoInJlc291cmNlcyIpOwot
Ci0gICAgICAgIGlmIChkZWJ1Z2dlckluZGV4ID09PSAtMSkKLSAgICAgICAgICAgIGRlYnVnZ2Vy
SW5kZXggPSBJbmZpbml0eTsKLSAgICAgICAgaWYgKHJlc291cmNlc0luZGV4ID09PSAtMSkKLSAg
ICAgICAgICAgIHJlc291cmNlc0luZGV4ID0gSW5maW5pdHk7Ci0KLSAgICAgICAgbGV0IHNvdXJj
ZXNJbmRleCA9IE1hdGgubWluKGRlYnVnZ2VySW5kZXgsIHJlc291cmNlc0luZGV4KTsKLSAgICAg
ICAgV0kuX29wZW5UYWJzU2V0dGluZy52YWx1ZS5zcGxpY2Uoc291cmNlc0luZGV4LCAxLCBXSS5T
b3VyY2VzVGFiQ29udGVudFZpZXcuVHlwZSk7Ci0gICAgICAgIFdJLl9vcGVuVGFic1NldHRpbmcu
c2F2ZSgpOwotCi0gICAgICAgIGlmIChXSS5fc2VsZWN0ZWRUYWJJbmRleFNldHRpbmcudmFsdWUg
PT09IGRlYnVnZ2VySW5kZXggfHwgV0kuX3NlbGVjdGVkVGFiSW5kZXhTZXR0aW5nLnZhbHVlID09
PSByZXNvdXJjZXNJbmRleCkKLSAgICAgICAgICAgIFdJLl9zZWxlY3RlZFRhYkluZGV4U2V0dGlu
Zy52YWx1ZSA9IHNvdXJjZXNJbmRleDsKLSAgICB9Ci0KICAgICAvLyBGSVhNRTogPGh0dHBzOi8v
d2Via2l0Lm9yZy9iLzIwNTgyNz4gV2ViIEluc3BlY3RvcjogcmVtb3ZlIGxlZ2FjeSBjb2RlIGZv
ciByZXBsYWNpbmcgdGhlIENhbnZhcyBUYWIgd2l0aCB0aGUgR3JhcGhpY3MgVGFiCiAgICAgbGV0
IGNhbnZhc0luZGV4ID0gV0kuX29wZW5UYWJzU2V0dGluZy52YWx1ZS5pbmRleE9mKCJjYW52YXMi
KTsKICAgICBpZiAoY2FudmFzSW5kZXggPj0gMCkgewo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>407110</attachid>
            <date>2020-08-24 10:41:23 -0700</date>
            <delta_ts>2020-08-24 11:13:09 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-205826-20200824104122.patch</filename>
            <type>text/plain</type>
            <size>2266</size>
            <attacher name="Devin Rousso">hi</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi
SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGI4ZjM2ZDUwNWZlY2RkMGViNThiYWViOGZhMGIy
MTJjYzgxZmY4NDkuLmZmZWVhM2E5NDVlNTVlZjkyZDI2YzcxMTY1NzhlNDFiYzM0NDlhMmEgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl
Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA4LTI0ICBEZXZp
biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBy
ZW1vdmUgbGVnYWN5IGNvZGUgZm9yIHJlcGxhY2luZyB0aGUgUmVzb3VyY2VzIFRhYiBhbmQgRGVi
dWdnZXIgVGFiIHdpdGggdGhlIFNvdXJjZXMgVGFiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU4MjYKKworICAgICAgICBSZXZpZXdlZCBieSBKb3Nl
cGggUGVjb3Jhcm8uCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoKKyAg
ICAgICAgKFdJLmxvYWRlZCk6CisKIDIwMjAtMDgtMjQgIERldmluIFJvdXNzbyAgPGRyb3Vzc29A
YXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFsbG93IGV2ZW50IGJyZWFrcG9p
bnRzIHRvIGJlIGNvbmZpZ3VyZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V
c2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50
ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCAzZDdiNjM2ZGVkMzU1NDBiNzZmMDZhNDdjYjYwMDU5
MzdhMzNlYjFjLi4wMmQ1MWY5OTU4ZWE5MGM5NDYxMTYzYmFjN2YwN2VhZmVjMzM4NTI1IDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMK
KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBA
IC0xNTgsMjYgKzE1OCw2IEBAIFdJLmxvYWRlZCA9IGZ1bmN0aW9uKCkKICAgICBdKTsKICAgICBX
SS5fc2VsZWN0ZWRUYWJJbmRleFNldHRpbmcgPSBuZXcgV0kuU2V0dGluZygic2VsZWN0ZWQtdGFi
LWluZGV4IiwgMCk7CiAKLSAgICAvLyBGSVhNRTogPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIwNTgy
Nj4gV2ViIEluc3BlY3RvcjogcmVtb3ZlIGxlZ2FjeSBjb2RlIGZvciByZXBsYWNpbmcgdGhlIFJl
c291cmNlcyBUYWIgYW5kIERlYnVnZ2VyIFRhYiB3aXRoIHRoZSBTb3VyY2VzIFRhYgotICAgIGxl
dCBkZWJ1Z2dlckluZGV4ID0gV0kuX29wZW5UYWJzU2V0dGluZy52YWx1ZS5pbmRleE9mKCJkZWJ1
Z2dlciIpOwotICAgIGxldCByZXNvdXJjZXNJbmRleCA9IFdJLl9vcGVuVGFic1NldHRpbmcudmFs
dWUuaW5kZXhPZigicmVzb3VyY2VzIik7Ci0gICAgaWYgKGRlYnVnZ2VySW5kZXggPj0gMCB8fCBy
ZXNvdXJjZXNJbmRleCA+PSAwKSB7Ci0gICAgICAgIFdJLl9vcGVuVGFic1NldHRpbmcudmFsdWUu
cmVtb3ZlKCJkZWJ1Z2dlciIpOwotICAgICAgICBXSS5fb3BlblRhYnNTZXR0aW5nLnZhbHVlLnJl
bW92ZSgicmVzb3VyY2VzIik7Ci0KLSAgICAgICAgaWYgKGRlYnVnZ2VySW5kZXggPT09IC0xKQot
ICAgICAgICAgICAgZGVidWdnZXJJbmRleCA9IEluZmluaXR5OwotICAgICAgICBpZiAocmVzb3Vy
Y2VzSW5kZXggPT09IC0xKQotICAgICAgICAgICAgcmVzb3VyY2VzSW5kZXggPSBJbmZpbml0eTsK
LQotICAgICAgICBsZXQgc291cmNlc0luZGV4ID0gTWF0aC5taW4oZGVidWdnZXJJbmRleCwgcmVz
b3VyY2VzSW5kZXgpOwotICAgICAgICBXSS5fb3BlblRhYnNTZXR0aW5nLnZhbHVlLnNwbGljZShz
b3VyY2VzSW5kZXgsIDEsIFdJLlNvdXJjZXNUYWJDb250ZW50Vmlldy5UeXBlKTsKLSAgICAgICAg
V0kuX29wZW5UYWJzU2V0dGluZy5zYXZlKCk7Ci0KLSAgICAgICAgaWYgKFdJLl9zZWxlY3RlZFRh
YkluZGV4U2V0dGluZy52YWx1ZSA9PT0gZGVidWdnZXJJbmRleCB8fCBXSS5fc2VsZWN0ZWRUYWJJ
bmRleFNldHRpbmcudmFsdWUgPT09IHJlc291cmNlc0luZGV4KQotICAgICAgICAgICAgV0kuX3Nl
bGVjdGVkVGFiSW5kZXhTZXR0aW5nLnZhbHVlID0gc291cmNlc0luZGV4OwotICAgIH0KLQogICAg
IC8vIFN0YXRlLgogICAgIFdJLnByaW50U3R5bGVzRW5hYmxlZCA9IGZhbHNlOwogICAgIFdJLnNl
dFpvb21GYWN0b3IoV0kuc2V0dGluZ3Muem9vbUZhY3Rvci52YWx1ZSk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>