205822 2020-01-06 11:40:53 -0800 [iOS] Only prewarm fonts with valid font names 2020-01-10 14:43:47 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue mmaxfield webkit-bug-importer oldest_to_newest 1603182 0 pvollan 2020-01-06 11:40:53 -0800 The font names ".SF NS Text" and ".SF NS Display" are not valid on iOS. 1603183 1 386872 pvollan 2020-01-06 11:43:13 -0800 Created attachment 386872 Patch 1603198 2 386872 bfulgham 2020-01-06 12:13:01 -0800 Comment on attachment 386872 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386872&action=review r=me, but I wonder if that conditional should also allow MacCatalyst. > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1697 > +#if PLATFORM(MAC) What about MacCatalyst? 1603219 3 386878 pvollan 2020-01-06 12:49:33 -0800 Created attachment 386878 Patch 1603221 4 pvollan 2020-01-06 12:50:18 -0800 (In reply to Brent Fulgham from comment #2) > Comment on attachment 386872 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386872&action=review > > r=me, but I wonder if that conditional should also allow MacCatalyst. > > > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1697 > > +#if PLATFORM(MAC) > > What about MacCatalyst? Fixed. Thanks for reviewing! 1603257 5 386878 commit-queue 2020-01-06 14:00:45 -0800 Comment on attachment 386878 Patch Rejecting attachment 386878 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 386878, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13300244 1603285 6 386890 pvollan 2020-01-06 14:45:49 -0800 Created attachment 386890 Patch 1603374 7 386890 commit-queue 2020-01-06 16:49:39 -0800 Comment on attachment 386890 Patch Clearing flags on attachment: 386890 Committed r254099: <https://trac.webkit.org/changeset/254099> 1603422 8 webkit-bug-importer 2020-01-06 20:10:39 -0800 <rdar://problem/58362968> 386872 2020-01-06 11:43:13 -0800 2020-01-06 12:13:01 -0800 Patch bug-205822-20200106114313.patch text/plain 1382 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1NDA3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAxLTA2ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBPbmx5IHByZXdh cm0gZm9udHMgd2l0aCB2YWxpZCBmb250IG5hbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU4MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZm9udCBuYW1lcyAiLlNGIE5TIFRleHQiIGFuZCAi LlNGIE5TIERpc3BsYXkiIGFyZSBub3QgdmFsaWQgb24gaU9TLCBhbmQgc2hvdWxkIG5vdCBiZSBw cmV3YXJtZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250Q2FjaGVDb3JlVGV4dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpGb250Q2FjaGU6OnByZXdhcm1HbG9iYWxseSk6CisKIDIwMjAt MDEtMDYgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJF R1JFU1NJT04ocjI0NzYyNik6IEludHJvZHVjZWQgbWVtb3J5IHJlZ3Jlc3Npb24KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0ZvbnRDYWNoZUNvcmVUZXh0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9G b250Q2FjaGVDb3JlVGV4dC5jcHAJKHJldmlzaW9uIDI1NDA2NykKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0ZvbnRDYWNoZUNvcmVUZXh0LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTY5NCw4ICsxNjk0LDEwIEBAIHZvaWQgRm9udENhY2hlOjpwcmV3YXJtR2xvYmFs bHkoKQogICAgICAgICByZXR1cm47CiAKICAgICBWZWN0b3I8U3RyaW5nPiBmYW1pbGllcyA9IHN0 ZDo6aW5pdGlhbGl6ZXJfbGlzdDxTdHJpbmc+IHsKKyNpZiBQTEFURk9STShNQUMpCiAgICAgICAg ICIuU0YgTlMgVGV4dCJfcywKICAgICAgICAgIi5TRiBOUyBEaXNwbGF5Il9zLAorI2VuZGlmCiAg ICAgICAgICJBcmlhbCJfcywKICAgICAgICAgIkhlbHZldGljYSJfcywKICAgICAgICAgIkhlbHZl dGljYSBOZXVlIl9zLAo= 386878 2020-01-06 12:49:33 -0800 2020-01-06 14:46:42 -0800 Patch bug-205822-20200106124933.patch text/plain 1407 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1NDA3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAxLTA2ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBPbmx5IHByZXdh cm0gZm9udHMgd2l0aCB2YWxpZCBmb250IG5hbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU4MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZm9udCBuYW1lcyAiLlNGIE5TIFRleHQiIGFuZCAi LlNGIE5TIERpc3BsYXkiIGFyZSBub3QgdmFsaWQgb24gaU9TLCBhbmQgc2hvdWxkIG5vdCBiZSBw cmV3YXJtZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250Q2FjaGVDb3JlVGV4dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpGb250Q2FjaGU6OnByZXdhcm1HbG9iYWxseSk6CisKIDIwMjAt MDEtMDYgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJF R1JFU1NJT04ocjI0NzYyNik6IEludHJvZHVjZWQgbWVtb3J5IHJlZ3Jlc3Npb24KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0ZvbnRDYWNoZUNvcmVUZXh0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9G b250Q2FjaGVDb3JlVGV4dC5jcHAJKHJldmlzaW9uIDI1NDA2NykKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0ZvbnRDYWNoZUNvcmVUZXh0LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTY5NCw4ICsxNjk0LDEwIEBAIHZvaWQgRm9udENhY2hlOjpwcmV3YXJtR2xvYmFs bHkoKQogICAgICAgICByZXR1cm47CiAKICAgICBWZWN0b3I8U3RyaW5nPiBmYW1pbGllcyA9IHN0 ZDo6aW5pdGlhbGl6ZXJfbGlzdDxTdHJpbmc+IHsKKyNpZiBQTEFURk9STShNQUMpIHx8IFBMQVRG T1JNKE1BQ0NBVEFMWVNUKQogICAgICAgICAiLlNGIE5TIFRleHQiX3MsCiAgICAgICAgICIuU0Yg TlMgRGlzcGxheSJfcywKKyNlbmRpZgogICAgICAgICAiQXJpYWwiX3MsCiAgICAgICAgICJIZWx2 ZXRpY2EiX3MsCiAgICAgICAgICJIZWx2ZXRpY2EgTmV1ZSJfcywK 386890 2020-01-06 14:45:49 -0800 2020-01-06 16:49:39 -0800 Patch bug-205822-20200106144549.patch text/plain 1406 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1NDA3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAxLTA2ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBPbmx5IHByZXdh cm0gZm9udHMgd2l0aCB2YWxpZCBmb250IG5hbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU4MjIKKworICAgICAgICBSZXZpZXdlZCBieSBCcmVu dCBGdWxnaGFtLgorCisgICAgICAgIFRoZSBmb250IG5hbWVzICIuU0YgTlMgVGV4dCIgYW5kICIu U0YgTlMgRGlzcGxheSIgYXJlIG5vdCB2YWxpZCBvbiBpT1MsIGFuZCBzaG91bGQgbm90IGJlIHBy ZXdhcm1lZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0ZvbnRDYWNoZUNvcmVUZXh0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6cHJld2FybUdsb2JhbGx5KToKKwogMjAyMC0w MS0wNiAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVH UkVTU0lPTihyMjQ3NjI2KTogSW50cm9kdWNlZCBtZW1vcnkgcmVncmVzc2lvbgpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9udENhY2hlQ29yZVRleHQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0Zv bnRDYWNoZUNvcmVUZXh0LmNwcAkocmV2aXNpb24gMjU0MDY3KQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9udENhY2hlQ29yZVRleHQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xNjk0LDggKzE2OTQsMTAgQEAgdm9pZCBGb250Q2FjaGU6OnByZXdhcm1HbG9iYWxs eSgpCiAgICAgICAgIHJldHVybjsKIAogICAgIFZlY3RvcjxTdHJpbmc+IGZhbWlsaWVzID0gc3Rk Ojppbml0aWFsaXplcl9saXN0PFN0cmluZz4geworI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZP Uk0oTUFDQ0FUQUxZU1QpCiAgICAgICAgICIuU0YgTlMgVGV4dCJfcywKICAgICAgICAgIi5TRiBO UyBEaXNwbGF5Il9zLAorI2VuZGlmCiAgICAgICAgICJBcmlhbCJfcywKICAgICAgICAgIkhlbHZl dGljYSJfcywKICAgICAgICAgIkhlbHZldGljYSBOZXVlIl9zLAo=